From: Rob Herring <robh@kernel.org>
To: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
John Youn <John.Youn@synopsys.com>
Subject: Re: [RESENDING RFC PATCH 1/4] dt-bindings: usb: Add snps,consolidate-sgl & consolidate-sgl
Date: Sat, 4 Apr 2020 19:45:48 -0600 [thread overview]
Message-ID: <20200405014548.GA25539@bogus> (raw)
In-Reply-To: <8a9ca8e08d7c4957789a209c77589f1aa4bd2f06.1585297723.git.joglekar@synopsys.com>
On Fri, Mar 27, 2020 at 03:11:56PM +0530, Tejas Joglekar wrote:
> This commit adds the documentation for consolidate-sgl, and
> snps,consolidate-sgl property. These when set enables the quirk for
> XHCI driver for consolidation of sg list into a temporary buffer when small
> buffer sizes are scattered over the sg list not making up to MPS or total
> transfer size within TRB cache size with Synopsys xHC.
>
> Signed-off-by: Tejas Joglekar <joglekar@synopsys.com>
> ---
> Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++
> Documentation/devicetree/bindings/usb/usb-xhci.txt | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 9946ff9ba735..292d1f7969e4 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -104,6 +104,9 @@ Optional properties:
> this and tx-thr-num-pkt-prd to a valid, non-zero value
> 1-16 (DWC_usb31 programming guide section 1.2.3) to
> enable periodic ESS TX threshold.
> + - snps,consolidate-sgl: enable sg list consolidation - host mode only. Set to use
> + SG buffers of at least MPS size by consolidating smaller SG
> + buffers list into a single buffer.
The preference is not to keep adding properties for every single quirk
or feature. These should be implied by specific compatibles. As Synopsys
knows what quirks/errata/features are in each version of IP, the
compatible strings should reflect those versions. (And yes, I'm sure
there's customer ECO fixes that aren't reflected in the version, but
that's why we have SoC specific compatibles too.) This is the only way
we can fix quirks in the OS without doing DT updates. For comparison, do
you want to have to update your PC BIOS so an OS can work-around issues?
Rob
next prev parent reply other threads:[~2020-04-05 1:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 8:52 [RESENDING RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2020-03-27 8:34 ` [RFC PATCH 1/4] dt-bindings: usb: Add snps,consolidate-sgl & consolidate-sgl Tejas Joglekar
2020-03-27 9:41 ` [RESENDING RFC " Tejas Joglekar
2020-03-27 9:54 ` Greg KH
2020-03-27 10:11 ` Tejas Joglekar
2020-03-27 10:24 ` Greg KH
2020-03-27 10:28 ` Tejas Joglekar
2020-04-05 1:45 ` Rob Herring [this message]
2020-04-14 10:09 ` Tejas Joglekar
2020-04-16 8:22 ` Felipe Balbi
2020-04-16 16:37 ` Tejas Joglekar
2020-04-17 11:44 ` Mathias Nyman
2020-03-27 8:35 ` [RFC PATCH 2/4] usb: xhci: Set quirk for XHCI_CONSOLIDATE_SG_LIST Tejas Joglekar
2020-03-27 9:42 ` [RESENDING RFC " Tejas Joglekar
2020-03-27 8:35 ` [RFC PATCH 3/4] usb: dwc3: Add device property consolidate-sgl Tejas Joglekar
2020-03-27 9:42 ` [RESENDING RFC " Tejas Joglekar
2020-03-27 8:53 ` [RESENDING RFC PATCH 4/4] usb: xhci: Use temporary buffer to consolidate SG Tejas Joglekar
2020-03-27 9:27 ` Greg KH
2020-03-27 10:05 ` Tejas Joglekar
2020-03-27 10:22 ` Greg KH
2020-03-27 11:25 ` Mathias Nyman
2020-03-27 15:38 ` Raul Rangel
2020-03-27 9:28 ` [RESENDING RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC Greg KH
2020-03-27 9:43 ` Tejas Joglekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200405014548.GA25539@bogus \
--to=robh@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Tejas.Joglekar@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).