From: kernel test robot <lkp@intel.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, andersson@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, wcheng@codeaurora.org,
caleb.connolly@linaro.org, bryan.odonoghue@linaro.org,
konrad.dybcio@linaro.org, subbaram@quicinc.com,
jackp@quicinc.com, robertom@qti.qualcomm.com,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v4 13/18] phy: qcom-qmp: Register as a typec switch for orientation detection
Date: Sun, 19 Mar 2023 00:42:49 +0800 [thread overview]
Message-ID: <202303190010.w3QR1CU6-lkp@intel.com> (raw)
In-Reply-To: <20230318121828.739424-14-bryan.odonoghue@linaro.org>
Hi Bryan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus robh/for-next broonie-regulator/for-next lee-mfd/for-mfd-next linus/master v6.3-rc2 next-20230317]
[cannot apply to lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bryan-O-Donoghue/dt-bindings-regulator-qcom-usb-vbus-regulator-Mark-reg-as-required/20230318-202034
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20230318121828.739424-14-bryan.odonoghue%40linaro.org
patch subject: [PATCH v4 13/18] phy: qcom-qmp: Register as a typec switch for orientation detection
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230319/202303190010.w3QR1CU6-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/76d1e355779b094d3ddb20776b0835215dc3646c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/dt-bindings-regulator-qcom-usb-vbus-regulator-Mark-reg-as-required/20230318-202034
git checkout 76d1e355779b094d3ddb20776b0835215dc3646c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/phy/qualcomm/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303190010.w3QR1CU6-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/phy/qualcomm/phy-qcom-qmp-combo.c: In function 'qmp_combo_typec_switch_set':
>> drivers/phy/qualcomm/phy-qcom-qmp-combo.c:3383:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
3383 | int ret = 0;
| ^~~
vim +/ret +3383 drivers/phy/qualcomm/phy-qcom-qmp-combo.c
3376
3377 #if IS_ENABLED(CONFIG_PHY_QCOM_QMP_TYPEC)
3378 static int qmp_combo_typec_switch_set(struct typec_switch_dev *sw,
3379 enum typec_orientation orientation)
3380 {
3381 struct qmp_combo *qmp = typec_switch_get_drvdata(sw);
3382 struct phy *dp_phy = qmp->dp_phy;
> 3383 int ret = 0;
3384
3385 dev_dbg(qmp->dev, "Toggling orientation current %d requested %d\n",
3386 qmp->orientation, orientation);
3387
3388 qmp->orientation = orientation;
3389
3390 if (orientation == TYPEC_ORIENTATION_NONE) {
3391 if (qmp->init_count)
3392 ret = qmp_combo_dp_power_off(dp_phy);
3393 } else {
3394 if (!qmp->init_count)
3395 ret = qmp_combo_dp_power_on(dp_phy);
3396 }
3397
3398 return 0;
3399 }
3400
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-18 16:43 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 12:18 [PATCH v4 00/18] Add Qualcomm PMIC TPCM support Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 01/18] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark reg as required Bryan O'Donoghue
2023-03-19 11:41 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 02/18] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark regulator-*-microamp required Bryan O'Donoghue
2023-03-19 11:42 ` Krzysztof Kozlowski
2023-03-19 11:53 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 03/18] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add orientation-switch as optional Bryan O'Donoghue
2023-03-19 11:42 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 04/18] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add port as an optional Bryan O'Donoghue
2023-03-19 11:45 ` Krzysztof Kozlowski
2023-03-21 20:49 ` Rob Herring
2023-03-22 14:01 ` Bryan O'Donoghue
2023-03-23 13:39 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 05/18] dt-bindings: usb: Add qcom,pmic-typec dt-binding header Bryan O'Donoghue
2023-03-19 11:50 ` Krzysztof Kozlowski
2023-03-19 14:50 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 06/18] dt-bindings: usb: Add Qualcomm PMIC Type-C controller YAML schema Bryan O'Donoghue
2023-03-19 11:53 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 07/18] dt-bindings: usb: Add qcom,pmic-pdphy dt-binding header Bryan O'Donoghue
2023-03-19 11:50 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 08/18] dt-bindings: usb: Add Qualcomm PMIC PDPHY controller YAML schema Bryan O'Donoghue
2023-03-19 11:55 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 09/18] dt-bindings: usb: Add Qualcomm PMIC TCPM " Bryan O'Donoghue
2023-03-19 11:58 ` Krzysztof Kozlowski
2023-03-19 14:59 ` Bryan O'Donoghue
2023-03-19 15:10 ` Krzysztof Kozlowski
2023-03-19 15:44 ` Bryan O'Donoghue
2023-03-19 17:50 ` Krzysztof Kozlowski
2023-03-19 21:31 ` Caleb Connolly
2023-03-19 22:34 ` Bryan O'Donoghue
2023-03-19 22:32 ` Bryan O'Donoghue
2023-03-19 15:50 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 10/18] dt-bindings: mfd: qcom,spmi-pmic: Add pdphy to SPMI device types Bryan O'Donoghue
2023-03-19 11:58 ` Krzysztof Kozlowski
2023-03-21 20:58 ` Rob Herring
2023-03-21 23:52 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 11/18] dt-bindings: mfd: qcom,spmi-pmic: Add typec " Bryan O'Donoghue
2023-03-19 11:59 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 12/18] usb: typec: qcom: Add Qualcomm PMIC TCPM support Bryan O'Donoghue
2023-03-23 14:36 ` Jianhua Lu
2023-03-23 17:31 ` Bryan O'Donoghue
2023-03-24 0:43 ` Jianhua Lu
2023-03-24 0:53 ` Bryan O'Donoghue
2023-03-24 1:13 ` Jianhua Lu
2023-03-24 2:37 ` Bryan O'Donoghue
2023-03-24 10:16 ` Jianhua Lu
2023-03-24 13:25 ` Bryan O'Donoghue
2023-03-24 15:09 ` Jianhua Lu
2023-03-24 16:03 ` Bryan O'Donoghue
2023-03-24 14:00 ` Heikki Krogerus
2023-03-24 14:22 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 13/18] phy: qcom-qmp: Register as a typec switch for orientation detection Bryan O'Donoghue
2023-03-18 16:42 ` kernel test robot [this message]
2023-03-20 11:15 ` Neil Armstrong
2023-03-20 11:19 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 14/18] arm64: dts: qcom: pm8150b: Add a TCPM description Bryan O'Donoghue
2023-03-18 13:13 ` Konrad Dybcio
2023-03-18 21:09 ` kernel test robot
2023-03-18 12:18 ` [PATCH v4 15/18] arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 16/18] arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM Bryan O'Donoghue
2023-03-18 13:09 ` Konrad Dybcio
2023-03-18 12:18 ` [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Bryan O'Donoghue
2023-03-18 13:10 ` Konrad Dybcio
2023-03-18 17:46 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 18/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy Bryan O'Donoghue
2023-03-18 13:11 ` Konrad Dybcio
2023-03-18 17:47 ` Bryan O'Donoghue
2023-03-24 15:10 ` [PATCH v4 00/18] Add Qualcomm PMIC TPCM support Luca Weiss
2023-03-24 15:28 ` Bryan O'Donoghue
2023-03-31 8:48 ` Luca Weiss
2023-03-31 13:52 ` Bryan O'Donoghue
2023-03-31 14:58 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303190010.w3QR1CU6-lkp@intel.com \
--to=lkp@intel.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robertom@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=subbaram@quicinc.com \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).