From: Caleb Connolly <caleb.connolly@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, andersson@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Cc: wcheng@codeaurora.org, konrad.dybcio@linaro.org,
subbaram@quicinc.com, jackp@quicinc.com,
robertom@qti.qualcomm.com
Subject: Re: [PATCH v4 09/18] dt-bindings: usb: Add Qualcomm PMIC TCPM YAML schema
Date: Sun, 19 Mar 2023 21:31:49 +0000 [thread overview]
Message-ID: <5098322b-d09b-72ec-ac6a-128a6a64ea17@linaro.org> (raw)
In-Reply-To: <c5ac0d15-4651-318e-4dd2-37b2f90b2ba0@linaro.org>
On 19/03/2023 17:50, Krzysztof Kozlowski wrote:
> On 19/03/2023 16:44, Bryan O'Donoghue wrote:
>> On 19/03/2023 15:10, Krzysztof Kozlowski wrote:
>>> On 19/03/2023 15:59, Bryan O'Donoghue wrote:
>>>> On 19/03/2023 11:58, Krzysztof Kozlowski wrote:
>>>>>> +
>>>>>> +maintainers:
>>>>>> + - Bryan O'Donoghue<bryan.odonoghue@linaro.org>
>>>>>> +
>>>>>> +description: |
>>>>>> + Qualcomm PMIC Virtual Type-C Port Manager Driver
>>>>>> + A virtual device which manages Qualcomm PMIC provided Type-C port and
>>>>>> + Power Delivery in one place.
>>>>> OK, so it looks like bindings for driver, so a no-go. Unless there is
>>>>> such device as "manager", this does not look like hardware description.
>>>>>
>>>>>> +
>>>>>> +properties:
>>>>>> + compatible:
>>>>>> + const: qcom,pmic-virt-tcpm
>>>>>> +
>>>>>> + connector:
>>>>>> + type: object
>>>>>> + $ref: /schemas/connector/usb-connector.yaml#
>>>>>> + unevaluatedProperties: false
>>>>>> +
>>>>>> + port:
>>>>>> + $ref: /schemas/graph.yaml#/properties/port
>>>>>> + description:
>>>>>> + Contains a port which consumes data-role switching messages.
>>>>>> +
>>>>>> + qcom,pmic-typec:
>>>>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>>>>> + description:
>>>>>> + A phandle to the typec port hardware driver.
>>>>>> +
>>>>>> + qcom,pmic-pdphy:
>>>>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>>>> Having typec and phy as phandles - not children - also suggests this is
>>>>> some software construct, not hardware description.
>>>>
>>>> So probably I didn't interpret Rob's comment correctly here.
>>>
>>> He proposed to merge it with other node:
>>> "probably merged with
>>> one of the nodes these phandles point to."
>>>
>>> "Why can't most of this binding be part of"
>>>
>>> I don't see how you implemented his comments. Actually, nothing improved
>>> here in this regard - you still have these phandles.
>>
>> So this comment from Rob is what I was aiming for
>>
>> "Your other option is instantiate your own device from the virtual
>> driver's initcall based on presence of the 2 nodes above. "
>>
>> rather than two mush the pdphy and typec into one device, which they are
>> not.
>
> Sure, but you did not instantiate anything based on these two or one
> nodes. You added virtual device node.
>
>
>> I guess what I'm trying to understand is how you guys would suggest that
>> is actually done.
>
> You have there already node for the PMIC USB Type-C, so this should be
> part of it. I really do not understand why this is separate device lying
> around in parallel like:
The pdphy is fairly well encapsulated (3 tcpm callbacks go to it, that's
all?), I think the tcpm part could be merged in with the typec driver
and it could just have a phandle to the pdphy node to represent the
dependency.
Then in the typec driver you can get the device with
spmi_device_from_of() and call into it that way for the few tcpm
callbacks that it needs to handle and to pass in the tcpm_port.
>
> pmic {
> usb {
> };
> };
>
> virtual- pmic-tcpm {
> };
>
> What hardware piece does such description represent?
>
>>
>> Could I trouble you for an example ?
>>
>> ---
>> bod
>
> Best regards,
> Krzysztof
>
--
Kind Regards,
Caleb (they/them)
next prev parent reply other threads:[~2023-03-19 21:32 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 12:18 [PATCH v4 00/18] Add Qualcomm PMIC TPCM support Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 01/18] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark reg as required Bryan O'Donoghue
2023-03-19 11:41 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 02/18] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark regulator-*-microamp required Bryan O'Donoghue
2023-03-19 11:42 ` Krzysztof Kozlowski
2023-03-19 11:53 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 03/18] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add orientation-switch as optional Bryan O'Donoghue
2023-03-19 11:42 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 04/18] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add port as an optional Bryan O'Donoghue
2023-03-19 11:45 ` Krzysztof Kozlowski
2023-03-21 20:49 ` Rob Herring
2023-03-22 14:01 ` Bryan O'Donoghue
2023-03-23 13:39 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 05/18] dt-bindings: usb: Add qcom,pmic-typec dt-binding header Bryan O'Donoghue
2023-03-19 11:50 ` Krzysztof Kozlowski
2023-03-19 14:50 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 06/18] dt-bindings: usb: Add Qualcomm PMIC Type-C controller YAML schema Bryan O'Donoghue
2023-03-19 11:53 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 07/18] dt-bindings: usb: Add qcom,pmic-pdphy dt-binding header Bryan O'Donoghue
2023-03-19 11:50 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 08/18] dt-bindings: usb: Add Qualcomm PMIC PDPHY controller YAML schema Bryan O'Donoghue
2023-03-19 11:55 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 09/18] dt-bindings: usb: Add Qualcomm PMIC TCPM " Bryan O'Donoghue
2023-03-19 11:58 ` Krzysztof Kozlowski
2023-03-19 14:59 ` Bryan O'Donoghue
2023-03-19 15:10 ` Krzysztof Kozlowski
2023-03-19 15:44 ` Bryan O'Donoghue
2023-03-19 17:50 ` Krzysztof Kozlowski
2023-03-19 21:31 ` Caleb Connolly [this message]
2023-03-19 22:34 ` Bryan O'Donoghue
2023-03-19 22:32 ` Bryan O'Donoghue
2023-03-19 15:50 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 10/18] dt-bindings: mfd: qcom,spmi-pmic: Add pdphy to SPMI device types Bryan O'Donoghue
2023-03-19 11:58 ` Krzysztof Kozlowski
2023-03-21 20:58 ` Rob Herring
2023-03-21 23:52 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 11/18] dt-bindings: mfd: qcom,spmi-pmic: Add typec " Bryan O'Donoghue
2023-03-19 11:59 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 12/18] usb: typec: qcom: Add Qualcomm PMIC TCPM support Bryan O'Donoghue
2023-03-23 14:36 ` Jianhua Lu
2023-03-23 17:31 ` Bryan O'Donoghue
2023-03-24 0:43 ` Jianhua Lu
2023-03-24 0:53 ` Bryan O'Donoghue
2023-03-24 1:13 ` Jianhua Lu
2023-03-24 2:37 ` Bryan O'Donoghue
2023-03-24 10:16 ` Jianhua Lu
2023-03-24 13:25 ` Bryan O'Donoghue
2023-03-24 15:09 ` Jianhua Lu
2023-03-24 16:03 ` Bryan O'Donoghue
2023-03-24 14:00 ` Heikki Krogerus
2023-03-24 14:22 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 13/18] phy: qcom-qmp: Register as a typec switch for orientation detection Bryan O'Donoghue
2023-03-18 16:42 ` kernel test robot
2023-03-20 11:15 ` Neil Armstrong
2023-03-20 11:19 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 14/18] arm64: dts: qcom: pm8150b: Add a TCPM description Bryan O'Donoghue
2023-03-18 13:13 ` Konrad Dybcio
2023-03-18 21:09 ` kernel test robot
2023-03-18 12:18 ` [PATCH v4 15/18] arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 16/18] arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM Bryan O'Donoghue
2023-03-18 13:09 ` Konrad Dybcio
2023-03-18 12:18 ` [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Bryan O'Donoghue
2023-03-18 13:10 ` Konrad Dybcio
2023-03-18 17:46 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 18/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy Bryan O'Donoghue
2023-03-18 13:11 ` Konrad Dybcio
2023-03-18 17:47 ` Bryan O'Donoghue
2023-03-24 15:10 ` [PATCH v4 00/18] Add Qualcomm PMIC TPCM support Luca Weiss
2023-03-24 15:28 ` Bryan O'Donoghue
2023-03-31 8:48 ` Luca Weiss
2023-03-31 13:52 ` Bryan O'Donoghue
2023-03-31 14:58 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5098322b-d09b-72ec-ac6a-128a6a64ea17@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robertom@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=subbaram@quicinc.com \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).