From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
<linux@roeck-us.net>, <heikki.krogerus@linux.intel.com>,
<gregkh@linuxfoundation.org>, <andersson@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<linux-usb@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <wcheng@codeaurora.org>, <caleb.connolly@linaro.org>,
<konrad.dybcio@linaro.org>, <subbaram@quicinc.com>,
<jackp@quicinc.com>, <robertom@qti.qualcomm.com>,
<lujianhua000@gmail.com>
Subject: Re: [PATCH v4 00/18] Add Qualcomm PMIC TPCM support
Date: Fri, 31 Mar 2023 16:58:49 +0200 [thread overview]
Message-ID: <CRKNOI8764EP.1IEYF5GFODE7G@otso> (raw)
In-Reply-To: <233c8e94-d926-c5b2-a0b7-87333d5cdc2a@linaro.org>
On Fri Mar 31, 2023 at 3:52 PM CEST, Bryan O'Donoghue wrote:
> On 31/03/2023 09:48, Luca Weiss wrote:
> > Hi Bryan,
> >
> > On Fri Mar 24, 2023 at 4:28 PM CET, Bryan O'Donoghue wrote:
> >> On 24/03/2023 15:10, Luca Weiss wrote:
> >>> When plugging in the device with TCPM on into my PC (peripheral mode)
> >>> then the USB device registers and unregisters every couple of seconds,
> >>> never stays stable on. No messages in dmesg when this happens. This only
> >>> happens with the USB-C plug in one direction, in the other it
> >>> works reliable.
> >>
> >> Sounds like we need to do some SoC specific debug on orientation
> >> switching in the PHY.
> >
> > I also know that the phone has a AW35743 chip in the USB path,
> > controlled by DP_AUX_EN and DP_AUX_SEL gpios but I think this is only
> > for displayport, right?
> >
>
> https://www.awinic.com/en/productDetail/AW35743CSR#product-details D+/D-
> looks like USB 2.x ..
>
> Your DP should go over TX1+/1 TX2+/- depending on orientation and # of
> lanes in use.
There's USB0_DP_AUX_P & USB0_DP_AUX_M from the SoC connected on the
D1+/- & D2+/- pins of this awinic chip, and out comes USB_SBU1 and
USB_SBU2 which goes to the USB connector. So just switching polarity of
those pins.
But let's say whatever it does, it's not relevant to this use case now
without DP?
>
> https://www.allaboutcircuits.com/uploads/articles/Fig1m11292018.png
>
> >>
> >> I wonder how many lanes dp_opts->lanes says for your part ?
> >
> > Not sure.. Where is this configured?
>
> Heh - now that I look my lane count == 0, a bug to be fixed..
>
> Hmm, Luca can you test this change
>
> - if (orientation == TYPEC_ORIENTATION_NONE) {
> - if (qmp->init_count)
> - ret = qmp_combo_dp_power_off(dp_phy);
> - } else {
> - if (!qmp->init_count)
> - ret = qmp_combo_dp_power_on(dp_phy);
> - }
> + if (orientation == TYPEC_ORIENTATION_NONE)
> + ret = qmp_combo_dp_power_off(dp_phy);
> + else
> + ret = qmp_combo_dp_power_on(dp_phy);
I unfortunately don't really see any change in behavior with this..
>
>
> > But I also don't have DisplayPort over USB-C (video out) configured yet.
> > Related question: does video out work on sm8250+pm8150b for you?
>
> Nope - WIP. I see getting TCPM upstream and working as a first step,
> then we look at introduction of the redriver, DP work, dt etc.
Clear, I look forward to that landing ;) But also already what the
driver does now is really useful!
Regards
Luca
>
>
> > [ 1722.130836] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: get_cc: misc 0x000000cb cc1 0x00000001 Ra cc2 0x00000002 Rd attached 1 cc=cc1
> >
> > - unplug -
> >
> > [ 1867.223052] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: get_cc: misc 0x00000042 cc1 0x00000000 Open cc2 0x00000000 Open attached 0 cc=cc1
> > ==================================================================================
> > USB unstable (device plug orientation 2):
> > ==================================================================================
> >
> > [ 1894.263324] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: get_cc: misc 0x000000c9 cc1 0x00000002 Rd cc2 0x00000001 Ra attached 1 cc=cc2
> > - unplug -
> >
> > [ 1907.264840] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: get_cc: misc 0x00000040 cc1 0x00000000 Open cc2 0x00000000 Open attached 0 cc=cc2
>
> Normal, correct.
>
> For reference on 8250
>
> Attached orientation reverse / cc2
>
> [ 77.719278] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: set_cc:
> currsrc=2 Rp-3.0-330uA mode EN_SRC_ONLY debounce 1 attached 1 cc=cc2
>
> Detached orientation (none)
> [ 82.475667] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: get_cc:
> misc 0x000000c0 cc1 0x00000000 Open cc2 0x00000000 Open attached 0 cc=cc2
>
> Attached orientation normal / cc1
> [ 82.485375] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500:
> start_toggling: misc 0x00000040 attached 0 port_type 0 current cc 5 new 5
> [ 85.247368] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: get_cc:
> misc 0x000000cb cc1 0x00000001 Ra cc2 0x00000002 Rd attached 1 cc=cc1
>
> Anyway I reckon that guard I have in the PHY code is wrong, would
> appreciate a test.
>
> ---
> bod
prev parent reply other threads:[~2023-03-31 14:58 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 12:18 [PATCH v4 00/18] Add Qualcomm PMIC TPCM support Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 01/18] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark reg as required Bryan O'Donoghue
2023-03-19 11:41 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 02/18] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark regulator-*-microamp required Bryan O'Donoghue
2023-03-19 11:42 ` Krzysztof Kozlowski
2023-03-19 11:53 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 03/18] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add orientation-switch as optional Bryan O'Donoghue
2023-03-19 11:42 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 04/18] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add port as an optional Bryan O'Donoghue
2023-03-19 11:45 ` Krzysztof Kozlowski
2023-03-21 20:49 ` Rob Herring
2023-03-22 14:01 ` Bryan O'Donoghue
2023-03-23 13:39 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 05/18] dt-bindings: usb: Add qcom,pmic-typec dt-binding header Bryan O'Donoghue
2023-03-19 11:50 ` Krzysztof Kozlowski
2023-03-19 14:50 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 06/18] dt-bindings: usb: Add Qualcomm PMIC Type-C controller YAML schema Bryan O'Donoghue
2023-03-19 11:53 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 07/18] dt-bindings: usb: Add qcom,pmic-pdphy dt-binding header Bryan O'Donoghue
2023-03-19 11:50 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 08/18] dt-bindings: usb: Add Qualcomm PMIC PDPHY controller YAML schema Bryan O'Donoghue
2023-03-19 11:55 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 09/18] dt-bindings: usb: Add Qualcomm PMIC TCPM " Bryan O'Donoghue
2023-03-19 11:58 ` Krzysztof Kozlowski
2023-03-19 14:59 ` Bryan O'Donoghue
2023-03-19 15:10 ` Krzysztof Kozlowski
2023-03-19 15:44 ` Bryan O'Donoghue
2023-03-19 17:50 ` Krzysztof Kozlowski
2023-03-19 21:31 ` Caleb Connolly
2023-03-19 22:34 ` Bryan O'Donoghue
2023-03-19 22:32 ` Bryan O'Donoghue
2023-03-19 15:50 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 10/18] dt-bindings: mfd: qcom,spmi-pmic: Add pdphy to SPMI device types Bryan O'Donoghue
2023-03-19 11:58 ` Krzysztof Kozlowski
2023-03-21 20:58 ` Rob Herring
2023-03-21 23:52 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 11/18] dt-bindings: mfd: qcom,spmi-pmic: Add typec " Bryan O'Donoghue
2023-03-19 11:59 ` Krzysztof Kozlowski
2023-03-18 12:18 ` [PATCH v4 12/18] usb: typec: qcom: Add Qualcomm PMIC TCPM support Bryan O'Donoghue
2023-03-23 14:36 ` Jianhua Lu
2023-03-23 17:31 ` Bryan O'Donoghue
2023-03-24 0:43 ` Jianhua Lu
2023-03-24 0:53 ` Bryan O'Donoghue
2023-03-24 1:13 ` Jianhua Lu
2023-03-24 2:37 ` Bryan O'Donoghue
2023-03-24 10:16 ` Jianhua Lu
2023-03-24 13:25 ` Bryan O'Donoghue
2023-03-24 15:09 ` Jianhua Lu
2023-03-24 16:03 ` Bryan O'Donoghue
2023-03-24 14:00 ` Heikki Krogerus
2023-03-24 14:22 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 13/18] phy: qcom-qmp: Register as a typec switch for orientation detection Bryan O'Donoghue
2023-03-18 16:42 ` kernel test robot
2023-03-20 11:15 ` Neil Armstrong
2023-03-20 11:19 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 14/18] arm64: dts: qcom: pm8150b: Add a TCPM description Bryan O'Donoghue
2023-03-18 13:13 ` Konrad Dybcio
2023-03-18 21:09 ` kernel test robot
2023-03-18 12:18 ` [PATCH v4 15/18] arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 16/18] arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM Bryan O'Donoghue
2023-03-18 13:09 ` Konrad Dybcio
2023-03-18 12:18 ` [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Bryan O'Donoghue
2023-03-18 13:10 ` Konrad Dybcio
2023-03-18 17:46 ` Bryan O'Donoghue
2023-03-18 12:18 ` [PATCH v4 18/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy Bryan O'Donoghue
2023-03-18 13:11 ` Konrad Dybcio
2023-03-18 17:47 ` Bryan O'Donoghue
2023-03-24 15:10 ` [PATCH v4 00/18] Add Qualcomm PMIC TPCM support Luca Weiss
2023-03-24 15:28 ` Bryan O'Donoghue
2023-03-31 8:48 ` Luca Weiss
2023-03-31 13:52 ` Bryan O'Donoghue
2023-03-31 14:58 ` Luca Weiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CRKNOI8764EP.1IEYF5GFODE7G@otso \
--to=luca.weiss@fairphone.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lujianhua000@gmail.com \
--cc=robertom@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=subbaram@quicinc.com \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).