From: kbuild test robot <lkp@intel.com>
To: Pascal PAILLET-LME <p.paillet@st.com>
Cc: kbuild-all@01.org,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"benjamin.gaignard@linaro.org" <benjamin.gaignard@linaro.org>,
"eballetbo@gmail.com" <eballetbo@gmail.com>,
Pascal PAILLET-LME <p.paillet@st.com>
Subject: Re: [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver
Date: Tue, 9 Oct 2018 08:47:26 +0800 [thread overview]
Message-ID: <201810090846.it9ed9td%fengguang.wu@intel.com> (raw)
In-Reply-To: <1539016176-4072-9-git-send-email-p.paillet@st.com>
[-- Attachment #1: Type: text/plain, Size: 3094 bytes --]
Hi pascal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on ljones-mfd/for-mfd-next]
[also build test WARNING on v4.19-rc7 next-20181008]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pascal-PAILLET-LME/Introduce-STPMIC1-PMIC-Driver/20181009-042808
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: ia64-allyesconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=ia64
All warnings (new ones prefixed by >>):
In file included from drivers/watchdog/stpmic1_wdt.c:10:
drivers/watchdog/stpmic1_wdt.c: In function 'pmic_wdt_stop':
>> drivers/watchdog/stpmic1_wdt.c:48:33: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551614' to '4294967294' [-Woverflow]
WCHDG_CR, WDT_START_MASK, ~WDT_START);
include/linux/regmap.h:77:42: note: in definition of macro 'regmap_update_bits'
regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
^~~
vim +48 drivers/watchdog/stpmic1_wdt.c
4
5 #include <linux/kernel.h>
6 #include <linux/mfd/stpmic1.h>
7 #include <linux/module.h>
8 #include <linux/platform_device.h>
9 #include <linux/of.h>
> 10 #include <linux/regmap.h>
11 #include <linux/slab.h>
12 #include <linux/watchdog.h>
13
14 /* WATCHDOG CONTROL REGISTER bit */
15 #define WDT_START BIT(0)
16 #define WDT_PING BIT(1)
17 #define WDT_START_MASK BIT(0)
18 #define WDT_PING_MASK BIT(1)
19
20 #define PMIC_WDT_MIN_TIMEOUT 1
21 #define PMIC_WDT_MAX_TIMEOUT 256
22 #define PMIC_WDT_DEFAULT_TIMEOUT 30
23
24 static bool nowayout = WATCHDOG_NOWAYOUT;
25 module_param(nowayout, bool, 0);
26 MODULE_PARM_DESC(nowayout,
27 "Watchdog cannot be stopped once started (default="
28 __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
29
30 struct stpmic1_wdt {
31 struct stpmic1 *pmic;
32 struct watchdog_device wdtdev;
33 };
34
35 static int pmic_wdt_start(struct watchdog_device *wdd)
36 {
37 struct stpmic1_wdt *wdt = watchdog_get_drvdata(wdd);
38
39 return regmap_update_bits(wdt->pmic->regmap,
40 WCHDG_CR, WDT_START_MASK, WDT_START);
41 }
42
43 static int pmic_wdt_stop(struct watchdog_device *wdd)
44 {
45 struct stpmic1_wdt *wdt = watchdog_get_drvdata(wdd);
46
47 return regmap_update_bits(wdt->pmic->regmap,
> 48 WCHDG_CR, WDT_START_MASK, ~WDT_START);
49 }
50
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54978 bytes --]
next prev parent reply other threads:[~2018-10-09 0:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 16:29 [PATCH v3 0/8] Introduce STPMIC1 PMIC Driver Pascal PAILLET-LME
2018-10-08 16:29 ` [PATCH v3 1/8] dt-bindings: mfd: document stpmic1 Pascal PAILLET-LME
2018-10-12 15:28 ` Rob Herring
2018-10-08 16:29 ` [PATCH v3 2/8] mfd: stpmic1: add stpmic1 driver Pascal PAILLET-LME
2018-10-08 16:29 ` [PATCH v3 3/8] dt-bindings: regulator: document stpmic1 pmic regulators Pascal PAILLET-LME
2018-10-12 15:32 ` Rob Herring
2018-10-08 16:29 ` [PATCH v3 4/8] regulator: stpmic1: add stpmic1 regulator driver Pascal PAILLET-LME
2018-10-08 16:29 ` [PATCH v3 5/8] dt-bindings: input: document stpmic1 pmic onkey Pascal PAILLET-LME
2018-10-09 13:52 ` Pascal PAILLET-LME
2018-10-12 15:33 ` Rob Herring
2018-10-08 16:29 ` [PATCH v3 7/8] dt-bindings: watchdog: document stpmic1 pmic watchdog Pascal PAILLET-LME
2018-10-08 16:29 ` [PATCH v3 6/8] input: stpmic1: add stpmic1 onkey driver Pascal PAILLET-LME
2018-10-15 22:32 ` dmitry.torokhov
2018-10-08 16:29 ` [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver Pascal PAILLET-LME
2018-10-08 16:35 ` Randy Dunlap
2018-10-09 0:47 ` kbuild test robot [this message]
2018-10-09 21:44 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201810090846.it9ed9td%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=kbuild-all@01.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).