From: Bob Copeland <me@bobcopeland.com>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, jirislaby@gmail.com, nbd@openwrt.org
Subject: Re: [ath5k-devel] [PATCH 4/4] ath5k: Use SWI to trigger calibration
Date: Fri, 31 Jul 2009 15:11:02 -0400 [thread overview]
Message-ID: <b6c5339f0907311211w4d810b23uc6ec8027924da647@mail.gmail.com> (raw)
In-Reply-To: <40f31dec0907311125o1654bd23jee861ba8bea57611@mail.gmail.com>
On Fri, Jul 31, 2009 at 2:25 PM, Nick Kossifidis<mickflemm@gmail.com> wrote:
> Also we don't need to run calibration if we are idle (no interrupts).
I think this is the big win right now...
> c) Having calibration on a tasklet is better since during calibration
> we can't transmit or receive (antennas are detached to measure
> noise floor), previously calibration could run in parallel with tx/rx
> and interfere (packet loss).
This can still happen, no? Two tasklets can run in parallel on
different processors, as long as they are different tasklets.
In practice, this won't happen much because tasklets run on the
cpu that scheduled them, and irq affinity is such (at least on my
hardware) that it's almost always the same CPU. But I think to
make the above true it needs to stop the queues etc when doing
calibration.
Also we are missing tasklet_kill()?
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-07-31 19:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 18:10 [PATCH 4/4] ath5k: Use SWI to trigger calibration Nick Kossifidis
2009-07-31 18:15 ` Luis R. Rodriguez
2009-07-31 18:25 ` [ath5k-devel] " Nick Kossifidis
2009-07-31 18:48 ` Luis R. Rodriguez
2009-07-31 19:09 ` Pavel Roskin
2009-07-31 19:35 ` Nick Kossifidis
2009-07-31 19:43 ` Pavel Roskin
2009-07-31 19:11 ` Bob Copeland [this message]
2009-07-31 19:52 ` Nick Kossifidis
2009-08-01 13:22 ` Bob Copeland
2009-08-01 13:31 ` Nick Kossifidis
2009-08-02 16:14 ` Bob Copeland
2009-07-31 18:34 ` Nick Kossifidis
2009-08-01 5:46 ` Nick Kossifidis
2009-08-01 8:19 ` Jiri Slaby
2009-08-01 8:21 ` Johannes Berg
2009-08-01 8:24 ` Jiri Slaby
2009-08-01 8:28 ` Johannes Berg
2009-08-01 8:31 ` [ath5k-devel] " Nick Kossifidis
2009-08-01 8:35 ` Jiri Slaby
2009-08-03 17:54 ` Nick Kossifidis
2009-08-07 14:55 ` John W. Linville
2009-08-07 19:50 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c5339f0907311211w4d810b23uc6ec8027924da647@mail.gmail.com \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=mickflemm@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).