* Re: [PATCH] Megaraid cleanup [not found] <9738BCBE884FDB42801FAD8A7769C265142031@NAMAIL1.ad.lsil.com> @ 2006-01-24 15:41 ` Jesper Juhl 2006-01-24 17:05 ` James Bottomley 0 siblings, 1 reply; 5+ messages in thread From: Jesper Juhl @ 2006-01-24 15:41 UTC (permalink / raw) To: Ju, Seokmann Cc: Linux Kernel Mailing List, James Bottomley, Kolli, Neela, linux-scsi On 1/24/06, Ju, Seokmann <Seokmann.Ju@lsil.com> wrote: > Hi, > > The patch has been verified and accepted. > > Thank you, > Great, thanks. I assume you'll take care of pushing it forward or should I do that? -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Megaraid cleanup 2006-01-24 15:41 ` [PATCH] Megaraid cleanup Jesper Juhl @ 2006-01-24 17:05 ` James Bottomley 2006-01-25 21:22 ` Jesper Juhl 0 siblings, 1 reply; 5+ messages in thread From: James Bottomley @ 2006-01-24 17:05 UTC (permalink / raw) To: Jesper Juhl Cc: Ju, Seokmann, Linux Kernel Mailing List, Kolli, Neela, linux-scsi On Tue, 2006-01-24 at 16:41 +0100, Jesper Juhl wrote: > I assume you'll take care of pushing it forward or should I do that? I can't actually find this patch on the SCSI list, so resending it would be a good start. James ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Megaraid cleanup 2006-01-24 17:05 ` James Bottomley @ 2006-01-25 21:22 ` Jesper Juhl 2006-02-09 21:06 ` Jesper Juhl 0 siblings, 1 reply; 5+ messages in thread From: Jesper Juhl @ 2006-01-25 21:22 UTC (permalink / raw) To: James Bottomley Cc: Ju, Seokmann, Linux Kernel Mailing List, Kolli, Neela, linux-scsi [-- Attachment #1: Type: text/plain, Size: 1835 bytes --] On 1/24/06, James Bottomley <James.Bottomley@steeleye.com> wrote: > On Tue, 2006-01-24 at 16:41 +0100, Jesper Juhl wrote: > > I assume you'll take care of pushing it forward or should I do that? > > I can't actually find this patch on the SCSI list, so resending it would > be a good start. > Hmm, I guess it never made it due to size. Below is the description I initially wrote for the patch and the patch itself is attached as a bzip2 archive so it will hopefully make it to you. From: Jesper Juhl <jesper.juhl@gmail.com> Ok, I went into drivers/scsi/megaraid.c just to fix a few compiler warnings, but ended up doing a big spring-cleaning. I'm sorry this patch is not split into one patch pr logical change, but I did everything in one go from the top of the file to the bottom and splitting the changes after I was done would have been a big task in itself. Since all the changes are pretty trivial I hope it'll be acceptable as-is, but if not then let me know and I'll try and split it up. Here's a summary of the changes made : - CodingStyle & Whitespace cleanups, incl. removing excessive blank lines. - Merge some printk's. - Remove some pointless casts. - Remove some pointless initializations of variables to 0. - Merge some variable initializations. - return is not a function. - Remove unneeded variables. - Fix two warnings ; drivers/scsi/megaraid.c:3660: warning: ignoring return value of `copy_to_user', declared with attribute warn_unused_result drivers/scsi/megaraid.c:4473: warning: unused variable `flags' Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html [-- Attachment #2: megaraid-cleanup.patch.bz2 --] [-- Type: application/x-bzip2, Size: 20967 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Megaraid cleanup 2006-01-25 21:22 ` Jesper Juhl @ 2006-02-09 21:06 ` Jesper Juhl 0 siblings, 0 replies; 5+ messages in thread From: Jesper Juhl @ 2006-02-09 21:06 UTC (permalink / raw) To: James Bottomley Cc: Ju, Seokmann, Linux Kernel Mailing List, Kolli, Neela, linux-scsi On 1/25/06, Jesper Juhl <jesper.juhl@gmail.com> wrote: > On 1/24/06, James Bottomley <James.Bottomley@steeleye.com> wrote: > > On Tue, 2006-01-24 at 16:41 +0100, Jesper Juhl wrote: > > > I assume you'll take care of pushing it forward or should I do that? > > > > I can't actually find this patch on the SCSI list, so resending it would > > be a good start. > > > Hmm, I guess it never made it due to size. > > Below is the description I initially wrote for the patch and the patch > itself is attached as a bzip2 archive so it will hopefully make it to > you. > James: any comments on the patch? Any chance it'll be applied to mainline? If there's anything you want/need me to redo then please just let me know and I'll be happy to work out any issues there might be. -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <9738BCBE884FDB42801FAD8A7769C265142001@NAMAIL1.ad.lsil.com>]
* Re: [PATCH] Megaraid cleanup [not found] <9738BCBE884FDB42801FAD8A7769C265142001@NAMAIL1.ad.lsil.com> @ 2006-01-10 21:03 ` Jesper Juhl 0 siblings, 0 replies; 5+ messages in thread From: Jesper Juhl @ 2006-01-10 21:03 UTC (permalink / raw) To: Ju, Seokmann Cc: Linux Kernel Mailing List, James Bottomley, Kolli, Neela, linux-scsi On 1/10/06, Ju, Seokmann <Seokmann.Ju@lsil.com> wrote: > Hi, > > Ok, I went into drivers/scsi/megaraid.c just to fix a few > > compiler warnings, > > but ended up doing a big spring-cleaning. > > Thank you for the patch first of all. You're welcome. > I would like to step through the changes in the patch and > Will get back to you. > I would think you've already verified the patch by testing > The updated driver. Please confirm this. > As far as I could without having access to actual hardware, yes. That means I've read through my changes and tried to verify them visually/logically. I've also compile tested it - it builds fine. And I've also attempted to load it, and it fails (due to no hardware) as it's supposed to. Beyond that I'm unable to test it. -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-02-09 21:06 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <9738BCBE884FDB42801FAD8A7769C265142031@NAMAIL1.ad.lsil.com> 2006-01-24 15:41 ` [PATCH] Megaraid cleanup Jesper Juhl 2006-01-24 17:05 ` James Bottomley 2006-01-25 21:22 ` Jesper Juhl 2006-02-09 21:06 ` Jesper Juhl [not found] <9738BCBE884FDB42801FAD8A7769C265142001@NAMAIL1.ad.lsil.com> 2006-01-10 21:03 ` Jesper Juhl
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).