Re: [PATCH] Megaraid cleanup

Re: [PATCH] Megaraid cleanup

[Jesper Juhl]

On 1/10/06, Ju, Seokmann <Seokmann.Ju@lsil.com> wrote:
> Hi,
> > Ok, I went into drivers/scsi/megaraid.c just to fix a few
> > compiler warnings,
> > but ended up doing a big spring-cleaning.
>
> Thank you for the patch first of all.

You're welcome.

> I would like to step through the changes in the patch and
> Will get back to you.
> I would think you've already verified the patch by testing
> The updated driver. Please confirm this.
>
As far as I could without having access to actual hardware, yes.
That means I've read through my changes and tried to verify them
visually/logically.
I've also compile tested it - it builds fine.
And I've also attempted to load it, and it fails (due to no hardware)
as it's supposed to.
Beyond that I'm unable to test it.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [PATCH] Megaraid cleanup

[Jesper Juhl]

On 1/25/06, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> On 1/24/06, James Bottomley <James.Bottomley@steeleye.com> wrote:
> > On Tue, 2006-01-24 at 16:41 +0100, Jesper Juhl wrote:
> > > I assume you'll take care of pushing it forward or should I do that?
> >
> > I can't actually find this patch on the SCSI list, so resending it would
> > be a good start.
> >
> Hmm, I guess it never made it due to size.
>
> Below is the description I initially wrote for the patch and the patch
> itself is attached as a bzip2 archive so it will hopefully make it to
> you.
>

James: any comments on the patch?
Any chance it'll be applied to mainline?
If there's anything you want/need me to redo then please just let me
know and I'll be happy to work out any issues there might be.


--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [PATCH] Megaraid cleanup

[Jesper Juhl]

[-- Attachment #1: Type: text/plain, Size: 1835 bytes --]

On 1/24/06, James Bottomley <James.Bottomley@steeleye.com> wrote:
> On Tue, 2006-01-24 at 16:41 +0100, Jesper Juhl wrote:
> > I assume you'll take care of pushing it forward or should I do that?
>
> I can't actually find this patch on the SCSI list, so resending it would
> be a good start.
>
Hmm, I guess it never made it due to size.

Below is the description I initially wrote for the patch and the patch
itself is attached as a bzip2 archive so it will hopefully make it to
you.



From: Jesper Juhl <jesper.juhl@gmail.com>


Ok, I went into drivers/scsi/megaraid.c just to fix a few compiler warnings,
but ended up doing a big spring-cleaning.

I'm sorry this patch is not split into one patch pr logical change, but I
did everything in one go from the top of the file to the bottom and
splitting the changes after I was done would have been a big task in itself.
Since all the changes are pretty trivial I hope it'll be acceptable as-is,
but if not then let me know and I'll try and split it up.

Here's a summary of the changes made :


 - CodingStyle & Whitespace cleanups, incl. removing excessive blank lines.
 - Merge some printk's.
 - Remove some pointless casts.
 - Remove some pointless initializations of variables to 0.
 - Merge some variable initializations.
 - return is not a function.
 - Remove unneeded variables.
 - Fix two warnings ;
    drivers/scsi/megaraid.c:3660: warning: ignoring return value of
`copy_to_user', declared with attribute warn_unused_result
    drivers/scsi/megaraid.c:4473: warning: unused variable `flags'


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>



--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

[-- Attachment #2: megaraid-cleanup.patch.bz2 --]
[-- Type: application/x-bzip2, Size: 20967 bytes --]

Re: [PATCH] Megaraid cleanup

[James Bottomley]

On Tue, 2006-01-24 at 16:41 +0100, Jesper Juhl wrote:
> I assume you'll take care of pushing it forward or should I do that?

I can't actually find this patch on the SCSI list, so resending it would
be a good start.

James

Re: [PATCH] Megaraid cleanup

[Jesper Juhl]

On 1/24/06, Ju, Seokmann <Seokmann.Ju@lsil.com> wrote:
> Hi,
>
> The patch has been verified and accepted.
>
> Thank you,
>

Great, thanks.
I assume you'll take care of pushing it forward or should I do that?

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html