From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Mike Galbraith <efault@gmx.de>
Cc: Paul Turner <pjt@google.com>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] sched: automated per session task groups
Date: Tue, 30 Nov 2010 14:48:07 +0100 [thread overview]
Message-ID: <1291124887.32004.791.camel@laptop> (raw)
In-Reply-To: <1291123083.28239.18.camel@marge.simson.net>
On Tue, 2010-11-30 at 14:18 +0100, Mike Galbraith wrote:
>
> From: Mike Galbraith <efault@gmx.de>
> Date: Tue Nov 30 14:07:12 CET 2010
> Subject: [PATCH] sched: Improve desktop interactivity: Implement automated per session task groups
>
> A recurring complaint from CFS users is that parallel kbuild has a negative
> impact on desktop interactivity. This patch implements an idea from Linus,
> to automatically create task groups. Currently, only per session autogroups
> are implemented, but the patch leaves the way open for enhancement.
>
> Implementation: each task's signal struct contains an inherited pointer to
> a refcounted autogroup struct containing a task group pointer, the default
> for all tasks pointing to the init_task_group. When a task calls setsid(),
> a new task group is created, the process is moved into the new task group,
> and a reference to the preveious task group is dropped. Child processes
> inherit this task group thereafter, and increase it's refcount. When the
> last thread of a process exits, the process's reference is dropped, such
> that when the last process referencing an autogroup exits, the autogroup
> is destroyed.
>
> At runqueue selection time, IFF a task has no cgroup assignment, its current
> autogroup is used.
>
> Autogroup bandwidth is controllable via setting it's nice level through the
> proc filesystem. cat /proc/<pid>/autogroup displays the task's group and the
> group's nice level. echo <nice level> > /proc/<pid>/autogroup Sets the task
> group's shares to the weight of nice <level> task. Setting nice level is rate
> limited for !admin users due to the abuse risk of task group locking.
>
> The feature is enabled from boot by default if CONFIG_SCHED_AUTOGROUP=y is
> selected, but can be disabled via the boot option noautogroup, and can also
> be turned on/off on the fly via..
> echo [01] > /proc/sys/kernel/sched_autogroup_enabled.
> ..which will automatically move tasks to/from the root task group.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> LKML-Reference: <1290281700.28711.9.camel@maggy.simson.net>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Looks good to me, Thanks Mike!
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
next prev parent reply other threads:[~2010-11-30 13:49 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 13:37 [PATCH v4] sched: automated per session task groups Ingo Molnar
2010-11-21 13:39 ` Ingo Molnar
2010-11-21 15:44 ` Oleg Nesterov
2010-11-21 16:35 ` Mike Galbraith
2010-11-21 16:15 ` Mike Galbraith
2010-11-21 18:43 ` Gene Heskett
2010-11-25 16:00 ` Mike Galbraith
2010-11-28 14:24 ` Mike Galbraith
2010-11-28 19:31 ` Linus Torvalds
2010-11-28 20:18 ` Ingo Molnar
2010-11-29 11:53 ` Peter Zijlstra
2010-11-29 12:30 ` Ingo Molnar
2010-11-29 13:45 ` Mike Galbraith
2010-11-29 13:47 ` Ingo Molnar
2010-11-29 14:04 ` Mike Galbraith
2010-11-29 16:27 ` Linus Torvalds
2010-11-29 16:44 ` Ingo Molnar
2010-11-29 17:37 ` Peter Zijlstra
2010-11-29 18:03 ` Ingo Molnar
2010-11-29 19:06 ` Mike Galbraith
2010-11-29 19:20 ` Ingo Molnar
2010-11-30 3:39 ` Paul Turner
2010-11-30 4:14 ` Mike Galbraith
2010-11-30 4:23 ` Paul Turner
2010-11-30 13:18 ` Mike Galbraith
2010-11-30 13:48 ` Peter Zijlstra [this message]
2010-11-30 13:59 ` Ingo Molnar
2010-11-30 14:13 ` Ingo Molnar
2010-11-30 16:41 ` Mike Galbraith
2010-11-30 15:17 ` Vivek Goyal
2010-11-30 17:13 ` Mike Galbraith
2010-11-30 19:36 ` Vivek Goyal
2010-12-01 5:01 ` Américo Wang
2010-12-01 6:09 ` Mike Galbraith
2010-12-01 11:36 ` Peter Zijlstra
2010-12-01 22:12 ` Valdis.Kletnieks
2010-12-01 5:57 ` Mike Galbraith
2010-12-01 11:33 ` Peter Zijlstra
2010-12-01 11:55 ` Mike Galbraith
2010-12-01 14:55 ` Vivek Goyal
2010-12-01 15:04 ` Mike Galbraith
2010-11-30 7:54 ` Mike Galbraith
2010-11-30 14:18 ` Ingo Molnar
2010-11-30 14:53 ` Ingo Molnar
2010-11-30 15:01 ` Peter Zijlstra
2010-11-30 15:11 ` Ingo Molnar
2010-11-30 16:28 ` Mike Galbraith
2010-11-29 5:45 ` Mike Galbraith
2010-12-01 3:39 ` Paul Turner
2010-12-01 3:39 ` Paul Turner
2010-12-01 6:16 ` Mike Galbraith
2010-12-03 5:11 ` Paul Turner
2010-12-03 6:48 ` Mike Galbraith
2010-12-03 8:37 ` Paul Turner
2010-12-04 23:55 ` James Courtier-Dutton
2010-12-05 5:11 ` Paul Turner
2010-12-07 11:32 ` Paul Turner
2010-12-15 12:10 ` Paul Turner
2010-12-01 11:34 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2010-11-15 1:13 [RFC/RFT PATCH v3] sched: automated per tty " Mike Galbraith
2010-11-15 8:57 ` Peter Zijlstra
2010-11-15 11:32 ` Mike Galbraith
2010-11-15 11:46 ` Mike Galbraith
2010-11-15 12:57 ` Oleg Nesterov
2010-11-15 21:25 ` Mike Galbraith
2010-11-16 13:04 ` Oleg Nesterov
2010-11-16 14:18 ` Mike Galbraith
2010-11-16 15:03 ` Oleg Nesterov
2010-11-16 15:41 ` Mike Galbraith
2010-11-16 17:28 ` Ingo Molnar
2010-11-20 19:35 ` [PATCH v4] sched: automated per session " Mike Galbraith
2010-12-04 17:39 ` Colin Walters
2010-12-04 18:33 ` Linus Torvalds
2010-12-04 20:01 ` Colin Walters
2010-12-04 22:39 ` Linus Torvalds
2010-12-04 23:43 ` Colin Walters
2010-12-05 0:31 ` Linus Torvalds
2010-12-05 7:47 ` Ray Lee
2010-12-05 19:22 ` Colin Walters
2010-12-05 20:47 ` Linus Torvalds
2010-12-05 22:47 ` Colin Walters
2010-12-05 22:58 ` Jesper Juhl
2010-12-05 23:05 ` Jesper Juhl
2010-12-07 18:51 ` Peter Zijlstra
2010-12-05 10:18 ` Con Kolivas
2010-12-05 11:36 ` Mike Galbraith
2010-12-05 20:58 ` Ingo Molnar
2010-12-04 23:31 ` david
2010-12-05 11:11 ` Nikos Chantziaras
2010-12-06 0:28 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291124887.32004.791.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=pjt@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).