From: Fenghua Yu <fenghua.yu@intel.com>
To: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>, "H Peter Anvin" <hpa@zytor.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Lu Baolu" <baolu.lu@linux.intel.com>,
"Frederic Barrat" <fbarrat@linux.ibm.com>,
"Andrew Donnellan" <ajd@linux.ibm.com>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Dave Hansen" <dave.hansen@intel.com>,
"Tony Luck" <tony.luck@intel.com>,
"Ashok Raj" <ashok.raj@intel.com>,
"Jacob Jun Pan" <jacob.jun.pan@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Yu-cheng Yu" <yu-cheng.yu@intel.com>,
"Sohil Mehta" <sohil.mehta@intel.com>,
"Ravi V Shankar" <ravi.v.shankar@intel.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
"x86" <x86@kernel.org>,
iommu@lists.linux-foundation.org,
"amd-gfx" <amd-gfx@lists.freedesktop.org>,
"linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: [PATCH v2 03/12] iommu/vt-d: Change flags type to unsigned int in binding mm
Date: Fri, 12 Jun 2020 17:41:24 -0700 [thread overview]
Message-ID: <1592008893-9388-4-git-send-email-fenghua.yu@intel.com> (raw)
In-Reply-To: <1592008893-9388-1-git-send-email-fenghua.yu@intel.com>
"flags" passed to intel_svm_bind_mm() is a bit mask and should be
defined as "unsigned int" instead of "int".
Change its type to "unsigned int".
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
---
v2:
- Add this new patch per Thomas' comment.
drivers/iommu/intel/svm.c | 7 ++++---
include/linux/intel-iommu.h | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index b5618341b4b1..4e775e12ae52 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -427,7 +427,8 @@ int intel_svm_unbind_gpasid(struct device *dev, unsigned int pasid)
/* Caller must hold pasid_mutex, mm reference */
static int
-intel_svm_bind_mm(struct device *dev, int flags, struct svm_dev_ops *ops,
+intel_svm_bind_mm(struct device *dev, unsigned int flags,
+ struct svm_dev_ops *ops,
struct mm_struct *mm, struct intel_svm_dev **sd)
{
struct intel_iommu *iommu = intel_svm_device_to_iommu(dev);
@@ -954,7 +955,7 @@ intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata)
{
struct iommu_sva *sva = ERR_PTR(-EINVAL);
struct intel_svm_dev *sdev = NULL;
- int flags = 0;
+ unsigned int flags = 0;
int ret;
/*
@@ -963,7 +964,7 @@ intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata)
* and intel_svm etc.
*/
if (drvdata)
- flags = *(int *)drvdata;
+ flags = *(unsigned int *)drvdata;
mutex_lock(&pasid_mutex);
ret = intel_svm_bind_mm(dev, flags, NULL, mm, &sdev);
if (ret)
diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
index 44fa8879f829..9abc30cf10fc 100644
--- a/include/linux/intel-iommu.h
+++ b/include/linux/intel-iommu.h
@@ -759,7 +759,7 @@ struct intel_svm {
struct mm_struct *mm;
struct intel_iommu *iommu;
- int flags;
+ unsigned int flags;
unsigned int pasid;
int gpasid; /* In case that guest PASID is different from host PASID */
struct list_head devs;
--
2.19.1
next prev parent reply other threads:[~2020-06-13 0:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 0:41 [PATCH v2 00/12] x86: tag application address space for devices Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 01/12] iommu: Change type of pasid to unsigned int Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 02/12] ocxl: " Fenghua Yu
2020-06-18 8:05 ` Frederic Barrat
2020-06-18 15:37 ` Fenghua Yu
2020-06-18 16:56 ` Frederic Barrat
2020-06-13 0:41 ` Fenghua Yu [this message]
2020-06-13 0:41 ` [PATCH v2 04/12] docs: x86: Add documentation for SVA (Shared Virtual Addressing) Fenghua Yu
2020-06-13 12:17 ` Lu Baolu
2020-06-15 23:16 ` Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 05/12] x86/cpufeatures: Enumerate ENQCMD and ENQCMDS instructions Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 06/12] x86/fpu/xstate: Add supervisor PASID state for ENQCMD feature Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 07/12] x86/msr-index: Define IA32_PASID MSR Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 08/12] mm: Define pasid in mm Fenghua Yu
2020-06-16 8:28 ` Jean-Philippe Brucker
2020-06-16 15:11 ` Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 09/12] fork: Clear PASID for new mm Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 10/12] x86/process: Clear PASID state for a newly forked/cloned thread Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 11/12] x86/mmu: Allocate/free PASID Fenghua Yu
2020-06-13 13:07 ` Lu Baolu
2020-06-15 2:13 ` Lu Baolu
2020-06-13 0:41 ` [PATCH v2 12/12] x86/traps: Fix up invalid PASID Fenghua Yu
2020-06-15 7:53 ` Peter Zijlstra
2020-06-15 7:56 ` Peter Zijlstra
2020-06-15 15:48 ` Fenghua Yu
2020-06-15 16:03 ` Peter Zijlstra
2020-06-15 17:11 ` Luck, Tony
2020-06-15 18:12 ` Fenghua Yu
2020-06-15 18:31 ` Peter Zijlstra
2020-06-15 18:55 ` Fenghua Yu
2020-06-15 19:09 ` Peter Zijlstra
2020-06-15 20:17 ` Fenghua Yu
2020-06-15 20:51 ` Andy Lutomirski
2020-06-15 20:56 ` Luck, Tony
2020-06-15 21:18 ` Andy Lutomirski
2020-06-15 21:24 ` Luck, Tony
2020-06-15 21:53 ` Peter Zijlstra
2020-06-16 23:23 ` Fenghua Yu
2020-06-17 8:31 ` Peter Zijlstra
2020-06-15 18:19 ` Raj, Ashok
2020-06-15 18:32 ` Peter Zijlstra
2020-06-15 7:52 ` [PATCH v2 00/12] x86: tag application address space for devices Peter Zijlstra
2020-06-15 14:53 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592008893-9388-4-git-send-email-fenghua.yu@intel.com \
--to=fenghua.yu@intel.com \
--cc=Felix.Kuehling@amd.com \
--cc=ajd@linux.ibm.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.jiang@intel.com \
--cc=dwmw2@infradead.org \
--cc=fbarrat@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).