From: Fenghua Yu <fenghua.yu@intel.com>
To: Frederic Barrat <fbarrat@linux.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Andrew Donnellan <ajd@linux.ibm.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Joerg Roedel <joro@8bytes.org>,
Dave Hansen <dave.hansen@intel.com>,
Tony Luck <tony.luck@intel.com>, Ashok Raj <ashok.raj@intel.com>,
Jacob Jun Pan <jacob.jun.pan@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>,
Sohil Mehta <sohil.mehta@intel.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
iommu@lists.linux-foundation.org,
amd-gfx <amd-gfx@lists.freedesktop.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 02/12] ocxl: Change type of pasid to unsigned int
Date: Thu, 18 Jun 2020 08:37:47 -0700 [thread overview]
Message-ID: <20200618153747.GE15763@romley-ivt3.sc.intel.com> (raw)
In-Reply-To: <972dc2cb-9643-53af-b11d-ebb56d96053d@linux.ibm.com>
Hi, Frederic,
On Thu, Jun 18, 2020 at 10:05:19AM +0200, Frederic Barrat wrote:
>
>
> Le 13/06/2020 à 02:41, Fenghua Yu a écrit :
> >PASID is defined as "int" although it's a 20-bit value and shouldn't be
> >negative int. To be consistent with type defined in iommu, define PASID
> >as "unsigned int".
>
>
> It looks like this patch was considered because of the use of 'pasid' in
> variable or function names. The ocxl driver only makes sense on powerpc and
> shouldn't compile on anything else, so it's probably useless in the context
> of that series.
> The pasid here is defined by the opencapi specification
> (https://opencapi.org), it is borrowed from the PCI world and you could
> argue it could be an unsigned int. But then I think the patch doesn't go far
> enough. But considering it's not used on x86, I think this patch can be
> dropped.
The first 3 patches clean up pasid and flag defitions to prepare for
following patches.
If you think this patch can be dropped, we will drop it.
Thanks.
-Fenghua
next prev parent reply other threads:[~2020-06-18 15:37 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 0:41 [PATCH v2 00/12] x86: tag application address space for devices Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 01/12] iommu: Change type of pasid to unsigned int Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 02/12] ocxl: " Fenghua Yu
2020-06-18 8:05 ` Frederic Barrat
2020-06-18 15:37 ` Fenghua Yu [this message]
2020-06-18 16:56 ` Frederic Barrat
2020-06-13 0:41 ` [PATCH v2 03/12] iommu/vt-d: Change flags type to unsigned int in binding mm Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 04/12] docs: x86: Add documentation for SVA (Shared Virtual Addressing) Fenghua Yu
2020-06-13 12:17 ` Lu Baolu
2020-06-15 23:16 ` Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 05/12] x86/cpufeatures: Enumerate ENQCMD and ENQCMDS instructions Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 06/12] x86/fpu/xstate: Add supervisor PASID state for ENQCMD feature Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 07/12] x86/msr-index: Define IA32_PASID MSR Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 08/12] mm: Define pasid in mm Fenghua Yu
2020-06-16 8:28 ` Jean-Philippe Brucker
2020-06-16 15:11 ` Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 09/12] fork: Clear PASID for new mm Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 10/12] x86/process: Clear PASID state for a newly forked/cloned thread Fenghua Yu
2020-06-13 0:41 ` [PATCH v2 11/12] x86/mmu: Allocate/free PASID Fenghua Yu
2020-06-13 13:07 ` Lu Baolu
2020-06-15 2:13 ` Lu Baolu
2020-06-13 0:41 ` [PATCH v2 12/12] x86/traps: Fix up invalid PASID Fenghua Yu
2020-06-15 7:53 ` Peter Zijlstra
2020-06-15 7:56 ` Peter Zijlstra
2020-06-15 15:48 ` Fenghua Yu
2020-06-15 16:03 ` Peter Zijlstra
2020-06-15 17:11 ` Luck, Tony
2020-06-15 18:12 ` Fenghua Yu
2020-06-15 18:31 ` Peter Zijlstra
2020-06-15 18:55 ` Fenghua Yu
2020-06-15 19:09 ` Peter Zijlstra
2020-06-15 20:17 ` Fenghua Yu
2020-06-15 20:51 ` Andy Lutomirski
2020-06-15 20:56 ` Luck, Tony
2020-06-15 21:18 ` Andy Lutomirski
2020-06-15 21:24 ` Luck, Tony
2020-06-15 21:53 ` Peter Zijlstra
2020-06-16 23:23 ` Fenghua Yu
2020-06-17 8:31 ` Peter Zijlstra
2020-06-15 18:19 ` Raj, Ashok
2020-06-15 18:32 ` Peter Zijlstra
2020-06-15 7:52 ` [PATCH v2 00/12] x86: tag application address space for devices Peter Zijlstra
2020-06-15 14:53 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618153747.GE15763@romley-ivt3.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=Felix.Kuehling@amd.com \
--cc=ajd@linux.ibm.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.jiang@intel.com \
--cc=dwmw2@infradead.org \
--cc=fbarrat@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).