linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Jerome Marchand <jmarchan@redhat.com>,
	Arnd Bergmann <arnd@arndb.de>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	mingo@elte.hu, david.woodhouse@intel.com, gregkh@suse.de,
	davem@davemloft.net, axboe@kernel.dk, holt@sgi.com,
	linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
	hskinnemoen@gmail.com, egtvedt@samfundet.no, msalter@redhat.com,
	a-jacquiot@ti.com, starvik@axis.com, jesper.nilsson@axis.com,
	dhowells@redhat.com, takata@linux-m32r.org, geert@linux-m68k.org,
	yasutake.koichi@jp.panasonic.com, jonas@southpole.se,
	kyle@mcmartin.ca, deller@gmx.de, jejb@parisc-linux.org,
	chris@zankel.net, greg@kroah.com, davej@redhat.com,
	airlied@linux.ie, jkosina@suse.cz, mchehab@infradead.org,
	johannes@sipsolutions.net, linville@tuxdriver.com
Subject: Re: [PATCH] kconfig: untangle EXPERT and EMBEDDED
Date: Tue, 17 Jan 2012 15:46:44 +0100	[thread overview]
Message-ID: <20120117144644.GC3188@turtle.usersys.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201161530170.16270@chino.kir.corp.google.com>

On Mon, Jan 16, 2012 at 03:37:01PM -0800, David Rientjes wrote:
> > For instance, Why would CONFIG_EXPERT disable by default some HID devices?
> > I could understand why it is done for CONFIG_EMBEDDED, but certainly not
> > for an general EXPERT option.
> > 
> 
> Then this is a prime example that you've identified were it would make 
> sense to have the default value be dependant on EMBEDDED rather than 
> EXPERT.  Feel free to send a patch to the HID maintainers.
> 

How would you propose to write this patch? You say the default value
should be dependant on EMBEDDED, instead of EXPERT? So maybe something
like

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index a421abd..73c2d39 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -63,7 +63,7 @@ menu "Special HID drivers"
 config HID_A4TECH
        tristate "A4 tech mice" if EXPERT
        depends on USB_HID
-       default !EXPERT
+       default !EMBEDDED
        ---help---
        Support for A4 tech X5 and WOP-35 / Trust 450L mice.

and the other HID drivers...

I guess it could be changed to 'if EXPERT || EMBEDDED', but at the moment
EMBEDDED selects EXPERT, so that's not currently necessary. I guess what's
above should be sufficient then. Oh, wait! That's exactly what this patch
does! And anybody who actually read it would have seen that.

I'm sorry if my writing style is starting to become a bit sarcastic. I
tend to get that way when I'm overly irritated. And I tend to get
irritated when people nack patches without reading them.

BTW, the HID maintainer, Jiri Kosina, is already on cc, since I cc'ed
every maintainer of the files that this patch touches.

Drew

  reply	other threads:[~2012-01-17 14:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 15:16 [PATCH] kconfig: untangle EXPERT and EMBEDDED Andrew Jones
2012-01-11 21:57 ` David Rientjes
2012-01-12  9:18   ` Arnd Bergmann
2012-01-12 10:18     ` Andrew Jones
2012-01-12 21:06       ` David Rientjes
2012-01-13  8:51         ` Andrew Jones
2012-01-13 10:53           ` David Rientjes
2012-01-13 12:22             ` Andrew Jones
2012-01-13 21:27               ` David Rientjes
2012-01-16  9:20                 ` Andrew Jones
2012-01-16 23:28                   ` David Rientjes
2012-01-17 14:27                     ` Andrew Jones
2012-01-17 20:46                       ` David Rientjes
2012-01-18  8:14                         ` Andrew Jones
2012-01-18  9:19                           ` David Rientjes
2012-01-16 15:31                 ` Jerome Marchand
2012-01-16 23:37                   ` David Rientjes
2012-01-17 14:46                     ` Andrew Jones [this message]
2012-01-17 20:54                       ` David Rientjes
2012-01-18  8:51                         ` Jerome Marchand
2012-01-18  8:56                         ` Andrew Jones
2012-01-18  9:31                           ` David Rientjes
2012-01-18  9:54                             ` Andrew Jones
2012-01-18  9:38                         ` Andrew Jones
2012-01-12 20:59     ` David Rientjes
2012-01-16 15:40 ` Jerome Marchand
2012-01-16 15:50   ` Andrew Jones
2012-01-16 17:34     ` Geert Uytterhoeven
2012-01-17  8:28       ` Andrew Jones
2012-01-18 11:08 ` Andrew Jones
2012-01-18 20:28   ` Andrew Morton
2012-01-18 20:46     ` Russell King - ARM Linux
2012-01-18 21:04     ` Alexey Dobriyan
2012-01-18 21:36       ` Andrew Morton
2012-01-18 21:48     ` Paul Bolle
2012-01-18 21:55       ` Andrew Morton
2012-01-18 22:13         ` Russell King - ARM Linux
2012-01-18 22:06       ` Alexey Dobriyan
2012-01-18 22:13       ` Dave Jones
2012-01-19  8:09     ` Andrew Jones
2012-01-23 13:46     ` Andrew Jones
2012-01-24  0:43       ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120117144644.GC3188@turtle.usersys.redhat.com \
    --to=drjones@redhat.com \
    --cc=a-jacquiot@ti.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=chris@zankel.net \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=david.woodhouse@intel.com \
    --cc=deller@gmx.de \
    --cc=dhowells@redhat.com \
    --cc=egtvedt@samfundet.no \
    --cc=geert@linux-m68k.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=holt@sgi.com \
    --cc=hskinnemoen@gmail.com \
    --cc=jejb@parisc-linux.org \
    --cc=jesper.nilsson@axis.com \
    --cc=jkosina@suse.cz \
    --cc=jmarchan@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=jonas@southpole.se \
    --cc=kyle@mcmartin.ca \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linville@tuxdriver.com \
    --cc=mchehab@infradead.org \
    --cc=mingo@elte.hu \
    --cc=msalter@redhat.com \
    --cc=rientjes@google.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=yasutake.koichi@jp.panasonic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).