From: Andrew Jones <drjones@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Jerome Marchand <jmarchan@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
mingo@elte.hu, david.woodhouse@intel.com, gregkh@suse.de,
davem@davemloft.net, axboe@kernel.dk, holt@sgi.com,
linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
hskinnemoen@gmail.com, egtvedt@samfundet.no, msalter@redhat.com,
a-jacquiot@ti.com, starvik@axis.com, jesper.nilsson@axis.com,
dhowells@redhat.com, takata@linux-m32r.org, geert@linux-m68k.org,
yasutake.koichi@jp.panasonic.com, jonas@southpole.se,
kyle@mcmartin.ca, deller@gmx.de, jejb@parisc-linux.org,
chris@zankel.net, greg@kroah.com, davej@redhat.com,
airlied@linux.ie, jkosina@suse.cz, mchehab@infradead.org,
johannes@sipsolutions.net, linville@tuxdriver.com
Subject: Re: [PATCH] kconfig: untangle EXPERT and EMBEDDED
Date: Wed, 18 Jan 2012 10:38:19 +0100 [thread overview]
Message-ID: <20120118093818.GC2317@turtle.usersys.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201171246280.2595@chino.kir.corp.google.com>
On Tue, Jan 17, 2012 at 12:54:01PM -0800, David Rientjes wrote:
> When it's configurable only for CONFIG_EMBEDDED, then you can propose that
> to the HID maintainers. If they agree, then we don't care if users
> currently with CONFIG_EXPERT=y and CONFIG_EMBEDDED=n lose the option, but
> that needs to be handled on a case-by-case basis when breaking backwards
> compatibility.
>
Ah, I think I may have just gotten to the bottom of this long, useless
thread. Based on your last email and by rereading what you wrote above.
You seem to believe a patch like
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 82928f5..ec1023d 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -771,7 +771,7 @@ config DEBUG_WRITECOUNT
config DEBUG_MEMORY_INIT
bool "Debug memory initialisation" if EXPERT
- default !EXPERT
+ default !EMBEDDED
help
Enable this for additional checks during memory initialisation.
The sanity checks verify aspects of the VM such as the memory
model
means that configs with CONFIG_EXPERT=y and CONFIG_EMBEDDED=n would then
generate kernels that no longer have the additional memory checks. Those
checks are generally a good thing, and in fact the config help for that
option says "If unsure, say Y". So a general kernel, using the general
kernel option, EXPERT, but not the specific option, EMBEDDED, would be
upset when losing that option.
Your problem is that your logic is backwards. The kernel right now has
precisely that issue, due to 6a108a14fa35. If EXPERT is on, then you'll
lose DEBUG_MEMORY_INIT. That, and all the other silently changed defaults,
is exactly what this patch fixes.
Please review the logic and the entire patch again.
next prev parent reply other threads:[~2012-01-18 9:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 15:16 [PATCH] kconfig: untangle EXPERT and EMBEDDED Andrew Jones
2012-01-11 21:57 ` David Rientjes
2012-01-12 9:18 ` Arnd Bergmann
2012-01-12 10:18 ` Andrew Jones
2012-01-12 21:06 ` David Rientjes
2012-01-13 8:51 ` Andrew Jones
2012-01-13 10:53 ` David Rientjes
2012-01-13 12:22 ` Andrew Jones
2012-01-13 21:27 ` David Rientjes
2012-01-16 9:20 ` Andrew Jones
2012-01-16 23:28 ` David Rientjes
2012-01-17 14:27 ` Andrew Jones
2012-01-17 20:46 ` David Rientjes
2012-01-18 8:14 ` Andrew Jones
2012-01-18 9:19 ` David Rientjes
2012-01-16 15:31 ` Jerome Marchand
2012-01-16 23:37 ` David Rientjes
2012-01-17 14:46 ` Andrew Jones
2012-01-17 20:54 ` David Rientjes
2012-01-18 8:51 ` Jerome Marchand
2012-01-18 8:56 ` Andrew Jones
2012-01-18 9:31 ` David Rientjes
2012-01-18 9:54 ` Andrew Jones
2012-01-18 9:38 ` Andrew Jones [this message]
2012-01-12 20:59 ` David Rientjes
2012-01-16 15:40 ` Jerome Marchand
2012-01-16 15:50 ` Andrew Jones
2012-01-16 17:34 ` Geert Uytterhoeven
2012-01-17 8:28 ` Andrew Jones
2012-01-18 11:08 ` Andrew Jones
2012-01-18 20:28 ` Andrew Morton
2012-01-18 20:46 ` Russell King - ARM Linux
2012-01-18 21:04 ` Alexey Dobriyan
2012-01-18 21:36 ` Andrew Morton
2012-01-18 21:48 ` Paul Bolle
2012-01-18 21:55 ` Andrew Morton
2012-01-18 22:13 ` Russell King - ARM Linux
2012-01-18 22:06 ` Alexey Dobriyan
2012-01-18 22:13 ` Dave Jones
2012-01-19 8:09 ` Andrew Jones
2012-01-23 13:46 ` Andrew Jones
2012-01-24 0:43 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118093818.GC2317@turtle.usersys.redhat.com \
--to=drjones@redhat.com \
--cc=a-jacquiot@ti.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=chris@zankel.net \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=david.woodhouse@intel.com \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=geert@linux-m68k.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=holt@sgi.com \
--cc=hskinnemoen@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=jkosina@suse.cz \
--cc=jmarchan@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=jonas@southpole.se \
--cc=kyle@mcmartin.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linville@tuxdriver.com \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=msalter@redhat.com \
--cc=rientjes@google.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).