linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	mingo@elte.hu, david.woodhouse@intel.com, gregkh@suse.de,
	davem@davemloft.net, axboe@kernel.dk, holt@sgi.com,
	linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
	hskinnemoen@gmail.com, egtvedt@samfundet.no, msalter@redhat.com,
	a-jacquiot@ti.com, starvik@axis.com, jesper.nilsson@axis.com,
	dhowells@redhat.com, takata@linux-m32r.org, geert@linux-m68k.org,
	yasutake.koichi@jp.panasonic.com, jonas@southpole.se,
	kyle@mcmartin.ca, deller@gmx.de, jejb@parisc-linux.org,
	chris@zankel.net, greg@kroah.com, davej@redhat.com,
	airlied@linux.ie, jkosina@suse.cz, mchehab@infradead.org,
	johannes@sipsolutions.net, linville@tuxdriver.com
Subject: Re: [PATCH] kconfig: untangle EXPERT and EMBEDDED
Date: Mon, 16 Jan 2012 15:37:01 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1201161530170.16270@chino.kir.corp.google.com> (raw)
In-Reply-To: <4F1442C5.70500@redhat.com>

On Mon, 16 Jan 2012, Jerome Marchand wrote:

> I don't see what your objections to this patch are. It actually does not
> change anything to CONFIG_EMBEDDED and 6a108a14fa35 didn't either.

Then you don't understand the context in which it was written.  
CONFIG_EMBEDDED was hijacked to allow certain options to be configurable 
that have nothing to do with embedded devices.  It was a dumping ground 
for any option that was non-standard.  So we decided that enough is enough 
and to actually give it a name that would imply you should know what 
you're turning on and off before you can configure it.

We also didn't want to break the millions of configs out in the wild that 
tune CONFIG_EMBEDDED, so we allowed it to select EXPERT in the meantime 
for backwards compatibility.  This allowed CONFIG_EMBEDDED to be extended 
in the future so that it could separate the options away from EXPERT that 
actually made sense for embedded devices to be aware of a configure.  At 
that point, it would be possible to remove the "select EXPERT" from 
CONFIG_EMBEDDED once all existing users become "depends on EXPERT || 
EMBEDDED", or possibly even just "depends on EMBEDDED" in rare cases where 
non-embedded users would never want to enable it.  (CONFIG_SLOB may be an 
example of the latter, but I'll leave that to the embedded world to 
decide.)

> For instance, Why would CONFIG_EXPERT disable by default some HID devices?
> I could understand why it is done for CONFIG_EMBEDDED, but certainly not
> for an general EXPERT option.
> 

Then this is a prime example that you've identified were it would make 
sense to have the default value be dependant on EMBEDDED rather than 
EXPERT.  Feel free to send a patch to the HID maintainers.

> >> This patch is actually attempting to make progress in the separation of
> >> the semantics for EXPERT and the old, insane EMBEDDED, which had the very
> >> loose semantics. That's why it's called "untangle EXPERT and EMBEDDED".
> >>
> 
> If EMBEDDED was insane before 6a108a14fa35, then it still was after, since
> nothing changed. EMBEDDED was just renamed EXPERT, and the "new" EMBEDDED
> option just selects EXPERT.
> 

Except now it's possible to decouple from EXPERT.  That's the goal that 
Andrew doesn't understand and he's fine with breaking everybody's config 
because they aren't defconfigs and there's no way such a thing would be 
merged.

  reply	other threads:[~2012-01-16 23:37 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 15:16 [PATCH] kconfig: untangle EXPERT and EMBEDDED Andrew Jones
2012-01-11 21:57 ` David Rientjes
2012-01-12  9:18   ` Arnd Bergmann
2012-01-12 10:18     ` Andrew Jones
2012-01-12 21:06       ` David Rientjes
2012-01-13  8:51         ` Andrew Jones
2012-01-13 10:53           ` David Rientjes
2012-01-13 12:22             ` Andrew Jones
2012-01-13 21:27               ` David Rientjes
2012-01-16  9:20                 ` Andrew Jones
2012-01-16 23:28                   ` David Rientjes
2012-01-17 14:27                     ` Andrew Jones
2012-01-17 20:46                       ` David Rientjes
2012-01-18  8:14                         ` Andrew Jones
2012-01-18  9:19                           ` David Rientjes
2012-01-16 15:31                 ` Jerome Marchand
2012-01-16 23:37                   ` David Rientjes [this message]
2012-01-17 14:46                     ` Andrew Jones
2012-01-17 20:54                       ` David Rientjes
2012-01-18  8:51                         ` Jerome Marchand
2012-01-18  8:56                         ` Andrew Jones
2012-01-18  9:31                           ` David Rientjes
2012-01-18  9:54                             ` Andrew Jones
2012-01-18  9:38                         ` Andrew Jones
2012-01-12 20:59     ` David Rientjes
2012-01-16 15:40 ` Jerome Marchand
2012-01-16 15:50   ` Andrew Jones
2012-01-16 17:34     ` Geert Uytterhoeven
2012-01-17  8:28       ` Andrew Jones
2012-01-18 11:08 ` Andrew Jones
2012-01-18 20:28   ` Andrew Morton
2012-01-18 20:46     ` Russell King - ARM Linux
2012-01-18 21:04     ` Alexey Dobriyan
2012-01-18 21:36       ` Andrew Morton
2012-01-18 21:48     ` Paul Bolle
2012-01-18 21:55       ` Andrew Morton
2012-01-18 22:13         ` Russell King - ARM Linux
2012-01-18 22:06       ` Alexey Dobriyan
2012-01-18 22:13       ` Dave Jones
2012-01-19  8:09     ` Andrew Jones
2012-01-23 13:46     ` Andrew Jones
2012-01-24  0:43       ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1201161530170.16270@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=a-jacquiot@ti.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=chris@zankel.net \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=david.woodhouse@intel.com \
    --cc=deller@gmx.de \
    --cc=dhowells@redhat.com \
    --cc=drjones@redhat.com \
    --cc=egtvedt@samfundet.no \
    --cc=geert@linux-m68k.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=holt@sgi.com \
    --cc=hskinnemoen@gmail.com \
    --cc=jejb@parisc-linux.org \
    --cc=jesper.nilsson@axis.com \
    --cc=jkosina@suse.cz \
    --cc=jmarchan@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=jonas@southpole.se \
    --cc=kyle@mcmartin.ca \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linville@tuxdriver.com \
    --cc=mchehab@infradead.org \
    --cc=mingo@elte.hu \
    --cc=msalter@redhat.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=yasutake.koichi@jp.panasonic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).