From: Jerome Marchand <jmarchan@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
rientjes@google.com, mingo@elte.hu, david.woodhouse@intel.com,
gregkh@suse.de, davem@davemloft.net, axboe@kernel.dk,
arnd@arndb.de, holt@sgi.com, linux-arch@vger.kernel.org,
linux@arm.linux.org.uk, hskinnemoen@gmail.com,
egtvedt@samfundet.no, msalter@redhat.com, a-jacquiot@ti.com,
starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com,
takata@linux-m32r.org, geert@linux-m68k.org,
yasutake.koichi@jp.panasonic.com, jonas@southpole.se,
kyle@mcmartin.ca, deller@gmx.de, jejb@parisc-linux.org,
chris@zankel.net, greg@kroah.com, davej@redhat.com,
airlied@linux.ie, jkosina@suse.cz, mchehab@infradead.org,
johannes@sipsolutions.net, linville@tuxdriver.com
Subject: Re: [PATCH] kconfig: untangle EXPERT and EMBEDDED
Date: Mon, 16 Jan 2012 16:40:47 +0100 [thread overview]
Message-ID: <4F1444FF.60205@redhat.com> (raw)
In-Reply-To: <1326295008-29795-1-git-send-email-drjones@redhat.com>
On 01/11/2012 04:16 PM, Andrew Jones wrote:
> Commit 6a108a14fa35 renamed CONFIG_EMBEDDED to CONFIG_EXPERT with the
> justification that EMBEDDED was being used with a broader scope. It was
> no longer just being used to expose standard options to embedded kernel
> configs for tweaking, but rather for all "non-standard" kernel configs.
> This is nice, because now developers have a way to clean up the config
> menu by adding 'if EXPERT' to all entries in their Kconfig files that
> should rarely have a non-default value selected (hint1: it would be nice
> if developers would do this, hint2: it would also be nice if developers
> would do this rather than making these types of options silent, and thus
> impossible to override).
>
> Unfortunately, EMBEDDED was also being used to modify the defaults of
> some of these options to selections more appropriate for embedded
> kernels. Since the renaming was a simple global search-replace, if
> developers were to follow hints 1 and 2 above for non-embedded kernels,
> then they may find unexpected changes in their configs after turning on
> EXPERT.
>
> This patch attempts to untangle these two, making EXPERT true to its
> purpose, which is to only expose standard options for tweaking, and
> EMBEDDED to resume use as a default option modifier. The patch was made
> with the following four steps, which could not be split into separate
> patches without breaking configs
>
> 1. Make sure EMBEDDED does nothing, i.e. s/EMBEDDED/EXPERT/. There were
> only three places EMBEDDED was used.
>
> 2. Add CONFIG_EXPERT=y to all configs that had CONFIG_EMBEDDED=y (and
> not CONFIG_EXPERT=y already) to make sure step1 has no effect. This step
> isn't strictly necessary since EMBEDDED selects EXPERT, but I wanted the
> configs expressing the new need explicitly. Only 13 *_defconfig files.
>
> 3. Move all side effects (default changes) from EXPERT to EMBEDDED
>
> 4. Add CONFIG_EMBEDDED=y to all configs that had CONFIG_EXPERT=y (and
> not CONFIG_EMBEDDED=y already) to make sure step3 has no effect.
>
> I certainly didn't test this for every touched config. However, I did
> test it for one config and got the expected results;
> Before patch:
> 1. diff config.orig orig.EXPERT -- shows many changes
> 2. diff config.orig orig.EMBEDDED -- shows same changes as (1)
> plus EMBEDDED on
> After patch:
> 3. diff config.orig config.new -- no change
> 4. diff config.orig new.EXPERT -- only 1 change, EXPERT on
> 5. diff config.orig new.EMBEDDED -- shows same changes as (2)
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> @@ -1259,8 +1259,7 @@ config SLUB
> a slab allocator.
>
> config SLOB
> - depends on EXPERT
> - bool "SLOB (Simple Allocator)"
> + bool "SLOB (Simple Allocator)" if EXPERT
> help
> SLOB replaces the stock allocator with a drastically simpler
> allocator. SLOB is generally more space efficient but
Am I missing something or this particular chunk does not actually change
anything?
Jerome
next prev parent reply other threads:[~2012-01-16 15:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 15:16 [PATCH] kconfig: untangle EXPERT and EMBEDDED Andrew Jones
2012-01-11 21:57 ` David Rientjes
2012-01-12 9:18 ` Arnd Bergmann
2012-01-12 10:18 ` Andrew Jones
2012-01-12 21:06 ` David Rientjes
2012-01-13 8:51 ` Andrew Jones
2012-01-13 10:53 ` David Rientjes
2012-01-13 12:22 ` Andrew Jones
2012-01-13 21:27 ` David Rientjes
2012-01-16 9:20 ` Andrew Jones
2012-01-16 23:28 ` David Rientjes
2012-01-17 14:27 ` Andrew Jones
2012-01-17 20:46 ` David Rientjes
2012-01-18 8:14 ` Andrew Jones
2012-01-18 9:19 ` David Rientjes
2012-01-16 15:31 ` Jerome Marchand
2012-01-16 23:37 ` David Rientjes
2012-01-17 14:46 ` Andrew Jones
2012-01-17 20:54 ` David Rientjes
2012-01-18 8:51 ` Jerome Marchand
2012-01-18 8:56 ` Andrew Jones
2012-01-18 9:31 ` David Rientjes
2012-01-18 9:54 ` Andrew Jones
2012-01-18 9:38 ` Andrew Jones
2012-01-12 20:59 ` David Rientjes
2012-01-16 15:40 ` Jerome Marchand [this message]
2012-01-16 15:50 ` Andrew Jones
2012-01-16 17:34 ` Geert Uytterhoeven
2012-01-17 8:28 ` Andrew Jones
2012-01-18 11:08 ` Andrew Jones
2012-01-18 20:28 ` Andrew Morton
2012-01-18 20:46 ` Russell King - ARM Linux
2012-01-18 21:04 ` Alexey Dobriyan
2012-01-18 21:36 ` Andrew Morton
2012-01-18 21:48 ` Paul Bolle
2012-01-18 21:55 ` Andrew Morton
2012-01-18 22:13 ` Russell King - ARM Linux
2012-01-18 22:06 ` Alexey Dobriyan
2012-01-18 22:13 ` Dave Jones
2012-01-19 8:09 ` Andrew Jones
2012-01-23 13:46 ` Andrew Jones
2012-01-24 0:43 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1444FF.60205@redhat.com \
--to=jmarchan@redhat.com \
--cc=a-jacquiot@ti.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=chris@zankel.net \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=david.woodhouse@intel.com \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=drjones@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=geert@linux-m68k.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=holt@sgi.com \
--cc=hskinnemoen@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=jkosina@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=jonas@southpole.se \
--cc=kyle@mcmartin.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linville@tuxdriver.com \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=msalter@redhat.com \
--cc=rientjes@google.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).