[PATCH 1/1] sysfs: Fixed a trailing white space error

[PATCH 1/1] sysfs: Fixed a trailing white space error

[Bin Wang]

This patch removes the trailing white space in fs/sysfs/mount.c.

Signed-off-by: Bin Wang <wbin00@gmail.com>
---
 fs/sysfs/mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
index 71eb7e2..24bfcb4 100644
--- a/fs/sysfs/mount.c
+++ b/fs/sysfs/mount.c
@@ -10,7 +10,7 @@
  * Please see Documentation/filesystems/sysfs.txt for more information.
  */
 
-#define DEBUG 
+#define DEBUG
 
 #include <linux/fs.h>
 #include <linux/mount.h>
-- 
1.7.11.7

[PATCH RFC -next] Fix the trailing blank space issue

[Cong Ding]

On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote:
> This patch removes the trailing white space in fs/sysfs/mount.c.
> 
> Signed-off-by: Bin Wang <wbin00@gmail.com>
> ---
>  fs/sysfs/mount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Hi Greg,

I am not sure it is really necessary to remove all the trailing blank spaces
in the project. I have done a try by this shell command
$ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i
and find there are 2812 files/31712 lines with this issue. 

If necessary, I think it's better to run this shell code by yourself in the
whole linux-next tree and commit it. Nevertheless, the patch file of my try is
available from gist: https://gist.github.com/4225286

Even the diff summary is very large, hence I attach a simple version diff
result and commit information here. 

- cong

---
>From 30ed9bb0e6f7c8866447d27c86f466c44749116e Mon Sep 17 00:00:00 2001
From: Cong Ding <dinggnu@gmail.com>
Date: Thu, 6 Dec 2012 15:58:15 +0100
Subject: [PATCH RFC -next] remove all the trailing blank space

clean all the trailing blank space by using shell command
$ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i

I have manually checked a random set of all the changes, and find no error.
I also compiled the whole system and tested many times by randconfig.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
 2812 files changed, 31712 insertions(+), 31712 deletions(-)

Re: [PATCH RFC -next] Fix the trailing blank space issue

[Greg Kroah-Hartman]

On Thu, Dec 06, 2012 at 03:42:20PM +0000, Cong Ding wrote:
> On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote:
> > This patch removes the trailing white space in fs/sysfs/mount.c.
> > 
> > Signed-off-by: Bin Wang <wbin00@gmail.com>
> > ---
> >  fs/sysfs/mount.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> Hi Greg,
> 
> I am not sure it is really necessary to remove all the trailing blank spaces
> in the project. I have done a try by this shell command
> $ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i
> and find there are 2812 files/31712 lines with this issue. 

That's very true, why would you want to do this?

This comes up every 6 months or so on the linux-kernel mailing list,
please see the archives for previous responses to the topic.

If you want, just slowly send patches to the different subsystem
maintainers, to clean the issue up.

best of luck,

greg k-h

Re: [PATCH RFC -next] Fix the trailing blank space issue

[Cong Ding]

On Thu, Dec 06, 2012 at 08:06:06AM -0800, Greg Kroah-Hartman wrote:
> On Thu, Dec 06, 2012 at 03:42:20PM +0000, Cong Ding wrote:
> > On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote:
> > > This patch removes the trailing white space in fs/sysfs/mount.c.
> > > 
> > > Signed-off-by: Bin Wang <wbin00@gmail.com>
> > > ---
> > >  fs/sysfs/mount.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > Hi Greg,
> > 
> > I am not sure it is really necessary to remove all the trailing blank spaces
> > in the project. I have done a try by this shell command
> > $ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i
> > and find there are 2812 files/31712 lines with this issue. 
> 
> That's very true, why would you want to do this?
> 
> This comes up every 6 months or so on the linux-kernel mailing list,
> please see the archives for previous responses to the topic.
> 
> If you want, just slowly send patches to the different subsystem
> maintainers, to clean the issue up.
sorry for forgetting press "reply all" in the former email...

Sending them slowly to different subsystem maintainers is a very bad idea,
because it wastes lots of time for both me and them. But the current situation
is that there are some people send this kind of patches in random time which
also is a kind of wasting their time.

I think we'd better to find a solution, not only for the blank space issue,
but also all the coding style issues able to be fixed by scripts.

I would suggest to write a series of scripts. And then announce a date
(preferably some holiday like Xmas) to run these scripts. The announce is to
avoid conflicts with other developers. It will save both developers' and
subsystem maintains' time, do you agree?

- cong

Re: [PATCH RFC -next] Fix the trailing blank space issue

[Greg Kroah-Hartman]

On Thu, Dec 06, 2012 at 04:31:39PM +0000, Cong Ding wrote:
> On Thu, Dec 06, 2012 at 08:06:06AM -0800, Greg Kroah-Hartman wrote:
> > On Thu, Dec 06, 2012 at 03:42:20PM +0000, Cong Ding wrote:
> > > On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote:
> > > > This patch removes the trailing white space in fs/sysfs/mount.c.
> > > > 
> > > > Signed-off-by: Bin Wang <wbin00@gmail.com>
> > > > ---
> > > >  fs/sysfs/mount.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > Hi Greg,
> > > 
> > > I am not sure it is really necessary to remove all the trailing blank spaces
> > > in the project. I have done a try by this shell command
> > > $ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i
> > > and find there are 2812 files/31712 lines with this issue. 
> > 
> > That's very true, why would you want to do this?
> > 
> > This comes up every 6 months or so on the linux-kernel mailing list,
> > please see the archives for previous responses to the topic.
> > 
> > If you want, just slowly send patches to the different subsystem
> > maintainers, to clean the issue up.
> sorry for forgetting press "reply all" in the former email...
> 
> Sending them slowly to different subsystem maintainers is a very bad idea,
> because it wastes lots of time for both me and them. But the current situation
> is that there are some people send this kind of patches in random time which
> also is a kind of wasting their time.
> 
> I think we'd better to find a solution, not only for the blank space issue,
> but also all the coding style issues able to be fixed by scripts.
> 
> I would suggest to write a series of scripts. And then announce a date
> (preferably some holiday like Xmas) to run these scripts. The announce is to
> avoid conflicts with other developers. It will save both developers' and
> subsystem maintains' time, do you agree?

No I do not, it's not a big issue at all.  As I said, look in the
archives, this comes up every six months or so.

greg k-h

Re: [PATCH RFC -next] Fix the trailing blank space issue

[Alan Cox]

> I would suggest to write a series of scripts. And then announce a date
> (preferably some holiday like Xmas) to run these scripts. The announce is to
> avoid conflicts with other developers. It will save both developers' and
> subsystem maintains' time, do you agree?

And if any of them are wrong how will we notice ?

By all means generate them in subsystem sized chunks but they do need to
get a human glance just to be sure. If you send me drivers/tty for
example I'll go over it happily and give it an Ack unless something is
very odd.

And to be honest if they don't all get done - who cares. There are a
several thousand more serious things the scanning and analyser tools flag
that are much more useful to fix.

Alan

Re: [PATCH RFC -next] Fix the trailing blank space issue

[Bin Wang]

Sorry for the late response.

It is not a big deal about the code formate. It just makes me 
uncomfortable since my editor has a highlight for the trailing space. 
The similar things are the two-space between words of document and so on.

It's surely better to formate the code. So I submit a patch while I just 
read and find these little things . I'm not sure if it is a waste of 
time for the maintainers.

On 12/07/2012 12:59 AM, Greg Kroah-Hartman wrote:
> On Thu, Dec 06, 2012 at 04:31:39PM +0000, Cong Ding wrote:
>> On Thu, Dec 06, 2012 at 08:06:06AM -0800, Greg Kroah-Hartman wrote:
>>> On Thu, Dec 06, 2012 at 03:42:20PM +0000, Cong Ding wrote:
>>>> On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote:
>>>>> This patch removes the trailing white space in fs/sysfs/mount.c.
>>>>>
>>>>> Signed-off-by: Bin Wang <wbin00@gmail.com>
>>>>> ---
>>>>>   fs/sysfs/mount.c | 2 +-
>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>> Hi Greg,
>>>>
>>>> I am not sure it is really necessary to remove all the trailing blank spaces
>>>> in the project. I have done a try by this shell command
>>>> $ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i
>>>> and find there are 2812 files/31712 lines with this issue.
>>> That's very true, why would you want to do this?
>>>
>>> This comes up every 6 months or so on the linux-kernel mailing list,
>>> please see the archives for previous responses to the topic.
>>>
>>> If you want, just slowly send patches to the different subsystem
>>> maintainers, to clean the issue up.
>> sorry for forgetting press "reply all" in the former email...
>>
>> Sending them slowly to different subsystem maintainers is a very bad idea,
>> because it wastes lots of time for both me and them. But the current situation
>> is that there are some people send this kind of patches in random time which
>> also is a kind of wasting their time.
>>
>> I think we'd better to find a solution, not only for the blank space issue,
>> but also all the coding style issues able to be fixed by scripts.
>>
>> I would suggest to write a series of scripts. And then announce a date
>> (preferably some holiday like Xmas) to run these scripts. The announce is to
>> avoid conflicts with other developers. It will save both developers' and
>> subsystem maintains' time, do you agree?
> No I do not, it's not a big issue at all.  As I said, look in the
> archives, this comes up every six months or so.
>
> greg k-h