* [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
@ 2015-09-18 17:36 eu
2015-09-21 9:21 ` Felipe Tonello
0 siblings, 1 reply; 6+ messages in thread
From: eu @ 2015-09-18 17:36 UTC (permalink / raw)
To: linux-usb
Cc: linux-kernel, Peter Chen, Greg Kroah-Hartman, Felipe Balbi,
Andrzej Pietrasiewicz, Felipe F. Tonello
From: "Felipe F. Tonello" <eu@felipetonello.com>
f_midi is not checking whether there is an error on usb_ep_queue
request, ignoring potential problems, such as memory leaks.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
Changes for v2:
- Update code style.
Changes for v3:
- Use ip_ep instead of out_ep. Fixed typo in commit message.
drivers/usb/gadget/function/f_midi.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index ad50a67..edb84ca 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -543,10 +543,16 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
}
}
- if (req->length > 0)
- usb_ep_queue(ep, req, GFP_ATOMIC);
- else
+ if (req->length > 0) {
+ int err;
+
+ err = usb_ep_queue(ep, req, GFP_ATOMIC);
+ if (err < 0)
+ ERROR(midi, "%s queue req: %d\n",
+ midi->in_ep->name, err);
+ } else {
free_ep_req(ep, req);
+ }
}
static void f_midi_in_tasklet(unsigned long data)
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
2015-09-18 17:36 [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu
@ 2015-09-21 9:21 ` Felipe Tonello
2015-09-22 4:04 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: Felipe Tonello @ 2015-09-21 9:21 UTC (permalink / raw)
To: USB list
Cc: Kernel development list, Peter Chen, Greg Kroah-Hartman,
Felipe Balbi, Andrzej Pietrasiewicz, Felipe F. Tonello
Hi Balbi,
On Fri, Sep 18, 2015 at 6:36 PM, <eu@felipetonello.com> wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> f_midi is not checking whether there is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>
> Changes for v2:
> - Update code style.
>
> Changes for v3:
> - Use ip_ep instead of out_ep. Fixed typo in commit message.
I forgot to add v3 to the patch subject, so it queued here instead. Do
you want me to re-send as v3?
Felipe Tonello
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
2015-09-21 9:21 ` Felipe Tonello
@ 2015-09-22 4:04 ` Felipe Balbi
2015-09-22 5:39 ` Peter Chen
0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2015-09-22 4:04 UTC (permalink / raw)
To: Felipe Tonello
Cc: USB list, Kernel development list, Peter Chen,
Greg Kroah-Hartman, Felipe Balbi, Andrzej Pietrasiewicz
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
Hi,
On Mon, Sep 21, 2015 at 10:21:31AM +0100, Felipe Tonello wrote:
> Hi Balbi,
>
> On Fri, Sep 18, 2015 at 6:36 PM, <eu@felipetonello.com> wrote:
> > From: "Felipe F. Tonello" <eu@felipetonello.com>
> >
> > f_midi is not checking whether there is an error on usb_ep_queue
> > request, ignoring potential problems, such as memory leaks.
> >
> > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> > ---
> >
> > Changes for v2:
> > - Update code style.
> >
> > Changes for v3:
> > - Use ip_ep instead of out_ep. Fixed typo in commit message.
>
> I forgot to add v3 to the patch subject, so it queued here instead. Do
> you want me to re-send as v3?
you need to ask Peter, he's the chipidea maintainer. Peter ?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
2015-09-22 4:04 ` Felipe Balbi
@ 2015-09-22 5:39 ` Peter Chen
0 siblings, 0 replies; 6+ messages in thread
From: Peter Chen @ 2015-09-22 5:39 UTC (permalink / raw)
To: Felipe Balbi
Cc: Felipe Tonello, USB list, Kernel development list,
Greg Kroah-Hartman, Andrzej Pietrasiewicz
On Mon, Sep 21, 2015 at 11:04:42PM -0500, Felipe Balbi wrote:
> Hi,
>
> On Mon, Sep 21, 2015 at 10:21:31AM +0100, Felipe Tonello wrote:
> > Hi Balbi,
> >
> > On Fri, Sep 18, 2015 at 6:36 PM, <eu@felipetonello.com> wrote:
> > > From: "Felipe F. Tonello" <eu@felipetonello.com>
> > >
> > > f_midi is not checking whether there is an error on usb_ep_queue
> > > request, ignoring potential problems, such as memory leaks.
> > >
> > > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> > > ---
> > >
> > > Changes for v2:
> > > - Update code style.
> > >
> > > Changes for v3:
> > > - Use ip_ep instead of out_ep. Fixed typo in commit message.
> >
> > I forgot to add v3 to the patch subject, so it queued here instead. Do
> > you want me to re-send as v3?
>
> you need to ask Peter, he's the chipidea maintainer. Peter ?
>
I have queued the first two for chipidea changes, the third one is
for gadget change.
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] usb: chipidea: udc: _ep_queue and _hw_queue cleanup
@ 2015-09-18 17:30 eu
2015-09-18 17:30 ` [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu
0 siblings, 1 reply; 6+ messages in thread
From: eu @ 2015-09-18 17:30 UTC (permalink / raw)
To: linux-usb
Cc: linux-kernel, Peter Chen, Greg Kroah-Hartman, Felipe Balbi,
Andrzej Pietrasiewicz, Felipe F. Tonello
From: "Felipe F. Tonello" <eu@felipetonello.com>
Update comments to reflect current state of functions.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
Changes for v2:
- Introduced this patch.
drivers/usb/chipidea/udc.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 764f668..c936c72 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -404,9 +404,9 @@ static inline u8 _usb_addr(struct ci_hw_ep *ep)
}
/**
- * _hardware_queue: configures a request at hardware level
- * @gadget: gadget
+ * _hardware_enqueue: configures a request at hardware level
* @hwep: endpoint
+ * @hwreq: request
*
* This function returns an error code
*/
@@ -750,8 +750,12 @@ static void isr_get_status_complete(struct usb_ep *ep, struct usb_request *req)
/**
* _ep_queue: queues (submits) an I/O request to an endpoint
+ * @ep: endpoint
+ * @req: request
+ * @gfp_flags: GFP flags (not used)
*
* Caller must hold lock
+ * This function returns an error code
*/
static int _ep_queue(struct usb_ep *ep, struct usb_request *req,
gfp_t __maybe_unused gfp_flags)
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
2015-09-18 17:30 [PATCH 1/3] usb: chipidea: udc: _ep_queue and _hw_queue cleanup eu
@ 2015-09-18 17:30 ` eu
2015-09-18 17:32 ` Felipe Tonello
0 siblings, 1 reply; 6+ messages in thread
From: eu @ 2015-09-18 17:30 UTC (permalink / raw)
To: linux-usb
Cc: linux-kernel, Peter Chen, Greg Kroah-Hartman, Felipe Balbi,
Andrzej Pietrasiewicz, Felipe F. Tonello
From: "Felipe F. Tonello" <eu@felipetonello.com>
f_midi is not checking weather the is an error on usb_ep_queue
request, ignoring potential problems, such as memory leaks.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
Changes for v2:
- Update code style.
drivers/usb/gadget/function/f_midi.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index ad50a67..c04133422 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -543,10 +543,16 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
}
}
- if (req->length > 0)
- usb_ep_queue(ep, req, GFP_ATOMIC);
- else
+ if (req->length > 0) {
+ int err;
+
+ err = usb_ep_queue(ep, req, GFP_ATOMIC);
+ if (err < 0)
+ ERROR(midi, "%s queue req: %d\n",
+ midi->out_ep->name, err);
+ } else {
free_ep_req(ep, req);
+ }
}
static void f_midi_in_tasklet(unsigned long data)
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
2015-09-18 17:30 ` [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu
@ 2015-09-18 17:32 ` Felipe Tonello
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Tonello @ 2015-09-18 17:32 UTC (permalink / raw)
To: USB list
Cc: linux-kernel, Peter Chen, Greg Kroah-Hartman, Felipe Balbi,
Andrzej Pietrasiewicz, Felipe F. Tonello
On Fri, Sep 18, 2015 at 6:30 PM, <eu@felipetonello.com> wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>
> Changes for v2:
> - Update code style.
>
> drivers/usb/gadget/function/f_midi.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index ad50a67..c04133422 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -543,10 +543,16 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
> }
> }
>
> - if (req->length > 0)
> - usb_ep_queue(ep, req, GFP_ATOMIC);
> - else
> + if (req->length > 0) {
> + int err;
> +
> + err = usb_ep_queue(ep, req, GFP_ATOMIC);
> + if (err < 0)
> + ERROR(midi, "%s queue req: %d\n",
> + midi->out_ep->name, err);
I just realised there is a problem here. It is in_ep in this case. I
will fix it in v3.
> + } else {
> free_ep_req(ep, req);
> + }
> }
>
> static void f_midi_in_tasklet(unsigned long data)
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-22 6:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-18 17:36 [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu
2015-09-21 9:21 ` Felipe Tonello
2015-09-22 4:04 ` Felipe Balbi
2015-09-22 5:39 ` Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2015-09-18 17:30 [PATCH 1/3] usb: chipidea: udc: _ep_queue and _hw_queue cleanup eu
2015-09-18 17:30 ` [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu
2015-09-18 17:32 ` Felipe Tonello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).