Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

From: "Pali Rohár" <pali.rohar@gmail.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Michael Welling" <mwelling@ieee.org>,
	"Mika Penttilä" <mika.penttila@nextfour.com>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Igor Grinberg" <grinberg@compulab.co.il>,
	"Andrew F. Davis" <afd@ti.com>, "Mark Brown" <broonie@kernel.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Alexander Stein" <alexander.stein@systec-electronic.com>,
	"Eric Engestrom" <eric@engestrom.ch>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Petr Cvek" <petr.cvek@tul.cz>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Hans Verkuil" <hans.verkuil@cisco.com>,
	"Nick Dyer" <nick@shmanahar.org>,
	"Siebren Vroegindeweij" <siebren.vroegindeweij@hotmail.com>,
	"Michel Verlaan" <michel.verl@gmail.com>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	letux-kernel@openphoenux.org, linux-iio@vger.kernel.org,
	kernel@pyra-handheld.com,
	"Aaro Koskinen" <aaro.koskinen@nokia.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Andrey Gelman" <andrey.gelman@compulab.co.il>,
	"Haibo Chen" <haibo.chen@freescale.com>
Subject: Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation
Date: Mon, 20 Feb 2017 20:42:15 +0100	[thread overview]
Message-ID: <201702202042.15878@pali> (raw)
In-Reply-To: <B30D00D0-1967-4BD5-A304-E2ADC815A805@goldelico.com>

[-- Attachment #1: Type: Text/Plain, Size: 1460 bytes --]

Hi Nikolaus!

On Monday 20 February 2017 17:50:04 H. Nikolaus Schaller wrote:
> Hi Dmitry,
> 
> > Input driver may set resolution for given axis in units per mm (or
> > units per radian for rotational axis ABS_RX, ABS_RY, ABS_RZ), and
> > if you check the binding, you can use "touchscreen-x-mm" and
> > "touchscreen-y-mm" to specify the size of entire touch surface and
> > set resolution from it so that userspace can calculate the proper
> > scaling factor.
> 
> How is this information exposed by the kernel to user-space? By
> scanning the DT file or tree?

Set input_abs_set_res() from kernel. And in userspace call EVIOCGABS 
ioctl() on input device. Look at struct input_absinfo, you should have 
all needed information here. This is generic input interface, no DT is 
needed.

I hope that XServer is already using it for evdev devices...

For whole implementation look at evtest program. That should be good 
starting point for your userspace implementation.

While I'm watching this discussion... in my opinion kernel should just 
invert input axes (when needed) and should not do any other 
normalization or integer/floating-point re-calibration/re-calculation. 
If it correctly exports minimum value, maximum value and resolution then 
userspace can correctly re-scale input events to units which userspace 
needs (e.g. mapping into LCD screen pixels or whatever is needed).

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]