From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Jonathan Cameron <jic23@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Sebastian Reichel" <sre@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@armlinux.org.uk>,
"Arnd Bergmann" <arnd@arndb.de>,
"Michael Welling" <mwelling@ieee.org>,
"Mika Penttilä" <mika.penttila@nextfour.com>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Igor Grinberg" <grinberg@compulab.co.il>,
"Andrew F. Davis" <afd@ti.com>, "Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Alexander Stein" <alexander.stein@systec-electronic.com>,
"Eric Engestrom" <eric@engestrom.ch>,
"Hans de Goede" <hdegoede@redhat.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Petr Cvek" <petr.cvek@tul.cz>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Nick Dyer" <nick@shmanahar.org>,
"Siebren Vroegindeweij" <siebren.vroegindeweij@hotmail.com>,
"Michel Verlaan" <michel.verl@gmail.com>,
linux-input@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
"Discussions about the Letux Kernel"
<letux-kernel@openphoenux.org>,
linux-iio@vger.kernel.org, kernel@pyra-handheld.com
Subject: Re: [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values)
Date: Sat, 21 Jan 2017 14:17:39 +0100 [thread overview]
Message-ID: <B04BF50A-A54E-4CA2-BB0E-7B547D40403A@goldelico.com> (raw)
In-Reply-To: <17d2c23b-6cbb-d365-71cb-fd4d7af7c958@kernel.org>
> Am 21.01.2017 um 14:08 schrieb Jonathan Cameron <jic23@kernel.org>:
>
> On 16/01/17 06:34, H. Nikolaus Schaller wrote:
>> ping
> Always good to say who you are pinging ;)
default = Maintainer
Only he/she can finally accept a patch series so I assume he has
to take action if there are no more things to debate.
> Saves the rest of us wondering
> if we have missing something we should have reviewed.
>
> Guessing it's Dmitry in this case!
Yes, you are right. Since there have not been any more comments for a
while, I formally ask to add this to some tree so that it appears in
linux-next for further tests.
BR and thanks,
Nikolaus
>
> Jonathan
>>
>>> Am 28.12.2016 um 15:53 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>>>
>>> Changes V9:
>>> * added explicit CONFIG for TSC2007_IIO and simplified Makefile (suggested by Dmitry Torokhov <dmitry.torokhov@gmail.com>)
>>> * make the tsc2007 iio patch the last one in this sequence
>>>
>>> 2016-11-22 15:02:42: Changes V8:
>>> * fix compilation for CONFIG_IIO=m (reported by Jonathan Cameron <jic23@kernel.org>)
>>> * add some more Reviewed-by: and Acked-by:
>>> * mutiple improvements suggested by Dmitry Torokhov <dmitry.torokhov@gmail.com>:
>>> ** drop patch "send pendown and penup only once" (input core does take care of it now)
>>> ** remove not necessary EXPORT_SYMBOL
>>> ** remove explicit file names from comment header
>>> ** move tsc2007_iio_configure() to the end of the probe process and simplify the error path again
>>> ** remove unnecessary input_unregister_device()
>>> ** improvement for compilation with CONFIG_IIO=m and CONFIG_TSC2007=y
>>>
>>> 2016-11-11 20:02:11: Changes V7:
>>> * rearranged the include files (asked for by Jonathan Cameron <jic23@kernel.org>)
>>> * forward reference struct iio_dev * instead of condition in tsc2007.h (asked for by Jonathan Cameron <jic23@kernel.org>)
>>> * add some Acked-by:
>>>
>>> 2016-10-27 10:44:29: Changes V6:
>>> * iio patch (no changes elsewhere)
>>> - tsc2007_iio: fix a missing return 0 for non-iio case (found by kbuid test robot)
>>> - tsc2007_core: group error return paths so that tsc2007_iio_unconfigure is called at only one place
>>> - tsc2007_iio: fix copyright (this file is 100% original work)
>>>
>>> 2016-10-25 21:26:46: Changes V5:
>>> * ads7846: remove an empty line (suggested by Andrew F. Davis <afd@ti.com>)
>>> * ads7846: remove MODULE_ALIAS for SPI (suggested by Andrew F. Davis <afd@ti.com>)
>>> * tsc2007: fix a bug from swapping patch 3/n and patch 4/n (found by kbuild test robot)
>>> * refactored tsc2007 into tsc2007_core and tsc2007_iio (asked for by Jonathan Cameron <jic23@kernel.org>)
>>>
>>> 2016-10-17 16:00:02: Changes V4:
>>> * fix a merge/squash issue resulting in a non-bisectable patch set (suggested by kbuid test robot)
>>> * remove some unnecessary #include (suggested by Jonathan Cameron <jic23@kernel.org>)
>>> * make the iio extension depend on CONFIG_IIO rather than selecting it (suggested by Jonathan Cameron <jic23@kernel.org>)
>>> * swapped patch 3/n and patch 4/n to remove internal dependency
>>>
>>> 2016-09-23 14:41:23: Changes V3:
>>> * fix an issue with swapping
>>> * remove hard clipping to min/max rectangle - some systems expect to handle negative coordinates
>>> * make use of commit ed7c9870c9bc ("Input: of_touchscreen - add support for inverted / swapped axes")
>>>
>>> 2015-11-13 21:36:07: Changes V2:
>>> * add a patch to make drivers still recognise the old "ti,swap-xy" property (suggested by Rob Herring)
>>>
>>> 2015-11-06 16:14:53: V1: This patch series improves the drivers for the tsc2007 and
>>> ads7846/tsc2046 touchscreen controllers which are e.g. used by the GTA04
>>> OpenPandora and Pyra devices.
>>>
>>> New common bindings have been defined by
>>> commit b98abe52fa8e ("Input: add common DT binding for touchscreens"):
>>>
>>> Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>>>
>>> which also defines a helper function to parse the DT. These new parameters
>>> allow to specify the fuzz factors (jitter suppression), inversion of x or y axis and
>>> swapping of x and y to achieve inversion and rotation so that the touch
>>> coordinate axes match the natural orientation of the display panel.
>>>
>>> Another improvement is to better use the min/max ADC values and
>>> scale to the screen size as defined by the DT. This allows to coarsely
>>> calibrate the touch to match the LCD to which it is glued on so that the
>>> touch can quite precisely be operated before any user-space fine-calibration
>>> can be (and needs to be) started.
>>>
>>> For the adc7846 we fix an issue with the spi module table.
>>>
>>> Finally we add an iio interface for the AUX and temperature ADC channels of
>>> the tsc2007 and also provide the touch screen raw values. This allows to read
>>> an optional ambient light sensor installed on the gta04 board and improves
>>> calibration and hardware monitoring.
>>>
>>>
>>> H. Nikolaus Schaller (8):
>>> drivers:input:tsc2007: add new common binding names, pre-calibration,
>>> flipping and rotation
>>> drivers:input:tsc2007: check for presence and power down tsc2007
>>> during probe
>>> DT:omap3+tsc2007: use new common touchscreen bindings
>>> drivers:input:ads7846(+tsc2046): add new common binding names,
>>> pre-calibration and flipping
>>> dt-bindings: input: move ads7846 bindings to touchscreen subdirectory
>>> drivers:input:ads7846(+tsc2046): fix spi module table
>>> DT:omap3+ads7846: use new common touchscreen bindings
>>> drivers:input:tsc2007: add iio interface to read external ADC input
>>> and temperature
>>>
>>> .../bindings/input/{ => touchscreen}/ads7846.txt | 9 +-
>>> .../bindings/input/touchscreen/tsc2007.txt | 20 +-
>>> arch/arm/boot/dts/omap3-gta04.dtsi | 25 ++-
>>> arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 2 +-
>>> arch/arm/boot/dts/omap3-pandora-common.dtsi | 17 +-
>>> .../boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi | 3 +-
>>> drivers/input/touchscreen/Kconfig | 10 +
>>> drivers/input/touchscreen/Makefile | 2 +
>>> drivers/input/touchscreen/ads7846.c | 71 ++++++--
>>> drivers/input/touchscreen/tsc2007.h | 116 ++++++++++++
>>> .../touchscreen/{tsc2007.c => tsc2007_core.c} | 201 ++++++++++++---------
>>> drivers/input/touchscreen/tsc2007_iio.c | 150 +++++++++++++++
>>> include/linux/i2c/tsc2007.h | 8 +
>>> 13 files changed, 520 insertions(+), 114 deletions(-)
>>> rename Documentation/devicetree/bindings/input/{ => touchscreen}/ads7846.txt (90%)
>>> create mode 100644 drivers/input/touchscreen/tsc2007.h
>>> rename drivers/input/touchscreen/{tsc2007.c => tsc2007_core.c} (74%)
>>> create mode 100644 drivers/input/touchscreen/tsc2007_iio.c
>>>
>>> --
>>> 2.7.3
>>>
>>
>
next prev parent reply other threads:[~2017-01-21 13:17 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 14:53 [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation H. Nikolaus Schaller
2017-01-09 17:43 ` Rob Herring
2017-01-28 19:33 ` Dmitry Torokhov
2017-01-28 21:44 ` H. Nikolaus Schaller
2017-02-17 20:40 ` Dmitry Torokhov
2017-02-18 3:22 ` Sebastian Reichel
2017-02-18 11:33 ` H. Nikolaus Schaller
2017-02-18 23:44 ` Sebastian Reichel
2017-02-19 12:07 ` H. Nikolaus Schaller
2017-02-19 20:15 ` Sebastian Reichel
2017-02-20 16:49 ` H. Nikolaus Schaller
2017-02-18 7:45 ` [Letux-kernel] " Andreas Kemnade
2017-02-18 9:15 ` Pavel Machek
2017-02-18 11:33 ` H. Nikolaus Schaller
2017-02-18 18:08 ` Pavel Machek
2017-02-18 19:17 ` H. Nikolaus Schaller
2017-02-18 22:54 ` Pavel Machek
2017-02-19 12:05 ` H. Nikolaus Schaller
2017-02-19 14:17 ` Pavel Machek
2017-02-19 17:04 ` H. Nikolaus Schaller
2017-02-19 17:15 ` Pavel Machek
2017-02-19 17:51 ` H. Nikolaus Schaller
2017-02-19 19:05 ` Pavel Machek
2017-02-19 19:31 ` H. Nikolaus Schaller
2017-02-19 20:57 ` Pavel Machek
2017-02-19 22:01 ` H. Nikolaus Schaller
2017-02-19 22:19 ` Pavel Machek
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:29 ` Pavel Machek
2017-02-20 20:20 ` H. Nikolaus Schaller
2017-02-20 22:26 ` Petr Cvek
2017-02-21 8:29 ` H. Nikolaus Schaller
2017-02-19 22:29 ` [Letux-kernel] " Andreas Kemnade
2017-02-19 22:39 ` Pavel Machek
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:32 ` Pavel Machek
2017-02-20 20:22 ` H. Nikolaus Schaller
2017-02-20 20:50 ` H. Nikolaus Schaller
2017-02-18 11:32 ` H. Nikolaus Schaller
2017-02-20 1:07 ` Dmitry Torokhov
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:42 ` Pali Rohár
2017-02-20 20:35 ` H. Nikolaus Schaller
2017-02-20 21:07 ` Pali Rohár
2017-02-20 21:24 ` H. Nikolaus Schaller
2017-02-20 21:54 ` Pali Rohár
2017-02-21 6:42 ` H. Nikolaus Schaller
2017-02-21 8:53 ` Pali Rohár
2017-02-20 21:08 ` Pali Rohár
2017-02-20 21:27 ` H. Nikolaus Schaller
2017-02-20 21:50 ` Dmitry Torokhov
2017-02-20 22:21 ` Petr Cvek
2017-02-20 22:24 ` Dmitry Torokhov
2017-02-21 6:56 ` H. Nikolaus Schaller
2017-02-20 22:45 ` Pali Rohár
2017-02-21 6:36 ` H. Nikolaus Schaller
2017-02-21 9:09 ` Pali Rohár
2017-02-21 17:07 ` [Letux-kernel] " Andreas Kemnade
2017-02-20 22:04 ` Pali Rohár
2017-02-21 6:49 ` H. Nikolaus Schaller
2017-02-21 7:14 ` H. Nikolaus Schaller
2017-02-21 8:47 ` Pali Rohár
2017-02-21 8:57 ` [Letux-kernel] " Christ van Willegen
2017-02-21 11:07 ` Pavel Machek
2016-12-28 14:53 ` [PATCH v9 2/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe H. Nikolaus Schaller
2017-02-17 20:52 ` Dmitry Torokhov
2016-12-28 14:53 ` [PATCH v9 3/8] DT:omap3+tsc2007: use new common touchscreen bindings H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 4/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 5/8] dt-bindings: input: move ads7846 bindings to touchscreen subdirectory H. Nikolaus Schaller
2017-02-23 9:54 ` H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 6/8] drivers:input:ads7846(+tsc2046): fix spi module table H. Nikolaus Schaller
2017-01-28 19:35 ` Dmitry Torokhov
2017-01-29 8:39 ` H. Nikolaus Schaller
2017-01-29 18:01 ` Dmitry Torokhov
2017-01-29 18:25 ` H. Nikolaus Schaller
2017-02-01 20:20 ` H. Nikolaus Schaller
2017-02-01 21:14 ` Javier Martinez Canillas
2017-02-01 22:28 ` Dmitry Torokhov
2017-02-01 22:50 ` Javier Martinez Canillas
2017-02-02 5:47 ` H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 7/8] DT:omap3+ads7846: use new common touchscreen bindings H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 8/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature H. Nikolaus Schaller
2016-12-30 20:36 ` Jonathan Cameron
2017-02-17 21:27 ` Dmitry Torokhov
2017-02-18 11:35 ` H. Nikolaus Schaller
2017-01-16 6:34 ` [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2017-01-21 13:08 ` Jonathan Cameron
2017-01-21 13:17 ` H. Nikolaus Schaller [this message]
2017-01-28 18:16 ` [Letux-kernel] " H. Nikolaus Schaller
2017-02-12 15:18 ` H. Nikolaus Schaller
2017-02-15 14:03 ` H. Nikolaus Schaller
2017-02-17 20:43 ` Dmitry Torokhov
2017-02-18 11:30 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B04BF50A-A54E-4CA2-BB0E-7B547D40403A@goldelico.com \
--to=hns@goldelico.com \
--cc=afd@ti.com \
--cc=alexander.stein@systec-electronic.com \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=benjamin.tissoires@redhat.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eric@engestrom.ch \
--cc=grinberg@compulab.co.il \
--cc=hans.verkuil@cisco.com \
--cc=hdegoede@redhat.com \
--cc=javier@osg.samsung.com \
--cc=jic23@kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michel.verl@gmail.com \
--cc=mika.penttila@nextfour.com \
--cc=mwelling@ieee.org \
--cc=nick@shmanahar.org \
--cc=petr.cvek@tul.cz \
--cc=robh+dt@kernel.org \
--cc=siebren.vroegindeweij@hotmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).