From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Javier Martinez Canillas" <javier@osg.samsung.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Michel Verlaan" <michel.verl@gmail.com>,
"Nick Dyer" <nick@shmanahar.org>,
"Tony Lindgren" <tony@atomide.com>,
LKML <linux-kernel@vger.kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-omap <linux-omap@vger.kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Igor Grinberg" <grinberg@compulab.co.il>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
linux-input@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Eric Engestrom" <eric@engestrom.ch>,
"Hans de Goede" <hdegoede@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mika Penttilä" <mika.penttila@nextfour.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Petr Cvek" <petr.cvek@tul.cz>,
"Siebren Vroegindeweij" <siebren.vroegindeweij@hotmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
linux-iio@vger.kernel.org, "Andrew F. Davis" <afd@ti.com>,
"Mark Brown" <broonie@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
kernel@pyra-handheld.com, "Michael Welling" <mwelling@ieee.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Alexander Stein" <alexander.stein@systec-electronic.com>,
"Discussions about the Letux Kernel"
<letux-kernel@openphoenux.org>
Subject: Re: [PATCH v9 6/8] drivers:input:ads7846(+tsc2046): fix spi module table
Date: Thu, 2 Feb 2017 06:47:12 +0100 [thread overview]
Message-ID: <3BB78F3F-F1FE-4F4C-BFA9-EAB19845161B@goldelico.com> (raw)
In-Reply-To: <20170201222832.GA25554@dtor-ws>
Hi,
> Am 01.02.2017 um 23:28 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
>
> On Wed, Feb 01, 2017 at 06:14:39PM -0300, Javier Martinez Canillas wrote:
>> Hello Nikolaus,
>>
>> On 02/01/2017 05:20 PM, H. Nikolaus Schaller wrote:
>>> Hi Dmitry, Javier,
>>>
>>>> Am 29.01.2017 um 19:25 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>>>>
>>>> Hi Dmitry,
>>>>
>>>>> Am 29.01.2017 um 19:01 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
>>>>>
>>>>> On Sun, Jan 29, 2017 at 09:39:39AM +0100, H. Nikolaus Schaller wrote:
>>>>>> Hi Dmitry,
>>>>>>
>>>>>>> Am 28.01.2017 um 20:35 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
>>>>>>>
>>>>>>> On Wed, Dec 28, 2016 at 03:53:21PM +0100, H. Nikolaus Schaller wrote:
>>>>>>>> Fix module table so that the driver is loaded if compiled
>>>>>>>> as module and requested by DT.
>>>>>>>>
>>>>>>>
>>>>>>> I believe I already replied to a similar patch: we alreadyhave necessary
>>>>>>> aliases in this driver, we need to fix module loading to use it.
>>>>>>
>>>>>> Yes, you did comment on [PATCH v6 7/8] (19 Nov 2016):
>>>>>>
>>>>>>>> We really need to fix it between spi/i23c core and module utils instead
>>>>>>>> of keeping adding duplicate IDs all over drivers. We already have OF
>>>>>>>> module device table containing the same data, we should be able to use
>>>>>>>> it.
>>>>>>
>>>>>> And Javier Martinez Canillas replied (23 Nov 2016):
>>>>>>
>>>>>>> Agreed, unfortunately until the I2C and SPI core are changed to properly
>>>>>>> report OF modaliases, we will have to keep adding these duplicated IDs.
>>>>>>>
>>>>>>> And changing the I2C and SPI core isn't trivial since it could break a
>>>>>>> lot of drivers that rely on a platform modalias being reported (i.e: no
>>>>>>> OF device IDs present in the drivers even when are registered via DT).
>>>>>>
>>>>>> Therefore I didn't see a need to change it.
>>>>>
>>>>> I agree that changing I2C and SPI core is not trivial, however this is
>>>>> no reason for piling up workarounds in all drivers. Are you seriously
>>>>> advocating going though *every* driver and copying OF data into I2C/SPI
>>>>> instead of doing the right thing and fixing the root of the issue?
>>>>
>>>> If you prefer to have this done (and I agree it would be a tiny improvement),
>>>> please do it for us all. But please after merging this workaround.
>>>
>>> Have we been lucky to find someone who is able and willing to work on this?
>>>
>>
>> As said, changing the core is trivial. A RFC patch is [0].
>>
>> The problem is how to make sure that this change won't cause regressions
>> in existing drivers.
>
> If the concern with drivers having I2C or SPI device table, but not OF
> device table, then I think cocinnelle could be used to scan and find
> them.
>
>>
>> There was particularly tricky for the spi-nor driver, it doesn't help that
>> a lot of DT are using undocumented compatible strings (sometimes with no
>> vendor prefix). You can see the discussion here [1].
>>
>> In the same thread Mark Brown said that it wasn't that bad to have the
>> information in the OF device ID table duplicated in a SPI device table.
>>
>> Certainly isn't the best approach but IMHO is better than the module not
>> loading.
>
> You can always build the module into kernel or load it by hand if it is
> that important.
Well, it is the only exception on the OpenPandora that does NOT yet load
automatically from the DT.
And sure we can always find a hack or workaround in user-space for everything
the kernel isn't doing well.
> Module autoloading does not work anyway if you have
> several compatible strings, like
>
> compatible = "vendor,new-device", "vendor,generic-device";
We don't use that mechanism here since there is only one ads7846 installed
and it won't change.
BR,
Nikolaus
next prev parent reply other threads:[~2017-02-02 5:48 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 14:53 [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation H. Nikolaus Schaller
2017-01-09 17:43 ` Rob Herring
2017-01-28 19:33 ` Dmitry Torokhov
2017-01-28 21:44 ` H. Nikolaus Schaller
2017-02-17 20:40 ` Dmitry Torokhov
2017-02-18 3:22 ` Sebastian Reichel
2017-02-18 11:33 ` H. Nikolaus Schaller
2017-02-18 23:44 ` Sebastian Reichel
2017-02-19 12:07 ` H. Nikolaus Schaller
2017-02-19 20:15 ` Sebastian Reichel
2017-02-20 16:49 ` H. Nikolaus Schaller
2017-02-18 7:45 ` [Letux-kernel] " Andreas Kemnade
2017-02-18 9:15 ` Pavel Machek
2017-02-18 11:33 ` H. Nikolaus Schaller
2017-02-18 18:08 ` Pavel Machek
2017-02-18 19:17 ` H. Nikolaus Schaller
2017-02-18 22:54 ` Pavel Machek
2017-02-19 12:05 ` H. Nikolaus Schaller
2017-02-19 14:17 ` Pavel Machek
2017-02-19 17:04 ` H. Nikolaus Schaller
2017-02-19 17:15 ` Pavel Machek
2017-02-19 17:51 ` H. Nikolaus Schaller
2017-02-19 19:05 ` Pavel Machek
2017-02-19 19:31 ` H. Nikolaus Schaller
2017-02-19 20:57 ` Pavel Machek
2017-02-19 22:01 ` H. Nikolaus Schaller
2017-02-19 22:19 ` Pavel Machek
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:29 ` Pavel Machek
2017-02-20 20:20 ` H. Nikolaus Schaller
2017-02-20 22:26 ` Petr Cvek
2017-02-21 8:29 ` H. Nikolaus Schaller
2017-02-19 22:29 ` [Letux-kernel] " Andreas Kemnade
2017-02-19 22:39 ` Pavel Machek
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:32 ` Pavel Machek
2017-02-20 20:22 ` H. Nikolaus Schaller
2017-02-20 20:50 ` H. Nikolaus Schaller
2017-02-18 11:32 ` H. Nikolaus Schaller
2017-02-20 1:07 ` Dmitry Torokhov
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:42 ` Pali Rohár
2017-02-20 20:35 ` H. Nikolaus Schaller
2017-02-20 21:07 ` Pali Rohár
2017-02-20 21:24 ` H. Nikolaus Schaller
2017-02-20 21:54 ` Pali Rohár
2017-02-21 6:42 ` H. Nikolaus Schaller
2017-02-21 8:53 ` Pali Rohár
2017-02-20 21:08 ` Pali Rohár
2017-02-20 21:27 ` H. Nikolaus Schaller
2017-02-20 21:50 ` Dmitry Torokhov
2017-02-20 22:21 ` Petr Cvek
2017-02-20 22:24 ` Dmitry Torokhov
2017-02-21 6:56 ` H. Nikolaus Schaller
2017-02-20 22:45 ` Pali Rohár
2017-02-21 6:36 ` H. Nikolaus Schaller
2017-02-21 9:09 ` Pali Rohár
2017-02-21 17:07 ` [Letux-kernel] " Andreas Kemnade
2017-02-20 22:04 ` Pali Rohár
2017-02-21 6:49 ` H. Nikolaus Schaller
2017-02-21 7:14 ` H. Nikolaus Schaller
2017-02-21 8:47 ` Pali Rohár
2017-02-21 8:57 ` [Letux-kernel] " Christ van Willegen
2017-02-21 11:07 ` Pavel Machek
2016-12-28 14:53 ` [PATCH v9 2/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe H. Nikolaus Schaller
2017-02-17 20:52 ` Dmitry Torokhov
2016-12-28 14:53 ` [PATCH v9 3/8] DT:omap3+tsc2007: use new common touchscreen bindings H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 4/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 5/8] dt-bindings: input: move ads7846 bindings to touchscreen subdirectory H. Nikolaus Schaller
2017-02-23 9:54 ` H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 6/8] drivers:input:ads7846(+tsc2046): fix spi module table H. Nikolaus Schaller
2017-01-28 19:35 ` Dmitry Torokhov
2017-01-29 8:39 ` H. Nikolaus Schaller
2017-01-29 18:01 ` Dmitry Torokhov
2017-01-29 18:25 ` H. Nikolaus Schaller
2017-02-01 20:20 ` H. Nikolaus Schaller
2017-02-01 21:14 ` Javier Martinez Canillas
2017-02-01 22:28 ` Dmitry Torokhov
2017-02-01 22:50 ` Javier Martinez Canillas
2017-02-02 5:47 ` H. Nikolaus Schaller [this message]
2016-12-28 14:53 ` [PATCH v9 7/8] DT:omap3+ads7846: use new common touchscreen bindings H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 8/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature H. Nikolaus Schaller
2016-12-30 20:36 ` Jonathan Cameron
2017-02-17 21:27 ` Dmitry Torokhov
2017-02-18 11:35 ` H. Nikolaus Schaller
2017-01-16 6:34 ` [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2017-01-21 13:08 ` Jonathan Cameron
2017-01-21 13:17 ` H. Nikolaus Schaller
2017-01-28 18:16 ` [Letux-kernel] " H. Nikolaus Schaller
2017-02-12 15:18 ` H. Nikolaus Schaller
2017-02-15 14:03 ` H. Nikolaus Schaller
2017-02-17 20:43 ` Dmitry Torokhov
2017-02-18 11:30 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BB78F3F-F1FE-4F4C-BFA9-EAB19845161B@goldelico.com \
--to=hns@goldelico.com \
--cc=afd@ti.com \
--cc=alexander.stein@systec-electronic.com \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=benjamin.tissoires@redhat.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eric@engestrom.ch \
--cc=grinberg@compulab.co.il \
--cc=hans.verkuil@cisco.com \
--cc=hdegoede@redhat.com \
--cc=javier@osg.samsung.com \
--cc=jic23@kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michel.verl@gmail.com \
--cc=mika.penttila@nextfour.com \
--cc=mwelling@ieee.org \
--cc=nick@shmanahar.org \
--cc=petr.cvek@tul.cz \
--cc=robh+dt@kernel.org \
--cc=siebren.vroegindeweij@hotmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).