* [PATCH] staging: dgnc: Fix Kconfig help header and text
@ 2018-09-25 6:20 sehro rautenkranz
2018-09-25 15:34 ` Randy Dunlap
0 siblings, 1 reply; 11+ messages in thread
From: sehro rautenkranz @ 2018-09-25 6:20 UTC (permalink / raw)
To: lidza-louina
Cc: markh, driverdev-devel, devel, linux-kernel, sehro rautenkranz
Replace Kconfig help header and text to match other modules. Issue found
by checkpatch.
Signed-off-by: sehro rautenkranz <sehro@sehro.org>
---
drivers/staging/dgnc/Kconfig | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
index 032c2a795238..c845b357b53d 100644
--- a/drivers/staging/dgnc/Kconfig
+++ b/drivers/staging/dgnc/Kconfig
@@ -2,5 +2,9 @@ config DGNC
tristate "Digi Neo and Classic PCI Products"
default n
depends on TTY && PCI
- ---help---
- Driver for the Digi International Neo and Classic PCI based product line.
+ help
+ Say Y here to enable support for the Digi International Neo and
+ Classic PCI based product line.
+
+ To compile this driver as a module, say M here: the module will be
+ called dgnc
--
2.19.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
2018-09-25 6:20 [PATCH] staging: dgnc: Fix Kconfig help header and text sehro rautenkranz
@ 2018-09-25 15:34 ` Randy Dunlap
2018-09-25 15:53 ` sehro rautenkranz
0 siblings, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2018-09-25 15:34 UTC (permalink / raw)
To: sehro rautenkranz, lidza-louina
Cc: markh, driverdev-devel, devel, linux-kernel
On 9/24/18 11:20 PM, sehro rautenkranz wrote:
> Replace Kconfig help header and text to match other modules. Issue found
> by checkpatch.
>
> Signed-off-by: sehro rautenkranz <sehro@sehro.org>
> ---
Hi,
Documentation/process/coding-style.rst says:
Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.
> drivers/staging/dgnc/Kconfig | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
> index 032c2a795238..c845b357b53d 100644
> --- a/drivers/staging/dgnc/Kconfig
> +++ b/drivers/staging/dgnc/Kconfig
> @@ -2,5 +2,9 @@ config DGNC
> tristate "Digi Neo and Classic PCI Products"
> default n
> depends on TTY && PCI
> - ---help---
> - Driver for the Digi International Neo and Classic PCI based product line.
> + help
> + Say Y here to enable support for the Digi International Neo and
> + Classic PCI based product line.
> +
> + To compile this driver as a module, say M here: the module will be
> + called dgnc
>
thanks,
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] staging: dgnc: Fix Kconfig help header and text
2018-09-25 15:34 ` Randy Dunlap
@ 2018-09-25 15:53 ` sehro rautenkranz
2018-09-25 16:00 ` Randy Dunlap
0 siblings, 1 reply; 11+ messages in thread
From: sehro rautenkranz @ 2018-09-25 15:53 UTC (permalink / raw)
Cc: sehro, Lidza Louina, Mark Hounschell, Greg Kroah-Hartman,
driverdev-devel, devel, linux-kernel
Replace Kconfig help header and text to match other modules. Issue found
my checkpatch.
Spacing adjusted to match Documentation/process/coding-style.rst. Issue
reported by rdunlap@infradead.org.
Signed-off-by: sehro rautenkranz <sehro@sehro.org>
---
drivers/staging/dgnc/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
index c845b357b53d..7361d6cd73d4 100644
--- a/drivers/staging/dgnc/Kconfig
+++ b/drivers/staging/dgnc/Kconfig
@@ -3,8 +3,8 @@ config DGNC
default n
depends on TTY && PCI
help
- Say Y here to enable support for the Digi International Neo and
- Classic PCI based product line.
+ Say Y here to enable support for the Digi International Neo and
+ Classic PCI based product line.
- To compile this driver as a module, say M here: the module will be
- called dgnc
+ To compile this driver as a module, say M here: the module will be
+ called dgnc
--
2.19.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
2018-09-25 15:53 ` sehro rautenkranz
@ 2018-09-25 16:00 ` Randy Dunlap
2018-09-25 16:22 ` sehro rautenkranz
0 siblings, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2018-09-25 16:00 UTC (permalink / raw)
To: sehro rautenkranz
Cc: devel, Mark Hounschell, Lidza Louina, driverdev-devel,
linux-kernel, Greg Kroah-Hartman
On 9/25/18 8:53 AM, sehro rautenkranz wrote:
> Replace Kconfig help header and text to match other modules. Issue found
> my checkpatch.
by checkpatch.
>
> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
> reported by rdunlap@infradead.org.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
>
> Signed-off-by: sehro rautenkranz <sehro@sehro.org>
> ---
> drivers/staging/dgnc/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
> index c845b357b53d..7361d6cd73d4 100644
> --- a/drivers/staging/dgnc/Kconfig
> +++ b/drivers/staging/dgnc/Kconfig
> @@ -3,8 +3,8 @@ config DGNC
> default n
> depends on TTY && PCI
> help
> - Say Y here to enable support for the Digi International Neo and
> - Classic PCI based product line.
> + Say Y here to enable support for the Digi International Neo and
> + Classic PCI based product line.
>
> - To compile this driver as a module, say M here: the module will be
> - called dgnc
> + To compile this driver as a module, say M here: the module will be
> + called dgnc
That indentation is still not correct. :(
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] staging: dgnc: Fix Kconfig help header and text
2018-09-25 16:00 ` Randy Dunlap
@ 2018-09-25 16:22 ` sehro rautenkranz
2018-09-25 18:46 ` Greg Kroah-Hartman
0 siblings, 1 reply; 11+ messages in thread
From: sehro rautenkranz @ 2018-09-25 16:22 UTC (permalink / raw)
Cc: sehro rautenkranz, Lidza Louina, Mark Hounschell,
Greg Kroah-Hartman, driverdev-devel, devel, linux-kernel
Replace Kconfig help header and text to match other modules. Issue found
my checkpatch.
Spacing adjusted to match Documentation/process/coding-style.rst. Issue
reported by rdunlap@infradead.org. (try 2)
Signed-off-by: sehro rautenkranz <sehro@sehro.org>
---
drivers/staging/dgnc/Kconfig | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
index 032c2a795238..0f7537eb27d8 100644
--- a/drivers/staging/dgnc/Kconfig
+++ b/drivers/staging/dgnc/Kconfig
@@ -1,6 +1,10 @@
config DGNC
- tristate "Digi Neo and Classic PCI Products"
- default n
- depends on TTY && PCI
- ---help---
- Driver for the Digi International Neo and Classic PCI based product line.
+ tristate "Digi Neo and Classic PCI Products"
+ default n
+ depends on TTY && PCI
+ help
+ Say Y here to enable support for the Digi International Neo and
+ Classic PCI based product line.
+
+ To compile this driver as a module, say M here: the module will be
+ called dgnc
--
2.19.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
2018-09-25 16:22 ` sehro rautenkranz
@ 2018-09-25 18:46 ` Greg Kroah-Hartman
2018-09-25 19:49 ` Randy Dunlap
0 siblings, 1 reply; 11+ messages in thread
From: Greg Kroah-Hartman @ 2018-09-25 18:46 UTC (permalink / raw)
To: sehro rautenkranz
Cc: Lidza Louina, Mark Hounschell, driverdev-devel, devel, linux-kernel
On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote:
> Replace Kconfig help header and text to match other modules. Issue found
> my checkpatch.
>
> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
> reported by rdunlap@infradead.org. (try 2)
The "try 2" needs go to below the --- line.
Also, you need to properly version your patches so that I have a clue
as to which is the "latest" one.
> Signed-off-by: sehro rautenkranz <sehro@sehro.org>
You forgot Randy's Reported-by.
Also, properly Capitalize your name.
v3?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
2018-09-25 18:46 ` Greg Kroah-Hartman
@ 2018-09-25 19:49 ` Randy Dunlap
2018-09-25 23:41 ` [PATCH v3] " Sehro Rautenkranz
0 siblings, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2018-09-25 19:49 UTC (permalink / raw)
To: Greg Kroah-Hartman, sehro rautenkranz
Cc: Lidza Louina, Mark Hounschell, driverdev-devel, devel, linux-kernel
On 9/25/18 11:46 AM, Greg Kroah-Hartman wrote:
> On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote:
>> Replace Kconfig help header and text to match other modules. Issue found
>> my checkpatch.
>>
>> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
>> reported by rdunlap@infradead.org. (try 2)
>
> The "try 2" needs go to below the --- line.
>
> Also, you need to properly version your patches so that I have a clue
> as to which is the "latest" one.
>
>> Signed-off-by: sehro rautenkranz <sehro@sehro.org>
>
> You forgot Randy's Reported-by.
>
> Also, properly Capitalize your name.
>
> v3?
and the help text is still not indented correctly:
use one tab + 2 spaces for help text.
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] staging: dgnc: Fix Kconfig help header and text
2018-09-25 19:49 ` Randy Dunlap
@ 2018-09-25 23:41 ` Sehro Rautenkranz
[not found] ` <CA+t4uCMAgpNtpdLfxNY_cmx7WONKOYjiaTBDGRNd+7H_GUdRAA@mail.gmail.com>
0 siblings, 1 reply; 11+ messages in thread
From: Sehro Rautenkranz @ 2018-09-25 23:41 UTC (permalink / raw)
To: sehro
Cc: Lidza Louina, Mark Hounschell, Greg Kroah-Hartman,
driverdev-devel, devel, linux-kernel
Replace Kconfig help header and text to match other modules. Issue found
by checkpatch.
Spacing adjusted to match Documentation/process/coding-style.rst. Issue
reported by rdunlap@infradead.org.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Sehro Rautenkranz <sehro@sehro.org>
---
drivers/staging/dgnc/Kconfig | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
index 032c2a795238..9f4f52c9c27d 100644
--- a/drivers/staging/dgnc/Kconfig
+++ b/drivers/staging/dgnc/Kconfig
@@ -1,6 +1,10 @@
config DGNC
- tristate "Digi Neo and Classic PCI Products"
- default n
- depends on TTY && PCI
- ---help---
- Driver for the Digi International Neo and Classic PCI based product line.
+ tristate "Digi Neo and Classic PCI Products"
+ default n
+ depends on TTY && PCI
+ help
+ Say Y here to enable support for the Digi International Neo and
+ Classic PCI based product line.
+
+ To compile this driver as a module, say M here: the module will be
+ called dgnc
--
2.19.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-10-02 22:09 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-25 6:20 [PATCH] staging: dgnc: Fix Kconfig help header and text sehro rautenkranz
2018-09-25 15:34 ` Randy Dunlap
2018-09-25 15:53 ` sehro rautenkranz
2018-09-25 16:00 ` Randy Dunlap
2018-09-25 16:22 ` sehro rautenkranz
2018-09-25 18:46 ` Greg Kroah-Hartman
2018-09-25 19:49 ` Randy Dunlap
2018-09-25 23:41 ` [PATCH v3] " Sehro Rautenkranz
[not found] ` <CA+t4uCMAgpNtpdLfxNY_cmx7WONKOYjiaTBDGRNd+7H_GUdRAA@mail.gmail.com>
2018-10-01 12:09 ` Mark Hounschell
[not found] ` <CA+t4uCPFZSTjyN-Wd3ppOp-edAXfSSTTdT8uab+-E53=Htv9+A@mail.gmail.com>
2018-10-01 17:38 ` Mark Hounschell
2018-10-02 22:09 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).