* [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event
@ 2018-12-12 6:41 Kai-Heng Feng
2018-12-12 14:06 ` Pali Rohár
0 siblings, 1 reply; 4+ messages in thread
From: Kai-Heng Feng @ 2018-12-12 6:41 UTC (permalink / raw)
To: pali.rohar
Cc: mjg59, dvhart, andy, mario.limonciello, platform-driver-x86,
linux-kernel, Kai-Heng Feng
There's a new wmi event generated by dell-wmi when pressing keyboard
backlight hotkey:
[ 3285.474172] dell_wmi: Unknown key with type 0x0010 and code 0x003f pressed
This event is for notification purpose, let's ignore it. The keyboard
backlight hotkey uses another event so it still works without event
0x3f.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/platform/x86/dell-wmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 16c7f3d9a335..c3166ba73e9a 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -267,6 +267,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
/* Fn-lock switched to multimedia keys */
{ KE_IGNORE, 0x1, { KEY_RESERVED } },
+ /* Keyboard backlight change notification */
+ { KE_IGNORE, 0x3f, { KEY_RESERVED } },
+
/* Mic mute */
{ KE_KEY, 0x150, { KEY_MICMUTE } },
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event
2018-12-12 6:41 [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event Kai-Heng Feng
@ 2018-12-12 14:06 ` Pali Rohár
2019-01-24 6:25 ` Kai-Heng Feng
0 siblings, 1 reply; 4+ messages in thread
From: Pali Rohár @ 2018-12-12 14:06 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: mjg59, dvhart, andy, mario.limonciello, platform-driver-x86,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
On Wednesday 12 December 2018 14:41:25 Kai-Heng Feng wrote:
> There's a new wmi event generated by dell-wmi when pressing keyboard
> backlight hotkey:
> [ 3285.474172] dell_wmi: Unknown key with type 0x0010 and code 0x003f pressed
>
> This event is for notification purpose, let's ignore it. The keyboard
> backlight hotkey uses another event so it still works without event
> 0x3f.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> drivers/platform/x86/dell-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 16c7f3d9a335..c3166ba73e9a 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -267,6 +267,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
> /* Fn-lock switched to multimedia keys */
> { KE_IGNORE, 0x1, { KEY_RESERVED } },
>
> + /* Keyboard backlight change notification */
> + { KE_IGNORE, 0x3f, { KEY_RESERVED } },
> +
> /* Mic mute */
> { KE_KEY, 0x150, { KEY_MICMUTE } },
>
Looks good.
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event
2018-12-12 14:06 ` Pali Rohár
@ 2019-01-24 6:25 ` Kai-Heng Feng
2019-02-05 17:35 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Kai-Heng Feng @ 2019-01-24 6:25 UTC (permalink / raw)
To: dvhart
Cc: Pali Rohár, mjg59, andy, Mario Limonciello,
platform-driver-x86, lkml
Hi Darren,
> On Dec 12, 2018, at 22:06, Pali Rohár <pali.rohar@gmail.com> wrote:
>
> On Wednesday 12 December 2018 14:41:25 Kai-Heng Feng wrote:
>> There's a new wmi event generated by dell-wmi when pressing keyboard
>> backlight hotkey:
>> [ 3285.474172] dell_wmi: Unknown key with type 0x0010 and code 0x003f pressed
>>
>> This event is for notification purpose, let's ignore it. The keyboard
>> backlight hotkey uses another event so it still works without event
>> 0x3f.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> drivers/platform/x86/dell-wmi.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
>> index 16c7f3d9a335..c3166ba73e9a 100644
>> --- a/drivers/platform/x86/dell-wmi.c
>> +++ b/drivers/platform/x86/dell-wmi.c
>> @@ -267,6 +267,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>> /* Fn-lock switched to multimedia keys */
>> { KE_IGNORE, 0x1, { KEY_RESERVED } },
>>
>> + /* Keyboard backlight change notification */
>> + { KE_IGNORE, 0x3f, { KEY_RESERVED } },
>> +
>> /* Mic mute */
>> { KE_KEY, 0x150, { KEY_MICMUTE } },
>>
>
> Looks good.
>
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Please merge this patch, thanks.
Kai-Heng
>
> --
> Pali Rohár
> pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event
2019-01-24 6:25 ` Kai-Heng Feng
@ 2019-02-05 17:35 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2019-02-05 17:35 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: Darren Hart, Pali Rohár, Matthew Garrett, Andy Shevchenko,
Mario Limonciello, Platform Driver, lkml
On Thu, Jan 24, 2019 at 8:27 AM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> Hi Darren,
>
> > On Dec 12, 2018, at 22:06, Pali Rohár <pali.rohar@gmail.com> wrote:
> >
> > On Wednesday 12 December 2018 14:41:25 Kai-Heng Feng wrote:
> >> There's a new wmi event generated by dell-wmi when pressing keyboard
> >> backlight hotkey:
> >> [ 3285.474172] dell_wmi: Unknown key with type 0x0010 and code 0x003f pressed
> >>
> >> This event is for notification purpose, let's ignore it. The keyboard
> >> backlight hotkey uses another event so it still works without event
> >> 0x3f.
Pushed to my review and testing queue, thanks!
> >>
> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> ---
> >> drivers/platform/x86/dell-wmi.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> >> index 16c7f3d9a335..c3166ba73e9a 100644
> >> --- a/drivers/platform/x86/dell-wmi.c
> >> +++ b/drivers/platform/x86/dell-wmi.c
> >> @@ -267,6 +267,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
> >> /* Fn-lock switched to multimedia keys */
> >> { KE_IGNORE, 0x1, { KEY_RESERVED } },
> >>
> >> + /* Keyboard backlight change notification */
> >> + { KE_IGNORE, 0x3f, { KEY_RESERVED } },
> >> +
> >> /* Mic mute */
> >> { KE_KEY, 0x150, { KEY_MICMUTE } },
> >>
> >
> > Looks good.
> >
> > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>
> Please merge this patch, thanks.
>
> Kai-Heng
>
> >
> > --
> > Pali Rohár
> > pali.rohar@gmail.com
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-05 17:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12 6:41 [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event Kai-Heng Feng
2018-12-12 14:06 ` Pali Rohár
2019-01-24 6:25 ` Kai-Heng Feng
2019-02-05 17:35 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).