Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()

From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
Date: Fri, 11 Oct 2019 01:11:04 +0100	[thread overview]
Message-ID: <20191011001104.GJ26530@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHk-=wgWRQo0m7TUCK4T_J-3Vqte+p-FWzvT3CB1jJHgX-KctA@mail.gmail.com>

On Thu, Oct 10, 2019 at 03:12:49PM -0700, Linus Torvalds wrote:
> On Thu, Oct 10, 2019 at 12:55 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Anyway, another question you way: what do you think of try/catch approaches
> > to __get_user() blocks, like e.g. restore_sigcontext() is doing?
> 
> I'd rather have them converted to our unsafe_get/put_user() instead.
> 
> We don't generate great code for the "get" case (because of how gcc
> doesn't allow us to mix "asm goto" and outputs), but I really despise
> the x86-specific "{get,put}_user_ex()" machinery. It's not actually
> doing a real try/catch at all, and will just keep taking faults if one
> happens.
> 
> But I've not gotten around to rewriting those disgusting sequences to
> the unsafe_get/put_user() model. I did look at it, and it requires
> some changes exactly *because* the _ex() functions are broken and
> continue, but also because the current code ends up also doing other
> things inside the try/catch region that you're not supposed to do in a
> user_access_begin/end() region .

Hmm...  Which one was that?  AFAICS, we have
	do_sys_vm86: only get_user_ex()
	restore_sigcontext(): get_user_ex(), set_user_gs()
	ia32_restore_sigcontext(): get_user_ex()

So at least get_user_try/get_user_ex/get_user_catch should be killable.
The other side...
	save_v86_state(): put_user_ex()
	setup_sigcontext(): put_user_ex()
	__setup_rt_frame(): put_user_ex(), static_cpu_has()
	another one in __setup_rt_frame(): put_user_ex()
	x32_setup_rt_frame(): put_user_ex()
	ia32_setup_sigcontext(): put_user_ex()
	ia32_setup_frame(): put_user_ex()
	another one in ia32_setup_frame(): put_user_ex(), static_cpu_has()

IDGI...  Is static_cpu_has() not allowed in there?  Looks like it's all inlines
and doesn't do any potentially risky memory accesses...  What am I missing?

As for the try/catch model...  How about
	if (!user_access_begin())
		sod off
	...
	unsafe_get_user(..., l);
	...
	unsafe_get_user_nojump();
	...
	unsafe_get_user_nojump();
	...
	if (user_access_did_fail())
		goto l;

	user_access_end()
	...
	return 0;
l:
	...
	user_access_end()
	return -EFAULT;

making it clear that we are delaying the check for failures until it's
more convenient.  And *not* trying to trick C parser into enforcing
anything - let objtool do it and to hell with do { and } while (0) in
magic macros.  Could be mixed with the normal unsafe_..._user() without
any problems, AFAICS...