From: Stephan Mueller <smueller@chronox.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Alexander E. Patrakov" <patrakov@gmail.com>,
"Ahmed S. Darwish" <darwish.07@gmail.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Willy Tarreau <w@1wt.eu>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Vito Caputo <vcaputo@pengaru.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>, Ray Strode <rstrode@redhat.com>,
William Jon McCann <mccann@jhu.edu>,
zhangjs <zachary@baishancloud.com>,
Andy Lutomirski <luto@kernel.org>,
Florian Weimer <fweimer@redhat.com>,
Lennart Poettering <mzxreary@0pointer.de>,
Nicolai Stange <nstange@suse.de>,
"Peter, Matthias" <matthias.peter@bsi.bund.de>,
Marcelo Henrique Cerri <marcelo.cerri@canonical.com>,
Roman Drahtmueller <draht@schaltsekun.de>,
Neil Horman <nhorman@redhat.com>,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v27 09/12] LRNG - add Jitter RNG fast noise source
Date: Fri, 10 Jan 2020 08:45:22 +0100 [thread overview]
Message-ID: <3881936.EWlHz54Di6@tauon.chronox.de> (raw)
In-Reply-To: <0ba976fa-fed1-4720-c039-043160dbce9e@infradead.org>
Am Freitag, 10. Januar 2020, 01:24:47 CET schrieb Randy Dunlap:
Hi Randy,
> Hi,
>
> On 1/9/20 12:34 AM, Stephan Müller wrote:
> > ---
> >
> > drivers/char/lrng/Kconfig | 11 +++++
> > drivers/char/lrng/Makefile | 1 +
> > drivers/char/lrng/lrng_jent.c | 87 +++++++++++++++++++++++++++++++++++
> > 3 files changed, 99 insertions(+)
> > create mode 100644 drivers/char/lrng/lrng_jent.c
> >
> > diff --git a/drivers/char/lrng/lrng_jent.c b/drivers/char/lrng/lrng_jent.c
> > new file mode 100644
> > index 000000000000..97c0d192e9c8
> > --- /dev/null
> > +++ b/drivers/char/lrng/lrng_jent.c
> > @@ -0,0 +1,87 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> > +/*
> > + * LRNG Fast Noise Source: Jitter RNG
> > + *
> > + * Copyright (C) 2016 - 2020, Stephan Mueller <smueller@chronox.de>
> > + */
> > +
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > +
> > +#include <linux/types.h>
> > +#include <crypto/internal/jitterentropy.h>
> > +
> > +#include "lrng_internal.h"
> > +
> > +/*
> > + * Estimated entropy of data is a 16th of
> > LRNG_DRNG_SECURITY_STRENGTH_BITS. + * Albeit a full entropy assessment is
> > provided for the noise source indicating + * that it provides high
> > entropy rates and considering that it deactivates + * when it detects
> > insufficient hardware, the chosen under estimation of + * entropy is
> > considered to be acceptable to all reviewers.
> > + */
> > +static u32 jitterrng = LRNG_DRNG_SECURITY_STRENGTH_BITS>>4;
> > +module_param(jitterrng, uint, 0644);
> > +MODULE_PARM_DESC(jitterrng, "Entropy in bits of 256 data bits from Jitter
> > " + "RNG noise source");
> > +
> > +/**
> > + * Get Jitter RNG entropy
> > + *
> > + * @outbuf buffer to store entropy
> > + * @outbuflen length of buffer
> > + * @return > 0 on success where value provides the added entropy in bits
> > + * 0 if no fast source was available
> > + */
>
> Don't begin the comment block with /**
> or convert it to Linux kernel-doc notation format.
Yes, the colons are missing and there is no @return. It will be fixed with the
next patch set.
Thank you.
>
> > +static struct rand_data *lrng_jent_state;
> > +
> > +u32 lrng_get_jent(u8 *outbuf, unsigned int outbuflen)
> > +{
> > + int ret;
> > + u32 ent_bits = jitterrng;
> > + unsigned long flags;
> > + static DEFINE_SPINLOCK(lrng_jent_lock);
> > + static int lrng_jent_initialized = 0;
> > +
> > + spin_lock_irqsave(&lrng_jent_lock, flags);
> > +
> > + if (!ent_bits || (lrng_jent_initialized == -1)) {
> > + spin_unlock_irqrestore(&lrng_jent_lock, flags);
> > + return 0;
> > + }
> > +
> > + if (!lrng_jent_initialized) {
> > + lrng_jent_state = jent_lrng_entropy_collector();
> > + if (!lrng_jent_state) {
> > + jitterrng = 0;
> > + lrng_jent_initialized = -1;
> > + spin_unlock_irqrestore(&lrng_jent_lock, flags);
> > + pr_info("Jitter RNG unusable on current system\n");
> > + return 0;
> > + }
> > + lrng_jent_initialized = 1;
> > + pr_debug("Jitter RNG working on current system\n");
> > + }
> > + ret = jent_read_entropy(lrng_jent_state, outbuf, outbuflen);
> > + spin_unlock_irqrestore(&lrng_jent_lock, flags);
> > +
> > + if (ret) {
> > + pr_debug("Jitter RNG failed with %d\n", ret);
> > + return 0;
> > + }
> > +
> > + /* Obtain entropy statement */
> > + if (outbuflen != LRNG_DRNG_SECURITY_STRENGTH_BYTES)
> > + ent_bits = (ent_bits * outbuflen<<3) /
> > + LRNG_DRNG_SECURITY_STRENGTH_BITS;
> > + /* Cap entropy to buffer size in bits */
> > + ent_bits = min_t(u32, ent_bits, outbuflen<<3);
> > + pr_debug("obtained %u bits of entropy from Jitter RNG noise source\n",
> > + ent_bits);
> > +
> > + return ent_bits;
> > +}
> > +
> > +u32 lrng_jent_entropylevel(void)
> > +{
> > + return min_t(u32, jitterrng, LRNG_DRNG_SECURITY_STRENGTH_BITS);
> > +}
>
> thanks.
Ciao
Stephan
next prev parent reply other threads:[~2020-01-10 7:46 UTC|newest]
Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 18:17 [PATCH v24 00/12] /dev/random - a new approach with full SP800-90B compliance Stephan Müller
2019-11-11 18:18 ` [PATCH v24 01/12] Linux Random Number Generator Stephan Müller
2019-11-11 23:54 ` Thomas Gleixner
2019-11-12 2:25 ` Stephan Müller
2019-11-12 10:16 ` Thomas Gleixner
2019-11-12 22:30 ` kbuild test robot
2019-11-12 23:15 ` Stephan Müller
2019-11-13 0:14 ` kbuild test robot
2019-11-13 0:25 ` Stephan Müller
2019-11-24 4:51 ` Sandy Harris
2019-11-24 9:02 ` Stephan Mueller
2019-11-11 18:19 ` [PATCH v24 02/12] LRNG - allocate one SDRNG instance per NUMA node Stephan Müller
2019-11-11 18:20 ` [PATCH v24 03/12] LRNG - /proc interface Stephan Müller
2019-11-11 18:20 ` [PATCH v24 04/12] LRNG - add switchable DRNG support Stephan Müller
2019-11-11 18:21 ` [PATCH v24 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller
2019-11-11 18:21 ` [PATCH v24 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller
2019-11-11 18:22 ` [PATCH v24 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller
2019-11-11 18:23 ` [PATCH v24 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller
2019-11-11 18:23 ` [PATCH v24 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller
2019-11-11 18:24 ` [PATCH v24 10/12] LRNG - add TRNG support Stephan Müller
2019-11-11 18:26 ` [PATCH v24 11/12] LRNG - add SP800-90B compliant health tests Stephan Müller
2019-11-12 19:58 ` Alexander E. Patrakov
2019-11-12 23:11 ` Stephan Müller
2019-11-13 0:36 ` Stephan Müller
2019-11-13 6:02 ` Alexander E. Patrakov
2019-11-14 1:46 ` Stephan Müller
2019-11-11 18:26 ` [PATCH v24 12/12] LRNG - add interface for gathering of raw entropy Stephan Müller
2019-11-12 20:55 ` kbuild test robot
2019-11-12 23:13 ` Stephan Müller
2019-11-12 13:23 ` [PATCH v24 00/12] /dev/random - a new approach with full SP800-90B compliance Florian Weimer
2019-11-12 22:43 ` Stephan Müller
2019-11-12 15:33 ` Andy Lutomirski
2019-11-12 23:03 ` Stephan Müller
2019-11-12 23:26 ` Stephan Müller
2019-11-13 4:24 ` Stephan Müller
2019-11-13 4:48 ` Andy Lutomirski
2019-11-13 12:16 ` Stephan Müller
2019-11-16 9:32 ` [PATCH v25 00/12] /dev/random - a new approach with full SP800-90B Stephan Müller
2019-11-16 9:33 ` [PATCH v25 01/12] Linux Random Number Generator Stephan Müller
2019-11-16 11:25 ` Thomas Gleixner
2019-11-17 10:30 ` Stephan Müller
2019-11-16 18:13 ` Nicolai Stange
2019-11-17 11:01 ` Stephan Müller
2019-11-16 9:33 ` [PATCH v25 02/12] LRNG - allocate one SDRNG instance per NUMA node Stephan Müller
2019-11-16 9:34 ` [PATCH v25 03/12] LRNG - /proc interface Stephan Müller
2019-11-16 16:39 ` Andy Lutomirski
2019-11-17 12:16 ` Stephan Müller
2019-11-19 10:06 ` Andy Lutomirski
2019-11-19 10:55 ` Stephan Mueller
2019-11-19 17:40 ` Andy Lutomirski
2019-11-16 23:36 ` Eric W. Biederman
2019-11-17 11:37 ` Stephan Müller
2019-11-16 9:34 ` [PATCH v25 04/12] LRNG - add switchable DRNG support Stephan Müller
2019-11-16 9:35 ` [PATCH v25 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller
2019-11-16 9:35 ` [PATCH v25 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller
2019-11-16 9:35 ` [PATCH v25 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller
2019-11-16 9:36 ` [PATCH v25 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller
2019-11-16 9:36 ` [PATCH v25 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller
2019-11-20 13:33 ` Neil Horman
2019-11-20 20:07 ` Stephan Müller
2019-11-21 14:19 ` Neil Horman
2019-11-21 14:33 ` Stephan Mueller
2019-11-16 9:37 ` [PATCH v25 10/12] LRNG - add TRNG support Stephan Müller
2019-11-16 16:09 ` Andy Lutomirski
2019-11-17 11:10 ` Stephan Müller
2019-11-19 10:07 ` Andy Lutomirski
2019-11-19 10:46 ` Stephan Mueller
2019-11-19 12:41 ` Greg Kroah-Hartman
2019-11-20 8:58 ` Stephan Müller
2019-11-20 9:55 ` Alexander E. Patrakov
2019-11-20 13:29 ` Greg Kroah-Hartman
2019-11-20 19:51 ` Stephan Müller
2019-11-20 19:57 ` Alexander E. Patrakov
2019-11-20 20:32 ` Greg Kroah-Hartman
2019-11-21 13:06 ` Stephan Müller
2019-11-16 9:37 ` [PATCH v25 11/12] LRNG - add SP800-90B compliant health tests Stephan Müller
2019-11-16 9:38 ` [PATCH v25 12/12] LRNG - add interface for gathering of raw entropy Stephan Müller
2019-11-16 16:51 ` Andy Lutomirski
2019-11-17 22:55 ` Stephan Müller
2019-11-19 10:04 ` Andy Lutomirski
2019-11-19 17:17 ` Randy Dunlap
2019-11-20 9:01 ` Stephan Müller
2019-11-21 12:18 ` Nicolai Stange
2019-11-21 15:18 ` Stephan Müller
2019-11-23 20:08 ` [PATCH v26 00/12] /dev/random - a new approach with full SP800-90B Stephan Müller
2019-11-23 20:10 ` [PATCH v26 01/12] Linux Random Number Generator Stephan Müller
2019-11-24 22:44 ` kbuild test robot
2019-11-25 6:29 ` Stephan Mueller
2019-11-23 20:10 ` [PATCH v26 02/12] LRNG - allocate one SDRNG instance per NUMA node Stephan Müller
2019-11-23 20:11 ` [PATCH v26 03/12] LRNG - sysctls and /proc interface Stephan Müller
2019-11-23 20:11 ` [PATCH v26 04/12] LRNG - add switchable DRNG support Stephan Müller
2019-11-23 20:31 ` [PATCH v26 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller
2019-11-23 20:32 ` [PATCH v26 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller
2019-11-23 20:32 ` [PATCH v26 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller
2019-11-23 20:33 ` [PATCH v26 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller
2019-11-23 20:34 ` [PATCH v26 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller
2019-11-23 20:34 ` [PATCH v26 10/12] LRNG - add TRNG support Stephan Müller
2019-11-23 20:34 ` [PATCH v26 11/12] LRNG - add SP800-90B compliant health tests Stephan Müller
2019-11-23 20:35 ` [PATCH v26 12/12] LRNG - add interface for gathering of raw entropy Stephan Müller
2020-01-09 8:29 ` [PATCH v27 00/12] /dev/random - a new approach with full SP800-90B Stephan Müller
2020-01-09 8:30 ` [PATCH v27 01/12] Linux Random Number Generator Stephan Müller
2020-01-16 6:09 ` kbuild test robot
2020-01-16 6:41 ` Stephan Mueller
2020-01-09 8:31 ` [PATCH v27 02/12] LRNG - allocate one DRNG instance per NUMA node Stephan Müller
2020-01-09 8:31 ` [PATCH v27 03/12] LRNG - sysctls and /proc interface Stephan Müller
2020-01-09 8:32 ` [PATCH v27 04/12] LRNG - add switchable DRNG support Stephan Müller
2020-01-11 7:09 ` kbuild test robot
2020-01-12 10:12 ` Stephan Müller
2020-01-09 8:32 ` [PATCH v27 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller
2020-01-09 8:32 ` [PATCH v27 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller
2020-01-09 8:33 ` [PATCH v27 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller
2020-01-09 8:33 ` [PATCH v27 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller
2020-01-09 8:34 ` [PATCH v27 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller
2020-01-10 0:24 ` Randy Dunlap
2020-01-10 7:45 ` Stephan Mueller [this message]
2020-01-09 8:34 ` [PATCH v27 10/12] LRNG - add SP800-90B compliant health tests Stephan Müller
2020-01-10 0:20 ` Randy Dunlap
2020-01-10 8:27 ` Stephan Mueller
2020-01-09 8:35 ` [PATCH v27 11/12] LRNG - add interface for gathering of raw entropy Stephan Müller
2020-01-09 8:35 ` [PATCH v27 12/12] LRNG - add power-on and runtime self-tests Stephan Müller
2020-01-10 0:22 ` Randy Dunlap
2020-01-10 7:48 ` Stephan Mueller
2020-01-13 10:39 ` Dan Carpenter
2020-01-13 10:46 ` Stephan Mueller
2020-01-15 10:31 ` [PATCH v28 00/12] /dev/random - a new approach with full SP800-90B Stephan Müller
2020-01-15 10:31 ` [PATCH v28 01/12] Linux Random Number Generator Stephan Müller
2020-01-16 0:11 ` Randy Dunlap
2020-01-16 7:22 ` Stephan Mueller
2020-01-15 10:32 ` [PATCH v28 02/12] LRNG - allocate one DRNG instance per NUMA node Stephan Müller
2020-01-15 10:32 ` [PATCH v28 03/12] LRNG - sysctls and /proc interface Stephan Müller
2020-01-15 10:32 ` [PATCH v28 04/12] LRNG - add switchable DRNG support Stephan Müller
2020-01-15 10:33 ` [PATCH v28 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller
2020-01-15 10:33 ` [PATCH v28 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller
2020-01-16 0:14 ` Randy Dunlap
2020-01-16 6:55 ` Stephan Mueller
2020-01-15 10:34 ` [PATCH v28 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller
2020-01-16 0:15 ` Randy Dunlap
2020-01-16 6:54 ` Stephan Mueller
2020-01-15 10:34 ` [PATCH v28 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller
2020-01-15 10:34 ` [PATCH v28 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller
2020-01-16 0:17 ` Randy Dunlap
2020-01-16 6:51 ` Stephan Mueller
2020-01-15 10:35 ` [PATCH v28 10/12] LRNG - add SP800-90B compliant health tests Stephan Müller
2020-01-15 10:35 ` [PATCH v28 11/12] LRNG - add interface for gathering of raw entropy Stephan Müller
2020-01-16 0:18 ` Randy Dunlap
2020-01-16 6:43 ` Stephan Mueller
2020-01-16 6:48 ` Randy Dunlap
2020-01-16 6:52 ` Stephan Mueller
2020-01-15 10:36 ` [PATCH v28 12/12] LRNG - add power-on and runtime self-tests Stephan Müller
2020-01-19 21:12 ` [PATCH v29 00/12] /dev/random - a new approach with full SP800-90B Stephan Müller
2020-01-19 21:13 ` [PATCH v29 01/12] Linux Random Number Generator Stephan Müller
2020-01-19 21:13 ` [PATCH v29 02/12] LRNG - allocate one DRNG instance per NUMA node Stephan Müller
2020-01-19 21:14 ` [PATCH v29 03/12] LRNG - sysctls and /proc interface Stephan Müller
2020-01-19 21:14 ` [PATCH v29 04/12] LRNG - add switchable DRNG support Stephan Müller
2020-01-19 21:15 ` [PATCH v29 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller
2020-01-19 21:16 ` [PATCH v29 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller
2020-01-19 21:16 ` [PATCH v29 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller
2020-01-19 21:17 ` [PATCH v29 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller
2020-01-19 21:18 ` [PATCH v29 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller
2020-01-19 21:18 ` [PATCH v29 10/12] LRNG - add SP800-90B compliant health tests Stephan Müller
2020-01-19 21:19 ` [PATCH v29 11/12] LRNG - add interface for gathering of raw entropy Stephan Müller
2020-01-19 21:20 ` [PATCH v29 12/12] LRNG - add power-on and runtime self-tests Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3881936.EWlHz54Di6@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=darwish.07@gmail.com \
--cc=draht@schaltsekun.de \
--cc=ebiederm@xmission.com \
--cc=fweimer@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=julia.lawall@inria.fr \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=matthias.peter@bsi.bund.de \
--cc=mccann@jhu.edu \
--cc=mjg59@srcf.ucam.org \
--cc=mzxreary@0pointer.de \
--cc=nhorman@redhat.com \
--cc=nstange@suse.de \
--cc=patrakov@gmail.com \
--cc=rdunlap@infradead.org \
--cc=rstrode@redhat.com \
--cc=tytso@mit.edu \
--cc=vcaputo@pengaru.com \
--cc=w@1wt.eu \
--cc=zachary@baishancloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).