LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Rajendra Nayak <rnayak@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
	MSM <linux-arm-msm@vger.kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 0/9] Add power domain driver for corners on msm8996/sdm845
Date: Mon, 21 Jan 2019 14:50:47 +0530
Message-ID: <392710d8-3e3d-4987-e0be-a5098da852ab@codeaurora.org> (raw)
In-Reply-To: <40459ee8-7933-505a-bc39-64858d4e7637@free.fr>



On 1/18/2019 3:47 PM, Marc Gonzalez wrote:
> On 18/01/2019 04:54, Rajendra Nayak wrote:
> 
>> On 1/17/2019 8:33 PM, Marc Gonzalez wrote:
>>
>>> On 10/01/2019 05:02, Rajendra Nayak wrote:
>>>
>>>> Rajendra Nayak (9):
>>>>     dt-bindings: opp: Introduce opp-level bindings
>>>>     OPP: Add support for parsing the 'opp-level' property
>>>>     dt-bindings: power: Add qcom rpm power domain driver bindings
>>>>     soc: qcom: rpmpd: Add a Power domain driver to model corners
>>>>     soc: qcom: rpmpd: Add support for get/set performance state
>>>>     arm64: dts: msm8996: Add rpmpd device node
>>>>     soc: qcom: rpmhpd: Add RPMh power domain driver
>>>>     arm64: dts: sdm845: Add rpmh powercontroller node
>>>>     soc: qcom: rpmhpd: Mark mx as a parent for cx
>>>>
>>>>    Documentation/devicetree/bindings/opp/opp.txt |   3 +
>>>>    .../devicetree/bindings/power/qcom,rpmpd.txt  | 145 +++++++
>>>>    arch/arm64/boot/dts/qcom/msm8996.dtsi         |  34 ++
>>>>    arch/arm64/boot/dts/qcom/sdm845.dtsi          |  51 +++
>>>
>>> Whenever I see these patches adding support for msm8996 (aka sdm820) and sdm845
>>> simultaneously, I think to myself: "Why is sdm835 being left out? It was released
>>> between sdm820 and sdm845, it cannot be /that/ different."
>>
>> It isn't that different, and it should be quite straight forward to add support for it
>> with the rpmpd driver (the rpmhpd is for platforms sdm845 and beyond which use rpmh)
>>
>> When I started working on these patches, support for sdm835 upstream was non-existent
>> so I started off with what was the better supported one which was the 820 (msm8996).
> 
> Once you land this patch series, could you take a quick look at how much work is needed
> to add msm8998 support? I'm betting it would take you only a few hours.

Sure, I can take a look. I think I do have a 8998 device which I can probably do
some testing on too.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

      reply index

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  4:02 Rajendra Nayak
2019-01-10  4:02 ` [PATCH v11 1/9] dt-bindings: opp: Introduce opp-level bindings Rajendra Nayak
2019-01-10  6:26   ` Viresh Kumar
2019-01-11 19:06   ` Stephen Boyd
2019-01-11 22:16   ` Doug Anderson
2019-01-15 19:59   ` Rob Herring
2019-01-10  4:02 ` [PATCH v11 2/9] OPP: Add support for parsing the 'opp-level' property Rajendra Nayak
2019-01-10  6:29   ` Viresh Kumar
2019-01-11 19:06   ` Stephen Boyd
2019-01-10  4:02 ` [PATCH v11 3/9] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2019-01-10  4:02 ` [PATCH v11 4/9] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2019-01-17 17:42   ` Guenter Roeck
2019-01-18  4:54     ` Rajendra Nayak
2019-01-10  4:02 ` [PATCH v11 5/9] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2019-01-10  4:02 ` [PATCH v11 6/9] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2019-01-10  4:02 ` [PATCH v11 7/9] soc: qcom: rpmhpd: Add RPMh power domain driver Rajendra Nayak
2019-01-10  4:02 ` [PATCH v11 8/9] arm64: dts: sdm845: Add rpmh powercontroller node Rajendra Nayak
2019-01-10  4:02 ` [PATCH v11 9/9] soc: qcom: rpmhpd: Mark mx as a parent for cx Rajendra Nayak
2019-01-10  6:33 ` [PATCH v11 0/9] Add power domain driver for corners on msm8996/sdm845 Viresh Kumar
2019-01-16  5:52   ` Bjorn Andersson
2019-01-16 15:18     ` Ulf Hansson
2019-01-17  4:24     ` Viresh Kumar
2019-01-17 15:03 ` Marc Gonzalez
2019-01-18  3:54   ` Rajendra Nayak
2019-01-18 10:17     ` Marc Gonzalez
2019-01-21  9:20       ` Rajendra Nayak [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=392710d8-3e3d-4987-e0be-a5098da852ab@codeaurora.org \
    --to=rnayak@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox