From: Mark Lord <lkml@rtr.ca>
To: Greg KH <greg@kroah.com>
Cc: Oliver Neukum <oneukum@suse.de>, Adrian Bunk <bunk@stusta.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG} usb-serial regression in 2.6.21-rc2-git3
Date: Mon, 12 Mar 2007 12:50:33 -0400 [thread overview]
Message-ID: <45F584D9.4090802@rtr.ca> (raw)
In-Reply-To: <45F57F63.7010308@rtr.ca>
Mark Lord wrote:
>
> Okay, from that part (above), the problem is obvious:
> in that the "MCT U232 converter now disconnected" appears,
> and then we continue to try and call the driver's method.. Oops!
>
> The hack patch below "fixes" this, but it really just hides whatever
> the real problem underneath was:
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
> --- linux/include/linux/usb/serial.h.orig 2007-03-12
> 12:18:48.000000000 -0400
> +++ linux/include/linux/usb/serial.h 2007-03-12 12:18:23.000000000 -0400
> @@ -99,11 +99,19 @@
> /* get and set the port private data pointer helper functions */
> static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
> {
> + if (!port) {
> + WARN_ON(1);
> + return NULL;
> + }
> return dev_get_drvdata(&port->dev);
> }
>
> static inline void usb_set_serial_port_data (struct usb_serial_port
> *port, void *data)
> {
> + if (!port) {
> + WARN_ON(1);
> + return;
> + }
> dev_set_drvdata(&port->dev, data);
> }
>
Mmmm.. and that same hack also prevents the Oops seen
when I leave ckermit running during suspend/resume(RAM),
giving me this BUG() report now instead:
12:29:51 kernel: pl2303 ttyUSB0: pl2303 converter now disconnected from ttyUSB0
12:29:51 kernel: BUG: at include/linux/usb/serial.h:103 usb_get_serial_port_data()
12:29:51 kernel: [<f8a03254>] pl2303_shutdown+0x95/0xb5 [pl2303]
12:29:51 kernel: [<f8a23ca1>] destroy_serial+0x89/0x122 [usbserial]
12:29:51 kernel: [<f8a23c18>] destroy_serial+0x0/0x122 [usbserial]
12:29:51 kernel: [kref_put+95/110] kref_put+0x5f/0x6e
12:29:51 kernel: [tty_fasync+60/180] tty_fasync+0x3c/0xb4
12:29:51 kernel: [release_dev+484/1496] release_dev+0x1e4/0x5d8
12:29:51 kernel: [find_get_page+21/69] find_get_page+0x15/0x45
12:29:51 kernel: [filemap_nopage+385/726] filemap_nopage+0x181/0x2d6
12:29:51 kernel: [pty_write+43/53] pty_write+0x2b/0x35
12:29:51 kernel: [getnstimeofday+48/216] getnstimeofday+0x30/0xd8
12:29:51 kernel: [rb_insert_color+74/173] rb_insert_color+0x4a/0xad
12:29:51 kernel: [enqueue_hrtimer+256/268] enqueue_hrtimer+0x100/0x10c
12:29:51 kernel: [tty_release+15/24] tty_release+0xf/0x18
12:29:51 kernel: [__fput+150/336] __fput+0x96/0x150
12:29:51 kernel: [filp_close+79/86] filp_close+0x4f/0x56
12:29:51 kernel: [sys_close+117/183] sys_close+0x75/0xb7
12:29:51 kernel: [sysenter_past_esp+95/133] sysenter_past_esp+0x5f/0x85
12:29:51 kernel: =======================
next prev parent reply other threads:[~2007-03-12 16:50 UTC|newest]
Thread overview: 187+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 5:16 Linux 2.6.21-rc2 Linus Torvalds
2007-02-28 5:50 ` Gabriel C
2007-02-28 7:13 ` [PATCH] affinity is not defined in non-smp kernels - i386 Fernando Luis Vázquez Cao
2007-02-28 7:16 ` [PATCH] affinity is not defined in non-smp kernels - i386 (v2) Fernando Luis Vázquez Cao
2007-02-28 7:24 ` [PATCH] affinity is not defined in non-smp kernels - i386 Eric W. Biederman
2007-02-28 17:31 ` Bill Davidsen
2007-02-28 18:21 ` Eric W. Biederman
2007-02-28 18:30 ` Linus Torvalds
2007-02-28 7:42 ` [PATCH] affinity is not defined in non-smp kernels - i386 (v2) Fernando Luis Vázquez Cao
2007-02-28 7:17 ` [PATCH] affinity is not defined in non-smp kernels - x86_64 Fernando Luis Vázquez Cao
2007-02-28 7:23 ` Linux 2.6.21-rc2 David Brown
2007-02-28 7:39 ` Brice Goglin
2007-02-28 13:09 ` Eric W. Biederman
2007-02-28 16:44 ` David Brown
2007-02-28 17:07 ` Randy Dunlap
2007-02-28 7:41 ` [PATCH] affinity is not defined in non-smp kernels - x86_64 Fernando Luis Vázquez Cao
2007-02-28 7:59 ` Linux 2.6.21-rc2 Damien Wyart
2007-03-05 1:50 ` [1/6] 2.6.21-rc2: known regressions Adrian Bunk
2007-03-05 2:26 ` Andrew Morton
2007-03-05 3:35 ` Greg KH
2007-03-06 0:55 ` Johannes Berg
2007-03-05 4:01 ` Mark Lord
2007-03-05 4:34 ` Greg KH
2007-03-05 12:42 ` Marcel Holtmann
2007-03-05 4:34 ` [BUG} usb regression in 2.6.21-rc2-git3 Mark Lord
2007-03-05 4:37 ` [BUG] sdhci regression in 2.6.21-rc2 Mark Lord
2007-03-05 5:36 ` Pierre Ossman
2007-03-05 14:25 ` Mark Lord
2007-03-05 15:19 ` Mark Lord
2007-03-06 4:17 ` Andrew Morton
2007-03-06 5:47 ` Pierre Ossman
2007-03-06 6:09 ` Andrew Morton
2007-03-06 7:23 ` Pierre Ossman
2007-03-05 15:20 ` Pierre Ossman
2007-03-05 15:23 ` Pierre Ossman
2007-03-05 15:35 ` Mark Lord
2007-03-05 16:00 ` Pierre Ossman
2007-03-05 16:18 ` Mark Lord
2007-03-05 4:43 ` [BUG} usb regression in 2.6.21-rc2-git3 Mark Lord
2007-03-12 14:56 ` [BUG} usb-serial " Mark Lord
2007-03-12 15:06 ` Oliver Neukum
2007-03-12 15:13 ` Mark Lord
2007-03-12 15:27 ` Oliver Neukum
2007-03-12 15:29 ` Greg KH
2007-03-12 15:38 ` Oliver Neukum
2007-03-12 16:03 ` Mark Lord
2007-03-12 16:10 ` Greg KH
2007-03-12 16:22 ` Mark Lord
2007-03-12 16:11 ` Mark Lord
2007-03-12 16:14 ` Mark Lord
2007-03-12 16:27 ` Mark Lord
2007-03-12 16:50 ` Mark Lord [this message]
2007-03-12 18:48 ` Oliver Neukum
2007-03-12 20:22 ` [PATCH] usb-serial regression (Oops) in 2.6.21-rc* Mark Lord
2007-03-12 20:33 ` Greg KH
2007-03-12 22:20 ` Mark Lord
2007-03-12 22:42 ` Jim Radford
2007-03-12 22:59 ` [PATCH] usb-serial regression fix Jim Radford
2007-03-13 0:18 ` Greg KH
2007-03-13 0:41 ` Jim Radford
2007-03-13 1:55 ` Mark Lord
2007-03-13 9:14 ` Jim Radford
2007-03-13 10:14 ` Oliver Neukum
2007-03-13 13:39 ` Mark Lord
2007-03-13 13:50 ` Oliver Neukum
2007-03-13 13:55 ` Mark Lord
2007-03-13 15:30 ` Jim Radford
2007-03-13 16:35 ` Mark Lord
2007-03-12 16:28 ` [BUG} usb-serial regression in 2.6.21-rc2-git3 Oliver Neukum
2007-03-12 15:31 ` Greg KH
2007-03-07 11:06 ` [1/6] 2.6.21-rc2: known regressions Jeff Garzik
2007-03-07 22:17 ` Albert Hopkins
2007-03-05 1:50 ` [2/6] " Adrian Bunk
2007-03-07 11:09 ` Jeff Garzik
2007-03-07 16:10 ` Linus Torvalds
2007-03-08 12:03 ` Ash Milsted
2007-03-08 12:31 ` Michael S. Tsirkin
2007-03-08 15:11 ` Jeff Chua
2007-03-08 18:01 ` Linus Torvalds
2007-03-08 19:06 ` Ingo Molnar
2007-03-08 19:10 ` Ingo Molnar
2007-03-08 19:47 ` Michael S. Tsirkin
2007-03-08 20:10 ` Ingo Molnar
2007-03-08 19:25 ` Ingo Molnar
2007-03-08 23:07 ` Ingo Molnar
2007-03-08 23:12 ` Ingo Molnar
2007-03-08 23:28 ` Ingo Molnar
2007-03-08 23:49 ` Linus Torvalds
2007-03-09 10:56 ` Ingo Molnar
2007-03-09 18:00 ` Linus Torvalds
2007-03-09 11:19 ` Pavel Machek
2007-03-18 16:07 ` Ingo Molnar
2007-03-18 16:40 ` [linux-pm] " Jim Gettys
2007-03-19 19:08 ` BSOD (was: [2/6] 2.6.21-rc2: known regressions) Pete Zaitcev
2007-03-19 19:38 ` BSOD David Miller
2007-03-19 19:54 ` BSOD Jesse Barnes
2007-03-19 20:05 ` BSOD David Miller
2007-03-19 20:20 ` BSOD Jesse Barnes
2007-03-19 20:20 ` BSOD Jim Gettys
2007-03-20 9:19 ` BSOD Paul Mackerras
2007-03-20 20:33 ` BSOD Jim Gettys
2007-03-19 20:33 ` [linux-pm] [2/6] 2.6.21-rc2: known regressions Bill Davidsen
2007-03-19 22:08 ` Jim Gettys
2007-03-20 14:44 ` Bill Davidsen
2007-03-09 17:48 ` Johannes Stezenbach
2007-03-09 23:35 ` Pavel Machek
2007-03-10 9:01 ` Ingo Molnar
2007-03-10 11:43 ` Stefan Seyfried
2007-03-10 13:53 ` Johannes Stezenbach
2007-03-10 15:18 ` Ingo Molnar
2007-03-10 22:08 ` Pavel Machek
2007-03-11 8:20 ` Ingo Molnar
2007-03-12 6:34 ` Stefan Seyfried
2007-03-10 22:04 ` s2ram (was Re: [2/6] 2.6.21-rc2: known regressions) Pavel Machek
2007-03-08 19:46 ` [2/6] 2.6.21-rc2: known regressions Michael S. Tsirkin
2007-03-08 19:57 ` Michael S. Tsirkin
[not found] ` <20070311120802.GA8823@elte.hu>
2007-03-12 20:20 ` Michael S. Tsirkin
2007-03-17 21:41 ` Michael S. Tsirkin
2007-03-17 22:33 ` Thomas Gleixner
2007-03-21 17:28 ` Michael S. Tsirkin
2007-03-05 1:50 ` [3/6] " Adrian Bunk
2007-03-05 3:58 ` Michal Jaegermann
2007-03-06 17:08 ` Alan Cox
2007-03-07 11:12 ` Jeff Garzik
2007-03-10 1:09 ` Mathieu Bérard
2007-03-10 4:11 ` and try remove another quirk on this computers " Sergio Monteiro Basto
2007-03-10 5:41 ` Linus Torvalds
2007-03-11 4:32 ` Sergio Monteiro Basto
2007-03-12 11:37 ` Tejun Heo
2007-03-13 12:31 ` Mathieu Bérard
2007-03-13 12:41 ` Tejun Heo
2007-03-13 20:56 ` Mathieu Bérard
2007-03-14 6:07 ` Tejun Heo
2007-03-14 10:49 ` Mathieu Bérard
2007-03-05 1:50 ` [4/6] " Adrian Bunk
2007-03-05 10:35 ` Antonino A. Daplas
2007-03-05 15:06 ` Andrew
2007-03-08 23:28 ` Len Brown
2007-03-09 19:25 ` Andrew
2007-03-05 12:21 ` Richard Purdie
2007-03-05 1:50 ` [5/6] " Adrian Bunk
2007-03-05 7:57 ` Ingo Molnar
2007-03-05 8:13 ` Andrew Morton
2007-03-05 15:25 ` Daniel Walker
2007-03-05 15:27 ` Ingo Molnar
2007-03-05 16:42 ` Daniel Walker
2007-03-05 19:30 ` Ingo Molnar
2007-03-05 16:14 ` Bill Davidsen
2007-03-05 16:21 ` Ingo Molnar
2007-03-05 23:12 ` Adrian Bunk
2007-03-05 23:43 ` Thomas Gleixner
2007-03-05 23:45 ` Linus Torvalds
2007-03-06 0:25 ` Thomas Gleixner
2007-03-06 6:49 ` Soeren Sonnenburg
2007-03-06 7:49 ` Soeren Sonnenburg
2007-03-06 0:38 ` Linus Torvalds
2007-03-06 1:02 ` Thomas Gleixner
2007-03-06 1:31 ` Linus Torvalds
2007-03-06 2:18 ` Linus Torvalds
2007-03-06 7:25 ` Ingo Molnar
2007-03-06 8:09 ` Thomas Gleixner
2007-03-06 10:33 ` Michael S. Tsirkin
2007-03-06 10:37 ` Ingo Molnar
2007-03-06 10:46 ` Michael S. Tsirkin
2007-03-06 11:32 ` Ingo Molnar
2007-03-06 12:20 ` Michael S. Tsirkin
2007-03-06 16:44 ` Linus Torvalds
2007-03-06 17:05 ` Ingo Molnar
2007-03-06 17:29 ` [PATCH] highres: do not run the TIMER_SOFTIRQ after switching to highres mode Thomas Gleixner
2007-03-06 17:41 ` Linus Torvalds
2007-03-16 15:18 ` [5/6] 2.6.21-rc2: known regressions Randy Dunlap
2007-03-06 11:36 ` Soeren Sonnenburg
2007-03-06 12:07 ` Ingo Molnar
2007-03-06 12:15 ` Michael S. Tsirkin
2007-03-06 12:51 ` Ingo Molnar
2007-03-06 12:55 ` Michael S. Tsirkin
2007-03-06 13:03 ` Ingo Molnar
2007-03-06 13:09 ` Thomas Gleixner
2007-03-06 12:09 ` Jeff Chua
2007-03-11 17:32 ` Pavel Machek
2007-03-06 10:33 ` Michael S. Tsirkin
2007-03-05 1:50 ` [6/6] " Adrian Bunk
2007-03-05 2:07 ` David Miller
2007-03-05 2:26 ` Adrian Bunk
2007-03-05 2:29 ` David Miller
2007-03-05 4:42 ` David Miller
2007-03-05 3:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F584D9.4090802@rtr.ca \
--to=lkml@rtr.ca \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).