Re: [PATCH 1/8] usb: add bus type for USB ULPI

From: Stephen Boyd <sboyd@codeaurora.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Baolu Lu <baolu.lu@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] usb: add bus type for USB ULPI
Date: Thu, 12 Feb 2015 17:44:20 -0800	[thread overview]
Message-ID: <54DD56F4.5040200@codeaurora.org> (raw)
In-Reply-To: <1422025978-178336-2-git-send-email-heikki.krogerus@linux.intel.com>

On 01/23/15 07:12, Heikki Krogerus wrote:
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index e614ef6..753cb08 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -1176,6 +1176,19 @@ static int do_rio_entry(const char *filename,
>  }
>  ADD_TO_DEVTABLE("rapidio", rio_device_id, do_rio_entry);
>  
> +/* Looks like: mei:S */

This comment doesn't look right.

> +static int do_ulpi_entry(const char *filename, void *symval,
> +			 char *alias)
> +{
> +	DEF_FIELD(symval, ulpi_device_id, vendor);
> +	DEF_FIELD(symval, ulpi_device_id, product);
> +
> +	sprintf(alias, "ulpi:v%04xp%04x", vendor, product);
> +
> +	return 1;
> +}
> +ADD_TO_DEVTABLE("ulpi", ulpi_device_id, do_ulpi_entry);
> +

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project