From: Helge Deller <deller@gmx.de>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>,
gregkh@linuxfoundation.org, Carlos Bilbao <bilbao@vt.edu>
Cc: davem@davemloft.net, kuba@kernel.org,
James.Bottomley@hansenpartnership.com, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: Follow the indentation coding standard on printks
Date: Fri, 9 Jul 2021 08:43:40 +0200 [thread overview]
Message-ID: <6ce9de29-2669-deb5-ea0e-895992240bea@gmx.de> (raw)
In-Reply-To: <2148456.iZASKD2KPV@daneel.sf-tec.de>
On 7/8/21 11:25 PM, Rolf Eike Beer wrote:
> Am Donnerstag, 8. Juli 2021, 15:10:01 CEST schrieb Carlos Bilbao:
>> Fix indentation of printks that start at the beginning of the line. Change
>> this for the right number of space characters, or tabs if the file uses
>> them.
> [...]
>> --- a/drivers/parisc/iosapic.c
>> +++ b/drivers/parisc/iosapic.c
>> @@ -633,7 +633,7 @@ static void iosapic_unmask_irq(struct irq_data *d)
>> printk("\n");
>> }
>>
>> -printk("iosapic_enable_irq(): sel ");
>> + printk("iosapic_enable_irq(): sel ");
>> {
>> struct iosapic_info *isp = vi->iosapic;
>>
>> @@ -642,7 +642,7 @@ printk("iosapic_enable_irq(): sel ");
>> printk(" %x", d1);
>> }
>> }
>> -printk("\n");
>> + printk("\n");
>> #endif
>>
>> /*
>
> This is also debug code. It is basically unchanged since it has been imported
> into git. So it may be time to remove the whole block. Helge?
I'd prefer to clean it proper up and keep it.
>> diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
>> index dce4cdf786cd..c3381facdfc5 100644
>> --- a/drivers/parisc/sba_iommu.c
>> +++ b/drivers/parisc/sba_iommu.c
>> @@ -1550,7 +1550,7 @@ static void sba_hw_init(struct sba_device *sba_dev)
>>
>>
>> #if 0
>> -printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n",
>> PAGE0->mem_boot.hpa,
>> + printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x
>> 0x%x\n", PAGE0->mem_boot.hpa, PAGE0->mem_boot.spa, PAGE0->mem_boot.pad,
>> PAGE0->mem_boot.cl_class);
>>
>> /*
>
> This is equally old. It should be either also removed, also this seems at
> least worth as documentation. Maybe just switch it to pr_debug() or
> dev_debug() while fixing the indentation.
Yes, I'll clean it up too.
@Carlos:
Instead of just removing or fixing the indentation, I'll fix it for both parisc
drivers. Unless you want to try...
Helge
next prev parent reply other threads:[~2021-07-09 6:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 13:10 [PATCH] drivers: Follow the indentation coding standard on printks Carlos Bilbao
2021-07-08 14:40 ` Greg KH
2021-07-08 15:19 ` [PATCH] drivers: atm: " Carlos Bilbao
2021-07-08 15:48 ` Andrew Lunn
2021-07-08 17:06 ` Carlos Bilbao
2021-07-08 17:23 ` [PATCH net-next v2] " Carlos Bilbao
2021-07-08 17:27 ` Carlos Bilbao
2021-07-08 18:15 ` Andrew Lunn
2021-07-08 14:53 ` [PATCH] drivers: " Andrew Lunn
2021-07-08 15:08 ` Carlos Bilbao
2021-07-08 21:25 ` Rolf Eike Beer
2021-07-09 0:27 ` Stephen Hemminger
2021-07-09 6:43 ` Helge Deller [this message]
2021-07-09 10:30 ` bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ce9de29-2669-deb5-ea0e-895992240bea@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bilbao@vt.edu \
--cc=davem@davemloft.net \
--cc=eike-kernel@sf-tec.de \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).