linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Bilbao <bilbao@vt.edu>
To: gregkh@linuxfoundation.org
Cc: andrew@lunn.ch, alexander.deucher@amd.com, davem@davemloft.net,
	mchehab+huawei@kernel.org, kuba@kernel.org,
	James.Bottomley@hansenpartnership.com, netdev@vger.kernel.org,
	linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: Follow the indentation coding standard on printks
Date: Thu, 08 Jul 2021 11:08:47 -0400	[thread overview]
Message-ID: <7263255.EvYhyI6sBW@iron-maiden> (raw)
In-Reply-To: <YOcRfBtS/UJ81CFq@lunn.ch>

Hello,

> - Your patch did many different things all at once, making it difficult
>  to review.  All Linux kernel patches need to only do one thing at a
>  time.  If you need to do multiple things (such as clean up all coding

Greg, I am going to divide the patch in three parts, for atm/, net/ and parisc/.

> 
> Why not use DPRINTK(), defined at the start of suni.c?
> 
>     Andrew

Thanks for the idea Andrew, I will make a new version of the net/ patch.

thanks,
Carlos. 



  reply	other threads:[~2021-07-08 15:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 13:10 [PATCH] drivers: Follow the indentation coding standard on printks Carlos Bilbao
2021-07-08 14:40 ` Greg KH
2021-07-08 15:19   ` [PATCH] drivers: atm: " Carlos Bilbao
2021-07-08 15:48     ` Andrew Lunn
2021-07-08 17:06       ` Carlos Bilbao
2021-07-08 17:23         ` [PATCH net-next v2] " Carlos Bilbao
2021-07-08 17:27       ` Carlos Bilbao
2021-07-08 18:15         ` Andrew Lunn
2021-07-08 14:53 ` [PATCH] drivers: " Andrew Lunn
2021-07-08 15:08   ` Carlos Bilbao [this message]
2021-07-08 21:25 ` Rolf Eike Beer
2021-07-09  0:27   ` Stephen Hemminger
2021-07-09  6:43   ` Helge Deller
2021-07-09 10:30     ` bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7263255.EvYhyI6sBW@iron-maiden \
    --to=bilbao@vt.edu \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=alexander.deucher@amd.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).