* [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-08 8:06 ` Krzysztof Kozlowski
2022-12-07 5:53 ` [PATCH v2 02/16] dt-bindings: reset: Fix node descriptions in uniphier-reset example Kunihiko Hayashi
` (14 subsequent siblings)
15 siblings, 1 reply; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Prior to adding dt-bindings for SoC-dependent controllers, rename the
clock nodes their parent nodes to the generic names in the example.
And also fix the missing compatible string.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../clock/socionext,uniphier-clock.yaml | 21 +++++++++++--------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
index 9a0cc7341630..672450a1ecda 100644
--- a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
@@ -61,11 +61,12 @@ required:
examples:
- |
- sysctrl@61840000 {
- compatible = "socionext,uniphier-sysctrl", "simple-mfd", "syscon";
+ syscon@61840000 {
+ compatible = "socionext,uniphier-ld11-sysctrl",
+ "simple-mfd", "syscon";
reg = <0x61840000 0x4000>;
- clock {
+ clock-controller {
compatible = "socionext,uniphier-ld11-clock";
#clock-cells = <1>;
};
@@ -74,11 +75,12 @@ examples:
};
- |
- mioctrl@59810000 {
- compatible = "socionext,uniphier-mioctrl", "simple-mfd", "syscon";
+ syscon@59810000 {
+ compatible = "socionext,uniphier-ld11-mioctrl",
+ "simple-mfd", "syscon";
reg = <0x59810000 0x800>;
- clock {
+ clock-controller {
compatible = "socionext,uniphier-ld11-mio-clock";
#clock-cells = <1>;
};
@@ -87,11 +89,12 @@ examples:
};
- |
- perictrl@59820000 {
- compatible = "socionext,uniphier-perictrl", "simple-mfd", "syscon";
+ syscon@59820000 {
+ compatible = "socionext,uniphier-ld11-perictrl",
+ "simple-mfd", "syscon";
reg = <0x59820000 0x200>;
- clock {
+ clock-controller {
compatible = "socionext,uniphier-ld11-peri-clock";
#clock-cells = <1>;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example
2022-12-07 5:53 ` [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example Kunihiko Hayashi
@ 2022-12-08 8:06 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
0 siblings, 1 reply; 41+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:06 UTC (permalink / raw)
To: Kunihiko Hayashi, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Prior to adding dt-bindings for SoC-dependent controllers, rename the
> clock nodes their parent nodes to the generic names in the example.
>
> And also fix the missing compatible string.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../clock/socionext,uniphier-clock.yaml | 21 +++++++++++--------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
> index 9a0cc7341630..672450a1ecda 100644
> --- a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
> @@ -61,11 +61,12 @@ required:
>
> examples:
> - |
> - sysctrl@61840000 {
> - compatible = "socionext,uniphier-sysctrl", "simple-mfd", "syscon";
> + syscon@61840000 {
> + compatible = "socionext,uniphier-ld11-sysctrl",
> + "simple-mfd", "syscon";
> reg = <0x61840000 0x4000>;
>
> - clock {
> + clock-controller {
> compatible = "socionext,uniphier-ld11-clock";
> #clock-cells = <1>;
> };
> @@ -74,11 +75,12 @@ examples:
> };
>
> - |
> - mioctrl@59810000 {
> - compatible = "socionext,uniphier-mioctrl", "simple-mfd", "syscon";
> + syscon@59810000 {
> + compatible = "socionext,uniphier-ld11-mioctrl",
> + "simple-mfd", "syscon";
> reg = <0x59810000 0x800>;
>
> - clock {
> + clock-controller {
> compatible = "socionext,uniphier-ld11-mio-clock";
> #clock-cells = <1>;
> };
> @@ -87,11 +89,12 @@ examples:
> };
>
> - |
> - perictrl@59820000 {
> - compatible = "socionext,uniphier-perictrl", "simple-mfd", "syscon";
> + syscon@59820000 {
> + compatible = "socionext,uniphier-ld11-perictrl",
> + "simple-mfd", "syscon";
> reg = <0x59820000 0x200>;
>
> - clock {
These are all three same examples (no differences except compatibles),
so you can as well keep only one. You can also skip parent node,
otherwise you might keep getting warnings for this schema. The parent is
not that relevant here and its bindings (e.g.
socionext,uniphier-sysctrl.yaml) should include complete example -
parent with all the children.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example
2022-12-08 8:06 ` Krzysztof Kozlowski
@ 2022-12-08 15:09 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 15:09 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 2022/12/08 17:06, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Prior to adding dt-bindings for SoC-dependent controllers, rename the
>> clock nodes their parent nodes to the generic names in the example.
>>
>> And also fix the missing compatible string.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../clock/socionext,uniphier-clock.yaml | 21 +++++++++++--------
>> 1 file changed, 12 insertions(+), 9 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
>> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
>> index 9a0cc7341630..672450a1ecda 100644
>> ---
>> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
>> +++
>> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
>> @@ -61,11 +61,12 @@ required:
>>
>> examples:
>> - |
>> - sysctrl@61840000 {
>> - compatible = "socionext,uniphier-sysctrl", "simple-mfd",
>> "syscon";
>> + syscon@61840000 {
>> + compatible = "socionext,uniphier-ld11-sysctrl",
>> + "simple-mfd", "syscon";
>> reg = <0x61840000 0x4000>;
>>
>> - clock {
>> + clock-controller {
>> compatible = "socionext,uniphier-ld11-clock";
>> #clock-cells = <1>;
>> };
>> @@ -74,11 +75,12 @@ examples:
>> };
>>
>> - |
>> - mioctrl@59810000 {
>> - compatible = "socionext,uniphier-mioctrl", "simple-mfd",
>> "syscon";
>> + syscon@59810000 {
>> + compatible = "socionext,uniphier-ld11-mioctrl",
>> + "simple-mfd", "syscon";
>> reg = <0x59810000 0x800>;
>>
>> - clock {
>> + clock-controller {
>> compatible = "socionext,uniphier-ld11-mio-clock";
>> #clock-cells = <1>;
>> };
>> @@ -87,11 +89,12 @@ examples:
>> };
>>
>> - |
>> - perictrl@59820000 {
>> - compatible = "socionext,uniphier-perictrl", "simple-mfd",
>> "syscon";
>> + syscon@59820000 {
>> + compatible = "socionext,uniphier-ld11-perictrl",
>> + "simple-mfd", "syscon";
>> reg = <0x59820000 0x200>;
>>
>> - clock {
>
> These are all three same examples (no differences except compatibles),
> so you can as well keep only one. You can also skip parent node,
> otherwise you might keep getting warnings for this schema. The parent is
> not that relevant here and its bindings (e.g.
> socionext,uniphier-sysctrl.yaml) should include complete example -
> parent with all the children.
I understand.
I'll keep one and drop the parent node from the example.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 02/16] dt-bindings: reset: Fix node descriptions in uniphier-reset example
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example Kunihiko Hayashi
` (13 subsequent siblings)
15 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Prior to adding dt-bindings for SoC-dependent controllers, rename the
reset nodes and their parent nodes to the generic names in the example.
And also add the missing compatible string.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../reset/socionext,uniphier-glue-reset.yaml | 7 +++--
.../reset/socionext,uniphier-reset.yaml | 28 +++++++++++--------
2 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.yaml b/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.yaml
index 0a2c13e1e230..e6c6cb2ab8b8 100644
--- a/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/socionext,uniphier-glue-reset.yaml
@@ -95,13 +95,14 @@ required:
examples:
- |
- usb-glue@65b00000 {
- compatible = "simple-mfd";
+ usb@65b00000 {
+ compatible = "socionext,uniphier-ld20-dwc3-glue", "simple-mfd";
+ reg = <0x65b00000 0x400>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0x65b00000 0x400>;
- usb_rst: reset@0 {
+ usb_rst: reset-controller@0 {
compatible = "socionext,uniphier-ld20-usb3-reset";
reg = <0x0 0x4>;
#reset-cells = <1>;
diff --git a/Documentation/devicetree/bindings/reset/socionext,uniphier-reset.yaml b/Documentation/devicetree/bindings/reset/socionext,uniphier-reset.yaml
index 6566804ec567..c8abc44582a7 100644
--- a/Documentation/devicetree/bindings/reset/socionext,uniphier-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/socionext,uniphier-reset.yaml
@@ -66,11 +66,12 @@ required:
examples:
- |
- sysctrl@61840000 {
- compatible = "socionext,uniphier-sysctrl", "simple-mfd", "syscon";
+ syscon@61840000 {
+ compatible = "socionext,uniphier-ld11-sysctrl",
+ "simple-mfd", "syscon";
reg = <0x61840000 0x4000>;
- reset {
+ reset-controller {
compatible = "socionext,uniphier-ld11-reset";
#reset-cells = <1>;
};
@@ -79,11 +80,12 @@ examples:
};
- |
- mioctrl@59810000 {
- compatible = "socionext,uniphier-mioctrl", "simple-mfd", "syscon";
+ syscon@59810000 {
+ compatible = "socionext,uniphier-ld11-mioctrl",
+ "simple-mfd", "syscon";
reg = <0x59810000 0x800>;
- reset {
+ reset-controller {
compatible = "socionext,uniphier-ld11-mio-reset";
#reset-cells = <1>;
};
@@ -92,11 +94,12 @@ examples:
};
- |
- perictrl@59820000 {
- compatible = "socionext,uniphier-perictrl", "simple-mfd", "syscon";
+ syscon@59820000 {
+ compatible = "socionext,uniphier-ld11-perictrl",
+ "simple-mfd", "syscon";
reg = <0x59820000 0x200>;
- reset {
+ reset-controller {
compatible = "socionext,uniphier-ld11-peri-reset";
#reset-cells = <1>;
};
@@ -105,11 +108,12 @@ examples:
};
- |
- adamv@57920000 {
- compatible = "socionext,uniphier-ld11-adamv", "simple-mfd", "syscon";
+ syscon@57920000 {
+ compatible = "socionext,uniphier-ld11-adamv",
+ "simple-mfd", "syscon";
reg = <0x57920000 0x1000>;
- reset {
+ reset-controller {
compatible = "socionext,uniphier-ld11-adamv-reset";
#reset-cells = <1>;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 02/16] dt-bindings: reset: Fix node descriptions in uniphier-reset example Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-08 8:07 ` Krzysztof Kozlowski
2022-12-07 5:53 ` [PATCH v2 04/16] dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example Kunihiko Hayashi
` (12 subsequent siblings)
15 siblings, 1 reply; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Rename the parent node to the generic node name "syscon".
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
index 14a8c0215cc6..186fc550af4c 100644
--- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
@@ -69,7 +69,7 @@ examples:
- |
// The UniPhier pinctrl should be a subnode of a "syscon" compatible node.
- soc-glue@5f800000 {
+ syscon@5f800000 {
compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
reg = <0x5f800000 0x2000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example
2022-12-07 5:53 ` [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example Kunihiko Hayashi
@ 2022-12-08 8:07 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
0 siblings, 1 reply; 41+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:07 UTC (permalink / raw)
To: Kunihiko Hayashi, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Rename the parent node to the generic node name "syscon".
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> index 14a8c0215cc6..186fc550af4c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> @@ -69,7 +69,7 @@ examples:
> - |
> // The UniPhier pinctrl should be a subnode of a "syscon" compatible node.
>
> - soc-glue@5f800000 {
> + syscon@5f800000 {
> compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
> reg = <0x5f800000 0x2000>;
>
Not visible in the diff but this is a poor example. It has only
compatible! Drop the parent node instead and extend the pinctrl node to
show complete picture of pinctrl.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example
2022-12-08 8:07 ` Krzysztof Kozlowski
@ 2022-12-08 15:09 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 15:09 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 2022/12/08 17:07, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Rename the parent node to the generic node name "syscon".
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> index 14a8c0215cc6..186fc550af4c 100644
>> ---
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> +++
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> @@ -69,7 +69,7 @@ examples:
>> - |
>> // The UniPhier pinctrl should be a subnode of a "syscon" compatible
>> node.
>>
>> - soc-glue@5f800000 {
>> + syscon@5f800000 {
>> compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd",
>> "syscon";
>> reg = <0x5f800000 0x2000>;
>>
>
> Not visible in the diff but this is a poor example. It has only
> compatible! Drop the parent node instead and extend the pinctrl node to
> show complete picture of pinctrl.
I should add some child nodes of groups and pin attributes as an example
from the devicetree.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 04/16] dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (2 preceding siblings ...)
2022-12-07 5:53 ` [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 05/16] dt-bindings: thermal: Fix node descriptions in uniphier-thermal example Kunihiko Hayashi
` (11 subsequent siblings)
15 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Rename the parent node to the generic node name "syscon".
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml b/Documentation/devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml
index 90698cfa8f94..33fb94f9c730 100644
--- a/Documentation/devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/socionext,uniphier-wdt.yaml
@@ -25,7 +25,7 @@ examples:
- |
// The UniPhier watchdog should be a subnode of a "syscon" compatible node.
- sysctrl@61840000 {
+ syscon@61840000 {
compatible = "socionext,uniphier-ld11-sysctrl",
"simple-mfd", "syscon";
reg = <0x61840000 0x10000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v2 05/16] dt-bindings: thermal: Fix node descriptions in uniphier-thermal example
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (3 preceding siblings ...)
2022-12-07 5:53 ` [PATCH v2 04/16] dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 06/16] dt-bindings: phy: Fix node descriptions in uniphier-phy example Kunihiko Hayashi
` (10 subsequent siblings)
15 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Prior to adding dt-bindings for SoC-dependent controllers, rename the
thermal node and its parent node to the generic names in the example.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../bindings/thermal/socionext,uniphier-thermal.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
index c5b25ce44956..dcc02f86ac5a 100644
--- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
@@ -46,12 +46,12 @@ examples:
- |
// The UniPhier thermal should be a subnode of a "syscon" compatible node.
- sysctrl@61840000 {
+ syscon@61840000 {
compatible = "socionext,uniphier-ld20-sysctrl",
"simple-mfd", "syscon";
reg = <0x61840000 0x10000>;
- pvtctl: thermal {
+ pvtctl: thermal-sensor {
compatible = "socionext,uniphier-ld20-thermal";
interrupts = <0 3 1>;
#thermal-sensor-cells = <0>;
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v2 06/16] dt-bindings: phy: Fix node descriptions in uniphier-phy example
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (4 preceding siblings ...)
2022-12-07 5:53 ` [PATCH v2 05/16] dt-bindings: thermal: Fix node descriptions in uniphier-thermal example Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 07/16] dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example Kunihiko Hayashi
` (9 subsequent siblings)
15 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Prior to adding dt-bindings for SoC-dependent controllers, rename the
phy nodes and their parent nodes to the generic names in the example.
And also add missing reg property for the parent nodes.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml | 1 +
.../devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml | 4 ++--
.../bindings/phy/socionext,uniphier-usb3hs-phy.yaml | 5 +++--
.../bindings/phy/socionext,uniphier-usb3ss-phy.yaml | 5 +++--
4 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
index a3cd45acea28..b3928c519b08 100644
--- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
@@ -120,6 +120,7 @@ examples:
ahci-glue@65700000 {
compatible = "socionext,uniphier-pxs3-ahci-glue",
"simple-mfd";
+ reg = <0x65700000 0x100>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0x65700000 0x100>;
diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml
index 63dab914a48d..5d93feb2758d 100644
--- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb2-phy.yaml
@@ -61,11 +61,11 @@ examples:
- |
// The UniPhier usb2-phy should be a subnode of a "syscon" compatible node.
- soc-glue@5f800000 {
+ syscon@5f800000 {
compatible = "socionext,uniphier-ld11-soc-glue", "simple-mfd", "syscon";
reg = <0x5f800000 0x2000>;
- usb-controller {
+ usb-hub {
compatible = "socionext,uniphier-ld11-usb2-phy";
#address-cells = <1>;
#size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
index 21e4414eea60..2dbdc14a03d9 100644
--- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
@@ -146,13 +146,14 @@ additionalProperties: false
examples:
- |
- usb-glue@65b00000 {
+ usb@65b00000 {
compatible = "socionext,uniphier-ld20-dwc3-glue", "simple-mfd";
+ reg = <0x65b00000 0x400>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0x65b00000 0x400>;
- usb_hsphy0: hs-phy@200 {
+ usb_hsphy0: phy@200 {
compatible = "socionext,uniphier-ld20-usb3-hsphy";
reg = <0x200 0x10>;
#phy-cells = <0>;
diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
index 4c26d2d2303d..f52dc5289dec 100644
--- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
@@ -131,14 +131,15 @@ additionalProperties: false
examples:
- |
- usb-glue@65b00000 {
+ usb@65b00000 {
compatible = "socionext,uniphier-ld20-dwc3-glue",
"simple-mfd";
+ reg = <0x65b00000 0x400>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0x65b00000 0x400>;
- usb_ssphy0: ss-phy@300 {
+ usb_ssphy0: phy@300 {
compatible = "socionext,uniphier-ld20-usb3-ssphy";
reg = <0x300 0x10>;
#phy-cells = <0>;
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v2 07/16] dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (5 preceding siblings ...)
2022-12-07 5:53 ` [PATCH v2 06/16] dt-bindings: phy: Fix node descriptions in uniphier-phy example Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller Kunihiko Hayashi
` (8 subsequent siblings)
15 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Prior to adding dt-bindings for SoC-dependent controllers, rename the
parent node to the generic name in the example.
And also add missing compatibles and reg property for the parent nodes.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml b/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
index 2578e39deda9..33ba78083b38 100644
--- a/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
+++ b/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
@@ -33,8 +33,10 @@ examples:
- |
// The UniPhier eFuse should be a subnode of a "soc-glue" node.
- soc-glue@5f900000 {
- compatible = "simple-mfd";
+ syscon@5f900000 {
+ compatible = "socionext,uniphier-ld20-soc-glue-debug",
+ "simple-mfd", "syscon";
+ reg = <0x5f900000 0x2000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x0 0x5f900000 0x2000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (6 preceding siblings ...)
2022-12-07 5:53 ` [PATCH v2 07/16] dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:15 ` Krzysztof Kozlowski
2022-12-07 5:53 ` [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Kunihiko Hayashi
` (7 subsequent siblings)
15 siblings, 2 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add devicetree binding schema for the system controller implemented on
Socionext Uniphier SoCs.
This system controller has multiple functions such as clock control,
reset control, internal watchdog timer, thermal management, and so on.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext/socionext,uniphier-sysctrl.yaml | 105 ++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 106 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
new file mode 100644
index 000000000000..c1b7cec8def4
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-sysctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier system controller
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ System controller implemented on Socionext UniPhier SoCs has multiple
+ functions such as clock control, reset control, internal watchdog timer,
+ thermal management, and so on.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld4-sysctrl
+ - socionext,uniphier-pro4-sysctrl
+ - socionext,uniphier-pro5-sysctrl
+ - socionext,uniphier-pxs2-sysctrl
+ - socionext,uniphier-sld8-sysctrl
+ - socionext,uniphier-ld11-sysctrl
+ - socionext,uniphier-ld20-sysctrl
+ - socionext,uniphier-pxs3-sysctrl
+ - socionext,uniphier-nx1-sysctrl
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+patternProperties:
+ "^clock-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/clock/socionext,uniphier-clock.yaml#
+
+ "^reset-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/reset/socionext,uniphier-reset.yaml#
+
+ "^watchdog(@[0-9a-f]+)?$":
+ $ref: /schemas/watchdog/socionext,uniphier-wdt.yaml#
+
+ "^thermal-sensor(@[0-9a-f]+)?$":
+ $ref: /schemas/thermal/socionext,uniphier-thermal.yaml#
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: socionext,uniphier-ld4-sysctrl
+ then:
+ patternProperties:
+ "^watchdog(@[0-9a-f]+)?$": false
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - socionext,uniphier-ld4-sysctrl
+ - socionext,uniphier-pro4-sysctrl
+ - socionext,uniphier-sld8-sysctrl
+ - socionext,uniphier-ld11-sysctrl
+ then:
+ patternProperties:
+ "^thermal-sensor(@[0-9a-f]+)?$": false
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ syscon@61840000 {
+ compatible = "socionext,uniphier-ld20-sysctrl",
+ "simple-mfd", "syscon";
+ reg = <0x61840000 0x4000>;
+
+ clock-controller {
+ compatible = "socionext,uniphier-ld20-clock";
+ #clock-cells = <1>;
+ };
+
+ reset-controller {
+ compatible = "socionext,uniphier-ld20-reset";
+ #reset-cells = <1>;
+ };
+
+ watchdog {
+ compatible = "socionext,uniphier-wdt";
+ };
+
+ thermal-sensor {
+ compatible = "socionext,uniphier-ld20-thermal";
+ interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
+ #thermal-sensor-cells = <0>;
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 0d8faba73fe8..8cec8ea46dd1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3103,6 +3103,7 @@ S: Maintained
F: Documentation/devicetree/bindings/arm/socionext/uniphier.yaml
F: Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
F: Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
+F: Documentation/devicetree/bindings/soc/socionext/socionext,uniphier*.yaml
F: arch/arm/boot/dts/uniphier*
F: arch/arm/include/asm/hardware/cache-uniphier.h
F: arch/arm/mach-uniphier/
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller
2022-12-07 5:53 ` [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller Kunihiko Hayashi
@ 2022-12-07 14:19 ` Rob Herring
2022-12-08 6:37 ` Kunihiko Hayashi
2022-12-08 8:15 ` Krzysztof Kozlowski
1 sibling, 1 reply; 41+ messages in thread
From: Rob Herring @ 2022-12-07 14:19 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: Rob Herring, Masami Hiramatsu, linux-arm-kernel, linux-kernel,
devicetree, Krzysztof Kozlowski
On Wed, 07 Dec 2022 14:53:57 +0900, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the system controller implemented on
> Socionext Uniphier SoCs.
>
> This system controller has multiple functions such as clock control,
> reset control, internal watchdog timer, thermal management, and so on.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext/socionext,uniphier-sysctrl.yaml | 105 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 106 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.example.dtb: sysctrl@61840000: 'thermal' does not match any of the regexes: '^clock-controller(@[0-9a-f]+)?$', '^reset-controller(@[0-9a-f]+)?$', '^thermal-sensor(@[0-9a-f]+)?$', '^watchdog(@[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-9-hayashi.kunihiko@socionext.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller
2022-12-07 14:19 ` Rob Herring
@ 2022-12-08 6:37 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 6:37 UTC (permalink / raw)
To: Rob Herring
Cc: Rob Herring, Masami Hiramatsu, linux-arm-kernel, linux-kernel,
devicetree, Krzysztof Kozlowski
On 2022/12/07 23:19, Rob Herring wrote:
>
> On Wed, 07 Dec 2022 14:53:57 +0900, Kunihiko Hayashi wrote:
>> Add devicetree binding schema for the system controller implemented on
>> Socionext Uniphier SoCs.
>>
>> This system controller has multiple functions such as clock control,
>> reset control, internal watchdog timer, thermal management, and so on.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../socionext/socionext,uniphier-sysctrl.yaml | 105 ++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 106 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.example.dtb:
> sysctrl@61840000: 'thermal' does not match any of the regexes:
> '^clock-controller(@[0-9a-f]+)?$', '^reset-controller(@[0-9a-f]+)?$',
> '^thermal-sensor(@[0-9a-f]+)?$', '^watchdog(@[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>
> doc reference errors (make refcheckdocs):
>
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-9-hayashi.kunihiko@socionext.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.
Already confirmed with example fixes.
This warning is a result evaluated before applying PATCH 5.
[05/16] dt-bindings: thermal: Fix node descriptions in uniphier-thermal example
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller
2022-12-07 5:53 ` [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
@ 2022-12-08 8:15 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
1 sibling, 1 reply; 41+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:15 UTC (permalink / raw)
To: Kunihiko Hayashi, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the system controller implemented on
> Socionext Uniphier SoCs.
>
> This system controller has multiple functions such as clock control,
> reset control, internal watchdog timer, thermal management, and so on.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext/socionext,uniphier-sysctrl.yaml | 105 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 106 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
> new file mode 100644
> index 000000000000..c1b7cec8def4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-sysctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier system controller
> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + System controller implemented on Socionext UniPhier SoCs has multiple
> + functions such as clock control, reset control, internal watchdog timer,
> + thermal management, and so on.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - socionext,uniphier-ld4-sysctrl
> + - socionext,uniphier-pro4-sysctrl
> + - socionext,uniphier-pro5-sysctrl
> + - socionext,uniphier-pxs2-sysctrl
> + - socionext,uniphier-sld8-sysctrl
> + - socionext,uniphier-ld11-sysctrl
> + - socionext,uniphier-ld20-sysctrl
> + - socionext,uniphier-pxs3-sysctrl
> + - socionext,uniphier-nx1-sysctrl
> + - const: simple-mfd
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + "^clock-controller(@[0-9a-f]+)?$":
I don't remember if we talked about this but: why do you include here
unit address? All your bindings expect these take regmap from the parent
and they do not have separate MMIO address space, so these should be
properties, not pattern properties.
Same in places below.
> + $ref: /schemas/clock/socionext,uniphier-clock.yaml#
> +
> + "^reset-controller(@[0-9a-f]+)?$":
> + $ref: /schemas/reset/socionext,uniphier-reset.yaml#
> +
> + "^watchdog(@[0-9a-f]+)?$":
> + $ref: /schemas/watchdog/socionext,uniphier-wdt.yaml#
> +
> + "^thermal-sensor(@[0-9a-f]+)?$":
> + $ref: /schemas/thermal/socionext,uniphier-thermal.yaml#
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: socionext,uniphier-ld4-sysctrl
> + then:
> + patternProperties:
> + "^watchdog(@[0-9a-f]+)?$": false
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - socionext,uniphier-ld4-sysctrl
> + - socionext,uniphier-pro4-sysctrl
> + - socionext,uniphier-sld8-sysctrl
> + - socionext,uniphier-ld11-sysctrl
> + then:
> + patternProperties:
> + "^thermal-sensor(@[0-9a-f]+)?$": false
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller
2022-12-08 8:15 ` Krzysztof Kozlowski
@ 2022-12-08 15:09 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 15:09 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 2022/12/08 17:15, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Add devicetree binding schema for the system controller implemented on
>> Socionext Uniphier SoCs.
>>
>> This system controller has multiple functions such as clock control,
>> reset control, internal watchdog timer, thermal management, and so on.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../socionext/socionext,uniphier-sysctrl.yaml | 105 ++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 106 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>> new file mode 100644
>> index 000000000000..c1b7cec8def4
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>> @@ -0,0 +1,105 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:
>> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-sysctrl.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Socionext UniPhier system controller
>> +
>> +maintainers:
>> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> +
>> +description: |+
>> + System controller implemented on Socionext UniPhier SoCs has multiple
>> + functions such as clock control, reset control, internal watchdog
>> timer,
>> + thermal management, and so on.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - socionext,uniphier-ld4-sysctrl
>> + - socionext,uniphier-pro4-sysctrl
>> + - socionext,uniphier-pro5-sysctrl
>> + - socionext,uniphier-pxs2-sysctrl
>> + - socionext,uniphier-sld8-sysctrl
>> + - socionext,uniphier-ld11-sysctrl
>> + - socionext,uniphier-ld20-sysctrl
>> + - socionext,uniphier-pxs3-sysctrl
>> + - socionext,uniphier-nx1-sysctrl
>> + - const: simple-mfd
>> + - const: syscon
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +patternProperties:
>> + "^clock-controller(@[0-9a-f]+)?$":
>
> I don't remember if we talked about this but: why do you include here
> unit address? All your bindings expect these take regmap from the parent
> and they do not have separate MMIO address space, so these should be
> properties, not pattern properties.
I thought this unit address was an option, however, there is no example
of the existing devicetree. It is no longer necessary.
> Same in places below.
>
>> + $ref: /schemas/clock/socionext,uniphier-clock.yaml#
>> +
>> + "^reset-controller(@[0-9a-f]+)?$":
>> + $ref: /schemas/reset/socionext,uniphier-reset.yaml#
>> +
>> + "^watchdog(@[0-9a-f]+)?$":
>> + $ref: /schemas/watchdog/socionext,uniphier-wdt.yaml#
>> +
>> + "^thermal-sensor(@[0-9a-f]+)?$":
>> + $ref: /schemas/thermal/socionext,uniphier-thermal.yaml#
I'll drop the address patterns.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (7 preceding siblings ...)
2022-12-07 5:53 ` [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-07 15:35 ` Rob Herring
2022-12-08 8:16 ` Krzysztof Kozlowski
2022-12-07 5:53 ` [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part Kunihiko Hayashi
` (6 subsequent siblings)
15 siblings, 2 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add devicetree binding schema for the SoC-glue logic implemented on
Socionext Uniphier SoCs.
This SoC-glue logic is a set of miscellaneous function registers
handling signals for specific devices outside system components,
and also has multiple functions such as I/O pinmux, usb-phy, debug,
clock-mux for a specific SoC, and so on.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext,uniphier-soc-glue.yaml | 113 ++++++++++++++++++
1 file changed, 113 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
new file mode 100644
index 000000000000..6fc790963660
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
@@ -0,0 +1,113 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier SoC-glue logic
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ SoC-glue logic implemented on Socionext UniPhier SoCs is a collection of
+ miscellaneous function registers handling signals outside system components.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld4-soc-glue
+ - socionext,uniphier-pro4-soc-glue
+ - socionext,uniphier-pro5-soc-glue
+ - socionext,uniphier-pxs2-soc-glue
+ - socionext,uniphier-sld8-soc-glue
+ - socionext,uniphier-ld11-soc-glue
+ - socionext,uniphier-ld20-soc-glue
+ - socionext,uniphier-pxs3-soc-glue
+ - socionext,uniphier-nx1-soc-glue
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+patternProperties:
+ "^pinctrl(@[0-9a-f]+)?$":
+ $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
+
+ "^usb-hub(@[0-9a-f]+)?$":
+ $ref: /schemas/phy/socionext,uniphier-usb2-phy.yaml#
+
+ "^clock-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/clock/socionext,uniphier-clock.yaml#
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - socionext,uniphier-pro4-soc-glue
+ - socionext,uniphier-ld11-soc-glue
+ else:
+ patternProperties:
+ "^usb-hub(@[0-9a-f]+)?$": false
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: socionext,uniphier-pro4-soc-glue
+ else:
+ patternProperties:
+ "^clock-controller(@[0-9a-f]+)?$": false
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@5f800000 {
+ compatible = "socionext,uniphier-pro4-soc-glue",
+ "simple-mfd", "syscon";
+ reg = <0x5f800000 0x2000>;
+
+ pinctrl {
+ compatible = "socionext,uniphier-pro4-pinctrl";
+ };
+
+ usb-hub {
+ compatible = "socionext,uniphier-pro4-usb2-phy";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ phy@0 {
+ reg = <0>;
+ #phy-cells = <0>;
+ };
+
+ phy@1 {
+ reg = <1>;
+ #phy-cells = <0>;
+ };
+
+ phy@2 {
+ reg = <2>;
+ #phy-cells = <0>;
+ };
+
+ phy@3 {
+ reg = <3>;
+ #phy-cells = <0>;
+ };
+ };
+
+ clock-controller {
+ compatible = "socionext,uniphier-pro4-sg-clock";
+ #clock-cells = <1>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
2022-12-07 5:53 ` [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Kunihiko Hayashi
@ 2022-12-07 15:35 ` Rob Herring
2022-12-08 6:37 ` Kunihiko Hayashi
2022-12-08 8:16 ` Krzysztof Kozlowski
1 sibling, 1 reply; 41+ messages in thread
From: Rob Herring @ 2022-12-07 15:35 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: Krzysztof Kozlowski, Masami Hiramatsu, devicetree,
linux-arm-kernel, linux-kernel
On Wed, Dec 07, 2022 at 02:53:58PM +0900, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the SoC-glue logic implemented on
> Socionext Uniphier SoCs.
>
> This SoC-glue logic is a set of miscellaneous function registers
> handling signals for specific devices outside system components,
> and also has multiple functions such as I/O pinmux, usb-phy, debug,
> clock-mux for a specific SoC, and so on.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-soc-glue.yaml | 113 ++++++++++++++++++
> 1 file changed, 113 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
> new file mode 100644
> index 000000000000..6fc790963660
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier SoC-glue logic
> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + SoC-glue logic implemented on Socionext UniPhier SoCs is a collection of
> + miscellaneous function registers handling signals outside system components.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - socionext,uniphier-ld4-soc-glue
> + - socionext,uniphier-pro4-soc-glue
> + - socionext,uniphier-pro5-soc-glue
> + - socionext,uniphier-pxs2-soc-glue
> + - socionext,uniphier-sld8-soc-glue
> + - socionext,uniphier-ld11-soc-glue
> + - socionext,uniphier-ld20-soc-glue
> + - socionext,uniphier-pxs3-soc-glue
> + - socionext,uniphier-nx1-soc-glue
> + - const: simple-mfd
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + "^pinctrl(@[0-9a-f]+)?$":
> + $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
> +
> + "^usb-hub(@[0-9a-f]+)?$":
> + $ref: /schemas/phy/socionext,uniphier-usb2-phy.yaml#
> +
> + "^clock-controller(@[0-9a-f]+)?$":
> + $ref: /schemas/clock/socionext,uniphier-clock.yaml#
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - socionext,uniphier-pro4-soc-glue
> + - socionext,uniphier-ld11-soc-glue
> + else:
> + patternProperties:
> + "^usb-hub(@[0-9a-f]+)?$": false
While just if and else is valid json-schema, we require 'then'. Can you
change this to 'if: { not: {...}, then: {}'.
You should be getting a warning for this. The rest of the warnings from
the bot look like false positives you can ignore.
Rob
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
2022-12-07 15:35 ` Rob Herring
@ 2022-12-08 6:37 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 6:37 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Masami Hiramatsu, devicetree,
linux-arm-kernel, linux-kernel
Hi Rob,
On 2022/12/08 0:35, Rob Herring wrote:
> On Wed, Dec 07, 2022 at 02:53:58PM +0900, Kunihiko Hayashi wrote:
>> Add devicetree binding schema for the SoC-glue logic implemented on
>> Socionext Uniphier SoCs.
>>
>> This SoC-glue logic is a set of miscellaneous function registers
>> handling signals for specific devices outside system components,
>> and also has multiple functions such as I/O pinmux, usb-phy, debug,
>> clock-mux for a specific SoC, and so on.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
(snip)
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - socionext,uniphier-pro4-soc-glue
>> + - socionext,uniphier-ld11-soc-glue
>> + else:
>> + patternProperties:
>> + "^usb-hub(@[0-9a-f]+)?$": false
>
> While just if and else is valid json-schema, we require 'then'. Can you
> change this to 'if: { not: {...}, then: {}'.
I see. I'll rewrite it with invert condition.
> You should be getting a warning for this. The rest of the warnings from
> the bot look like false positives you can ignore.
Hmm, I couldn't see the warning for this condition.
The warnings your bot printed are the results evaluated before
applying the example fixes (PATCH 1-7) or before fixing the
existing devicetree (need to fix but yet).
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
2022-12-07 5:53 ` [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Kunihiko Hayashi
2022-12-07 15:35 ` Rob Herring
@ 2022-12-08 8:16 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
1 sibling, 1 reply; 41+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:16 UTC (permalink / raw)
To: Kunihiko Hayashi, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the SoC-glue logic implemented on
> Socionext Uniphier SoCs.
>
> This SoC-glue logic is a set of miscellaneous function registers
> handling signals for specific devices outside system components,
> and also has multiple functions such as I/O pinmux, usb-phy, debug,
> clock-mux for a specific SoC, and so on.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-soc-glue.yaml | 113 ++++++++++++++++++
> 1 file changed, 113 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
> new file mode 100644
> index 000000000000..6fc790963660
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier SoC-glue logic
> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + SoC-glue logic implemented on Socionext UniPhier SoCs is a collection of
> + miscellaneous function registers handling signals outside system components.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - socionext,uniphier-ld4-soc-glue
> + - socionext,uniphier-pro4-soc-glue
> + - socionext,uniphier-pro5-soc-glue
> + - socionext,uniphier-pxs2-soc-glue
> + - socionext,uniphier-sld8-soc-glue
> + - socionext,uniphier-ld11-soc-glue
> + - socionext,uniphier-ld20-soc-glue
> + - socionext,uniphier-pxs3-soc-glue
> + - socionext,uniphier-nx1-soc-glue
> + - const: simple-mfd
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + "^pinctrl(@[0-9a-f]+)?$":
Your children cannot have unit address in this binding (not mentioning
that children schema has in example statement that unit address is
invalid: "must be a child of syscon node").
> + $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
> +
> + "^usb-hub(@[0-9a-f]+)?$":
> + $ref: /schemas/phy/socionext,uniphier-usb2-phy.yaml#
> +
> + "^clock-controller(@[0-9a-f]+)?$":
> + $ref: /schemas/clock/socionext,uniphier-clock.yaml#
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
2022-12-08 8:16 ` Krzysztof Kozlowski
@ 2022-12-08 15:11 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 15:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 2022/12/08 17:16, Krzysztof Kozlowski wrote:> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Add devicetree binding schema for the SoC-glue logic implemented on
>> Socionext Uniphier SoCs.
>>
>> This SoC-glue logic is a set of miscellaneous function registers
>> handling signals for specific devices outside system components,
>> and also has multiple functions such as I/O pinmux, usb-phy, debug,
>> clock-mux for a specific SoC, and so on.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../socionext,uniphier-soc-glue.yaml | 113 ++++++++++++++++++
>> 1 file changed, 113 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
>> new file mode 100644
>> index 000000000000..6fc790963660
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
>> @@ -0,0 +1,113 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:
>> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Socionext UniPhier SoC-glue logic
>> +
>> +maintainers:
>> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> +
>> +description: |+
>> + SoC-glue logic implemented on Socionext UniPhier SoCs is a collection
>> of
>> + miscellaneous function registers handling signals outside system
>> components.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - socionext,uniphier-ld4-soc-glue
>> + - socionext,uniphier-pro4-soc-glue
>> + - socionext,uniphier-pro5-soc-glue
>> + - socionext,uniphier-pxs2-soc-glue
>> + - socionext,uniphier-sld8-soc-glue
>> + - socionext,uniphier-ld11-soc-glue
>> + - socionext,uniphier-ld20-soc-glue
>> + - socionext,uniphier-pxs3-soc-glue
>> + - socionext,uniphier-nx1-soc-glue
>> + - const: simple-mfd
>> + - const: syscon
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +patternProperties:
>> + "^pinctrl(@[0-9a-f]+)?$":
>
> Your children cannot have unit address in this binding (not mentioning
> that children schema has in example statement that unit address is
> invalid: "must be a child of syscon node").
Same as uniphier-sysctrl, I'll drop the address patterns.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (8 preceding siblings ...)
2022-12-07 5:53 ` [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Kunihiko Hayashi
@ 2022-12-07 5:53 ` Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:18 ` Krzysztof Kozlowski
2022-12-07 5:54 ` [PATCH v2 11/16] dt-bindings: soc: socionext: Add UniPhier peripheral block Kunihiko Hayashi
` (5 subsequent siblings)
15 siblings, 2 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add devicetree binding schema for the SoC-glue logic debug part
implemented on Socionext Uniphier SoCs.
This SoC-glue logic debug part is a set of miscellaneous function
registers handling signals for specific devices outside system
components, and also has multiple functions such as efuse, debug unit,
several monitors for specific SoC, and so on.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext,uniphier-soc-glue-debug.yaml | 73 +++++++++++++++++++
1 file changed, 73 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
new file mode 100644
index 000000000000..db13c56b77b6
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue-debug.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier SoC-glue logic debug part
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ SoC-glue logic debug part implemented on Socionext UniPhier SoCs is
+ a collection of miscellaneous function registers handling signals outside
+ system components for debug and monitor use.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld4-soc-glue-debug
+ - socionext,uniphier-pro4-soc-glue-debug
+ - socionext,uniphier-pro5-soc-glue-debug
+ - socionext,uniphier-pxs2-soc-glue-debug
+ - socionext,uniphier-sld8-soc-glue-debug
+ - socionext,uniphier-ld11-soc-glue-debug
+ - socionext,uniphier-ld20-soc-glue-debug
+ - socionext,uniphier-pxs3-soc-glue-debug
+ - socionext,uniphier-nx1-soc-glue-debug
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 1
+
+ ranges: true
+
+patternProperties:
+ "^efuse(@[0-9a-f]+)?$":
+ $ref: /schemas/nvmem/socionext,uniphier-efuse.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@5f900000 {
+ compatible = "socionext,uniphier-pxs2-soc-glue-debug",
+ "simple-mfd", "syscon";
+ reg = <0x5f900000 0x2000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x5f900000 0x2000>;
+
+ efuse@100 {
+ compatible = "socionext,uniphier-efuse";
+ reg = <0x100 0x28>;
+ };
+
+ efuse@200 {
+ compatible = "socionext,uniphier-efuse";
+ reg = <0x200 0x58>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
2022-12-07 5:53 ` [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part Kunihiko Hayashi
@ 2022-12-07 14:19 ` Rob Herring
2022-12-08 8:18 ` Krzysztof Kozlowski
1 sibling, 0 replies; 41+ messages in thread
From: Rob Herring @ 2022-12-07 14:19 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: linux-kernel, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, Masami Hiramatsu
On Wed, 07 Dec 2022 14:53:59 +0900, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the SoC-glue logic debug part
> implemented on Socionext Uniphier SoCs.
>
> This SoC-glue logic debug part is a set of miscellaneous function
> registers handling signals for specific devices outside system
> components, and also has multiple functions such as efuse, debug unit,
> several monitors for specific SoC, and so on.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-soc-glue-debug.yaml | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-11-hayashi.kunihiko@socionext.com
soc-glue@5f900000: compatible: ['socionext,uniphier-ld11-soc-glue-debug', 'simple-mfd'] is too short
arch/arm64/boot/dts/socionext/uniphier-ld11-global.dtb
arch/arm64/boot/dts/socionext/uniphier-ld11-ref.dtb
soc-glue@5f900000: compatible: ['socionext,uniphier-ld20-soc-glue-debug', 'simple-mfd'] is too short
arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dtb
arch/arm64/boot/dts/socionext/uniphier-ld20-global.dtb
arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dtb
soc-glue@5f900000: compatible: ['socionext,uniphier-ld4-soc-glue-debug', 'simple-mfd'] is too short
arch/arm/boot/dts/uniphier-ld4-ref.dtb
soc-glue@5f900000: compatible: ['socionext,uniphier-pro4-soc-glue-debug', 'simple-mfd'] is too short
arch/arm/boot/dts/uniphier-pro4-ace.dtb
arch/arm/boot/dts/uniphier-pro4-ref.dtb
arch/arm/boot/dts/uniphier-pro4-sanji.dtb
soc-glue@5f900000: compatible: ['socionext,uniphier-pxs2-soc-glue-debug', 'simple-mfd'] is too short
arch/arm/boot/dts/uniphier-ld6b-ref.dtb
arch/arm/boot/dts/uniphier-pxs2-gentil.dtb
arch/arm/boot/dts/uniphier-pxs2-vodka.dtb
soc-glue@5f900000: compatible: ['socionext,uniphier-pxs3-soc-glue-debug', 'simple-mfd'] is too short
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref.dtb
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref-gadget0.dtb
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref-gadget1.dtb
soc-glue@5f900000: compatible: ['socionext,uniphier-sld8-soc-glue-debug', 'simple-mfd'] is too short
arch/arm/boot/dts/uniphier-sld8-ref.dtb
soc-glue@5f900000: 'reg' is a required property
arch/arm64/boot/dts/socionext/uniphier-ld11-global.dtb
arch/arm64/boot/dts/socionext/uniphier-ld11-ref.dtb
arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dtb
arch/arm64/boot/dts/socionext/uniphier-ld20-global.dtb
arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dtb
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref.dtb
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref-gadget0.dtb
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref-gadget1.dtb
arch/arm/boot/dts/uniphier-ld4-ref.dtb
arch/arm/boot/dts/uniphier-ld6b-ref.dtb
arch/arm/boot/dts/uniphier-pro4-ace.dtb
arch/arm/boot/dts/uniphier-pro4-ref.dtb
arch/arm/boot/dts/uniphier-pro4-sanji.dtb
arch/arm/boot/dts/uniphier-pxs2-gentil.dtb
arch/arm/boot/dts/uniphier-pxs2-vodka.dtb
arch/arm/boot/dts/uniphier-sld8-ref.dtb
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
2022-12-07 5:53 ` [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
@ 2022-12-08 8:18 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
1 sibling, 1 reply; 41+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:18 UTC (permalink / raw)
To: Kunihiko Hayashi, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the SoC-glue logic debug part
> implemented on Socionext Uniphier SoCs.
>
> This SoC-glue logic debug part is a set of miscellaneous function
> registers handling signals for specific devices outside system
> components, and also has multiple functions such as efuse, debug unit,
> several monitors for specific SoC, and so on.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-soc-glue-debug.yaml | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
> new file mode 100644
> index 000000000000..db13c56b77b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue-debug.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier SoC-glue logic debug part
> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + SoC-glue logic debug part implemented on Socionext UniPhier SoCs is
> + a collection of miscellaneous function registers handling signals outside
> + system components for debug and monitor use.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - socionext,uniphier-ld4-soc-glue-debug
> + - socionext,uniphier-pro4-soc-glue-debug
> + - socionext,uniphier-pro5-soc-glue-debug
> + - socionext,uniphier-pxs2-soc-glue-debug
> + - socionext,uniphier-sld8-soc-glue-debug
> + - socionext,uniphier-ld11-soc-glue-debug
> + - socionext,uniphier-ld20-soc-glue-debug
> + - socionext,uniphier-pxs3-soc-glue-debug
> + - socionext,uniphier-nx1-soc-glue-debug
> + - const: simple-mfd
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 1
> +
> + ranges: true
> +
> +patternProperties:
> + "^efuse(@[0-9a-f]+)?$":
Unit addresses are not optional.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
2022-12-08 8:18 ` Krzysztof Kozlowski
@ 2022-12-08 15:11 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 15:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 2022/12/08 17:18, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Add devicetree binding schema for the SoC-glue logic debug part
>> implemented on Socionext Uniphier SoCs.
>>
>> This SoC-glue logic debug part is a set of miscellaneous function
>> registers handling signals for specific devices outside system
>> components, and also has multiple functions such as efuse, debug unit,
>> several monitors for specific SoC, and so on.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../socionext,uniphier-soc-glue-debug.yaml | 73 +++++++++++++++++++
>> 1 file changed, 73 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
>> new file mode 100644
>> index 000000000000..db13c56b77b6
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
>> @@ -0,0 +1,73 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:
>> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue-debug.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Socionext UniPhier SoC-glue logic debug part
>> +
>> +maintainers:
>> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> +
>> +description: |+
>> + SoC-glue logic debug part implemented on Socionext UniPhier SoCs is
>> + a collection of miscellaneous function registers handling signals
>> outside
>> + system components for debug and monitor use.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - socionext,uniphier-ld4-soc-glue-debug
>> + - socionext,uniphier-pro4-soc-glue-debug
>> + - socionext,uniphier-pro5-soc-glue-debug
>> + - socionext,uniphier-pxs2-soc-glue-debug
>> + - socionext,uniphier-sld8-soc-glue-debug
>> + - socionext,uniphier-ld11-soc-glue-debug
>> + - socionext,uniphier-ld20-soc-glue-debug
>> + - socionext,uniphier-pxs3-soc-glue-debug
>> + - socionext,uniphier-nx1-soc-glue-debug
>> + - const: simple-mfd
>> + - const: syscon
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 1
>> +
>> + ranges: true
>> +
>> +patternProperties:
>> + "^efuse(@[0-9a-f]+)?$":
>
> Unit addresses are not optional.
In this case, the unit addresses are mandatory, so I'll fix it.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 11/16] dt-bindings: soc: socionext: Add UniPhier peripheral block
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (9 preceding siblings ...)
2022-12-07 5:53 ` [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part Kunihiko Hayashi
@ 2022-12-07 5:54 ` Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 12/16] dt-bindings: soc: socionext: Add UniPhier media I/O block Kunihiko Hayashi
` (4 subsequent siblings)
15 siblings, 1 reply; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add devicetree binding schema for the peripheral block implemented on
Socionext Uniphier SoCs.
Peripheral block implemented on Socionext UniPhier SoCs is an integrated
component of the peripherals including UART, I2C/FI2C, and SCSSI.
Peripheral block has some function logics to control the component.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext,uniphier-perictrl.yaml | 65 +++++++++++++++++++
1 file changed, 65 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
new file mode 100644
index 000000000000..23223a9fe76a
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-perictrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier peripheral block controller
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ Peripheral block implemented on Socionext UniPhier SoCs is an integrated
+ component of the peripherals including UART, I2C/FI2C, and SCSSI.
+ Peripheral block controller is a logic to control the component.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld4-perictrl
+ - socionext,uniphier-pro4-perictrl
+ - socionext,uniphier-pro5-perictrl
+ - socionext,uniphier-pxs2-perictrl
+ - socionext,uniphier-sld8-perictrl
+ - socionext,uniphier-ld11-perictrl
+ - socionext,uniphier-ld20-perictrl
+ - socionext,uniphier-pxs3-perictrl
+ - socionext,uniphier-nx1-perictrl
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+patternProperties:
+ "^clock-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/clock/socionext,uniphier-clock.yaml#
+
+ "^reset-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/reset/socionext,uniphier-reset.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@59820000 {
+ compatible = "socionext,uniphier-ld20-perictrl",
+ "simple-mfd", "syscon";
+ reg = <0x59820000 0x200>;
+
+ clock-controller {
+ compatible = "socionext,uniphier-ld20-peri-clock";
+ #clock-cells = <1>;
+ };
+
+ reset-controller {
+ compatible = "socionext,uniphier-ld20-peri-reset";
+ #reset-cells = <1>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 11/16] dt-bindings: soc: socionext: Add UniPhier peripheral block
2022-12-07 5:54 ` [PATCH v2 11/16] dt-bindings: soc: socionext: Add UniPhier peripheral block Kunihiko Hayashi
@ 2022-12-07 14:19 ` Rob Herring
0 siblings, 0 replies; 41+ messages in thread
From: Rob Herring @ 2022-12-07 14:19 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: linux-arm-kernel, Masami Hiramatsu, Krzysztof Kozlowski,
devicetree, linux-kernel, Rob Herring
On Wed, 07 Dec 2022 14:54:00 +0900, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the peripheral block implemented on
> Socionext Uniphier SoCs.
>
> Peripheral block implemented on Socionext UniPhier SoCs is an integrated
> component of the peripherals including UART, I2C/FI2C, and SCSSI.
>
> Peripheral block has some function logics to control the component.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-perictrl.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-12-hayashi.kunihiko@socionext.com
perictrl@59820000: 'clock', 'reset' do not match any of the regexes: '^clock-controller(@[0-9a-f]+)?$', '^reset-controller(@[0-9a-f]+)?$', 'pinctrl-[0-9]+'
arch/arm64/boot/dts/socionext/uniphier-ld11-global.dtb
arch/arm64/boot/dts/socionext/uniphier-ld11-ref.dtb
arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dtb
arch/arm64/boot/dts/socionext/uniphier-ld20-global.dtb
arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dtb
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref.dtb
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref-gadget0.dtb
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref-gadget1.dtb
arch/arm/boot/dts/uniphier-ld4-ref.dtb
arch/arm/boot/dts/uniphier-ld6b-ref.dtb
arch/arm/boot/dts/uniphier-pro4-ace.dtb
arch/arm/boot/dts/uniphier-pro4-ref.dtb
arch/arm/boot/dts/uniphier-pro4-sanji.dtb
arch/arm/boot/dts/uniphier-pxs2-gentil.dtb
arch/arm/boot/dts/uniphier-pxs2-vodka.dtb
arch/arm/boot/dts/uniphier-sld8-ref.dtb
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 12/16] dt-bindings: soc: socionext: Add UniPhier media I/O block
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (10 preceding siblings ...)
2022-12-07 5:54 ` [PATCH v2 11/16] dt-bindings: soc: socionext: Add UniPhier peripheral block Kunihiko Hayashi
@ 2022-12-07 5:54 ` Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 13/16] dt-bindings: soc: socionext: Add UniPhier SD interface block Kunihiko Hayashi
` (3 subsequent siblings)
15 siblings, 1 reply; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add devicetree binding schema for the media I/O block implemented on
Socionext Uniphier SoCs. This block is implemented on LD4, sLD8, Pro4,
and LD11 SoCs.
Media I/O block implemented on Socionext UniPhier SoCs is an integrated
component of the stream type peripherals including SD, USB2.0, eMMC,
and MIO-DMAC.
Media I/O block has a common logic to control the component.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext/socionext,uniphier-mioctrl.yaml | 66 +++++++++++++++++++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-mioctrl.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-mioctrl.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-mioctrl.yaml
new file mode 100644
index 000000000000..1994355a27d3
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-mioctrl.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-mioctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier media I/O block (MIO) controller
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ Media I/O block implemented on Socionext UniPhier SoCs is a legacy
+ integrated component of the stream type peripherals including USB2.0,
+ SD/eMMC, and MIO-DMAC.
+ Media I/O block has a common logic to control the component.
+
+ Recent SoCs have SD interface logic specialized only for SD functions
+ as a subset of media I/O block. See socionext,uniphier-sdctrl.yaml.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld4-mioctrl
+ - socionext,uniphier-pro4-mioctrl
+ - socionext,uniphier-sld8-mioctrl
+ - socionext,uniphier-ld11-mioctrl
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+patternProperties:
+ "^clock-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/clock/socionext,uniphier-clock.yaml#
+
+ "^reset-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/reset/socionext,uniphier-reset.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@5b3e0000 {
+ compatible = "socionext,uniphier-ld11-mioctrl",
+ "simple-mfd", "syscon";
+ reg = <0x5b3e0000 0x800>;
+
+ clock-controller {
+ compatible = "socionext,uniphier-ld11-mio-clock";
+ #clock-cells = <1>;
+ };
+
+ reset-controller {
+ compatible = "socionext,uniphier-ld11-mio-reset";
+ #reset-cells = <1>;
+ resets = <&sys_rst 7>;
+ };
+ };
+
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 12/16] dt-bindings: soc: socionext: Add UniPhier media I/O block
2022-12-07 5:54 ` [PATCH v2 12/16] dt-bindings: soc: socionext: Add UniPhier media I/O block Kunihiko Hayashi
@ 2022-12-07 14:19 ` Rob Herring
0 siblings, 0 replies; 41+ messages in thread
From: Rob Herring @ 2022-12-07 14:19 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: linux-kernel, devicetree, Rob Herring, Masami Hiramatsu,
linux-arm-kernel, Krzysztof Kozlowski
On Wed, 07 Dec 2022 14:54:01 +0900, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the media I/O block implemented on
> Socionext Uniphier SoCs. This block is implemented on LD4, sLD8, Pro4,
> and LD11 SoCs.
>
> Media I/O block implemented on Socionext UniPhier SoCs is an integrated
> component of the stream type peripherals including SD, USB2.0, eMMC,
> and MIO-DMAC.
>
> Media I/O block has a common logic to control the component.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext/socionext,uniphier-mioctrl.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-mioctrl.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-13-hayashi.kunihiko@socionext.com
mioctrl@59810000: 'clock', 'reset' do not match any of the regexes: '^clock-controller(@[0-9a-f]+)?$', '^reset-controller(@[0-9a-f]+)?$', 'pinctrl-[0-9]+'
arch/arm/boot/dts/uniphier-ld4-ref.dtb
arch/arm/boot/dts/uniphier-pro4-ace.dtb
arch/arm/boot/dts/uniphier-pro4-ref.dtb
arch/arm/boot/dts/uniphier-pro4-sanji.dtb
arch/arm/boot/dts/uniphier-sld8-ref.dtb
mioctrl@5b3e0000: 'clock', 'reset' do not match any of the regexes: '^clock-controller(@[0-9a-f]+)?$', '^reset-controller(@[0-9a-f]+)?$', 'pinctrl-[0-9]+'
arch/arm64/boot/dts/socionext/uniphier-ld11-global.dtb
arch/arm64/boot/dts/socionext/uniphier-ld11-ref.dtb
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 13/16] dt-bindings: soc: socionext: Add UniPhier SD interface block
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (11 preceding siblings ...)
2022-12-07 5:54 ` [PATCH v2 12/16] dt-bindings: soc: socionext: Add UniPhier media I/O block Kunihiko Hayashi
@ 2022-12-07 5:54 ` Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 14/16] dt-bindings: soc: socionext: Add UniPhier ADAMV block Kunihiko Hayashi
` (2 subsequent siblings)
15 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add devicetree binding schema for the SD interface block implemented on
Socionext Uniphier SoCs.
This SD interface block is attached outside SDHC, and has some SD related
functions such as clock control, reset control, mode switch, and so on.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext/socionext,uniphier-sdctrl.yaml | 62 +++++++++++++++++++
1 file changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sdctrl.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sdctrl.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sdctrl.yaml
new file mode 100644
index 000000000000..af73f7f3f8d7
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sdctrl.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-sdctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier SD interface logic
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ SD interface logic implemented on Socionext UniPhier SoCs is
+ attached outside SDHC, and has some SD related functions such as
+ clock control, reset control, mode switch, and so on.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-pro5-sdctrl
+ - socionext,uniphier-pxs2-sdctrl
+ - socionext,uniphier-ld11-sdctrl
+ - socionext,uniphier-ld20-sdctrl
+ - socionext,uniphier-pxs3-sdctrl
+ - socionext,uniphier-nx1-sdctrl
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+patternProperties:
+ "^clock-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/clock/socionext,uniphier-clock.yaml#
+
+ "^reset-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/reset/socionext,uniphier-reset.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@59810000 {
+ compatible = "socionext,uniphier-ld20-sdctrl",
+ "simple-mfd", "syscon";
+ reg = <0x59810000 0x400>;
+
+ clock-controller {
+ compatible = "socionext,uniphier-ld20-sd-clock";
+ #clock-cells = <1>;
+ };
+
+ reset-controller {
+ compatible = "socionext,uniphier-ld20-sd-reset";
+ #reset-cells = <1>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH v2 14/16] dt-bindings: soc: socionext: Add UniPhier ADAMV block
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (12 preceding siblings ...)
2022-12-07 5:54 ` [PATCH v2 13/16] dt-bindings: soc: socionext: Add UniPhier SD interface block Kunihiko Hayashi
@ 2022-12-07 5:54 ` Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI " Kunihiko Hayashi
15 siblings, 1 reply; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add devicetree binding schema for the ADAMV block implemented on Socionext
Uniphier SoCs.
The ADAMV block is analog signal amplifier that is a part of the external
video and audio I/O system. This block is implemented on LD11 and LD20,
and this is defined for controlling audio I/O reset only.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext/socionext,uniphier-adamv.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
new file mode 100644
index 000000000000..3d61d2919049
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-adamv.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier ADAMV block
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ ADAMV block implemented on Socionext UniPhier SoCs is an analog signal
+ amplifier that is a part of the external video and audio I/O system.
+
+ This block is defined for controlling audio I/O reset only.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld11-adamv
+ - socionext,uniphier-ld20-adamv
+ - const: simple-mfd
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+patternProperties:
+ "^reset-controller(@[0-9a-f]+)?$":
+ $ref: /schemas/reset/socionext,uniphier-reset.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@57920000 {
+ compatible = "socionext,uniphier-ld20-adamv",
+ "simple-mfd", "syscon";
+ reg = <0x57920000 0x1000>;
+
+ reset-controller {
+ compatible = "socionext,uniphier-ld20-adamv-reset";
+ #reset-cells = <1>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 14/16] dt-bindings: soc: socionext: Add UniPhier ADAMV block
2022-12-07 5:54 ` [PATCH v2 14/16] dt-bindings: soc: socionext: Add UniPhier ADAMV block Kunihiko Hayashi
@ 2022-12-07 14:19 ` Rob Herring
0 siblings, 0 replies; 41+ messages in thread
From: Rob Herring @ 2022-12-07 14:19 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: Masami Hiramatsu, Krzysztof Kozlowski, linux-arm-kernel,
linux-kernel, Rob Herring, devicetree
On Wed, 07 Dec 2022 14:54:03 +0900, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the ADAMV block implemented on Socionext
> Uniphier SoCs.
>
> The ADAMV block is analog signal amplifier that is a part of the external
> video and audio I/O system. This block is implemented on LD11 and LD20,
> and this is defined for controlling audio I/O reset only.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext/socionext,uniphier-adamv.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/reset/socionext,uniphier-reset.example.dtb: adamv@57920000: 'reset' does not match any of the regexes: '^reset-controller(@[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-15-hayashi.kunihiko@socionext.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (13 preceding siblings ...)
2022-12-07 5:54 ` [PATCH v2 14/16] dt-bindings: soc: socionext: Add UniPhier ADAMV block Kunihiko Hayashi
@ 2022-12-07 5:54 ` Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:23 ` Krzysztof Kozlowski
2022-12-07 5:54 ` [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI " Kunihiko Hayashi
15 siblings, 2 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add DT binding schema for components belonging to the platform-specific
DWC3 USB glue layer implemented in UniPhier SoCs.
This USB glue layer works as a sideband logic for the host controller,
including core reset, vbus control, PHYs, and some signals to the
controller.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext,uniphier-dwc3-glue.yaml | 106 ++++++++++++++++++
1 file changed, 106 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
new file mode 100644
index 000000000000..1b5585a5a3a2
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
@@ -0,0 +1,106 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-dwc3-glue.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier SoC DWC3 USB3.0 glue layer
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ DWC3 USB3.0 glue layer implemented on Socionext UniPhier SoCs is
+ a sideband logic handling signals to DWC3 host controller inside
+ USB3.0 component.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-pro4-dwc3-glue
+ - socionext,uniphier-pro5-dwc3-glue
+ - socionext,uniphier-pxs2-dwc3-glue
+ - socionext,uniphier-ld20-dwc3-glue
+ - socionext,uniphier-pxs3-dwc3-glue
+ - socionext,uniphier-nx1-dwc3-glue
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 1
+
+ ranges: true
+
+patternProperties:
+ "^reset-controller@[0-9a-f]+$":
+ $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
+
+ "^regulator@[0-9a-f]+$":
+ $ref: /schemas/regulator/socionext,uniphier-regulator.yaml#
+
+ "^phy@[0-9a-f]+$":
+ oneOf:
+ - $ref: /schemas/phy/socionext,uniphier-usb3hs-phy.yaml#
+ - $ref: /schemas/phy/socionext,uniphier-usb3ss-phy.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ usb@65b00000 {
+ compatible = "socionext,uniphier-ld20-dwc3-glue", "simple-mfd";
+ reg = <0x65b00000 0x400>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x65b00000 0x400>;
+
+ reset-controller@0 {
+ compatible = "socionext,uniphier-ld20-usb3-reset";
+ reg = <0x0 0x4>;
+ #reset-cells = <1>;
+ clock-names = "link";
+ clocks = <&sys_clk 14>;
+ reset-names = "link";
+ resets = <&sys_rst 14>;
+ };
+
+ regulator@100 {
+ compatible = "socionext,uniphier-ld20-usb3-regulator";
+ reg = <0x100 0x10>;
+ clock-names = "link";
+ clocks = <&sys_clk 14>;
+ reset-names = "link";
+ resets = <&sys_rst 14>;
+ };
+
+ phy@200 {
+ compatible = "socionext,uniphier-ld20-usb3-hsphy";
+ reg = <0x200 0x10>;
+ #phy-cells = <0>;
+ clock-names = "link", "phy";
+ clocks = <&sys_clk 14>, <&sys_clk 16>;
+ reset-names = "link", "phy";
+ resets = <&sys_rst 14>, <&sys_rst 16>;
+ };
+
+ phy@300 {
+ compatible = "socionext,uniphier-ld20-usb3-ssphy";
+ reg = <0x300 0x10>;
+ #phy-cells = <0>;
+ clock-names = "link", "phy";
+ clocks = <&sys_clk 14>, <&sys_clk 18>;
+ reset-names = "link", "phy";
+ resets = <&sys_rst 14>, <&sys_rst 18>;
+ };
+ };
+
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
2022-12-07 5:54 ` [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer Kunihiko Hayashi
@ 2022-12-07 14:19 ` Rob Herring
2022-12-08 8:23 ` Krzysztof Kozlowski
1 sibling, 0 replies; 41+ messages in thread
From: Rob Herring @ 2022-12-07 14:19 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: linux-kernel, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
Masami Hiramatsu, Rob Herring
On Wed, 07 Dec 2022 14:54:04 +0900, Kunihiko Hayashi wrote:
> Add DT binding schema for components belonging to the platform-specific
> DWC3 USB glue layer implemented in UniPhier SoCs.
>
> This USB glue layer works as a sideband logic for the host controller,
> including core reset, vbus control, PHYs, and some signals to the
> controller.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-dwc3-glue.yaml | 106 ++++++++++++++++++
> 1 file changed, 106 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.example.dtb: usb-glue@65b00000: 'reg' is a required property
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.example.dtb: usb-glue@65b00000: 'hs-phy@200' does not match any of the regexes: '^phy@[0-9a-f]+$', '^regulator@[0-9a-f]+$', '^reset-controller@[0-9a-f]+$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.example.dtb: usb-glue@65b00000: 'reg' is a required property
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.example.dtb: usb-glue@65b00000: 'ss-phy@300' does not match any of the regexes: '^phy@[0-9a-f]+$', '^regulator@[0-9a-f]+$', '^reset-controller@[0-9a-f]+$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-16-hayashi.kunihiko@socionext.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
2022-12-07 5:54 ` [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
@ 2022-12-08 8:23 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
1 sibling, 1 reply; 41+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:23 UTC (permalink / raw)
To: Kunihiko Hayashi, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 07/12/2022 06:54, Kunihiko Hayashi wrote:
> Add DT binding schema for components belonging to the platform-specific
> DWC3 USB glue layer implemented in UniPhier SoCs.
>
> This USB glue layer works as a sideband logic for the host controller,
> including core reset, vbus control, PHYs, and some signals to the
> controller.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-dwc3-glue.yaml | 106 ++++++++++++++++++
> 1 file changed, 106 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
> new file mode 100644
> index 000000000000..1b5585a5a3a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
> @@ -0,0 +1,106 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-dwc3-glue.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier SoC DWC3 USB3.0 glue layer
> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + DWC3 USB3.0 glue layer implemented on Socionext UniPhier SoCs is
> + a sideband logic handling signals to DWC3 host controller inside
> + USB3.0 component.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - socionext,uniphier-pro4-dwc3-glue
> + - socionext,uniphier-pro5-dwc3-glue
> + - socionext,uniphier-pxs2-dwc3-glue
> + - socionext,uniphier-ld20-dwc3-glue
> + - socionext,uniphier-pxs3-dwc3-glue
> + - socionext,uniphier-nx1-dwc3-glue
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
Use consistent quotes - either ' or "
> + const: 1
> +
> + '#size-cells':
> + const: 1
> +
> + ranges: true
> +
> +patternProperties:
> + "^reset-controller@[0-9a-f]+$":
> + $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
> +
> + "^regulator@[0-9a-f]+$":
> + $ref: /schemas/regulator/socionext,uniphier-regulator.yaml#
> +
> + "^phy@[0-9a-f]+$":
> + oneOf:
> + - $ref: /schemas/phy/socionext,uniphier-usb3hs-phy.yaml#
> + - $ref: /schemas/phy/socionext,uniphier-usb3ss-phy.yaml#
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
You need to fix
Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
example. I propose to drop usb-glue@65b00000 from that file. It's not
relevant to that example.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
2022-12-08 8:23 ` Krzysztof Kozlowski
@ 2022-12-08 15:11 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 15:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 2022/12/08 17:23, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:54, Kunihiko Hayashi wrote:
>> Add DT binding schema for components belonging to the platform-specific
>> DWC3 USB glue layer implemented in UniPhier SoCs.
>>
>> This USB glue layer works as a sideband logic for the host controller,
>> including core reset, vbus control, PHYs, and some signals to the
>> controller.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../socionext,uniphier-dwc3-glue.yaml | 106 ++++++++++++++++++
>> 1 file changed, 106 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
>> new file mode 100644
>> index 000000000000..1b5585a5a3a2
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
>> @@ -0,0 +1,106 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:
>> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-dwc3-glue.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Socionext UniPhier SoC DWC3 USB3.0 glue layer
>> +
>> +maintainers:
>> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> +
>> +description: |+
>> + DWC3 USB3.0 glue layer implemented on Socionext UniPhier SoCs is
>> + a sideband logic handling signals to DWC3 host controller inside
>> + USB3.0 component.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - socionext,uniphier-pro4-dwc3-glue
>> + - socionext,uniphier-pro5-dwc3-glue
>> + - socionext,uniphier-pxs2-dwc3-glue
>> + - socionext,uniphier-ld20-dwc3-glue
>> + - socionext,uniphier-pxs3-dwc3-glue
>> + - socionext,uniphier-nx1-dwc3-glue
>> + - const: simple-mfd
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + '#address-cells':
>
> Use consistent quotes - either ' or "
I'll change it.
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 1
>> +
>> + ranges: true
>> +
>> +patternProperties:
>> + "^reset-controller@[0-9a-f]+$":
>> + $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
>> +
>> + "^regulator@[0-9a-f]+$":
>> + $ref: /schemas/regulator/socionext,uniphier-regulator.yaml#
>> +
>> + "^phy@[0-9a-f]+$":
>> + oneOf:
>> + - $ref: /schemas/phy/socionext,uniphier-usb3hs-phy.yaml#
>> + - $ref: /schemas/phy/socionext,uniphier-usb3ss-phy.yaml#
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>
> You need to fix
> Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> example. I propose to drop usb-glue@65b00000 from that file. It's not
> relevant to that example.
I already fixed usb3-phy example in PATCH 6/16, however, it's better
to drop the parent node from the example not to avoid the effect of the changes.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
` (14 preceding siblings ...)
2022-12-07 5:54 ` [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer Kunihiko Hayashi
@ 2022-12-07 5:54 ` Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:24 ` Krzysztof Kozlowski
15 siblings, 2 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-07 5:54 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel,
Kunihiko Hayashi
Add DT binding schema for components belonging to the platform-specific
AHCI glue layer implemented in UniPhier SoCs.
This AHCI glue layer works as a sideband logic for the host controller,
including core reset, PHYs, and some signals to the controller.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../socionext,uniphier-ahci-glue.yaml | 78 +++++++++++++++++++
1 file changed, 78 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
new file mode 100644
index 000000000000..bf37be8a778d
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-ahci-glue.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier SoC AHCI glue layer
+
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+description: |+
+ AHCI glue layer implemented on Socionext UniPhier SoCs is a sideband
+ logic handling signals to AHCI host controller inside AHCI component.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-pro4-ahci-glue
+ - socionext,uniphier-pxs2-ahci-glue
+ - socionext,uniphier-pxs3-ahci-glue
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 1
+
+ ranges: true
+
+patternProperties:
+ "^reset-controller@[0-9a-f]+$":
+ $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
+
+ "phy@[0-9a-f]+$":
+ $ref: /schemas/phy/socionext,uniphier-ahci-phy.yaml#
+
+required:
+ - compatible
+ - reg
+
+additionalProperties:
+ type: object
+
+examples:
+ - |
+ sata-controller@65700000 {
+ compatible = "socionext,uniphier-pxs3-ahci-glue", "simple-mfd";
+ reg = <0x65b00000 0x400>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x65700000 0x100>;
+
+ reset-controller@0 {
+ compatible = "socionext,uniphier-pxs3-ahci-reset";
+ reg = <0x0 0x4>;
+ clock-names = "link";
+ clocks = <&sys_clk 28>;
+ reset-names = "link";
+ resets = <&sys_rst 28>;
+ #reset-cells = <1>;
+ };
+
+ phy@10 {
+ compatible = "socionext,uniphier-pxs3-ahci-phy";
+ reg = <0x10 0x10>;
+ clock-names = "link", "phy";
+ clocks = <&sys_clk 28>, <&sys_clk 30>;
+ reset-names = "link", "phy";
+ resets = <&sys_rst 28>, <&sys_rst 30>;
+ #phy-cells = <0>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
2022-12-07 5:54 ` [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI " Kunihiko Hayashi
@ 2022-12-07 14:19 ` Rob Herring
2022-12-08 8:24 ` Krzysztof Kozlowski
1 sibling, 0 replies; 41+ messages in thread
From: Rob Herring @ 2022-12-07 14:19 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: Krzysztof Kozlowski, linux-arm-kernel, Rob Herring, linux-kernel,
Masami Hiramatsu, devicetree
On Wed, 07 Dec 2022 14:54:05 +0900, Kunihiko Hayashi wrote:
> Add DT binding schema for components belonging to the platform-specific
> AHCI glue layer implemented in UniPhier SoCs.
>
> This AHCI glue layer works as a sideband logic for the host controller,
> including core reset, PHYs, and some signals to the controller.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-ahci-glue.yaml | 78 +++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.example.dtb: ahci-glue@65700000: 'reg' is a required property
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-17-hayashi.kunihiko@socionext.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
2022-12-07 5:54 ` [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI " Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
@ 2022-12-08 8:24 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
1 sibling, 1 reply; 41+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 8:24 UTC (permalink / raw)
To: Kunihiko Hayashi, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 07/12/2022 06:54, Kunihiko Hayashi wrote:
> Add DT binding schema for components belonging to the platform-specific
> AHCI glue layer implemented in UniPhier SoCs.
>
> This AHCI glue layer works as a sideband logic for the host controller,
> including core reset, PHYs, and some signals to the controller.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-ahci-glue.yaml | 78 +++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
> new file mode 100644
> index 000000000000..bf37be8a778d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-ahci-glue.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier SoC AHCI glue layer
> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + AHCI glue layer implemented on Socionext UniPhier SoCs is a sideband
> + logic handling signals to AHCI host controller inside AHCI component.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - socionext,uniphier-pro4-ahci-glue
> + - socionext,uniphier-pxs2-ahci-glue
> + - socionext,uniphier-pxs3-ahci-glue
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
use consistent quotes
> + const: 1
> +
> + '#size-cells':
> + const: 1
> +
> + ranges: true
> +
> +patternProperties:
> + "^reset-controller@[0-9a-f]+$":
> + $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
> +
> + "phy@[0-9a-f]+$":
> + $ref: /schemas/phy/socionext,uniphier-ahci-phy.yaml#
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties:
> + type: object
What is the additional object? It's not in your example, not in DTS. Why
do you need to allow it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
2022-12-08 8:24 ` Krzysztof Kozlowski
@ 2022-12-08 15:11 ` Kunihiko Hayashi
0 siblings, 0 replies; 41+ messages in thread
From: Kunihiko Hayashi @ 2022-12-08 15:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
Cc: Masami Hiramatsu, devicetree, linux-arm-kernel, linux-kernel
On 2022/12/08 17:24, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:54, Kunihiko Hayashi wrote:
>> Add DT binding schema for components belonging to the platform-specific
>> AHCI glue layer implemented in UniPhier SoCs.
>>
>> This AHCI glue layer works as a sideband logic for the host controller,
>> including core reset, PHYs, and some signals to the controller.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../socionext,uniphier-ahci-glue.yaml | 78 +++++++++++++++++++
>> 1 file changed, 78 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
>> new file mode 100644
>> index 000000000000..bf37be8a778d
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
>> @@ -0,0 +1,78 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:
>> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-ahci-glue.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Socionext UniPhier SoC AHCI glue layer
>> +
>> +maintainers:
>> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> +
>> +description: |+
>> + AHCI glue layer implemented on Socionext UniPhier SoCs is a sideband
>> + logic handling signals to AHCI host controller inside AHCI component.
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - socionext,uniphier-pro4-ahci-glue
>> + - socionext,uniphier-pxs2-ahci-glue
>> + - socionext,uniphier-pxs3-ahci-glue
>> + - const: simple-mfd
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + '#address-cells':
>
> use consistent quotes
I'll change it.
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 1
>> +
>> + ranges: true
>> +
>> +patternProperties:
>> + "^reset-controller@[0-9a-f]+$":
>> + $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
>> +
>> + "phy@[0-9a-f]+$":
>> + $ref: /schemas/phy/socionext,uniphier-ahci-phy.yaml#
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties:
>> + type: object
>
> What is the additional object? It's not in your example, not in DTS. Why
> do you need to allow it?
Sorry, I forgot to drop it. I'll replace it with:
additionalProperties: false
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 41+ messages in thread