From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "Paul Burton" <paulburton@kernel.org>,
linux-mips@vger.kernel.org,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 00/22] Add support for the Mobileye EyeQ5 SoC
Date: Fri, 15 Dec 2023 17:39:39 +0100 [thread overview]
Message-ID: <878r5vctdg.fsf@BL-laptop> (raw)
In-Reply-To: <20231212163459.1923041-1-gregory.clement@bootlin.com>
Hello Thomas,
> Hello,
>
> The EyeQ5 SoC from Mobileye is based on the MIPS I6500 architecture
> and features multiple controllers such as the classic UART, I2C, SPI,
> as well as CAN-FD, PCIe, Octal/Quad SPI Flash interface, Gigabit
> Ethernet, MIPI CSI-2, and eMMC 5.1. It also includes a Hardware
> Security Module, Functional Safety Hardware, and MJPEG encoder.
>
> One peculiarity of this SoC is that the physical address of the DDDR
> exceeds 32 bits. Given that the architecture is 64 bits, this is not
> an issue, but it requires some changes in how the mips64 is currently
> managed during boot.
>
> In this fifth version, there aren't many changes, mostly just tweaking
> commit messages based on Sergey's feedback and fixing up the code
> style. But, the real reason for this series is a bit of a whoopsie on
> my end. It turns out, despite what I confidently claimed in the last
> round, some configuration tweaks were missing. All sorted now, though!
>
A few weeks ago, you were concerned about the introduction of the
specific kconfig CONFIG_USE_XKPHYS to support EyeQ5, and you wanted us
to set up a new platform instead. Since then, Jiaxun proposed a series
that was merged here to provide more generic support.
I had other issues in the initial series, and I think that now I've
fixed all of them. So, I would like to know what your opinion is now
about this series.
Will you accept it, or do you still think that a new platform has to be
set up?
Regards,
Gregory
> To build and test the kernel, we need to run the following commands:
>
> make 64r6el_defconfig BOARDS=eyeq5
> make vmlinuz.itb
>
> Changelog:
>
> v4 -> v5:
>
> - Improve commit messages for patch 3, 5, 12 and 13.
>
> - Fix style in patch 9
>
> - Really enable SPARSMEM and use correct address in
> board-eyeq5.config in patch 21
>
> v3 -> v4:
>
> - Fix build warning in "MIPS: Get rid of CONFIG_NO_EXCEPT_FILL":
> check that we are in 64bit mode before using KSEG0 that exist only
> in this mode.
>
> - Modify "MIPS: spaces: Define a couple of handy macros" to be
> buildable in 32bit mode.
>
> - Use correct format specifier to print address in "MIPS: traps: Give
> more explanations if ebase doesn't belong to KSEG0"
>
> - In "MIPS: generic: Add support for Mobileye EyeQ5",remove
> CONFIG_ZBOOT_LOAD_ADDRESS from board-eyeq5.config, (as well as
> CONFIG_USE_XKPHYS that does not exist anymore) and add
> CONFIG_SPARSEMEM_MANUAL to enable SPARSMEM.
>
> v2 -> v3
>
> - Added more reviewed-by and acked-by tags
>
> - Fix sorting for cpus entries in
>
> - Fix indentation issue in Documentation/devicetree/bindings/mips/mobileye.yaml
>
> v1 -> v2
>
> - Added reviewed-by and acked-by tags
>
> - Fix typos reported
>
> - In patch 15 use 'img' vendor string instead of mti
>
> - In patch 16 modify licence
>
> - In patch 17 give more explanations about the block usage.
>
> - In patch 18, remove _ in node names, don't use anymore
> CONFIG_BUILTIN_DTB in Makefile, remove macro, modify licence.
>
> - In patch 19 remove most of the bootargs and only keeps earlycon. I
> also split the memory in 2 part in the device tree.
>
> - Integrate the series from Jiaxun Yang
> https://lore.kernel.org/linux-mips/20231027221106.405666-1-jiaxun.yang@flygoat.com/
>
> They are patches 2 to 6 and 8 to 12
>
> Then I added patch 7 to fix the cache issue visible on the Mobileye
> platform, I also add patch 13 to improve warning message when ebase
> doesn't belong to KSEG0
>
> Regards,
>
> Gregory
>
> Gregory CLEMENT (13):
> MIPS: compressed: Use correct instruction for 64 bit code
> MIPS: spaces: Define a couple of handy macros
> MIPS: Fix cache issue with mips_cps_core_entry
> MIPS: traps: Give more explanations if ebase doesn't belong to KSEG0
> dt-bindings: Add vendor prefix for Mobileye Vision Technologies Ltd.
> dt-bindings: mips: cpus: Sort the entries
> dt-bindings: mips: cpu: Add I-Class I6500 Multiprocessor Core
> dt-bindings: mips: Add bindings for Mobileye SoCs
> dt-bindings: mfd: syscon: Document EyeQ5 OLB
> MIPS: mobileye: Add EyeQ5 dtsi
> MIPS: mobileye: Add EPM5 device tree
> MIPS: generic: Add support for Mobileye EyeQ5
> MAINTAINERS: Add entry for Mobileye MIPS SoCs
>
> Jiaxun Yang (9):
> MIPS: Export higher/highest relocation functions in uasm
> MIPS: genex: Fix except_vec_vi for kernel in XKPHYS
> MIPS: Fix set_uncached_handler for ebase in XKPHYS
> MIPS: Refactor mips_cps_core_entry implementation
> MIPS: Allow kernel base to be set from Kconfig for all platforms
> MIPS: traps: Handle CPU with non standard vint offset
> MIPS: Avoid unnecessary reservation of exception space
> MIPS: traps: Enhance memblock ebase allocation process
> MIPS: Get rid of CONFIG_NO_EXCEPT_FILL
>
> .../devicetree/bindings/mfd/syscon.yaml | 1 +
> .../devicetree/bindings/mips/cpus.yaml | 13 +-
> .../devicetree/bindings/mips/mobileye.yaml | 32 ++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> MAINTAINERS | 12 +
> arch/mips/Kconfig | 26 +-
> arch/mips/boot/compressed/head.S | 4 +-
> arch/mips/boot/dts/Makefile | 1 +
> arch/mips/boot/dts/mobileye/Makefile | 4 +
> arch/mips/boot/dts/mobileye/eyeq5-epm5.dts | 24 ++
> .../boot/dts/mobileye/eyeq5-fixed-clocks.dtsi | 292 ++++++++++++++++++
> arch/mips/boot/dts/mobileye/eyeq5.dtsi | 134 ++++++++
> arch/mips/configs/generic/board-eyeq5.config | 42 +++
> arch/mips/generic/Kconfig | 15 +
> arch/mips/generic/Platform | 2 +
> arch/mips/generic/board-epm5.its.S | 24 ++
> arch/mips/include/asm/addrspace.h | 5 +
> arch/mips/include/asm/mach-generic/spaces.h | 2 +
> arch/mips/include/asm/mips-cm.h | 1 +
> arch/mips/include/asm/smp-cps.h | 4 +-
> arch/mips/include/asm/traps.h | 1 -
> arch/mips/include/asm/uasm.h | 2 +
> arch/mips/kernel/cps-vec.S | 110 +++----
> arch/mips/kernel/cpu-probe.c | 5 -
> arch/mips/kernel/cpu-r3k-probe.c | 2 -
> arch/mips/kernel/genex.S | 19 +-
> arch/mips/kernel/head.S | 7 +-
> arch/mips/kernel/smp-cps.c | 171 ++++++++--
> arch/mips/kernel/traps.c | 90 ++++--
> arch/mips/mm/uasm.c | 6 +-
> 30 files changed, 894 insertions(+), 159 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mips/mobileye.yaml
> create mode 100644 arch/mips/boot/dts/mobileye/Makefile
> create mode 100644 arch/mips/boot/dts/mobileye/eyeq5-epm5.dts
> create mode 100644 arch/mips/boot/dts/mobileye/eyeq5-fixed-clocks.dtsi
> create mode 100644 arch/mips/boot/dts/mobileye/eyeq5.dtsi
> create mode 100644 arch/mips/configs/generic/board-eyeq5.config
> create mode 100644 arch/mips/generic/board-epm5.its.S
>
> --
> 2.42.0
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2023-12-15 16:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 16:34 [PATCH v5 00/22] Add support for the Mobileye EyeQ5 SoC Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 01/22] MIPS: compressed: Use correct instruction for 64 bit code Gregory CLEMENT
2023-12-21 14:38 ` Thomas Bogendoerfer
2023-12-12 16:34 ` [PATCH v5 02/22] MIPS: Export higher/highest relocation functions in uasm Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 03/22] MIPS: spaces: Define a couple of handy macros Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 04/22] MIPS: genex: Fix except_vec_vi for kernel in XKPHYS Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 05/22] MIPS: Fix set_uncached_handler for ebase " Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 06/22] MIPS: Refactor mips_cps_core_entry implementation Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 07/22] MIPS: Fix cache issue with mips_cps_core_entry Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 08/22] MIPS: Allow kernel base to be set from Kconfig for all platforms Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 09/22] MIPS: traps: Handle CPU with non standard vint offset Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 10/22] MIPS: Avoid unnecessary reservation of exception space Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 11/22] MIPS: traps: Enhance memblock ebase allocation process Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 12/22] MIPS: Get rid of CONFIG_NO_EXCEPT_FILL Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 13/22] MIPS: traps: Give more explanations if ebase doesn't belong to KSEG0 Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 14/22] dt-bindings: Add vendor prefix for Mobileye Vision Technologies Ltd Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 15/22] dt-bindings: mips: cpus: Sort the entries Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 16/22] dt-bindings: mips: cpu: Add I-Class I6500 Multiprocessor Core Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 17/22] dt-bindings: mips: Add bindings for Mobileye SoCs Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 18/22] dt-bindings: mfd: syscon: Document EyeQ5 OLB Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 19/22] MIPS: mobileye: Add EyeQ5 dtsi Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 20/22] MIPS: mobileye: Add EPM5 device tree Gregory CLEMENT
2023-12-12 16:34 ` [PATCH v5 21/22] MIPS: generic: Add support for Mobileye EyeQ5 Gregory CLEMENT
2023-12-14 9:46 ` Jiaxun Yang
2023-12-15 16:52 ` Gregory CLEMENT
2023-12-15 20:29 ` Jiaxun Yang
2023-12-12 16:34 ` [PATCH v5 22/22] MAINTAINERS: Add entry for Mobileye MIPS SoCs Gregory CLEMENT
2023-12-15 16:39 ` Gregory CLEMENT [this message]
2023-12-20 21:49 ` [PATCH v5 00/22] Add support for the Mobileye EyeQ5 SoC Thomas Bogendoerfer
2023-12-21 1:57 ` Jiaxun Yang
2023-12-21 7:57 ` Gregory CLEMENT
2023-12-21 9:13 ` Gregory CLEMENT
2023-12-21 14:40 ` Thomas Bogendoerfer
2023-12-21 14:55 ` Thomas Bogendoerfer
2023-12-21 15:26 ` Gregory CLEMENT
2023-12-21 16:55 ` Thomas Bogendoerfer
2023-12-21 22:25 ` Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r5vctdg.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).