* [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver
@ 2020-09-02 4:04 Srinivasa Rao Mandadapu
2020-09-02 13:58 ` kernel test robot
2020-09-14 17:41 ` Doug Anderson
0 siblings, 2 replies; 4+ messages in thread
From: Srinivasa Rao Mandadapu @ 2020-09-02 4:04 UTC (permalink / raw)
To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree,
linux-kernel, rohitkr, srinivas.kandagatla
Cc: Ajit Pandey, Cheng-Yi Chiang, Srinivasa Rao Mandadapu
From: Ajit Pandey <ajitp@codeaurora.org>
Add the I2S controller node to sc7180 dtsi.
Add pinmux for primary and secondary I2S.
Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 69 ++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index d46b383..db60ca5 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -676,6 +676,36 @@
};
};
+ lpass_cpu: lpass@62f00000 {
+ compatible = "qcom,sc7180-lpass-cpu";
+
+ reg = <0 0x62f00000 0 0x29000>;
+ reg-names = "lpass-lpaif";
+
+ iommus = <&apps_smmu 0x1020 0>;
+
+ power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
+
+ clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>,
+ <&lpasscc LPASS_AUDIO_CORE_CORE_CLK>,
+ <&lpasscc LPASS_AUDIO_CORE_EXT_MCLK0_CLK>,
+ <&lpasscc LPASS_AUDIO_CORE_SYSNOC_MPORT_CORE_CLK>,
+ <&lpasscc LPASS_AUDIO_CORE_LPAIF_PRI_IBIT_CLK>,
+ <&lpasscc LPASS_AUDIO_CORE_LPAIF_SEC_IBIT_CLK>;
+
+ clock-names = "pcnoc-sway-clk", "audio-core",
+ "mclk0", "pcnoc-mport-clk",
+ "mi2s-bit-clk0", "mi2s-bit-clk1";
+
+
+ #sound-dai-cells = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "lpass-irq-lpaif";
+ };
+
sdhc_1: sdhci@7c4000 {
compatible = "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5";
reg = <0 0x7c4000 0 0x1000>,
@@ -1721,6 +1751,45 @@
};
};
+ sec_mi2s_active: sec-mi2s-active {
+ pinmux {
+ pins = "gpio49", "gpio50", "gpio51";
+ function = "mi2s_1";
+ };
+
+ pinconf {
+ pins = "gpio49", "gpio50", "gpio51";;
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+ };
+
+ pri_mi2s_active: pri-mi2s-active {
+ pinmux {
+ pins = "gpio53", "gpio54", "gpio55", "gpio56";
+ function = "mi2s_0";
+ };
+
+ pinconf {
+ pins = "gpio53", "gpio54", "gpio55", "gpio56";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+ };
+
+ pri_mi2s_mclk_active: pri-mi2s-mclk-active {
+ pinmux {
+ pins = "gpio57";
+ function = "lpass_ext";
+ };
+
+ pinconf {
+ pins = "gpio57";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+ };
+
sdc1_on: sdc1-on {
pinconf-clk {
pins = "sdc1_clk";
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver
2020-09-02 4:04 [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver Srinivasa Rao Mandadapu
@ 2020-09-02 13:58 ` kernel test robot
2020-09-14 17:41 ` Doug Anderson
1 sibling, 0 replies; 4+ messages in thread
From: kernel test robot @ 2020-09-02 13:58 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu, agross, bjorn.andersson, robh+dt,
linux-arm-msm, devicetree, linux-kernel, rohitkr,
srinivas.kandagatla
Cc: kbuild-all, Ajit Pandey, Cheng-Yi Chiang
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
Hi Srinivasa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.9-rc3 next-20200902]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Srinivasa-Rao-Mandadapu/arm64-dts-qcom-sc7180-Add-lpass-cpu-node-for-I2S-driver/20200902-120555
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r021-20200902 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/qcom/sc7180.dtsi:687.31-32 syntax error
>> FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36734 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver
2020-09-02 4:04 [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver Srinivasa Rao Mandadapu
2020-09-02 13:58 ` kernel test robot
@ 2020-09-14 17:41 ` Doug Anderson
2020-09-18 11:51 ` Srinivasa Rao Mandadapu
1 sibling, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2020-09-14 17:41 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Rohit kumar, Srinivas Kandagatla, Ajit Pandey, Cheng-Yi Chiang
Hi,
On Tue, Sep 1, 2020 at 9:04 PM Srinivasa Rao Mandadapu
<srivasam@codeaurora.org> wrote:
>
> From: Ajit Pandey <ajitp@codeaurora.org>
>
> Add the I2S controller node to sc7180 dtsi.
> Add pinmux for primary and secondary I2S.
>
> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---
>
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 69 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index d46b383..db60ca5 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -676,6 +676,36 @@
> };
> };
>
> + lpass_cpu: lpass@62f00000 {
> + compatible = "qcom,sc7180-lpass-cpu";
> +
> + reg = <0 0x62f00000 0 0x29000>;
> + reg-names = "lpass-lpaif";
> +
> + iommus = <&apps_smmu 0x1020 0>;
> +
> + power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
> +
> + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>,
> + <&lpasscc LPASS_AUDIO_CORE_CORE_CLK>,
> + <&lpasscc LPASS_AUDIO_CORE_EXT_MCLK0_CLK>,
> + <&lpasscc LPASS_AUDIO_CORE_SYSNOC_MPORT_CORE_CLK>,
> + <&lpasscc LPASS_AUDIO_CORE_LPAIF_PRI_IBIT_CLK>,
> + <&lpasscc LPASS_AUDIO_CORE_LPAIF_SEC_IBIT_CLK>;
> +
> + clock-names = "pcnoc-sway-clk", "audio-core",
> + "mclk0", "pcnoc-mport-clk",
> + "mi2s-bit-clk0", "mi2s-bit-clk1";
> +
> +
> + #sound-dai-cells = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "lpass-irq-lpaif";
> + };
> +
> sdhc_1: sdhci@7c4000 {
Your node is still sorted incorrectly. Nodes with unit addresses
should be sorted numerically.
The number 0x62f00000 is greater than the number 0x7c4000. Thus your
node should not be placed above "sdhci@7c4000". It should be placed
somewhere further down in the file.
> compatible = "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5";
> reg = <0 0x7c4000 0 0x1000>,
> @@ -1721,6 +1751,45 @@
> };
> };
>
> + sec_mi2s_active: sec-mi2s-active {
> + pinmux {
> + pins = "gpio49", "gpio50", "gpio51";
> + function = "mi2s_1";
> + };
> +
> + pinconf {
> + pins = "gpio49", "gpio50", "gpio51";;
nit: double-semi-colon.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver
2020-09-14 17:41 ` Doug Anderson
@ 2020-09-18 11:51 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 4+ messages in thread
From: Srinivasa Rao Mandadapu @ 2020-09-18 11:51 UTC (permalink / raw)
To: Doug Anderson
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Rohit kumar, Srinivas Kandagatla, Ajit Pandey, Cheng-Yi Chiang
Thanks Mr. Doug for your time to review this patch!!
On 9/14/2020 11:11 PM, Doug Anderson wrote:
> Hi,
>
> On Tue, Sep 1, 2020 at 9:04 PM Srinivasa Rao Mandadapu
> <srivasam@codeaurora.org> wrote:
>> From: Ajit Pandey <ajitp@codeaurora.org>
>>
>> Add the I2S controller node to sc7180 dtsi.
>> Add pinmux for primary and secondary I2S.
>>
>> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
>> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> ---
>>
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 69 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 69 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index d46b383..db60ca5 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -676,6 +676,36 @@
>> };
>> };
>>
>> + lpass_cpu: lpass@62f00000 {
>> + compatible = "qcom,sc7180-lpass-cpu";
>> +
>> + reg = <0 0x62f00000 0 0x29000>;
>> + reg-names = "lpass-lpaif";
>> +
>> + iommus = <&apps_smmu 0x1020 0>;
>> +
>> + power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
>> +
>> + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_CORE_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_EXT_MCLK0_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_SYSNOC_MPORT_CORE_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_LPAIF_PRI_IBIT_CLK>,
>> + <&lpasscc LPASS_AUDIO_CORE_LPAIF_SEC_IBIT_CLK>;
>> +
>> + clock-names = "pcnoc-sway-clk", "audio-core",
>> + "mclk0", "pcnoc-mport-clk",
>> + "mi2s-bit-clk0", "mi2s-bit-clk1";
>> +
>> +
>> + #sound-dai-cells = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "lpass-irq-lpaif";
>> + };
>> +
>> sdhc_1: sdhci@7c4000 {
> Your node is still sorted incorrectly. Nodes with unit addresses
> should be sorted numerically.
>
> The number 0x62f00000 is greater than the number 0x7c4000. Thus your
> node should not be placed above "sdhci@7c4000". It should be placed
> somewhere further down in the file.
Will place it accordingly.
>
>
>> compatible = "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5";
>> reg = <0 0x7c4000 0 0x1000>,
>> @@ -1721,6 +1751,45 @@
>> };
>> };
>>
>> + sec_mi2s_active: sec-mi2s-active {
>> + pinmux {
>> + pins = "gpio49", "gpio50", "gpio51";
>> + function = "mi2s_1";
>> + };
>> +
>> + pinconf {
>> + pins = "gpio49", "gpio50", "gpio51";;
> nit: double-semi-colon.
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-18 11:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 4:04 [PATCH v2] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver Srinivasa Rao Mandadapu
2020-09-02 13:58 ` kernel test robot
2020-09-14 17:41 ` Doug Anderson
2020-09-18 11:51 ` Srinivasa Rao Mandadapu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).