linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
@ 2019-09-04  7:52 Jacky.Cao
  2019-09-04  7:54 ` Felipe Balbi
  0 siblings, 1 reply; 12+ messages in thread
From: Jacky.Cao @ 2019-09-04  7:52 UTC (permalink / raw)
  To: balbi, gregkh, linux-usb, linux-kernel; +Cc: Kento.A.Kobayashi, Jacky.Cao

The power budget for SuperSpeed mode should be 900 mA
according to USB3.0 specification, so set the power
budget to 900 mA for dummy_start_ss which is only used
for SuperSpeed mode.

If the max power consumption of SuperSpeed device is
larger than 500 mA, insufficient available bus power
error happens in usb_choose_configuration function
when the device connects to dummy hcd.

Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 8414fac..52f2cf5 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -48,6 +48,7 @@
#define DRIVER_VERSION "02 May 2005"

 #define POWER_BUDGET  500  /* in mA; use 8 for low-power port testing */
+#define POWER_BUDGET_3_0  900  /* in mA */

 static const char  driver_name[] = "dummy_hcd";
static const char  driver_desc[] = "USB Host+Gadget Emulator";
@@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
     dum_hcd->rh_state = DUMMY_RH_RUNNING;
     dum_hcd->stream_en_ep = 0;
     INIT_LIST_HEAD(&dum_hcd->urbp_list);
-     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
+     dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
     dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
     dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
#ifdef CONFIG_USB_OTG
-- 
2.7.4

^ permalink raw reply	[flat|nested] 12+ messages in thread
[parent not found: <16EA1F625E922C43B00B9D8225022050086ECF6A@APYOKXMS108.ap.sony.com>]

end of thread, other threads:[~2019-09-05  4:18 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <16EA1F625E922C43B00B9D82250220500871C7D7@APYOKXMS108.ap.sony.com>
2019-09-04  7:46 ` [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode Felipe Balbi
2019-09-04  7:54   ` Jacky.Cao
2019-09-04  7:52 Jacky.Cao
2019-09-04  7:54 ` Felipe Balbi
2019-09-04  7:58   ` Greg KH
2019-09-04  8:52     ` Jacky.Cao
2019-09-04 10:01       ` Greg KH
2019-09-04 14:21   ` Alan Stern
2019-09-05  4:18     ` Jacky.Cao
     [not found] <16EA1F625E922C43B00B9D8225022050086ECF6A@APYOKXMS108.ap.sony.com>
     [not found] ` <16EA1F625E922C43B00B9D8225022050086F86B4@APYOKXMS108.ap.sony.com>
2019-09-04  6:12   ` Kobayashi, Kento (Sony)
2019-09-04  6:19     ` Felipe Balbi
2019-09-04  6:57       ` Kobayashi, Kento (Sony)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).