linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Douglas Anderson <dianders@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
	Jason Wessel <jason.wessel@windriver.com>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Kees Cook <keescook@chromium.org>,
	kgdb-bugreport@lists.sourceforge.net,
	Johannes Weiner <hannes@cmpxchg.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Nicholas Mc Guire <hofrat@osadl.org>
Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary
Date: Thu, 11 Apr 2019 18:06:23 +0900	[thread overview]
Message-ID: <CAK7LNARYMy2=viA1et9tZk409M=OSteD5D675oAKQEs6SG77HQ@mail.gmail.com> (raw)
In-Reply-To: <20190323015227.245455-1-dianders@chromium.org>

Hi Andrew,


On Sat, Mar 23, 2019 at 10:55 AM Douglas Anderson <dianders@chromium.org> wrote:
>
> If you drop into kdb and type "summary", it prints out a line that
> says this:
>
>   ccversion  CCVERSION
>
> ...and I don't mean that it actually prints out the version of the C
> compiler.  It literally prints out the string "CCVERSION".
>
> The version of the C Compiler is already printed at boot up and it
> doesn't seem useful to replicate this in kdb.  Let's just delete it.
> We can also delete the bit of the Makefile that called the C compiler
> in an attempt to pass this into kdb.  This will remove one extra call
> to the C compiler at Makefile parse time and (very slightly) speed up
> builds.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>


I know you add lots of Cc: lines
when you pick up patches, but I think
your script can be improved.

You added "Cc: Douglas Anderson <dianders@chromium.org>",
but Douglas is the author.
I think the author should be excluded from Cc.




This commit looks as follows in linux-next:

commit 685dc1264544c947d26963dcf1ac982d3408f444
Author: Douglas Anderson <dianders@chromium.org>
Date:   Wed Apr 10 11:02:35 2019 +1000

    kdb: det rid of broken attempt to print CCVERSION in kdb summary

    If you drop into kdb and type "summary", it prints out a line that says
    this:

      ccversion  CCVERSION

    ...and I don't mean that it actually prints out the version of the C
    compiler.  It literally prints out the string "CCVERSION".

    The version of the C Compiler is already printed at boot up and it doesn't
    seem useful to replicate this in kdb.  Let's just delete it.  We can also
    delete the bit of the Makefile that called the C compiler in an attempt to
    pass this into kdb.  This will remove one extra call to the C compiler at
    Makefile parse time and (very slightly) speed up builds.

    Link: http://lkml.kernel.org/r/20190323015227.245455-1-dianders@chromium.org
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    Cc: Douglas Anderson <dianders@chromium.org>
    Cc: Jason Wessel <jason.wessel@windriver.com>
    Cc: Christophe Leroy <christophe.leroy@c-s.fr>
    Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
    Cc: Nicholas Mc Guire <hofrat@osadl.org>,
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>



> ---
>
>  kernel/debug/kdb/Makefile   | 1 -
>  kernel/debug/kdb/kdb_main.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/kernel/debug/kdb/Makefile b/kernel/debug/kdb/Makefile
> index d4fc58f4b88d..efac857c5511 100644
> --- a/kernel/debug/kdb/Makefile
> +++ b/kernel/debug/kdb/Makefile
> @@ -6,7 +6,6 @@
>  # Copyright (c) 2009 Wind River Systems, Inc. All Rights Reserved.
>  #
>
> -CCVERSION      := $(shell $(CC) -v 2>&1 | sed -ne '$$p')
>  obj-y := kdb_io.o kdb_main.o kdb_support.o kdb_bt.o gen-kdb_cmds.o kdb_bp.o kdb_debugger.o
>  obj-$(CONFIG_KDB_KEYBOARD)    += kdb_keyboard.o
>
> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
> index 82a3b32a7cfc..fc96dbf8d9de 100644
> --- a/kernel/debug/kdb/kdb_main.c
> +++ b/kernel/debug/kdb/kdb_main.c
> @@ -2522,7 +2522,6 @@ static int kdb_summary(int argc, const char **argv)
>         kdb_printf("machine    %s\n", init_uts_ns.name.machine);
>         kdb_printf("nodename   %s\n", init_uts_ns.name.nodename);
>         kdb_printf("domainname %s\n", init_uts_ns.name.domainname);
> -       kdb_printf("ccversion  %s\n", __stringify(CCVERSION));
>
>         now = __ktime_get_real_seconds();
>         time64_to_tm(now, 0, &tm);
> --
> 2.21.0.392.gf8f6787159e-goog
>


-- 
Best Regards
Masahiro Yamada

  parent reply	other threads:[~2019-04-11  9:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23  1:52 Douglas Anderson
2019-03-30 12:14 ` Masahiro Yamada
2019-04-11  9:06 ` Masahiro Yamada [this message]
2019-04-16 23:30   ` Andrew Morton
2019-04-17  6:37     ` Masahiro Yamada
2019-04-18 23:06       ` Andrew Morton
2019-04-19  3:28         ` Masahiro Yamada
2019-04-19 11:14           ` Joe Perches
2019-04-19 20:58             ` Andrew Morton
2019-04-20  3:57               ` Joe Perches
2019-05-06 14:28             ` Masahiro Yamada
2019-05-07 13:55               ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNARYMy2=viA1et9tZk409M=OSteD5D675oAKQEs6SG77HQ@mail.gmail.com' \
    --to=yamada.masahiro@socionext.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=gustavo@embeddedor.com \
    --cc=hannes@cmpxchg.org \
    --cc=hofrat@osadl.org \
    --cc=jason.wessel@windriver.com \
    --cc=keescook@chromium.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --subject='Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).