From: Joe Perches <joe@perches.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jason Wessel <jason.wessel@windriver.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Kees Cook <keescook@chromium.org>,
kgdb-bugreport@lists.sourceforge.net,
Johannes Weiner <hannes@cmpxchg.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Nicholas Mc Guire <hofrat@osadl.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary
Date: Fri, 19 Apr 2019 04:14:27 -0700 [thread overview]
Message-ID: <e5f29ca9b6067fff9ea68cb25e15906659cd51ad.camel@perches.com> (raw)
In-Reply-To: <CAK7LNAQe2uaVfKee1F6R4siVvUSCMgSaYAnUQfz8MS5PeFqpGA@mail.gmail.com>
On Fri, 2019-04-19 at 12:28 +0900, Masahiro Yamada wrote:
> Hi Joe,
>
> Can you detect redundant Cc: by checkpatch?
>
> Please see below in details.
> Thanks.
Yes, but I'm not sure why it's useful or necessary.
git send-email using some scripts elides duplicate email addresses
---
scripts/checkpatch.pl | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 1c421ac42b07..bedec83cb797 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2688,6 +2688,19 @@ sub process {
$signatures{$sig_nospace} = 1;
}
+# Check for a cc: line with another signature -by: by the same author
+ if ($sig_nospace =~ /^cc:/) {
+ my $sig_email = substr($sig_nospace, 3);
+ foreach my $sig (sort keys %signatures) {
+ next if ($sig =~ /^cc:/);
+ $sig =~ s/^[^:]+://;
+ if ($sig eq $sig_email) {
+ WARN("BAD_SIGN_OFF",
+ "Unnecessary CC: as there is another signature with the same name/email address\n" . $herecurr);
+ }
+ }
+ }
+
# Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
if ($sign_off =~ /^co-developed-by:$/i) {
if ($email eq $author) {
next prev parent reply other threads:[~2019-04-19 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 1:52 Douglas Anderson
2019-03-30 12:14 ` Masahiro Yamada
2019-04-11 9:06 ` Masahiro Yamada
2019-04-16 23:30 ` Andrew Morton
2019-04-17 6:37 ` Masahiro Yamada
2019-04-18 23:06 ` Andrew Morton
2019-04-19 3:28 ` Masahiro Yamada
2019-04-19 11:14 ` Joe Perches [this message]
2019-04-19 20:58 ` Andrew Morton
2019-04-20 3:57 ` Joe Perches
2019-05-06 14:28 ` Masahiro Yamada
2019-05-07 13:55 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f29ca9b6067fff9ea68cb25e15906659cd51ad.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@c-s.fr \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=hannes@cmpxchg.org \
--cc=hofrat@osadl.org \
--cc=jason.wessel@windriver.com \
--cc=keescook@chromium.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=yamada.masahiro@socionext.com \
--subject='Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).