From: Naga Sureshkumar Relli <nagasure@xilinx.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
"richard@nod.at" <richard@nod.at>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
Michal Simek <michals@xilinx.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nagasuresh12@gmail.com" <nagasuresh12@gmail.com>,
"robh@kernel.org" <robh@kernel.org>
Subject: RE: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation
Date: Fri, 9 Nov 2018 13:19:28 +0000 [thread overview]
Message-ID: <MWHPR02MB2623087507F40BAF55D0FA98AFC60@MWHPR02MB2623.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20181109135405.3b93b267@xps13>
Hi Miquel,
> -----Original Message-----
> From: Miquel Raynal [mailto:miquel.raynal@bootlin.com]
> Sent: Friday, November 9, 2018 6:24 PM
> To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>; richard@nod.at; dwmw2@infradead.org;
> computersforpeace@gmail.com; marek.vasut@gmail.com; Michal Simek
> <michals@xilinx.com>; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org;
> nagasuresh12@gmail.com; robh@kernel.org
> Subject: Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding
> documentation
>
> Hi Naga,
>
> [...]
>
> > > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > > > b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > > > new file mode 100644
> > > > index 0000000..b522daf
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > > > @@ -0,0 +1,32 @@
> > > > +Arasan NAND Flash Controller with ONFI 3.1 support
> > > > +
> > > > +Required properties:
> > > > +- compatible: Should be "xlnx,zynqmp-nand", "arasan,nfc-v3p10"
> > > > +- reg: Memory map for module access
> > > > +- interrupts: Should contain the interrupt for the device
> > > > +- clock-name: List of input clocks - "sys", "flash"
> > > > + (See clock bindings for details)
> > > > +- clocks: Clock phandles (see clock bindings for details)
> > > > +
> > > > +Required properties for child node:
> > > > +- nand-ecc-mode: see nand.txt
> > >
> > > Why is it required? Can't you fallback to HW when this prop is missing?
> > Yes, we can.
> > Do you want me to update that in driver now?
> > Looks like you have some comments in driver as well, so while
> > addressing those I will update the code to fallback to HW ECC when It is missing.
>
> Yes, please.
>
> >
> > > Oh, and reg is not listed in the required props.
> > Which reg?
> > I already mention this " reg: Memory map for module access " in required properties.
> >
> > Thanks,
> > Naga Sureshkumar Relli
> > >
> > > > +
> > > > +For NAND partition information please refer the below file
> > > > +Documentation/devicetree/bindings/mtd/partition.txt
> > > > +
> > > > +Example:
> > > > + nfc: nand@ff100000 {
> > > > + compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10";
> > > > + reg = <0x0 0xff100000 0x1000>;
> > > > + clock-name = "sys", "flash";
> > > > + clocks = <&misc_clk &misc_clk>;
> > > > + interrupt-parent = <&gic>;
> > > > + interrupts = <0 14 4>;
> > > > + #address-cells = <1>;
> > > > + #size-cells = <0>;
> > > > +
> > > > + nand@0 {
> > > > + reg = <0>;
>
> This one, for the CS line(s).
Ok got it. I will update.
Thanks,
Naga Sureshkumar Relli
>
> > > > + nand-ecc-mode = "hw";
> > > > + };
> > > > + };
> >
>
>
> Thanks,
> Miquèl
next prev parent reply other threads:[~2018-11-09 13:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 5:00 [LINUX PATCH v12 0/3] Add support for Arasan NAND Flash controller Naga Sureshkumar Relli
2018-11-09 5:00 ` [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation Naga Sureshkumar Relli
2018-11-09 6:28 ` Boris Brezillon
2018-11-09 12:33 ` Naga Sureshkumar Relli
2018-11-09 12:54 ` Miquel Raynal
2018-11-09 13:19 ` Naga Sureshkumar Relli [this message]
2018-11-16 11:50 ` Martin Lund
2018-11-16 12:10 ` Martin Lund
2018-11-16 12:33 ` Michal Simek
2018-11-16 13:50 ` Naga Sureshkumar Relli
2018-11-16 14:22 ` Martin Lund
2018-11-09 5:00 ` [LINUX PATCH v12 2/3] mtd: rawnand: Add an option to get sdr timing mode number Naga Sureshkumar Relli
2018-11-09 5:00 ` [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Naga Sureshkumar Relli
2018-11-09 8:07 ` Boris Brezillon
2018-11-09 13:18 ` Naga Sureshkumar Relli
2018-11-09 23:03 ` kbuild test robot
2018-11-12 10:55 ` Martin Lund
2018-11-12 10:58 ` Boris Brezillon
2018-11-12 12:43 ` Naga Sureshkumar Relli
2018-11-15 9:34 ` Naga Sureshkumar Relli
2018-11-18 18:52 ` Miquel Raynal
2018-11-18 19:43 ` Boris Brezillon
2018-11-19 6:20 ` Naga Sureshkumar Relli
2018-11-19 8:02 ` Boris Brezillon
2018-11-20 7:02 ` Naga Sureshkumar Relli
2018-11-20 11:02 ` Boris Brezillon
2018-11-20 12:36 ` Miquel Raynal
2018-11-23 13:53 ` Naga Sureshkumar Relli
2018-12-12 5:27 ` Naga Sureshkumar Relli
2018-12-12 8:11 ` Miquel Raynal
2018-12-12 9:04 ` Naga Sureshkumar Relli
2018-12-12 9:09 ` Miquel Raynal
2018-12-12 13:07 ` Naga Sureshkumar Relli
2018-12-12 13:18 ` Miquel Raynal
2018-12-17 13:21 ` Naga Sureshkumar Relli
2018-12-17 16:41 ` Miquel Raynal
2018-12-18 5:33 ` Naga Sureshkumar Relli
2018-12-19 14:26 ` Miquel Raynal
2018-12-21 7:36 ` Naga Sureshkumar Relli
2019-01-28 6:04 ` Naga Sureshkumar Relli
2019-01-28 9:27 ` Miquel Raynal
2019-01-28 9:35 ` Naga Sureshkumar Relli
2019-06-19 4:44 ` Naga Sureshkumar Relli
2019-06-27 16:27 ` Miquel Raynal
2019-06-28 4:20 ` Naga Sureshkumar Relli
2018-11-15 16:45 ` Dan Carpenter
2018-11-20 16:24 ` Boris Brezillon
2018-12-04 9:18 ` Naga Sureshkumar Relli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR02MB2623087507F40BAF55D0FA98AFC60@MWHPR02MB2623.namprd02.prod.outlook.com \
--to=nagasure@xilinx.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=michals@xilinx.com \
--cc=miquel.raynal@bootlin.com \
--cc=nagasuresh12@gmail.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).