From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: Nitesh Narayan Lal <nitesh@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, x86@kernel.org, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, pbonzini@redhat.com,
tglx@linutronix.de, akpm@linux-foundation.org,
Luiz Capitulino <lcapitulino@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [RFC PATCH 0/4] kvm: Report unused guest pages to host
Date: Thu, 07 Feb 2019 08:56:00 -0800 [thread overview]
Message-ID: <d28e5bc95cfc18ca8c97e28459692fdd967d52d3.camel@linux.intel.com> (raw)
In-Reply-To: <e0bf61d2-c315-ae4f-6ddb-93b7882fd13f@redhat.com>
On Thu, 2019-02-07 at 09:48 -0500, Nitesh Narayan Lal wrote:
> On 2/4/19 1:15 PM, Alexander Duyck wrote:
> > This patch set provides a mechanism by which guests can notify the host of
> > pages that are not currently in use. Using this data a KVM host can more
> > easily balance memory workloads between guests and improve overall system
> > performance by avoiding unnecessary writing of unused pages to swap.
> >
> > In order to support this I have added a new hypercall to provided unused
> > page hints and made use of mechanisms currently used by PowerPC and s390
> > architectures to provide those hints. To reduce the overhead of this call
> > I am only using it per huge page instead of of doing a notification per 4K
> > page. By doing this we can avoid the expense of fragmenting higher order
> > pages, and reduce overall cost for the hypercall as it will only be
> > performed once per huge page.
> >
> > Because we are limiting this to huge pages it was necessary to add a
> > secondary location where we make the call as the buddy allocator can merge
> > smaller pages into a higher order huge page.
> >
> > This approach is not usable in all cases. Specifically, when KVM direct
> > device assignment is used, the memory for a guest is permanently assigned
> > to physical pages in order to support DMA from the assigned device. In
> > this case we cannot give the pages back, so the hypercall is disabled by
> > the host.
> >
> > Another situation that can lead to issues is if the page were accessed
> > immediately after free. For example, if page poisoning is enabled the
> > guest will populate the page *after* freeing it. In this case it does not
> > make sense to provide a hint about the page being freed so we do not
> > perform the hypercalls from the guest if this functionality is enabled.
>
> Hi Alexander,
>
> Did you get a chance to look at my v8 posting of Guest Free Page Hinting
> [1]?
> Considering both the solutions are trying to solve the same problem. It
> will be great if we can collaborate and come up with a unified solution.
>
> [1] https://lkml.org/lkml/2019/2/4/993
I haven't had a chance to review these yet.
I'll try to take a look later today and provide review notes based on
what I find.
Thanks.
- Alex
next prev parent reply other threads:[~2019-02-07 16:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 18:15 [RFC PATCH 0/4] kvm: Report unused guest pages to host Alexander Duyck
2019-02-04 18:15 ` [RFC PATCH 1/4] madvise: Expose ability to set dontneed from kernel Alexander Duyck
2019-02-04 18:15 ` [RFC PATCH 2/4] kvm: Add host side support for free memory hints Alexander Duyck
2019-02-10 0:44 ` Michael S. Tsirkin
2019-02-11 17:34 ` Alexander Duyck
2019-02-11 17:36 ` Michael S. Tsirkin
2019-02-11 17:41 ` Dave Hansen
2019-02-11 17:48 ` Michael S. Tsirkin
2019-02-11 18:30 ` Alexander Duyck
2019-02-11 19:24 ` Michael S. Tsirkin
2019-02-04 18:15 ` [RFC PATCH 3/4] kvm: Add guest " Alexander Duyck
2019-02-04 19:44 ` Dave Hansen
2019-02-04 20:42 ` Alexander Duyck
2019-02-04 23:00 ` Nadav Amit
2019-02-04 23:37 ` Alexander Duyck
2019-02-05 0:03 ` Nadav Amit
2019-02-05 0:16 ` Alexander Duyck
2019-02-05 1:46 ` Nadav Amit
2019-02-05 18:09 ` Alexander Duyck
2019-02-07 18:21 ` Luiz Capitulino
2019-02-07 18:44 ` Alexander Duyck
2019-02-07 20:02 ` Luiz Capitulino
2019-02-08 21:05 ` Nitesh Narayan Lal
2019-02-08 21:31 ` Alexander Duyck
2019-02-10 0:49 ` Michael S. Tsirkin
2019-02-11 16:31 ` Alexander Duyck
2019-02-11 17:36 ` Michael S. Tsirkin
2019-02-11 18:10 ` Alexander Duyck
2019-02-11 19:54 ` Michael S. Tsirkin
2019-02-11 21:00 ` Alexander Duyck
2019-02-11 22:52 ` Michael S. Tsirkin
[not found] ` <94462313ccd927d25675f69de459456cf066c1a2.camel@linux.intel.com>
2019-02-12 0:34 ` Michael S. Tsirkin
2019-02-11 17:48 ` Dave Hansen
2019-02-11 17:58 ` Michael S. Tsirkin
2019-02-11 18:19 ` Dave Hansen
2019-02-11 19:56 ` Michael S. Tsirkin
2019-02-04 18:15 ` [RFC PATCH 4/4] mm: Add merge page notifier Alexander Duyck
2019-02-04 19:40 ` Dave Hansen
2019-02-04 19:51 ` Alexander Duyck
2019-02-10 0:57 ` Michael S. Tsirkin
2019-02-11 13:30 ` Nitesh Narayan Lal
2019-02-11 14:17 ` Michael S. Tsirkin
2019-02-11 16:24 ` Nitesh Narayan Lal
2019-02-11 17:41 ` Michael S. Tsirkin
2019-02-11 18:09 ` Nitesh Narayan Lal
2019-02-11 6:40 ` Aaron Lu
2019-02-11 15:58 ` Alexander Duyck
2019-02-12 2:09 ` Aaron Lu
2019-02-12 17:20 ` Alexander Duyck
2019-02-04 18:19 ` [RFC PATCH QEMU] i386/kvm: Enable paravirtual unused page hint mechanism Alexander Duyck
2019-02-05 17:25 ` [RFC PATCH 0/4] kvm: Report unused guest pages to host Nitesh Narayan Lal
2019-02-05 18:43 ` Alexander Duyck
2019-02-07 14:48 ` Nitesh Narayan Lal
2019-02-07 16:56 ` Alexander Duyck [this message]
2019-02-10 0:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d28e5bc95cfc18ca8c97e28459692fdd967d52d3.camel@linux.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=bp@alien8.de \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=nitesh@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).