* [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie
@ 2022-11-24 3:57 Owen Yang
2022-11-24 3:57 ` [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie Owen Yang
[not found] ` <CAPao8GK93KMrtaXw7mNWOCE60zk=uCENLfBXhNRVxJXEnnaGFg@mail.gmail.com>
0 siblings, 2 replies; 11+ messages in thread
From: Owen Yang @ 2022-11-24 3:57 UTC (permalink / raw)
To: LKML
Cc: Bob Moragues, Krzysztof Kozlowski, Stephen Boyd, Harvey,
Douglas Anderson, Matthias Kaehlcke, Owen Yang, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-msm
Add an entry in the device tree binding for sc7280-zombie.
Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
---
Changes in v4:
- Dropping the redundant 'DT binding for' as requested by Krzysztof. v4.
- Adding an empty line here before "/dts-v1/;" in "sc7280-herobrine-zombie-lte.dts", "sc7280-herobrine-zombie.dts" as requested by Matthias. v4.
- Deleteing "/dts-v1/;" in "sc7280-herobrine-zombie.dtsi" as requested by Matthias. v4.
- Droping changing file path in description. v3. as requested by Matthias. v3.
- Changing Patch order, binding patch first and dt file second, as requested by Douglas. v2.
- Adding "arm64: dts: qcom: sc7280:" in dt patch ${SUBJECT}, as requested by Douglas. v2.
- Adding "dt-bindings: arm: qcom:" in bind patch ${SUBJECT}, as requested by Douglas. v2.
- Adding '#include "sc7280-herobrine-wifi-sku.dtsi"' in sc7280-herobrine-zombie.dts, as requested by Douglas. v2.
- Adding "(newest rev)" for zombie entry description in qcom.yaml, as requested by Douglas. v2.
- Adding "post-power-on-delay-ms = <100>;" for trackpad in "sc7280-herobrine-zombie.dtsi". v2
- Changing "vcc-supply" to "vdd-supply" for trackpad in "sc7280-herobrine-zombie.dtsi", as requested by Douglas. v2.
Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 463509f0f23a..7ec6240311db 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -655,6 +655,16 @@ properties:
- const: google,villager-sku512
- const: qcom,sc7280
+ - description: Google Zombie (newest rev)
+ items:
+ - const: google,zombie
+ - const: qcom,sc7280
+
+ - description: Google Zombie with LTE (newest rev)
+ items:
+ - const: google,zombie-sku512
+ - const: qcom,sc7280
+
- items:
- enum:
- lenovo,flex-5g
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie 2022-11-24 3:57 [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie Owen Yang @ 2022-11-24 3:57 ` Owen Yang [not found] ` <CAPao8GK93KMrtaXw7mNWOCE60zk=uCENLfBXhNRVxJXEnnaGFg@mail.gmail.com> 1 sibling, 0 replies; 11+ messages in thread From: Owen Yang @ 2022-11-24 3:57 UTC (permalink / raw) To: LKML Cc: Bob Moragues, Krzysztof Kozlowski, Stephen Boyd, Harvey, Douglas Anderson, Matthias Kaehlcke, Owen Yang, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm Add DT for sc7280-herobrine-zombie Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com> --- (no changes since v1) arch/arm64/boot/dts/qcom/Makefile | 2 + .../dts/qcom/sc7280-herobrine-zombie-lte.dts | 16 + .../boot/dts/qcom/sc7280-herobrine-zombie.dts | 16 + .../dts/qcom/sc7280-herobrine-zombie.dtsi | 309 ++++++++++++++++++ 4 files changed, 343 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index afe496a93f94..7b0644a39062 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -114,6 +114,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1-lte.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts new file mode 100644 index 000000000000..c9fe64529555 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts @@ -0,0 +1,16 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Zombie board device tree source + * + * Copyright 2022 Google LLC. + */ + +/dts-v1/; + +#include "sc7280-herobrine-zombie.dtsi" +#include "sc7280-herobrine-lte-sku.dtsi" + +/ { + model = "Google Zombie with LTE"; + compatible = "google,zombie-sku512", "qcom,sc7280"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts new file mode 100644 index 000000000000..0246c12b2f40 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts @@ -0,0 +1,16 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Zombie board device tree source + * + * Copyright 2022 Google LLC. + */ + +/dts-v1/; + +#include "sc7280-herobrine-zombie.dtsi" +#include "sc7280-herobrine-wifi-sku.dtsi" + +/ { + model = "Google Zombie"; + compatible = "google,zombie", "qcom,sc7280"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi new file mode 100644 index 000000000000..3de03602e1f7 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi @@ -0,0 +1,309 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Zombie board device tree source + * + * Copyright 2022 Google LLC. + */ + +#include "sc7280-herobrine.dtsi" +#include "sc7280-herobrine-audio-rt5682.dtsi" + +/* + * ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES + * + * Sort order matches the order in the parent files (parents before children). + */ + +&pp3300_codec { + status = "okay"; +}; + +/* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */ + +ap_tp_i2c: &i2c0 { + clock-frequency = <400000>; + status = "okay"; + + trackpad: trackpad@15 { + compatible = "hid-over-i2c"; + reg = <0x15>; + pinctrl-names = "default"; + pinctrl-0 = <&tp_int_odl>; + + interrupt-parent = <&tlmm>; + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; + + hid-descr-addr = <0x01>; + vdd-supply = <&pp3300_z1>; + post-power-on-delay-ms = <100>; + + wakeup-source; + }; +}; + +&ap_sar_sensor_i2c { + status = "okay"; +}; + +&ap_sar_sensor0 { + status = "okay"; +}; + +&ap_sar_sensor1 { + status = "okay"; +}; + +&mdss_edp { + status = "okay"; +}; + +&mdss_edp_phy { + status = "okay"; +}; + +/* For nvme */ +&pcie1 { + status = "okay"; +}; + +/* For nvme */ +&pcie1_phy { + status = "okay"; +}; + +&pwmleds { + status = "okay"; +}; + +/* For eMMC */ +&sdhc_1 { + status = "okay"; +}; + +/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */ + +&ts_rst_conn { + bias-disable; +}; + +/* PINCTRL - BOARD-SPECIFIC */ + +/* + * Methodology for gpio-line-names: + * - If a pin goes to herobrine board and is named it gets that name. + * - If a pin goes to herobrine board and is not named, it gets no name. + * - If a pin is totally internal to Qcard then it gets Qcard name. + * - If a pin is not hooked up on Qcard, it gets no name. + */ + +&pm8350c_gpios { + gpio-line-names = "FLASH_STROBE_1", /* 1 */ + "AP_SUSPEND", + "PM8008_1_RST_N", + "", + "", + "", + "PMIC_EDP_BL_EN", + "PMIC_EDP_BL_PWM", + ""; +}; + +&tlmm { + gpio-line-names = "AP_TP_I2C_SDA", /* 0 */ + "AP_TP_I2C_SCL", + "SSD_RST_L", + "PE_WAKE_ODL", + "AP_SAR_SDA", + "AP_SAR_SCL", + "PRB_SC_GPIO_6", + "TP_INT_ODL", + "HP_I2C_SDA", + "HP_I2C_SCL", + + "GNSS_L1_EN", /* 10 */ + "GNSS_L5_EN", + "SPI_AP_MOSI", + "SPI_AP_MISO", + "SPI_AP_CLK", + "SPI_AP_CS0_L", + /* + * AP_FLASH_WP is crossystem ABI. Schematics + * call it BIOS_FLASH_WP_OD. + */ + "AP_FLASH_WP", + "", + "AP_EC_INT_L", + "", + + "UF_CAM_RST_L", /* 20 */ + "WF_CAM_RST_L", + "UART_AP_TX_DBG_RX", + "UART_DBG_TX_AP_RX", + "", + "PM8008_IRQ_1", + "HOST2WLAN_SOL", + "WLAN2HOST_SOL", + "MOS_BT_UART_CTS", + "MOS_BT_UART_RFR", + + "MOS_BT_UART_TX", /* 30 */ + "MOS_BT_UART_RX", + "PRB_SC_GPIO_32", + "HUB_RST_L", + "", + "", + "AP_SPI_FP_MISO", + "AP_SPI_FP_MOSI", + "AP_SPI_FP_CLK", + "AP_SPI_FP_CS_L", + + "AP_EC_SPI_MISO", /* 40 */ + "AP_EC_SPI_MOSI", + "AP_EC_SPI_CLK", + "AP_EC_SPI_CS_L", + "LCM_RST_L", + "EARLY_EUD_N", + "", + "DP_HOT_PLUG_DET", + "IO_BRD_MLB_ID0", + "IO_BRD_MLB_ID1", + + "IO_BRD_MLB_ID2", /* 50 */ + "SSD_EN", + "TS_I2C_SDA_CONN", + "TS_I2C_CLK_CONN", + "TS_RST_CONN", + "TS_INT_CONN", + "AP_I2C_TPM_SDA", + "AP_I2C_TPM_SCL", + "PRB_SC_GPIO_58", + "PRB_SC_GPIO_59", + + "EDP_HOT_PLUG_DET_N", /* 60 */ + "FP_TO_AP_IRQ_L", + "", + "AMP_EN", + "CAM0_MCLK_GPIO_64", + "CAM1_MCLK_GPIO_65", + "WF_CAM_MCLK", + "PRB_SC_GPIO_67", + "FPMCU_BOOT0", + "UF_CAM_SDA", + + "UF_CAM_SCL", /* 70 */ + "", + "", + "WF_CAM_SDA", + "WF_CAM_SCL", + "", + "", + "EN_FP_RAILS", + "FP_RST_L", + "PCIE1_CLKREQ_ODL", + + "EN_PP3300_DX_EDP", /* 80 */ + "US_EURO_HS_SEL", + "FORCED_USB_BOOT", + "WCD_RESET_N", + "MOS_WLAN_EN", + "MOS_BT_EN", + "MOS_SW_CTRL", + "MOS_PCIE0_RST", + "MOS_PCIE0_CLKREQ_N", + "MOS_PCIE0_WAKE_N", + + "MOS_LAA_AS_EN", /* 90 */ + "SD_CD_ODL", + "", + "", + "MOS_BT_WLAN_SLIMBUS_CLK", + "MOS_BT_WLAN_SLIMBUS_DAT0", + "HP_MCLK", + "HP_BCLK", + "HP_DOUT", + "HP_DIN", + + "HP_LRCLK", /* 100 */ + "HP_IRQ", + "", + "", + "GSC_AP_INT_ODL", + "EN_PP3300_CODEC", + "AMP_BCLK", + "AMP_DIN", + "AMP_LRCLK", + "UIM1_DATA_GPIO_109", + + "UIM1_CLK_GPIO_110", /* 110 */ + "UIM1_RESET_GPIO_111", + "PRB_SC_GPIO_112", + "UIM0_DATA", + "UIM0_CLK", + "UIM0_RST", + "UIM0_PRESENT_ODL", + "SDM_RFFE0_CLK", + "SDM_RFFE0_DATA", + "WF_CAM_EN", + + "FASTBOOT_SEL_0", /* 120 */ + "SC_GPIO_121", + "FASTBOOT_SEL_1", + "SC_GPIO_123", + "FASTBOOT_SEL_2", + "SM_RFFE4_CLK_GRFC_8", + "SM_RFFE4_DATA_GRFC_9", + "WLAN_COEX_UART1_RX", + "WLAN_COEX_UART1_TX", + "PRB_SC_GPIO_129", + + "LCM_ID0", /* 130 */ + "LCM_ID1", + "", + "SDR_QLINK_REQ", + "SDR_QLINK_EN", + "QLINK0_WMSS_RESET_N", + "SMR526_QLINK1_REQ", + "SMR526_QLINK1_EN", + "SMR526_QLINK1_WMSS_RESET_N", + "PRB_SC_GPIO_139", + + "SAR1_IRQ_ODL", /* 140 */ + "SAR0_IRQ_ODL", + "PRB_SC_GPIO_142", + "", + "WCD_SWR_TX_CLK", + "WCD_SWR_TX_DATA0", + "WCD_SWR_TX_DATA1", + "WCD_SWR_RX_CLK", + "WCD_SWR_RX_DATA0", + "WCD_SWR_RX_DATA1", + + "DMIC01_CLK", /* 150 */ + "DMIC01_DATA", + "DMIC23_CLK", + "DMIC23_DATA", + "", + "", + "EC_IN_RW_ODL", + "HUB_EN", + "WCD_SWR_TX_DATA2", + "", + + "", /* 160 */ + "", + "", + "", + "", + "", + "", + "", + "", + "", + + "", /* 170 */ + "MOS_BLE_UART_TX", + "MOS_BLE_UART_RX", + "", + "", + ""; +}; -- 2.17.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <CAPao8GK93KMrtaXw7mNWOCE60zk=uCENLfBXhNRVxJXEnnaGFg@mail.gmail.com>]
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie [not found] ` <CAPao8GK93KMrtaXw7mNWOCE60zk=uCENLfBXhNRVxJXEnnaGFg@mail.gmail.com> @ 2022-11-24 9:29 ` Krzysztof Kozlowski [not found] ` <CAPao8GKbdK79Z7w91x0T6JW9v6VFoeYSaXGGAuzB_=ukR9g0_w@mail.gmail.com> 2022-11-28 15:51 ` Doug Anderson 0 siblings, 2 replies; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-24 9:29 UTC (permalink / raw) To: 楊宗翰, LKML Cc: Bob Moragues, Stephen Boyd, Harvey, Douglas Anderson, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang On 24/11/2022 05:30, 楊宗翰 wrote: > Hi Reviewers, > > I really appreciate your kind guide for this task, Matthias is right, I am > newer to upstream kernel development. > There are a lot of thing I need to learn, so I just try my best do not ask > stupid questions. (please forgive me) > > 1. > Because I missed V2, V3 changed log, so I supply in V4 commit, and using V# > to note which version's change. > > 2. > I notice Kryzysztof say he didn't in cc mail loop at beggin, and below is > my updated mail list: > --- > Series-to: LKML <linux-kernel@vger.kernel.org> > Series-cc: Douglas Anderson <dianders@chromium.org> > Series-cc: Bob Moragues <moragues@chromium.org> > Series-cc: Harvey <hunge@google.com> > Series-cc: Stephen Boyd <swboyd@chromium.org> > Series-cc: Matthias Kaehlcke <mka@chromium.org> > Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Is there anyone I missed? These are not correct addresses and not complete list of them. Don't invent the entries, don't add there some weird addresses. Use get_maintainers.pl. That's it. Nothing more, nothing less. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CAPao8GKbdK79Z7w91x0T6JW9v6VFoeYSaXGGAuzB_=ukR9g0_w@mail.gmail.com>]
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie [not found] ` <CAPao8GKbdK79Z7w91x0T6JW9v6VFoeYSaXGGAuzB_=ukR9g0_w@mail.gmail.com> @ 2022-11-24 11:27 ` Krzysztof Kozlowski 2022-11-28 15:56 ` Doug Anderson 0 siblings, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-24 11:27 UTC (permalink / raw) To: 楊宗翰 Cc: LKML, Bob Moragues, Stephen Boyd, Harvey, Douglas Anderson, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang On 24/11/2022 12:20, 楊宗翰 wrote: > Hi Krzysztof, Matthias, > > How to use "get_maintainers.pl"? > > I find this script in path "<MyCodebase>/kernel/v5.15/script", and output This looks like v5.15 kernel which is heavily outdated. Please never work on such kernels when interacting with upstream. The rule is you work on either last mainline kernel (v6.1-rc6), maintainers for-next branch (you should know who is the maintainer of subsystem you submit to, get_maintainers.pl gives this information) or on moderately recent linux-next. For bigger patchsets there might be exceptions for these rules, but it's not the case here. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie 2022-11-24 11:27 ` Krzysztof Kozlowski @ 2022-11-28 15:56 ` Doug Anderson 2022-11-28 17:22 ` Krzysztof Kozlowski 0 siblings, 1 reply; 11+ messages in thread From: Doug Anderson @ 2022-11-28 15:56 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: 楊宗翰, LKML, Bob Moragues, Stephen Boyd, Harvey, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang Hi, On Thu, Nov 24, 2022 at 3:27 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 24/11/2022 12:20, 楊宗翰 wrote: > > Hi Krzysztof, Matthias, > > > > How to use "get_maintainers.pl"? > > > > I find this script in path "<MyCodebase>/kernel/v5.15/script", and output > > This looks like v5.15 kernel which is heavily outdated. Please never > work on such kernels when interacting with upstream. The rule is you > work on either last mainline kernel (v6.1-rc6), maintainers for-next > branch (you should know who is the maintainer of subsystem you submit > to, get_maintainers.pl gives this information) or on moderately recent > linux-next. For bigger patchsets there might be exceptions for these > rules, but it's not the case here. Just to add context here, it's a fairly standard workflow for ChromeOS kernel engineers to work in a "versioned" kernel directory but still checkout and work with the upstream kernel. I'm sure it's confusing to anyone not used to working with the ChromeOS source tree and build system. Sorry! :( So the fact that Owen is in a directory called "v5.15" doesn't mean that he's actually working with the v5.15 kernel. The fact that Bjorn's address is correct in his CC list implies to me that he's actually got a proper upstream kernel. I had previously [0] instructed Owen to send against Bjorn's tree, so hopefully it's correct. [0] https://lore.kernel.org/r/CAD=FV=Vd4UFabWeEsd7cDhhpnFkjTuYhc38zwAbfyxq2AHnhYA@mail.gmail.com/ -Doug ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie 2022-11-28 15:56 ` Doug Anderson @ 2022-11-28 17:22 ` Krzysztof Kozlowski 2022-11-28 17:41 ` Matthias Kaehlcke 2022-11-28 18:55 ` Doug Anderson 0 siblings, 2 replies; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-28 17:22 UTC (permalink / raw) To: Doug Anderson Cc: 楊宗翰, LKML, Bob Moragues, Stephen Boyd, Harvey, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang On 28/11/2022 16:56, Doug Anderson wrote: > Hi, > > On Thu, Nov 24, 2022 at 3:27 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 24/11/2022 12:20, 楊宗翰 wrote: >>> Hi Krzysztof, Matthias, >>> >>> How to use "get_maintainers.pl"? >>> >>> I find this script in path "<MyCodebase>/kernel/v5.15/script", and output >> >> This looks like v5.15 kernel which is heavily outdated. Please never >> work on such kernels when interacting with upstream. The rule is you >> work on either last mainline kernel (v6.1-rc6), maintainers for-next >> branch (you should know who is the maintainer of subsystem you submit >> to, get_maintainers.pl gives this information) or on moderately recent >> linux-next. For bigger patchsets there might be exceptions for these >> rules, but it's not the case here. > > Just to add context here, it's a fairly standard workflow for ChromeOS > kernel engineers to work in a "versioned" kernel directory but still > checkout and work with the upstream kernel. I'm sure it's confusing to > anyone not used to working with the ChromeOS source tree and build > system. Sorry! :( So the fact that Owen is in a directory called > "v5.15" doesn't mean that he's actually working with the v5.15 kernel. > The fact that Bjorn's address is correct in his CC list implies to me > that he's actually got a proper upstream kernel. > > I had previously [0] instructed Owen to send against Bjorn's tree, so > hopefully it's correct. If it was on Bjorn's tree, get_maintainers.pl would not produce such result: --- Series-to: LKML <linux-kernel@vger.kernel.org> Series-cc: Douglas Anderson <dianders@chromium.org> Series-cc: Bob Moragues <moragues@chromium.org> Series-cc: Harvey <hunge@google.com> Series-cc: Stephen Boyd <swboyd@chromium.org> Series-cc: Matthias Kaehlcke <mka@chromium.org> Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- or this: --- owen@buildsvr-HP-ProDesk-600-G4-MT:~/chromebook_zombie_os/src/third_party/kernel/v5.15$ perl scripts/get_maintainer.pl -f MAINTAINERS --email linux-kernel@vger.kernel.org (open list) --- as Owen indicated earlier. They are either incomplete or not correct. Of course I don't know whether the base tree is the problem or usage of get_maintainers.pl... Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie 2022-11-28 17:22 ` Krzysztof Kozlowski @ 2022-11-28 17:41 ` Matthias Kaehlcke 2022-11-28 18:55 ` Doug Anderson 1 sibling, 0 replies; 11+ messages in thread From: Matthias Kaehlcke @ 2022-11-28 17:41 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Doug Anderson, 楊宗翰, LKML, Bob Moragues, Stephen Boyd, Harvey, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang On Mon, Nov 28, 2022 at 06:22:39PM +0100, Krzysztof Kozlowski wrote: > On 28/11/2022 16:56, Doug Anderson wrote: > > Hi, > > > > On Thu, Nov 24, 2022 at 3:27 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 24/11/2022 12:20, 楊宗翰 wrote: > >>> Hi Krzysztof, Matthias, > >>> > >>> How to use "get_maintainers.pl"? > >>> > >>> I find this script in path "<MyCodebase>/kernel/v5.15/script", and output > >> > >> This looks like v5.15 kernel which is heavily outdated. Please never > >> work on such kernels when interacting with upstream. The rule is you > >> work on either last mainline kernel (v6.1-rc6), maintainers for-next > >> branch (you should know who is the maintainer of subsystem you submit > >> to, get_maintainers.pl gives this information) or on moderately recent > >> linux-next. For bigger patchsets there might be exceptions for these > >> rules, but it's not the case here. > > > > Just to add context here, it's a fairly standard workflow for ChromeOS > > kernel engineers to work in a "versioned" kernel directory but still > > checkout and work with the upstream kernel. I'm sure it's confusing to > > anyone not used to working with the ChromeOS source tree and build > > system. Sorry! :( So the fact that Owen is in a directory called > > "v5.15" doesn't mean that he's actually working with the v5.15 kernel. > > The fact that Bjorn's address is correct in his CC list implies to me > > that he's actually got a proper upstream kernel. > > > > I had previously [0] instructed Owen to send against Bjorn's tree, so > > hopefully it's correct. > > If it was on Bjorn's tree, get_maintainers.pl would not produce such result: > > --- > Series-to: LKML <linux-kernel@vger.kernel.org> > Series-cc: Douglas Anderson <dianders@chromium.org> > Series-cc: Bob Moragues <moragues@chromium.org> > Series-cc: Harvey <hunge@google.com> > Series-cc: Stephen Boyd <swboyd@chromium.org> > Series-cc: Matthias Kaehlcke <mka@chromium.org> > Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> These look like manual entries for patman > or this: > > --- > owen@buildsvr-HP-ProDesk-600-G4-MT:~/chromebook_zombie_os/src/third_party/kernel/v5.15$ > perl scripts/get_maintainer.pl -f MAINTAINERS --email > linux-kernel@vger.kernel.org (open list) > --- > > as Owen indicated earlier. They are either incomplete or not correct. > > Of course I don't know whether the base tree is the problem or usage of > get_maintainers.pl... That looks like an operator error, the above command produces the same result with an upstream tree. Issue one is the use of '-f' which seems to expect a file with a list of e-mail addresses, which MAINTAINERS is not. The second issue is that no patch file or directory is specified. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie 2022-11-28 17:22 ` Krzysztof Kozlowski 2022-11-28 17:41 ` Matthias Kaehlcke @ 2022-11-28 18:55 ` Doug Anderson 1 sibling, 0 replies; 11+ messages in thread From: Doug Anderson @ 2022-11-28 18:55 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: 楊宗翰, LKML, Bob Moragues, Stephen Boyd, Harvey, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang Hi, On Mon, Nov 28, 2022 at 9:22 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 28/11/2022 16:56, Doug Anderson wrote: > > Hi, > > > > On Thu, Nov 24, 2022 at 3:27 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 24/11/2022 12:20, 楊宗翰 wrote: > >>> Hi Krzysztof, Matthias, > >>> > >>> How to use "get_maintainers.pl"? > >>> > >>> I find this script in path "<MyCodebase>/kernel/v5.15/script", and output > >> > >> This looks like v5.15 kernel which is heavily outdated. Please never > >> work on such kernels when interacting with upstream. The rule is you > >> work on either last mainline kernel (v6.1-rc6), maintainers for-next > >> branch (you should know who is the maintainer of subsystem you submit > >> to, get_maintainers.pl gives this information) or on moderately recent > >> linux-next. For bigger patchsets there might be exceptions for these > >> rules, but it's not the case here. > > > > Just to add context here, it's a fairly standard workflow for ChromeOS > > kernel engineers to work in a "versioned" kernel directory but still > > checkout and work with the upstream kernel. I'm sure it's confusing to > > anyone not used to working with the ChromeOS source tree and build > > system. Sorry! :( So the fact that Owen is in a directory called > > "v5.15" doesn't mean that he's actually working with the v5.15 kernel. > > The fact that Bjorn's address is correct in his CC list implies to me > > that he's actually got a proper upstream kernel. > > > > I had previously [0] instructed Owen to send against Bjorn's tree, so > > hopefully it's correct. > > If it was on Bjorn's tree, get_maintainers.pl would not produce such result: > > --- > Series-to: LKML <linux-kernel@vger.kernel.org> > Series-cc: Douglas Anderson <dianders@chromium.org> > Series-cc: Bob Moragues <moragues@chromium.org> > Series-cc: Harvey <hunge@google.com> > Series-cc: Stephen Boyd <swboyd@chromium.org> > Series-cc: Matthias Kaehlcke <mka@chromium.org> > Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- So the above is the _manual_ set of names to add atop get_maintainers. Patman starts with the list you've manually added (via Series-to and Series-cc) and then automatically CCs the results of get_maintainers.pl > or this: > > --- > owen@buildsvr-HP-ProDesk-600-G4-MT:~/chromebook_zombie_os/src/third_party/kernel/v5.15$ > perl scripts/get_maintainer.pl -f MAINTAINERS --email > linux-kernel@vger.kernel.org (open list) Wow, really? Maybe I don't have Bjorn's tree correctly checked out either. ...or you can tell me what I'm doing wrong. $ git checkout linux_qcom/for-next HEAD is now at 4d2b529bce12 Merge branches 'arm64-defconfig-for-6.2', 'arm64-for-6.2', 'clk-for-6.2', 'defconfig-for-6.2', 'drivers-for-6.2', 'dts-for-6.2' and 'arm64-fixes-for-6.1' into for-next $ perl scripts/get_maintainer.pl -f MAINTAINERS --email linux-kernel@vger.kernel.org (open list) > as Owen indicated earlier. They are either incomplete or not correct. > > Of course I don't know whether the base tree is the problem or usage of > get_maintainers.pl... I suspect it's because the only "maintainer" of the file MAINTAINERS is LKML. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie 2022-11-24 9:29 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie Krzysztof Kozlowski [not found] ` <CAPao8GKbdK79Z7w91x0T6JW9v6VFoeYSaXGGAuzB_=ukR9g0_w@mail.gmail.com> @ 2022-11-28 15:51 ` Doug Anderson 2022-11-28 17:30 ` Krzysztof Kozlowski 1 sibling, 1 reply; 11+ messages in thread From: Doug Anderson @ 2022-11-28 15:51 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: 楊宗翰, LKML, Bob Moragues, Stephen Boyd, Harvey, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang Hi, On Thu, Nov 24, 2022 at 1:29 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > > 2. > > I notice Kryzysztof say he didn't in cc mail loop at beggin, and below is > > my updated mail list: > > --- > > Series-to: LKML <linux-kernel@vger.kernel.org> > > Series-cc: Douglas Anderson <dianders@chromium.org> > > Series-cc: Bob Moragues <moragues@chromium.org> > > Series-cc: Harvey <hunge@google.com> > > Series-cc: Stephen Boyd <swboyd@chromium.org> > > Series-cc: Matthias Kaehlcke <mka@chromium.org> > > Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Is there anyone I missed? > > These are not correct addresses and not complete list of them. Don't > invent the entries, don't add there some weird addresses. > > Use get_maintainers.pl. That's it. Nothing more, nothing less. Just to give context here, I think Owen is using `patman` [0] to send patches. Yes, it's part of the u-boot tree but it's designed for sending Linux patches too. By default, that means that get_maintainer is automatically called on all patches and those entries are CCed. The extra "Series-cc" just lets you add extra people. It's fine to add extra people to patches if you think that those people are interested in getting it. [0] https://source.denx.de/u-boot/u-boot/-/blob/master/tools/patman/patman.rst ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie 2022-11-28 15:51 ` Doug Anderson @ 2022-11-28 17:30 ` Krzysztof Kozlowski 2022-11-28 19:01 ` Doug Anderson 0 siblings, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-28 17:30 UTC (permalink / raw) To: Doug Anderson Cc: 楊宗翰, LKML, Bob Moragues, Stephen Boyd, Harvey, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang On 28/11/2022 16:51, Doug Anderson wrote: > Hi, > > On Thu, Nov 24, 2022 at 1:29 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >>> 2. >>> I notice Kryzysztof say he didn't in cc mail loop at beggin, and below is >>> my updated mail list: >>> --- >>> Series-to: LKML <linux-kernel@vger.kernel.org> >>> Series-cc: Douglas Anderson <dianders@chromium.org> >>> Series-cc: Bob Moragues <moragues@chromium.org> >>> Series-cc: Harvey <hunge@google.com> >>> Series-cc: Stephen Boyd <swboyd@chromium.org> >>> Series-cc: Matthias Kaehlcke <mka@chromium.org> >>> Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> Is there anyone I missed? >> >> These are not correct addresses and not complete list of them. Don't >> invent the entries, don't add there some weird addresses. >> >> Use get_maintainers.pl. That's it. Nothing more, nothing less. > > Just to give context here, I think Owen is using `patman` [0] to send > patches. Yes, it's part of the u-boot tree but it's designed for > sending Linux patches too. > > By default, that means that get_maintainer is automatically called on > all patches and those entries are CCed. The extra "Series-cc" just > lets you add extra people. It's fine to add extra people to patches if > you think that those people are interested in getting it. The tool is just the tool, if it uses get_maintainers.pl, then result would be correct. The problem was that CC list on v1 and v2: https://lore.kernel.org/linux-devicetree/20221117094251.2.Ibfc4751e4ba044d1caa1f88a16015e7c45c7db65@changeid/ https://lore.kernel.org/linux-devicetree/20221122203635.v2.1.Ie05fd439d0b271b927acb25c2a6e41af7a927e90@changeid/ As you can notice there easily: 1. Bjorn's address is wrong 2. My and Konrad's are missing So if you say that get_maintainers.pl were used and tree is not v5.15, then what else? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie 2022-11-28 17:30 ` Krzysztof Kozlowski @ 2022-11-28 19:01 ` Doug Anderson 0 siblings, 0 replies; 11+ messages in thread From: Doug Anderson @ 2022-11-28 19:01 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: 楊宗翰, LKML, Bob Moragues, Stephen Boyd, Harvey, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm, Gavin.Lee, Darren.Chen, Abner.Yen, Vicy.Lee, Jason.Huang Hi, On Mon, Nov 28, 2022 at 9:30 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 28/11/2022 16:51, Doug Anderson wrote: > > Hi, > > > > On Thu, Nov 24, 2022 at 1:29 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >>> 2. > >>> I notice Kryzysztof say he didn't in cc mail loop at beggin, and below is > >>> my updated mail list: > >>> --- > >>> Series-to: LKML <linux-kernel@vger.kernel.org> > >>> Series-cc: Douglas Anderson <dianders@chromium.org> > >>> Series-cc: Bob Moragues <moragues@chromium.org> > >>> Series-cc: Harvey <hunge@google.com> > >>> Series-cc: Stephen Boyd <swboyd@chromium.org> > >>> Series-cc: Matthias Kaehlcke <mka@chromium.org> > >>> Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> --- > >>> Is there anyone I missed? > >> > >> These are not correct addresses and not complete list of them. Don't > >> invent the entries, don't add there some weird addresses. > >> > >> Use get_maintainers.pl. That's it. Nothing more, nothing less. > > > > Just to give context here, I think Owen is using `patman` [0] to send > > patches. Yes, it's part of the u-boot tree but it's designed for > > sending Linux patches too. > > > > By default, that means that get_maintainer is automatically called on > > all patches and those entries are CCed. The extra "Series-cc" just > > lets you add extra people. It's fine to add extra people to patches if > > you think that those people are interested in getting it. > > The tool is just the tool, if it uses get_maintainers.pl, then result > would be correct. The problem was that CC list on v1 and v2: > > https://lore.kernel.org/linux-devicetree/20221117094251.2.Ibfc4751e4ba044d1caa1f88a16015e7c45c7db65@changeid/ > > https://lore.kernel.org/linux-devicetree/20221122203635.v2.1.Ie05fd439d0b271b927acb25c2a6e41af7a927e90@changeid/ > > As you can notice there easily: > 1. Bjorn's address is wrong > 2. My and Konrad's are missing > > So if you say that get_maintainers.pl were used and tree is not v5.15, > then what else? Certainly on v1 and v2 he was targeting v5.15, not upstream. When I replied to v1 I told him this. Apparently he messed up still on v2. Matthias again pointed it out on v2. After v2, it was corrected. ...so right, you didn't get v1 and v2 and those of us on the email thread pointed that out and it got corrected. I'm not sure what happened to v3, but that seems like yet another mistake and I believe Matthias also commented on this. Here we're on v4 which is correctly tagged as v4 and sent (as far as I can tell) mostly correctly. It makes sense that you're surprised that v4 came without you seeing earlier versions, but given that the error had already been identified and corrected (which is why you got v4 at all) then I don't think we need to keep debugging it, right? -Doug ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-11-28 19:02 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 3:57 [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie Owen Yang
2022-11-24 3:57 ` [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie Owen Yang
[not found] ` <CAPao8GK93KMrtaXw7mNWOCE60zk=uCENLfBXhNRVxJXEnnaGFg@mail.gmail.com>
2022-11-24 9:29 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie Krzysztof Kozlowski
[not found] ` <CAPao8GKbdK79Z7w91x0T6JW9v6VFoeYSaXGGAuzB_=ukR9g0_w@mail.gmail.com>
2022-11-24 11:27 ` Krzysztof Kozlowski
2022-11-28 15:56 ` Doug Anderson
2022-11-28 17:22 ` Krzysztof Kozlowski
2022-11-28 17:41 ` Matthias Kaehlcke
2022-11-28 18:55 ` Doug Anderson
2022-11-28 15:51 ` Doug Anderson
2022-11-28 17:30 ` Krzysztof Kozlowski
2022-11-28 19:01 ` Doug Anderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).