[PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET

[PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET

[Peter Oskolkov]

Lightweight tunnels are L3 constructs that are used with IP/IP6.

For example, lwtunnel_xmit is called from ip_output.c and
ip6_output.c only.

Make the dependency explicit at least for LWT-BPF, as now they
call into IP routing.

V2: added "Reported-by" below.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Peter Oskolkov <posk@google.com>
---
 net/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/Kconfig b/net/Kconfig
index 5cb9de1aaf88..62da6148e9f8 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -403,7 +403,7 @@ config LWTUNNEL
 
 config LWTUNNEL_BPF
 	bool "Execute BPF program as route nexthop action"
-	depends on LWTUNNEL
+	depends on LWTUNNEL && INET
 	default y if LWTUNNEL=y
 	---help---
 	  Allows to run BPF programs as a nexthop action following a route
-- 
2.21.0.rc0.258.g878e2cd30e-goog

Re: [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET

[Randy Dunlap]

On 2/15/19 9:51 AM, Peter Oskolkov wrote:
> Lightweight tunnels are L3 constructs that are used with IP/IP6.
> 
> For example, lwtunnel_xmit is called from ip_output.c and
> ip6_output.c only.
> 
> Make the dependency explicit at least for LWT-BPF, as now they
> call into IP routing.
> 
> V2: added "Reported-by" below.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Peter Oskolkov <posk@google.com>

Yes, that works.  Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

> ---
>  net/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/Kconfig b/net/Kconfig
> index 5cb9de1aaf88..62da6148e9f8 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -403,7 +403,7 @@ config LWTUNNEL
>  
>  config LWTUNNEL_BPF
>  	bool "Execute BPF program as route nexthop action"
> -	depends on LWTUNNEL
> +	depends on LWTUNNEL && INET
>  	default y if LWTUNNEL=y
>  	---help---
>  	  Allows to run BPF programs as a nexthop action following a route
> 


-- 
~Randy

Re: [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET

[Daniel Borkmann]

On 02/15/2019 11:55 PM, Randy Dunlap wrote:
> On 2/15/19 9:51 AM, Peter Oskolkov wrote:
>> Lightweight tunnels are L3 constructs that are used with IP/IP6.
>>
>> For example, lwtunnel_xmit is called from ip_output.c and
>> ip6_output.c only.
>>
>> Make the dependency explicit at least for LWT-BPF, as now they
>> call into IP routing.
>>
>> V2: added "Reported-by" below.
>>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Peter Oskolkov <posk@google.com>
> 
> Yes, that works.  Thanks.
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Applied, thanks!