* [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET
@ 2019-02-15 17:51 Peter Oskolkov
2019-02-15 22:55 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Peter Oskolkov @ 2019-02-15 17:51 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, netdev
Cc: Peter Oskolkov, Peter Oskolkov, Randy Dunlap
Lightweight tunnels are L3 constructs that are used with IP/IP6.
For example, lwtunnel_xmit is called from ip_output.c and
ip6_output.c only.
Make the dependency explicit at least for LWT-BPF, as now they
call into IP routing.
V2: added "Reported-by" below.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Peter Oskolkov <posk@google.com>
---
net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/Kconfig b/net/Kconfig
index 5cb9de1aaf88..62da6148e9f8 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -403,7 +403,7 @@ config LWTUNNEL
config LWTUNNEL_BPF
bool "Execute BPF program as route nexthop action"
- depends on LWTUNNEL
+ depends on LWTUNNEL && INET
default y if LWTUNNEL=y
---help---
Allows to run BPF programs as a nexthop action following a route
--
2.21.0.rc0.258.g878e2cd30e-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET
2019-02-15 17:51 [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET Peter Oskolkov
@ 2019-02-15 22:55 ` Randy Dunlap
2019-02-16 0:16 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2019-02-15 22:55 UTC (permalink / raw)
To: Peter Oskolkov, Alexei Starovoitov, Daniel Borkmann, netdev
Cc: Peter Oskolkov
On 2/15/19 9:51 AM, Peter Oskolkov wrote:
> Lightweight tunnels are L3 constructs that are used with IP/IP6.
>
> For example, lwtunnel_xmit is called from ip_output.c and
> ip6_output.c only.
>
> Make the dependency explicit at least for LWT-BPF, as now they
> call into IP routing.
>
> V2: added "Reported-by" below.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Peter Oskolkov <posk@google.com>
Yes, that works. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> net/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 5cb9de1aaf88..62da6148e9f8 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -403,7 +403,7 @@ config LWTUNNEL
>
> config LWTUNNEL_BPF
> bool "Execute BPF program as route nexthop action"
> - depends on LWTUNNEL
> + depends on LWTUNNEL && INET
> default y if LWTUNNEL=y
> ---help---
> Allows to run BPF programs as a nexthop action following a route
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET
2019-02-15 22:55 ` Randy Dunlap
@ 2019-02-16 0:16 ` Daniel Borkmann
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2019-02-16 0:16 UTC (permalink / raw)
To: Randy Dunlap, Peter Oskolkov, Alexei Starovoitov, netdev; +Cc: Peter Oskolkov
On 02/15/2019 11:55 PM, Randy Dunlap wrote:
> On 2/15/19 9:51 AM, Peter Oskolkov wrote:
>> Lightweight tunnels are L3 constructs that are used with IP/IP6.
>>
>> For example, lwtunnel_xmit is called from ip_output.c and
>> ip6_output.c only.
>>
>> Make the dependency explicit at least for LWT-BPF, as now they
>> call into IP routing.
>>
>> V2: added "Reported-by" below.
>>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Peter Oskolkov <posk@google.com>
>
> Yes, that works. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-16 0:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-15 17:51 [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET Peter Oskolkov
2019-02-15 22:55 ` Randy Dunlap
2019-02-16 0:16 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).