From: Song Gao <gaosong@loongson.cn>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, chenhuacai@gmail.com
Cc: peter.maydell@linaro.org, yangxiaojuan@loongson.cn,
david@redhat.com, bin.meng@windriver.com,
mark.cave-ayland@ilande.co.uk, aleksandar.rikalo@syrmia.com,
jcmvbkbc@gmail.com, tsimpson@quicinc.com,
alistair.francis@wdc.com, edgar.iglesias@gmail.com,
philmd@redhat.com, atar4qemu@gmail.com, thuth@redhat.com,
ehabkost@redhat.com, groug@kaod.org, maobibo@loongson.cn,
mrolnik@gmail.com, shorne@gmail.com, alex.bennee@linaro.org,
david@gibson.dropbear.id.au, kbastian@mail.uni-paderborn.de,
crwulff@gmail.com, laurent@vivier.eu, palmer@dabbelt.com,
pbonzini@redhat.com, aurelien@aurel32.net
Subject: Re: [PATCH v4 17/21] LoongArch Linux User Emulation
Date: Wed, 8 Sep 2021 17:50:37 +0800 [thread overview]
Message-ID: <3e7fd708-fe13-8163-2926-d1baa75e3b10@loongson.cn> (raw)
In-Reply-To: <4e47e1a7-d946-f8ec-a9a1-aadc6eeb7941@linaro.org>
Hi Richard,
On 09/05/2021 06:04 PM, Richard Henderson wrote:
>> +struct sigframe {
>> + uint32_t sf_ass[4]; /* argument save space for o32 */
>
> Surely there is no "o32" for loongarch?
>
Yes, qemu only support 64bit. but the kernel has 'o32'. Should we have to be consistent with the kernel?
>> + uint32_t sf_code[2]; /* signal trampoline */
>
> Note that there are patches on-list for moving the signal trampoline off of the stack.
>
>> diff --git a/linux-user/loongarch64/termbits.h b/linux-user/loongarch64/termbits.h
>> new file mode 100644
>> index 0000000..33e74ed
>> --- /dev/null
>> +++ b/linux-user/loongarch64/termbits.h
>> @@ -0,0 +1,229 @@
>> +#ifndef LINUX_USER_LOONGARCH_TERMBITS_H
>> +#define LINUX_USER_LOONGARCH_TERMBITS_H
>> +
>> +#define TARGET_NCCS 19
>
> Surely you should be using generic/termbits.h?
> OK.
> We will prefer not to merge a linux-user port that is not upstream, because the ABI may change in between. Can you provide a pointer to your kernel port in the meantime?
Latest kernel: https://github.com/loongson/linux/tree/loongarch-next
Song Gao
Thanks.
next prev parent reply other threads:[~2021-09-08 9:56 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 12:40 [PATCH v4 00/21] Add LoongArch linux-user emulation support Song Gao
2021-09-02 12:40 ` [PATCH v4 01/21] target/loongarch: Add README Song Gao
2021-09-02 12:40 ` [PATCH v4 02/21] target/loongarch: Add core definition Song Gao
2021-09-04 9:44 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 03/21] target/loongarch: Add main translation routines Song Gao
2021-09-04 9:45 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 04/21] target/loongarch: Add fixed point arithmetic instruction translation Song Gao
2021-09-04 11:04 ` Richard Henderson
2021-09-07 12:36 ` Song Gao
2021-09-02 12:40 ` [PATCH v4 05/21] target/loongarch: Add fixed point shift " Song Gao
2021-09-04 11:17 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 06/21] target/loongarch: Add fixed point bit " Song Gao
2021-09-04 12:57 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 07/21] target/loongarch: Add fixed point load/store " Song Gao
2021-09-04 13:03 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 08/21] target/loongarch: Add fixed point atomic " Song Gao
2021-09-04 13:14 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 09/21] target/loongarch: Add fixed point extra " Song Gao
2021-09-05 8:39 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 10/21] target/loongarch: Add floating point arithmetic " Song Gao
2021-09-05 9:08 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 11/21] target/loongarch: Add floating point comparison " Song Gao
2021-09-05 9:24 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 12/21] target/loongarch: Add floating point conversion " Song Gao
2021-09-05 9:29 ` Richard Henderson
2021-09-02 12:40 ` [PATCH v4 13/21] target/loongarch: Add floating point move " Song Gao
2021-09-05 9:38 ` Richard Henderson
2021-09-05 9:45 ` Richard Henderson
2021-09-02 12:41 ` [PATCH v4 14/21] target/loongarch: Add floating point load/store " Song Gao
2021-09-05 9:46 ` Richard Henderson
2021-09-02 12:41 ` [PATCH v4 15/21] target/loongarch: Add branch " Song Gao
2021-09-05 9:49 ` Richard Henderson
2021-09-02 12:41 ` [PATCH v4 16/21] target/loongarch: Add disassembler Song Gao
2021-09-02 12:41 ` [PATCH v4 17/21] LoongArch Linux User Emulation Song Gao
2021-09-05 10:04 ` Richard Henderson
2021-09-08 9:50 ` Song Gao [this message]
2021-09-10 12:52 ` Richard Henderson
2021-09-11 5:58 ` Song Gao
2021-09-12 12:38 ` Richard Henderson
2021-09-02 12:41 ` [PATCH v4 18/21] default-configs: Add loongarch linux-user support Song Gao
2021-09-02 12:41 ` [PATCH v4 19/21] target/loongarch: Add target build suport Song Gao
2021-09-05 10:05 ` Richard Henderson
2021-09-02 12:41 ` [PATCH v4 20/21] target/loongarch: 'make check-tcg' support Song Gao
2021-09-05 10:06 ` Richard Henderson
2021-09-02 12:41 ` [PATCH v4 21/21] scripts: add loongarch64 binfmt config Song Gao
2021-09-05 10:08 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e7fd708-fe13-8163-2926-d1baa75e3b10@loongson.cn \
--to=gaosong@loongson.cn \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=bin.meng@windriver.com \
--cc=chenhuacai@gmail.com \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=maobibo@loongson.cn \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mrolnik@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shorne@gmail.com \
--cc=thuth@redhat.com \
--cc=tsimpson@quicinc.com \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).