From: Jason Wang <jasowang@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Yan Zhao <yan.y.zhao@intel.com>,
Juan Quintela <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Eugenio Perez Martin <eperezma@redhat.com>,
Avi Kivity <avi@redhat.com>, Eric Auger <eric.auger@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks
Date: Wed, 2 Sep 2020 13:13:32 +0800 [thread overview]
Message-ID: <63caf29f-4d19-1fcd-8053-e5d63890f317@redhat.com> (raw)
In-Reply-To: <20200901193504.GA3053@xz-x1>
On 2020/9/2 上午3:35, Peter Xu wrote:
> On Tue, Sep 01, 2020 at 11:05:18AM +0800, Jason Wang wrote:
>> On 2020/8/21 下午10:12, Peter Xu wrote:
>>> On Thu, Aug 20, 2020 at 10:28:00AM +0800, Jason Wang wrote:
>>>> On 2020/8/19 下午11:50, Peter Xu wrote:
>>>>> On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote:
>>>>>> Yes, actually, I feel confused after reading the codes. Is notifier->start
>>>>>> IOVA or GPA?
>>>>>>
>>>>>> In vfio.c, we did:
>>>>>>
>>>>>> iommu_notifier_init(&giommu->n, vfio_iommu_map_notify,
>>>>>> IOMMU_NOTIFIER_ALL,
>>>>>> section->offset_within_region,
>>>>>> int128_get64(llend),
>>>>>> iommu_idx);
>>>>>>
>>>>>> So it looks to me the start and end are GPA, but the assertion above check
>>>>>> it against IOVA which seems to be wrong ....
>>>>> It should be iova; both section->offset_within_region and llend are for the
>>>>> device's iova address space. Thanks,
>>>>>
>>>> Interesting, how can memory region know which IOVA is used by guest?
>>> Does it need to know? :)
>>>
>>> AFAICT what we do here is only register with the whole possible IOVA address
>>> space (e.g., across the whole 64bit address space). Then vfio will get
>>> notifications when there're new iova ranges mapped into it.
>>
>> Right, but the whole IOVA address space should be something vIOMMU specific,
>> e.g for Intel it should be calculated by GAW, but I found:
>>
>> memory_region_init_iommu(&vtd_dev_as->iommu,
>> sizeof(vtd_dev_as->iommu),
>> TYPE_INTEL_IOMMU_MEMORY_REGION, OBJECT(s),
>> name, UINT64_MAX);
>>
>> which assumes UINT64_MAX.
> Right. AFAICT it can be reduced to gaw width, but I don't see a problem either
> even with UINT64_MAX (as long as it covers the range specified by gaw). Or did
> I miss something?
Dunno :)
Just notice this difference, for safety, maybe its better to cap it with
GAW.
Btw, the naming of "vtd-ir" is kind of confusing, it should work without ir.
Thanks
> Thanks,
>
next prev parent reply other threads:[~2020-09-02 5:14 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 6:41 [RFC v2 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier Eugenio Pérez
2020-06-26 6:41 ` [RFC v2 1/1] " Eugenio Pérez
2020-06-26 21:29 ` Peter Xu
2020-06-27 7:26 ` Yan Zhao
2020-06-27 12:57 ` Peter Xu
2020-06-28 1:36 ` Yan Zhao
2020-06-28 7:03 ` Jason Wang
2020-06-28 14:47 ` Peter Xu
2020-06-29 5:51 ` Jason Wang
2020-06-29 13:34 ` Peter Xu
2020-06-30 2:41 ` Jason Wang
2020-06-30 8:29 ` Jason Wang
2020-06-30 9:21 ` Michael S. Tsirkin
2020-06-30 9:23 ` Jason Wang
2020-06-30 15:20 ` Peter Xu
2020-07-01 8:11 ` Jason Wang
2020-07-01 12:16 ` Peter Xu
2020-07-01 12:30 ` Jason Wang
2020-07-01 12:41 ` Peter Xu
2020-07-02 3:00 ` Jason Wang
2020-06-30 15:39 ` Peter Xu
2020-07-01 8:09 ` Jason Wang
2020-07-02 3:01 ` Jason Wang
2020-07-02 15:45 ` Peter Xu
2020-07-03 7:24 ` Jason Wang
2020-07-03 13:03 ` Peter Xu
2020-07-07 8:03 ` Jason Wang
2020-07-07 19:54 ` Peter Xu
2020-07-08 5:42 ` Jason Wang
2020-07-08 14:16 ` Peter Xu
2020-07-09 5:58 ` Jason Wang
2020-07-09 14:10 ` Peter Xu
2020-07-10 6:34 ` Jason Wang
2020-07-10 13:30 ` Peter Xu
2020-07-13 4:04 ` Jason Wang
2020-07-16 1:00 ` Peter Xu
2020-07-16 2:54 ` Jason Wang
2020-07-17 14:18 ` Peter Xu
2020-07-20 4:02 ` Jason Wang
2020-07-20 13:03 ` Peter Xu
2020-07-21 6:20 ` Jason Wang
2020-07-21 15:10 ` Peter Xu
2020-08-03 16:00 ` Eugenio Pérez
2020-08-04 20:30 ` Peter Xu
2020-08-05 5:45 ` Jason Wang
2020-08-11 17:01 ` Eugenio Perez Martin
2020-08-11 17:10 ` Eugenio Perez Martin
2020-06-29 15:05 ` [RFC v2 0/1] " Paolo Bonzini
2020-07-03 7:39 ` Eugenio Perez Martin
2020-07-03 10:10 ` Paolo Bonzini
2020-08-11 17:55 ` [RFC v3 " Eugenio Pérez
2020-08-11 17:55 ` [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks Eugenio Pérez
2020-08-12 2:24 ` Jason Wang
2020-08-12 8:49 ` Eugenio Perez Martin
2020-08-18 14:24 ` Eugenio Perez Martin
2020-08-19 7:15 ` Jason Wang
2020-08-19 8:22 ` Eugenio Perez Martin
2020-08-19 9:36 ` Jason Wang
2020-08-19 15:50 ` Peter Xu
2020-08-20 2:28 ` Jason Wang
2020-08-21 14:12 ` Peter Xu
2020-09-01 3:05 ` Jason Wang
2020-09-01 19:35 ` Peter Xu
2020-09-02 5:13 ` Jason Wang [this message]
2020-08-11 18:10 ` [RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier Eugenio Perez Martin
2020-08-11 19:27 ` Peter Xu
2020-08-12 14:33 ` Eugenio Perez Martin
2020-08-12 21:12 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63caf29f-4d19-1fcd-8053-e5d63890f317@redhat.com \
--to=jasowang@redhat.com \
--cc=avi@redhat.com \
--cc=eperezma@redhat.com \
--cc=eric.auger@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).