QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] hw/i386: disable smbus migration for xenpv
@ 2020-01-13 17:45 Olaf Hering
  2020-01-13 17:46 ` [PATCH v1] hw/i386: disable smbus migration for xenfv Olaf Hering
                   ` (2 more replies)
  0 siblings, 3 replies; 24+ messages in thread
From: Olaf Hering @ 2020-01-13 17:45 UTC (permalink / raw)
  To: Paolo Bonzini, Richard Henderson, Eduardo Habkost,
	Michael S. Tsirkin, Marcel Apfelbaum, qemu-devel
  Cc: Olaf Hering

With commit 7fccf2a06890e3bc3b30e29827ad3fb93fe88fea a new member
smbus_no_migration_support was added, and enabled in two places.
With commit 4ab2f2a8aabfea95cc53c64e13b3f67960b27fdf the vmstate_acpi
got new elements, which are conditionally filled. As a result, an
incoming migration expected smbus related data unless smbus migration
was disabled for a given MachineClass.

Since commit 7fccf2a06890e3bc3b30e29827ad3fb93fe88fea forgot to handle
xenpv, live migration to receiving hosts using qemu-4.0 and later is broken.
Therefore this patch must be applied to stable-4.x as well.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 hw/i386/pc_piix.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index fa12203079..e19716d0d3 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -952,6 +952,7 @@ static void xenfv_machine_options(MachineClass *m)
     m->desc = "Xen Fully-virtualized PC";
     m->max_cpus = HVM_MAX_VCPUS;
     m->default_machine_opts = "accel=xen";
+    m->smbus_no_migration_support = true;
 }
 
 DEFINE_PC_MACHINE(xenfv, "xenfv", pc_xen_hvm_init,


^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, back to index

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 17:45 [PATCH v1] hw/i386: disable smbus migration for xenpv Olaf Hering
2020-01-13 17:46 ` [PATCH v1] hw/i386: disable smbus migration for xenfv Olaf Hering
2020-01-15 13:51 ` [PATCH v1] hw/i386: disable smbus migration for xenpv Michael S. Tsirkin
2020-01-16 18:03 ` [PATCH v2] hw/i386: disable smbus migration for xenfv Olaf Hering
2020-01-16 18:26   ` Paolo Bonzini
2020-01-16 18:33     ` Olaf Hering
2020-01-16 18:50       ` Paolo Bonzini
2020-01-17  9:22     ` Olaf Hering
2020-01-17 10:27       ` Paolo Bonzini
2020-01-17 13:06         ` Olaf Hering
2020-01-20 11:18           ` Paul Durrant
2020-01-27  9:09             ` Olaf Hering
2020-02-18 17:27               ` Olaf Hering
2020-02-18 17:37                 ` Paolo Bonzini
2020-02-18 18:30                   ` Olaf Hering
2020-02-18 19:44                   ` Olaf Hering
2020-02-19  8:05                     ` Paolo Bonzini
2020-02-19  8:13                       ` Olaf Hering
2020-01-27  9:35             ` Paolo Bonzini
2020-01-27 13:26               ` Olaf Hering
2020-01-27 18:21                 ` Paolo Bonzini
2020-02-19 11:35     ` Olaf Hering
2020-02-19 14:14       ` Olaf Hering
2020-02-20 10:50         ` Paolo Bonzini

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git