From: <akolli@qti.qualcomm.com> To: <ath10k@lists.infradead.org> Cc: <linux-wireless@vger.kernel.org>, <akolli@codeaurora.org>, Anilkumar Kolli <akolli@qti.qualcomm.com> Subject: [PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug Date: Thu, 30 Nov 2017 18:28:20 +0530 [thread overview] Message-ID: <1512046701-14435-2-git-send-email-akolli@qti.qualcomm.com> (raw) In-Reply-To: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> From: Anilkumar Kolli <akolli@qti.qualcomm.com> Move pktlog_filter from struct ath10k_debug to struct ath10k so that pktlog can be enabled even when debugfs is not enabled, needed to enable peer tx stats for 10.2.4. No changes in functionality. Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.h | 2 +- drivers/net/wireless/ath/ath10k/debug.c | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h index 643041ef3271..75dbfffe677a 100644 --- a/drivers/net/wireless/ath/ath10k/core.h +++ b/drivers/net/wireless/ath/ath10k/core.h @@ -488,7 +488,6 @@ struct ath10k_debug { /* protected by conf_mutex */ u64 fw_dbglog_mask; u32 fw_dbglog_level; - u32 pktlog_filter; u32 reg_addr; u32 nf_cal_period; void *cal_data; @@ -963,6 +962,7 @@ struct ath10k { } spectral; #endif + u32 pktlog_filter; struct { /* protected by conf_mutex */ struct ath10k_fw_components utf_mode_fw; diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index df514507d3f1..e278300b4f14 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -1950,14 +1950,14 @@ int ath10k_debug_start(struct ath10k *ar) ret); } - if (ar->debug.pktlog_filter) { + if (ar->pktlog_filter) { ret = ath10k_wmi_pdev_pktlog_enable(ar, - ar->debug.pktlog_filter); + ar->pktlog_filter); if (ret) /* not serious */ ath10k_warn(ar, "failed to enable pktlog filter %x: %d\n", - ar->debug.pktlog_filter, ret); + ar->pktlog_filter, ret); } else { ret = ath10k_wmi_pdev_pktlog_disable(ar); if (ret) @@ -2097,12 +2097,12 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file, mutex_lock(&ar->conf_mutex); if (ar->state != ATH10K_STATE_ON) { - ar->debug.pktlog_filter = filter; + ar->pktlog_filter = filter; ret = count; goto out; } - if (filter == ar->debug.pktlog_filter) { + if (filter == ar->pktlog_filter) { ret = count; goto out; } @@ -2111,7 +2111,7 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file, ret = ath10k_wmi_pdev_pktlog_enable(ar, filter); if (ret) { ath10k_warn(ar, "failed to enable pktlog filter %x: %d\n", - ar->debug.pktlog_filter, ret); + ar->pktlog_filter, ret); goto out; } } else { @@ -2122,7 +2122,7 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file, } } - ar->debug.pktlog_filter = filter; + ar->pktlog_filter = filter; ret = count; out: @@ -2139,7 +2139,7 @@ static ssize_t ath10k_read_pktlog_filter(struct file *file, char __user *ubuf, mutex_lock(&ar->conf_mutex); len = scnprintf(buf, sizeof(buf) - len, "%08x\n", - ar->debug.pktlog_filter); + ar->pktlog_filter); mutex_unlock(&ar->conf_mutex); return simple_read_from_buffer(ubuf, count, ppos, buf, len); -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: <akolli@qti.qualcomm.com> To: ath10k@lists.infradead.org Cc: Anilkumar Kolli <akolli@qti.qualcomm.com>, akolli@codeaurora.org, linux-wireless@vger.kernel.org Subject: [PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug Date: Thu, 30 Nov 2017 18:28:20 +0530 [thread overview] Message-ID: <1512046701-14435-2-git-send-email-akolli@qti.qualcomm.com> (raw) In-Reply-To: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> From: Anilkumar Kolli <akolli@qti.qualcomm.com> Move pktlog_filter from struct ath10k_debug to struct ath10k so that pktlog can be enabled even when debugfs is not enabled, needed to enable peer tx stats for 10.2.4. No changes in functionality. Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.h | 2 +- drivers/net/wireless/ath/ath10k/debug.c | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h index 643041ef3271..75dbfffe677a 100644 --- a/drivers/net/wireless/ath/ath10k/core.h +++ b/drivers/net/wireless/ath/ath10k/core.h @@ -488,7 +488,6 @@ struct ath10k_debug { /* protected by conf_mutex */ u64 fw_dbglog_mask; u32 fw_dbglog_level; - u32 pktlog_filter; u32 reg_addr; u32 nf_cal_period; void *cal_data; @@ -963,6 +962,7 @@ struct ath10k { } spectral; #endif + u32 pktlog_filter; struct { /* protected by conf_mutex */ struct ath10k_fw_components utf_mode_fw; diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index df514507d3f1..e278300b4f14 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -1950,14 +1950,14 @@ int ath10k_debug_start(struct ath10k *ar) ret); } - if (ar->debug.pktlog_filter) { + if (ar->pktlog_filter) { ret = ath10k_wmi_pdev_pktlog_enable(ar, - ar->debug.pktlog_filter); + ar->pktlog_filter); if (ret) /* not serious */ ath10k_warn(ar, "failed to enable pktlog filter %x: %d\n", - ar->debug.pktlog_filter, ret); + ar->pktlog_filter, ret); } else { ret = ath10k_wmi_pdev_pktlog_disable(ar); if (ret) @@ -2097,12 +2097,12 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file, mutex_lock(&ar->conf_mutex); if (ar->state != ATH10K_STATE_ON) { - ar->debug.pktlog_filter = filter; + ar->pktlog_filter = filter; ret = count; goto out; } - if (filter == ar->debug.pktlog_filter) { + if (filter == ar->pktlog_filter) { ret = count; goto out; } @@ -2111,7 +2111,7 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file, ret = ath10k_wmi_pdev_pktlog_enable(ar, filter); if (ret) { ath10k_warn(ar, "failed to enable pktlog filter %x: %d\n", - ar->debug.pktlog_filter, ret); + ar->pktlog_filter, ret); goto out; } } else { @@ -2122,7 +2122,7 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file, } } - ar->debug.pktlog_filter = filter; + ar->pktlog_filter = filter; ret = count; out: @@ -2139,7 +2139,7 @@ static ssize_t ath10k_read_pktlog_filter(struct file *file, char __user *ubuf, mutex_lock(&ar->conf_mutex); len = scnprintf(buf, sizeof(buf) - len, "%08x\n", - ar->debug.pktlog_filter); + ar->pktlog_filter); mutex_unlock(&ar->conf_mutex); return simple_read_from_buffer(ubuf, count, ppos, buf, len); -- 1.7.9.5 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-11-30 12:58 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-30 12:58 [PATCH 0/2] ath10k: tx stats for 10.2.4 akolli 2017-11-30 12:58 ` akolli 2017-11-30 12:58 ` akolli [this message] 2017-11-30 12:58 ` [PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug akolli 2017-11-30 12:58 ` [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 akolli 2017-11-30 12:58 ` akolli 2017-11-30 16:14 ` Kalle Valo 2017-11-30 16:14 ` Kalle Valo 2017-11-30 16:28 ` Toke Høiland-Jørgensen 2017-11-30 16:28 ` Toke Høiland-Jørgensen 2017-11-30 16:38 ` Kalle Valo 2017-11-30 16:38 ` Kalle Valo 2017-12-01 4:23 ` akolli 2017-12-01 4:23 ` akolli 2017-12-01 13:41 ` Toke Høiland-Jørgensen 2017-12-01 13:41 ` Toke Høiland-Jørgensen 2017-12-01 14:49 ` Kalle Valo 2017-12-01 14:49 ` Kalle Valo 2017-12-01 15:29 ` Toke Høiland-Jørgensen 2017-12-01 15:29 ` Toke Høiland-Jørgensen 2017-12-01 15:45 ` Johannes Berg 2017-12-01 15:45 ` Johannes Berg 2017-12-01 15:54 ` Toke Høiland-Jørgensen 2017-12-01 15:54 ` Toke Høiland-Jørgensen 2017-12-01 15:58 ` Johannes Berg 2017-12-01 15:58 ` Johannes Berg 2017-12-02 9:53 ` Toke Høiland-Jørgensen 2017-12-02 9:53 ` Toke Høiland-Jørgensen 2017-12-01 10:45 ` Maxime Bizon 2017-12-01 10:45 ` Maxime Bizon 2017-12-01 13:48 ` akolli 2017-12-01 13:48 ` akolli 2017-12-01 15:05 ` Maxime Bizon 2017-12-01 15:05 ` Maxime Bizon 2017-12-01 15:53 ` Christian Lamparter 2017-12-01 15:53 ` Christian Lamparter 2017-12-01 16:09 ` Maxime Bizon 2017-12-01 16:09 ` Maxime Bizon 2017-12-04 13:24 ` akolli 2017-12-04 13:24 ` akolli 2017-12-04 14:23 ` Maxime Bizon 2017-12-04 14:23 ` Maxime Bizon 2017-12-05 5:26 ` akolli 2017-12-05 5:26 ` akolli 2017-12-01 15:44 ` Kalle Valo 2017-12-01 15:44 ` Kalle Valo 2017-12-04 11:20 ` akolli 2017-12-04 11:20 ` akolli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1512046701-14435-2-git-send-email-akolli@qti.qualcomm.com \ --to=akolli@qti.qualcomm.com \ --cc=akolli@codeaurora.org \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.