From: "Pali Rohár" <pali@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Marvell: Update PCIe fixup
Date: Mon, 1 Nov 2021 18:56:49 +0100 [thread overview]
Message-ID: <20211101175649.q743eg65jpjtk7sd@pali> (raw)
In-Reply-To: <20211101162711.GA2744544@nvidia.com>
On Monday 01 November 2021 13:27:11 Jason Gunthorpe wrote:
> On Mon, Nov 01, 2021 at 04:04:05PM +0100, Pali Rohár wrote:
> > - The code relies on rc_pci_fixup being called, which only happens
> > when CONFIG_PCI_QUIRKS is enabled, so add that to Kconfig. Omitting
> > this causes a booting failure with a non-obvious cause.
> > - Update rc_pci_fixup to set the class properly, copying the
> > more modern style from other places
> > - Correct the rc_pci_fixup comment
> >
> > This patch just re-applies commit 1dc831bf53fd ("ARM: Kirkwood: Update
> > PCI-E fixup") for all other Marvell platforms which use same buggy PCIe
> > controller.
>
> I wonder if that code is even relevant any more since we started using
> CONFIG_PCI_MVEBU
>
> ?
It is (still) relevant for platforms which do not use CONFIG_PCI_MVEBU
yet.
> Really, these broken controllers should not be used "raw" but always
> via their special host bridge driver that fixes all the config space
> problems.
I agree.
Long-term goal should be to convert these platforms to use pci-mvebu.c
driver. And until it happens simple fixes like in commit 1dc831bf53fd is
needed for all affected Marvell platforms.
Some details how these Marvell PCIe controllers are broken is in email:
https://lore.kernel.org/linux-pci/20211003120944.3lmwxylnhlp2kfj7@pali/
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Marvell: Update PCIe fixup
Date: Mon, 1 Nov 2021 18:56:49 +0100 [thread overview]
Message-ID: <20211101175649.q743eg65jpjtk7sd@pali> (raw)
In-Reply-To: <20211101162711.GA2744544@nvidia.com>
On Monday 01 November 2021 13:27:11 Jason Gunthorpe wrote:
> On Mon, Nov 01, 2021 at 04:04:05PM +0100, Pali Rohár wrote:
> > - The code relies on rc_pci_fixup being called, which only happens
> > when CONFIG_PCI_QUIRKS is enabled, so add that to Kconfig. Omitting
> > this causes a booting failure with a non-obvious cause.
> > - Update rc_pci_fixup to set the class properly, copying the
> > more modern style from other places
> > - Correct the rc_pci_fixup comment
> >
> > This patch just re-applies commit 1dc831bf53fd ("ARM: Kirkwood: Update
> > PCI-E fixup") for all other Marvell platforms which use same buggy PCIe
> > controller.
>
> I wonder if that code is even relevant any more since we started using
> CONFIG_PCI_MVEBU
>
> ?
It is (still) relevant for platforms which do not use CONFIG_PCI_MVEBU
yet.
> Really, these broken controllers should not be used "raw" but always
> via their special host bridge driver that fixes all the config space
> problems.
I agree.
Long-term goal should be to convert these platforms to use pci-mvebu.c
driver. And until it happens simple fixes like in commit 1dc831bf53fd is
needed for all affected Marvell platforms.
Some details how these Marvell PCIe controllers are broken is in email:
https://lore.kernel.org/linux-pci/20211003120944.3lmwxylnhlp2kfj7@pali/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-01 17:57 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 15:04 [PATCH] PCI: Marvell: Update PCIe fixup Pali Rohár
2021-11-01 15:04 ` Pali Rohár
2021-11-01 16:27 ` Jason Gunthorpe
2021-11-01 16:27 ` Jason Gunthorpe
2021-11-01 17:56 ` Pali Rohár [this message]
2021-11-01 17:56 ` Pali Rohár
2021-11-01 18:03 ` Jason Gunthorpe
2021-11-01 18:03 ` Jason Gunthorpe
2021-11-02 8:42 ` Thomas Bogendoerfer
2021-11-02 8:42 ` Thomas Bogendoerfer
2021-11-02 9:02 ` Pali Rohár
2021-11-02 9:02 ` Pali Rohár
2021-11-02 9:47 ` Thomas Bogendoerfer
2021-11-02 9:47 ` Thomas Bogendoerfer
2021-11-02 10:00 ` Pali Rohár
2021-11-02 10:00 ` Pali Rohár
2021-11-02 12:35 ` Maciej W. Rozycki
2021-11-02 12:35 ` Maciej W. Rozycki
2021-11-02 12:58 ` Pali Rohár
2021-11-02 12:58 ` Pali Rohár
2021-11-02 14:01 ` Maciej W. Rozycki
2021-11-02 14:01 ` Maciej W. Rozycki
2021-11-02 14:49 ` Pali Rohár
2021-11-02 14:49 ` Pali Rohár
2021-11-02 15:48 ` Pali Rohár
2021-11-02 15:48 ` Pali Rohár
2021-11-02 17:03 ` Stefan Roese
2021-11-02 17:03 ` Stefan Roese
2021-11-03 14:59 ` Maciej W. Rozycki
2021-11-03 14:59 ` Maciej W. Rozycki
2021-11-03 14:49 ` Maciej W. Rozycki
2021-11-03 14:49 ` Maciej W. Rozycki
2021-11-03 15:03 ` Pali Rohár
2021-11-03 15:03 ` Pali Rohár
2021-11-02 15:02 ` Thomas Bogendoerfer
2021-11-02 15:02 ` Thomas Bogendoerfer
2021-11-02 15:13 ` Pali Rohár
2021-11-02 15:13 ` Pali Rohár
2021-11-09 23:42 ` Pali Rohár
2021-11-09 23:42 ` Pali Rohár
2021-11-10 8:55 ` Thomas Bogendoerfer
2021-11-10 8:55 ` Thomas Bogendoerfer
2021-11-02 17:12 ` [PATCH v2 1/2] ARM: " Pali Rohár
2021-11-02 17:12 ` Pali Rohár
2021-11-02 17:12 ` [PATCH v2 2/2] MIPS: Cobalt: Explain GT64111 early PCI fixup Pali Rohár
2021-11-03 16:36 ` Thomas Bogendoerfer
2021-11-09 22:53 ` [PATCH v2 1/2] ARM: Marvell: Update PCIe fixup Pali Rohár
2021-11-09 22:53 ` Pali Rohár
2022-05-14 18:21 ` Pali Rohár
2022-05-14 18:21 ` Pali Rohár
2022-07-07 18:31 ` Pali Rohár
2022-07-07 18:31 ` Pali Rohár
2022-07-07 19:22 ` Russell King (Oracle)
2022-07-07 19:22 ` Russell King (Oracle)
2022-02-19 14:30 ` Pali Rohár
2022-02-19 14:30 ` Pali Rohár
2022-07-18 10:34 ` Gregory CLEMENT
2022-07-18 10:34 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101175649.q743eg65jpjtk7sd@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=jgg@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.