radiotap.netbsd.org archive mirror
 help / color / mirror / Atom feed
From: Simon Barber <simon-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: Wojciech Dubowik
	<wojciech.dubowik-ASv44eHyqLVBDgjK7y7TUQ@public.gmane.org>,
	radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org
Subject: Re: MCS field - STBC and Ness
Date: Thu, 01 Nov 2012 17:24:59 -0700	[thread overview]
Message-ID: <509312DB.7070100@superduper.net> (raw)
In-Reply-To: <5091C0BC.4040305-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>

OK - I have now posted 3 patches on the proposal page (see Attachments):

1. A patch that applies to the Linux kernel v3.7-rc1 to collect the new 
STBC and Ness parameters from a wireless driver, and add them into the 
MCS radiotap field.
2. A patch to the Intel wireless driver in the kernel to collect STBC 
and Ness information.
3. A patch to wireshark to display STBC and Ness information.

With this I believe we have everything needed to start the 3 week 
comment period.

Simon


On 10/31/2012 05:22 PM, Simon Barber wrote:
> Hi Johannes & Wojciech,
>
> My work has been on hold, but has recently come off hold. I'm getting
> the patches together. As I rebase my work onto the current wireshark
> trunk I've found a simpler implementation of STBC has been applied by
> Wojciech. My proposal extends the STBC from his implemented 1 bit to the
> full 2 bits allowed in the 11n specification, and also includes 2 bits
> of Ness. I've posted an ieee80211 patch, and an intel driver patch (both
> attached to the proposed radiotap extension page). l'll post a wireshark
> patch shortly to start the comment period.
>
> Simon
>
>
> On Thu 05 Jul 2012 02:12:30 AM PDT, Johannes Berg wrote:
>> On Fri, 2012-05-11 at 21:27 -0700, Simon Barber wrote:
>>> Another slight tweak - I think STBC is more commonly used than Ness (as
>>> witnessed by Wojciech's interest), so give STBC the simpler encoding. I
>>> believe Ness is used for beamforming soundings.
>>>
>>> Spec would look like this:
>>>
>>> known    definition
>>> 0x01    bandwidth
>>> 0x02    MCS index known (in mcs part of the field)
>>> 0x04    guard interval
>>> 0x08    HT format
>>> 0x10    FEC type
>>> 0x20    STBC
>>> 0x40    Ness - Number of extension spatial streams is known
>>> 0x80    Ness2 - bit 1 (MSB) of Number of extension spatial streams.
>>>
>>> The flags field is any combination of the following:
>>>
>>> flag    definition
>>> 0x03    bandwidth - 0: 20, 1: 40, 2: 20L, 3: 20U
>>> 0x04    guard interval - 0: long GI, 1: short GI
>>> 0x08    HT format - 0: mixed, 1: greenfield
>>> 0x10    FEC type - 0: BCC, 1: LDPC
>>> 0x60    STBC - 0, 1 or 2: number of STBC streams
>>> 0x80    Ness - bit 0 (LSB) of Number of extension spatial streams.
>>>
>>> What should I do to advance this as an approved radiotap extension?
>>
>> I suppose you already have patches for wireshark for this? I can help
>> you out with a patch for the Linux kernel as an example producer of
>> this, and then I think just repost it to the list again to leave some
>> more discussion time.
>>
>> johannes
>>

  parent reply	other threads:[~2012-11-02  0:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11  0:31 MCS field - STBC and Ness Simon Barber
     [not found] ` <4FAC5DE0.90708-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-05-11  7:04   ` Wojciech Dubowik
     [not found]     ` <4FACBA13.9040509-ASv44eHyqLVBDgjK7y7TUQ@public.gmane.org>
2012-05-11 16:44       ` Simon Barber
     [not found]         ` <4FAD41E4.3090803-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-05-11 16:53           ` Simon Barber
     [not found]             ` <4FAD43F0.20807-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-05-11 18:35               ` Johannes Berg
     [not found]                 ` <1336761346.8739.3.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-05-12  4:27                   ` Simon Barber
     [not found]                     ` <4FADE69F.9040100-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-07-05  9:12                       ` Johannes Berg
     [not found]                         ` <1341479550.4455.36.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-11-01  0:22                           ` Simon Barber
     [not found]                             ` <5091C0BC.4040305-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-11-02  0:24                               ` Simon Barber [this message]
     [not found]                                 ` <509312DB.7070100-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2012-11-05 14:35                                   ` Johannes Berg
2012-11-17  6:32                                   ` Standardisation - adding 2 bit STBC and Ness to MCS Simon Barber
2012-07-04 17:06   ` MCS field - STBC and Ness David Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509312DB.7070100@superduper.net \
    --to=simon-vp0mx6+5gkqfx2apin6yfw@public.gmane.org \
    --cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
    --cc=radiotap-sUITvd46vNxg9hUCZPvPmw@public.gmane.org \
    --cc=wojciech.dubowik-ASv44eHyqLVBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).