From: LABBE Corentin <clabbe@baylibre.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Rob Herring <robh+dt@kernel.org>, SoC Team <soc@kernel.org>,
Hans Ulli Kroll <ulli.kroll@googlemail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] ARM: gemini: add device tree for edimax NS2502
Date: Tue, 18 May 2021 11:54:57 +0200 [thread overview]
Message-ID: <YKOO8UxdmZBjYbt4@Red> (raw)
Message-ID: <20210518095457.ALMJjNgjHiSxOHPyrS2vAkVoV2HfOeIMNfHjYOjx8jw@z> (raw)
In-Reply-To: <CACRpkdY3c4uvo1zbEgNW0meF-4P8be_nmoOEQAHP5V+GXgoG=A@mail.gmail.com>
Le Tue, May 18, 2021 at 01:46:20AM +0200, Linus Walleij a écrit :
> Hi Corentin,
>
> this is looking nice! Just one thing:
>
> On Mon, May 17, 2021 at 9:32 PM Corentin Labbe <clabbe@baylibre.com> wrote:
>
> > The edimax NS2502 is a NAS box running a SL3516 SoC.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>
> > +&flash {
> > + status = "okay";
> > + /* 8MB of flash */
> > + reg = <0x30000000 0x00800000>;
>
> No pin control setting? I guess it may work but this doesn't hurt
> (I think):
>
> pinctrl-names = "enabled", "disabled";
> pinctrl-0 = <&pflash_default_pins>;
> pinctrl-1 = <&pflash_disabled_pins>;
>
I have added, without any change in behavour.
> > + partitions {
> > + compatible = "fixed-partitions";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + partition@0 {
> > + label = "RedBoot";
> > + reg = <0x00000000 0x00020000>;
> > + read-only;
> > + };
> > + partition@20000 {
> > + label = "kernel";
> > + reg = <0x00020000 0x00700000>;
> > + };
> > + partition@720000 {
> > + label = "VCTL";
> > + reg = <0x00720000 0x00020000>;
> > + read-only;
> > + };
> > + partition@740000 {
> > + label = "CurConf";
> > + reg = <0x00740000 0x000a0000>;
> > + read-only;
> > + };
> > + partition@7e0000 {
> > + label = "FIS";
> > + reg = <0x007e0000 0x00010000>;
> > + read-only;
> > + };
> > + };
> > +};
>
> Is the FIS broken since you hardcode the partitions?
>
> Doesn't this work:
>
> partitions {
> compatible = "redboot-fis";
> /* Eraseblock at 0x7e0000 */
> fis-index-block = <0xfc>;
> };
>
> (Needs CONFIG_MTD_REDBOOT_PARTS)
No it does not.
physmap-flash 30000000.flash: no enabled pin control state
physmap-flash 30000000.flash: no disabled pin control state
physmap-flash 30000000.flash: initialized Gemini-specific physmap control
physmap-flash 30000000.flash: physmap platform flash device: [mem 0x30000000-0x331fffff]
30000000.flash: Found 1 x16 devices at 0x0 in 16-bit bank. Manufacturer ID 0x000001 Chip ID 0x002201
number of CFI chips: 1
Searching for RedBoot partition table in 30000000.flash at offset 0x1fe0000
No RedBoot partition table detected in 30000000.flash
Searching for RedBoot partition table in 30000000.flash at offset 0x1fe0000
No RedBoot partition table detected in 30000000.flash
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-18 10:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 19:32 [PATCH 0/5] ARM: gemini: add two more board Corentin Labbe
2021-05-17 19:32 ` Corentin Labbe
2021-05-17 19:32 ` [PATCH 1/5] ARM: dts: gemini: add labels for USB, IDE, flash and ethernet Corentin Labbe
2021-05-17 19:32 ` Corentin Labbe
2021-05-17 19:32 ` [PATCH 2/5] dt-bindings: add vendor prefix for edimax Corentin Labbe
2021-05-17 19:32 ` Corentin Labbe
2021-05-19 19:50 ` Rob Herring
2021-05-19 19:50 ` Rob Herring
2021-05-17 19:32 ` [PATCH 3/5] dt-bindings: add vendor prefix for ssi Corentin Labbe
2021-05-17 19:32 ` Corentin Labbe
2021-05-19 19:50 ` Rob Herring
2021-05-19 19:50 ` Rob Herring
2021-05-17 19:32 ` [PATCH 4/5] ARM: gemini: add device tree for edimax NS2502 Corentin Labbe
2021-05-17 19:32 ` Corentin Labbe
2021-05-17 23:46 ` Linus Walleij
2021-05-17 23:46 ` Linus Walleij
2021-05-17 23:46 ` Linus Walleij
2021-05-18 9:54 ` LABBE Corentin [this message]
2021-05-18 9:54 ` LABBE Corentin
2021-05-18 9:54 ` LABBE Corentin
2021-05-18 23:17 ` Linus Walleij
2021-05-18 23:17 ` Linus Walleij
2021-05-18 23:17 ` Linus Walleij
2021-05-20 13:02 ` LABBE Corentin
2021-05-20 13:02 ` LABBE Corentin
2021-05-20 13:02 ` LABBE Corentin
2021-05-17 19:32 ` [PATCH 5/5] ARM: gemini: add device tree for ssi1328 Corentin Labbe
2021-05-17 19:32 ` Corentin Labbe
2021-05-17 23:47 ` Linus Walleij
2021-05-17 23:47 ` Linus Walleij
2021-05-17 23:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKOO8UxdmZBjYbt4@Red \
--to=clabbe@baylibre.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).