soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Rob Herring <robh+dt@kernel.org>, SoC Team <soc@kernel.org>,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] ARM: gemini: add device tree for edimax NS2502
Date: Wed, 19 May 2021 01:17:59 +0200	[thread overview]
Message-ID: <CACRpkdYqaoggyBO9=fdi2iUh9O0Y_jT5jnc7+qbE9HzEWK57Sg@mail.gmail.com> (raw)
Message-ID: <20210518231759.ZIxoXt5oCYFb0F56_jhKVxr8XL5dHUHGzj3bfyFri0M@z> (raw)
In-Reply-To: <YKOO8UxdmZBjYbt4@Red>

On Tue, May 18, 2021 at 11:55 AM LABBE Corentin <clabbe@baylibre.com> wrote:
> Le Tue, May 18, 2021 at 01:46:20AM +0200, Linus Walleij a écrit :

> > Is the FIS broken since you hardcode the partitions?
> >
> > Doesn't this work:
> >
> > partitions {
> >     compatible = "redboot-fis";
> >     /* Eraseblock at 0x7e0000 */
> >     fis-index-block = <0xfc>;
> > };
> >
> > (Needs CONFIG_MTD_REDBOOT_PARTS)
>
> No it does not.
>
> physmap-flash 30000000.flash: no enabled pin control state
> physmap-flash 30000000.flash: no disabled pin control state
> physmap-flash 30000000.flash: initialized Gemini-specific physmap control
> physmap-flash 30000000.flash: physmap platform flash device: [mem 0x30000000-0x331fffff]
> 30000000.flash: Found 1 x16 devices at 0x0 in 16-bit bank. Manufacturer ID 0x000001 Chip ID 0x002201
> number of CFI chips: 1
> Searching for RedBoot partition table in 30000000.flash at offset 0x1fe0000
> No RedBoot partition table detected in 30000000.flash
> Searching for RedBoot partition table in 30000000.flash at offset 0x1fe0000
> No RedBoot partition table detected in 30000000.flash

Hm since it searches at 0x1fe0000 that's where it thinks the last
eraseblock is so the erase blocks are 0x20000 (128KB).

FIS at 0x7e0000 should be erase block
0x7e0000/0x20000 = 0x3f

Can you test fis-index-block = <0x3f> and see what happens?

Yours,
Linus Walleij

  parent reply	other threads:[~2021-05-18 23:18 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 19:32 [PATCH 0/5] ARM: gemini: add two more board Corentin Labbe
2021-05-17 19:32 ` Corentin Labbe
2021-05-17 19:32 ` [PATCH 1/5] ARM: dts: gemini: add labels for USB, IDE, flash and ethernet Corentin Labbe
2021-05-17 19:32   ` Corentin Labbe
2021-05-17 19:32 ` [PATCH 2/5] dt-bindings: add vendor prefix for edimax Corentin Labbe
2021-05-17 19:32   ` Corentin Labbe
2021-05-19 19:50   ` Rob Herring
2021-05-19 19:50     ` Rob Herring
2021-05-17 19:32 ` [PATCH 3/5] dt-bindings: add vendor prefix for ssi Corentin Labbe
2021-05-17 19:32   ` Corentin Labbe
2021-05-19 19:50   ` Rob Herring
2021-05-19 19:50     ` Rob Herring
2021-05-17 19:32 ` [PATCH 4/5] ARM: gemini: add device tree for edimax NS2502 Corentin Labbe
2021-05-17 19:32   ` Corentin Labbe
2021-05-17 23:46   ` Linus Walleij
2021-05-17 23:46     ` Linus Walleij
2021-05-17 23:46     ` Linus Walleij
2021-05-18  9:54     ` LABBE Corentin
2021-05-18  9:54       ` LABBE Corentin
2021-05-18  9:54       ` LABBE Corentin
2021-05-18 23:17       ` Linus Walleij [this message]
2021-05-18 23:17         ` Linus Walleij
2021-05-18 23:17         ` Linus Walleij
2021-05-20 13:02         ` LABBE Corentin
2021-05-20 13:02           ` LABBE Corentin
2021-05-20 13:02           ` LABBE Corentin
2021-05-17 19:32 ` [PATCH 5/5] ARM: gemini: add device tree for ssi1328 Corentin Labbe
2021-05-17 19:32   ` Corentin Labbe
2021-05-17 23:47   ` Linus Walleij
2021-05-17 23:47     ` Linus Walleij
2021-05-17 23:47     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdYqaoggyBO9=fdi2iUh9O0Y_jT5jnc7+qbE9HzEWK57Sg@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=clabbe@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=soc@kernel.org \
    --cc=ulli.kroll@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).