* Re: [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure
[not found] ` <20210421164317.1718831-2-maz@kernel.org>
@ 2021-04-21 17:20 ` Sudeep Holla
2021-04-21 17:57 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Sudeep Holla @ 2021-04-21 17:20 UTC (permalink / raw)
To: Marc Zyngier
Cc: Lorenzo Pieralisi, Hanjun Guo, dann frazier, Fu Wei, Len Brown,
Rafael J. Wysocki, linux-acpi, linux-arm-kernel, linux-kernel,
kernel-team, stable, Sudeep Holla
(with stable email fixed, but may need separate posting anyways)
On Wed, Apr 21, 2021 at 05:43:16PM +0100, Marc Zyngier wrote:
> When failing the driver probe because of invalid firmware properties,
> the GTDT driver unmaps the interrupt that it mapped earlier.
>
> However, it never checks whether the mapping of the interrupt actially
> succeeded. Even more, should the firmware report an illegal interrupt
> number that overlaps with the GIC SGI range, this can result in an
> IPI being unmapped, and subsequent fireworks (as reported by Dann
> Frazier).
>
> Rework the driver to have a slightly saner behaviour and actually
> check whether the interrupt has been mapped before unmapping things.
>
> Reported-by: dann frazier <dann.frazier@canonical.com>
> Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf
> Cc: stable@vgerlkernel.org
^^^
I thought I messed up while replying with my fat fingers, but here is the
culprit. I got mail delivery failure to my reply, thought I will let you
know as it may be difficult to notice this when using git send-email.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure
2021-04-21 17:20 ` [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure Sudeep Holla
@ 2021-04-21 17:57 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2021-04-21 17:57 UTC (permalink / raw)
To: Sudeep Holla
Cc: Lorenzo Pieralisi, Hanjun Guo, dann frazier, Fu Wei, Len Brown,
Rafael J. Wysocki, linux-acpi, linux-arm-kernel, linux-kernel,
kernel-team, stable
On Wed, 21 Apr 2021 18:20:56 +0100,
Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> (with stable email fixed, but may need separate posting anyways)
>
> On Wed, Apr 21, 2021 at 05:43:16PM +0100, Marc Zyngier wrote:
> > When failing the driver probe because of invalid firmware properties,
> > the GTDT driver unmaps the interrupt that it mapped earlier.
> >
> > However, it never checks whether the mapping of the interrupt actially
> > succeeded. Even more, should the firmware report an illegal interrupt
> > number that overlaps with the GIC SGI range, this can result in an
> > IPI being unmapped, and subsequent fireworks (as reported by Dann
> > Frazier).
> >
> > Rework the driver to have a slightly saner behaviour and actually
> > check whether the interrupt has been mapped before unmapping things.
> >
> > Reported-by: dann frazier <dann.frazier@canonical.com>
> > Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver")
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf
> > Cc: stable@vgerlkernel.org
> ^^^
>
> I thought I messed up while replying with my fat fingers, but here is the
> culprit. I got mail delivery failure to my reply, thought I will let you
> know as it may be difficult to notice this when using git send-email.
I'm definitely the one with very fat fingers. I'll fix the patch in my
tree.
Thanks for the heads up,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-21 17:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210421164317.1718831-1-maz@kernel.org>
[not found] ` <20210421164317.1718831-2-maz@kernel.org>
2021-04-21 17:20 ` [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure Sudeep Holla
2021-04-21 17:57 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).