From: Stefan Roese <sr@denx.de>
To: "Marek Behún" <kabel@kernel.org>
Cc: u-boot@lists.denx.de, "Pali Rohár" <pali@kernel.org>,
"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH u-boot-marvell 08/10] pci: pci_mvebu: Remove unused DECLARE_GLOBAL_DATA_PTR
Date: Fri, 12 Nov 2021 15:19:20 +0100 [thread overview]
Message-ID: <278bccab-0ff2-5712-2734-4a18f8cce43f@denx.de> (raw)
In-Reply-To: <20211111153549.29111-9-kabel@kernel.org>
On 11/11/21 16:35, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
>
> The global data pointer is not used in this driver, remove it's
> declaration.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> drivers/pci/pci_mvebu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
> index fea32414bf..f3830f67aa 100644
> --- a/drivers/pci/pci_mvebu.c
> +++ b/drivers/pci/pci_mvebu.c
> @@ -13,7 +13,6 @@
> #include <dm.h>
> #include <log.h>
> #include <malloc.h>
> -#include <asm/global_data.h>
> #include <dm/device-internal.h>
> #include <dm/lists.h>
> #include <dm/of_access.h>
> @@ -28,8 +27,6 @@
> #include <linux/mbus.h>
> #include <linux/sizes.h>
>
> -DECLARE_GLOBAL_DATA_PTR;
> -
> /* PCIe unit register offsets */
> #define SELECT(x, n) ((x >> n) & 1UL)
>
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2021-11-12 14:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 15:35 [PATCH u-boot-marvell 00/10] PCI mvebu and aardvark changes Marek Behún
2021-11-11 15:35 ` [PATCH u-boot-marvell 01/10] pci: pci_mvebu: Wait 100ms for Link Up in mvebu_pcie_probe() Marek Behún
2021-11-12 13:59 ` Stefan Roese
2021-11-12 15:44 ` Pali Rohár
2021-11-12 16:07 ` Stefan Roese
2021-11-18 18:06 ` Pali Rohár
2021-11-11 15:35 ` [PATCH u-boot-marvell 02/10] arm: mvebu: a38x: serdes: Move non-serdes PCIe code to pci_mvebu.c Marek Behún
2021-11-12 14:01 ` Stefan Roese
2021-11-18 18:01 ` Pali Rohár
2021-11-19 6:55 ` Stefan Roese
2021-11-23 15:59 ` Pali Rohár
2021-11-29 7:46 ` Stefan Roese
2021-11-29 9:06 ` Pali Rohár
2021-11-29 9:22 ` Stefan Roese
2021-11-29 11:47 ` Pali Rohár
2021-11-29 12:30 ` Stefan Roese
2021-11-29 13:27 ` Pali Rohár
2021-11-29 14:28 ` Pali Rohár
2021-11-29 16:07 ` Stefan Roese
2021-11-29 17:09 ` Marek Behún
2021-12-10 11:07 ` Pali Rohár
2021-12-10 14:23 ` Pali Rohár
2021-12-13 7:36 ` Stefan Roese
2021-12-13 10:28 ` Pali Rohár
2021-11-11 15:35 ` [PATCH u-boot-marvell 03/10] pci: pci_mvebu: Move setup for BAR[0] where other BARs are setup Marek Behún
2021-11-12 14:02 ` Stefan Roese
2021-12-21 8:22 ` Stefan Roese
2021-11-11 15:35 ` [PATCH u-boot-marvell 04/10] pci: pci_mvebu: Replace MBUS_PCI_*_SIZE by resource_size() Marek Behún
2021-11-12 14:03 ` Stefan Roese
2021-12-21 8:23 ` Stefan Roese
2021-11-11 15:35 ` [PATCH u-boot-marvell 05/10] pci: pci_mvebu, pci_aardvark: Fix size of configuration cache Marek Behún
2021-11-12 14:04 ` Stefan Roese
2021-12-15 10:57 ` Stefan Roese
2021-11-11 15:35 ` [PATCH u-boot-marvell 06/10] pci: pci_mvebu: Do not allow setting ROM BAR on PCI Bridge Marek Behún
2021-11-12 14:05 ` Stefan Roese
2021-12-15 10:57 ` Stefan Roese
2021-11-11 15:35 ` [PATCH u-boot-marvell 07/10] pci: pci_mvebu: Fix PCIe MEM and IO resources assignment and mbus mapping Marek Behún
2021-11-12 14:18 ` Stefan Roese
2021-11-18 17:46 ` Pali Rohár
2021-11-19 6:27 ` Stefan Roese
2021-11-11 15:35 ` [PATCH u-boot-marvell 08/10] pci: pci_mvebu: Remove unused DECLARE_GLOBAL_DATA_PTR Marek Behún
2021-11-12 14:19 ` Stefan Roese [this message]
2021-12-21 8:23 ` Stefan Roese
2021-11-11 15:35 ` [PATCH u-boot-marvell 09/10] arm: a37xx: pci: Do not allow setting ROM BAR on PCI Bridge Marek Behún
2021-11-12 14:19 ` Stefan Roese
2021-11-11 15:35 ` [PATCH u-boot-marvell 10/10] arm: mvebu: turris_mox: Remove extra newline after module topology Marek Behún
2021-11-12 14:20 ` Stefan Roese
2021-12-21 8:23 ` Stefan Roese
2021-12-12 11:23 ` [PATCH u-boot-marvell 00/10] PCI mvebu and aardvark changes Pali Rohár
2021-12-13 7:41 ` Stefan Roese
2021-12-13 10:27 ` Pali Rohár
2021-12-15 8:10 ` Stefan Roese
2021-12-16 10:28 ` Pali Rohár
2021-12-18 13:53 ` Stefan Roese
2021-12-20 13:30 ` Pali Rohár
2021-12-21 8:19 ` Stefan Roese
2021-12-21 10:57 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=278bccab-0ff2-5712-2734-4a18f8cce43f@denx.de \
--to=sr@denx.de \
--cc=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).